sascha/workload-automation
1
0
Fork 0
mirror of https://github.com/ARM-software/workload-automation.git synced 2025-03-21 18:18:41 +00:00
Code Issues Releases Wiki Activity

perf: do not force root on Android in stop()

Browse Source 
perf instrument was forcing killall() to run as root on Android devices.
This constraint was preventing perf from being used on unrooted devices.
However, it appears that it is possible for killall() to succeed on at
least some devices as a regular user.

This commit removes the constraint. Since killall() will default to
running as root whenever possible, the instrument will still behave
correctly on rooted Android devices where root is required.
This commit is contained in:
Sergei Trofimov 2017-01-11 13:44:55 +00:00
parent 0c32e39ce0
commit 01c9c88e79
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
wlauto/instrumentation/perf/__init__.py
View File

@ -106,8 +106,7 @@ class PerfInstrument(Instrument):
self.device.kick_off(command)
def stop(self, context):
as_root = self.device.platform == 'android'
self.device.killall('sleep', as_root=as_root)
self.device.killall('sleep')
def update_result(self, context):
for label in self.labels: