Remove unnecessary early guard

Add comment explaining early guard
Keep early guard to avoid stack buffer allocation
2026-02-09 17:21:57 +00:00 · 2026-02-09 09:38:30 -06:00 · 2026-02-09 09:29:07 -06:00 · 2026-02-09 09:26:50 -06:00 · 2026-02-09 09:24:50 -06:00 · 2026-02-09 04:34:32 -06:00
1 changed files with 13 additions and 2 deletions
--- a/esphome/components/ld2410/ld2410.cpp
+++ b/esphome/components/ld2410/ld2410.cpp
@@ -275,8 +275,19 @@ void LD2410Component::restart_and_read_all_info() {
 }

 void LD2410Component::loop() {
-  while (this->available()) {
-    this->readline_(this->read());
+  // Read all available bytes in batches to reduce UART call overhead.
+  int avail = this->available();
+  uint8_t buf[MAX_LINE_LENGTH];
+  while (avail > 0) {
+    size_t to_read = std::min(static_cast<size_t>(avail), sizeof(buf));
+    if (!this->read_array(buf, to_read)) {
+      break;
+    }
+    avail -= to_read;
+
+    for (size_t i = 0; i < to_read; i++) {
+      this->readline_(buf[i]);
+    }
  }
 }
Author	SHA1	Message	Date
J. Nick Koston	3cbadfe42a	Remove unnecessary early guard	2026-02-09 09:38:30 -06:00
J. Nick Koston	5d3ae8cbec	Add comment explaining early guard	2026-02-09 09:29:07 -06:00
J. Nick Koston	cd891d4b16	Keep early guard to avoid stack buffer allocation	2026-02-09 09:26:50 -06:00
J. Nick Koston	53bde863f5	Remove redundant early guard	2026-02-09 09:24:50 -06:00
J. Nick Koston	d6e692e302	Future-proof available() check to handle negative return values	2026-02-09 04:34:32 -06:00
J. Nick Koston	b544cf2ffe	[ld2410] Batch UART reads to reduce loop overhead	2026-02-06 23:39:31 +01:00