Remove unnecessary early guard

Add comment explaining early guard
Keep early guard to avoid stack buffer allocation
2026-02-09 17:21:57 +00:00 · 2026-02-09 09:38:12 -06:00 · 2026-02-09 09:28:51 -06:00 · 2026-02-09 09:26:29 -06:00 · 2026-02-09 09:24:34 -06:00 · 2026-02-09 04:29:37 -06:00
1 changed files with 13 additions and 2 deletions
--- a/esphome/components/ld2412/ld2412.cpp
+++ b/esphome/components/ld2412/ld2412.cpp
@@ -310,8 +310,19 @@ void LD2412Component::restart_and_read_all_info() {
 }

 void LD2412Component::loop() {
-  while (this->available()) {
-    this->readline_(this->read());
+  // Read all available bytes in batches to reduce UART call overhead.
+  int avail = this->available();
+  uint8_t buf[MAX_LINE_LENGTH];
+  while (avail > 0) {
+    size_t to_read = std::min(static_cast<size_t>(avail), sizeof(buf));
+    if (!this->read_array(buf, to_read)) {
+      break;
+    }
+    avail -= to_read;
+
+    for (size_t i = 0; i < to_read; i++) {
+      this->readline_(buf[i]);
+    }
  }
 }
Author	SHA1	Message	Date
J. Nick Koston	277a11f0ea	Remove unnecessary early guard	2026-02-09 09:38:12 -06:00
J. Nick Koston	59a2f6f538	Add comment explaining early guard	2026-02-09 09:28:51 -06:00
J. Nick Koston	2784059a64	Keep early guard to avoid stack buffer allocation	2026-02-09 09:26:29 -06:00
J. Nick Koston	dfb0c8670d	Remove redundant early guard	2026-02-09 09:24:34 -06:00
J. Nick Koston	a875a2fb9b	Future-proof available() check to handle negative return values	2026-02-09 04:29:37 -06:00
J. Nick Koston	6d1281301f	[ld2412] Batch UART reads to reduce loop overhead Read all available bytes in batches via read_array() instead of byte-at-a-time read() calls. Each read() internally chains through read_byte -> read_array(1) -> check_read_timeout_ -> available(), resulting in 3 UART calls per byte. Batching reduces this significantly.	2026-02-06 23:36:01 +01:00