Remove unnecessary early guard

Add comment explaining early guard
Keep early guard to avoid stack buffer allocation
2026-02-09 17:21:57 +00:00 · 2026-02-09 09:39:04 -06:00 · 2026-02-09 09:29:42 -06:00 · 2026-02-09 09:27:20 -06:00 · 2026-02-09 09:25:23 -06:00 · 2026-02-09 04:35:11 -06:00
1 changed files with 10 additions and 4 deletions
--- a/esphome/components/nextion/nextion.cpp
+++ b/esphome/components/nextion/nextion.cpp
@@ -397,11 +397,17 @@ bool Nextion::remove_from_q_(bool report_empty) {
 }

 void Nextion::process_serial_() {
-  uint8_t d;
+  // Read all available bytes in batches to reduce UART call overhead.
+  int avail = this->available();
+  uint8_t buf[64];
+  while (avail > 0) {
+    size_t to_read = std::min(static_cast<size_t>(avail), sizeof(buf));
+    if (!this->read_array(buf, to_read)) {
+      break;
+    }
+    avail -= to_read;

-  while (this->available()) {
-    read_byte(&d);
-    this->command_data_ += d;
+    this->command_data_.append(reinterpret_cast<const char *>(buf), to_read);
  }
 }
 // nextion.tech/instruction-set/
Author	SHA1	Message	Date
J. Nick Koston	9c9e8ac388	Remove unnecessary early guard	2026-02-09 09:39:04 -06:00
J. Nick Koston	cc1f83ac35	Add comment explaining early guard	2026-02-09 09:29:42 -06:00
J. Nick Koston	457d68256d	Keep early guard to avoid stack buffer allocation	2026-02-09 09:27:20 -06:00
J. Nick Koston	8dff0ee449	Remove redundant early guard	2026-02-09 09:25:23 -06:00
J. Nick Koston	a0f736b7aa	Future-proof available() check to handle negative return values	2026-02-09 04:35:11 -06:00
J. Nick Koston	33c831dbb8	Update esphome/components/nextion/nextion.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2026-02-07 00:07:05 +01:00
J. Nick Koston	6b7c52799d	[nextion] Batch UART reads to reduce loop overhead	2026-02-07 00:02:10 +01:00