Merge branch 'dev' into jesserockz-2023-304

.clang-tidy

@@ -7,39 +7,28 @@ Checks: >-
   -boost-*,
   -bugprone-easily-swappable-parameters,
   -bugprone-implicit-widening-of-multiplication-result,
-  -bugprone-multi-level-implicit-pointer-conversion,
   -bugprone-narrowing-conversions,
   -bugprone-signed-char-misuse,
-  -bugprone-switch-missing-default-case,
   -cert-dcl50-cpp,
   -cert-err33-c,
   -cert-err58-cpp,
   -cert-oop57-cpp,
   -cert-str34-c,
-  -clang-analyzer-optin.core.EnumCastOutOfRange,
   -clang-analyzer-optin.cplusplus.UninitializedObject,
   -clang-analyzer-osx.*,
   -clang-diagnostic-delete-abstract-non-virtual-dtor,
   -clang-diagnostic-delete-non-abstract-non-virtual-dtor,
-  -clang-diagnostic-deprecated-declarations,
   -clang-diagnostic-ignored-optimization-argument,
-  -clang-diagnostic-missing-field-initializers,
   -clang-diagnostic-shadow-field,
   -clang-diagnostic-unused-const-variable,
   -clang-diagnostic-unused-parameter,
-  -clang-diagnostic-vla-cxx-extension,
   -concurrency-*,
   -cppcoreguidelines-avoid-c-arrays,
-  -cppcoreguidelines-avoid-const-or-ref-data-members,
-  -cppcoreguidelines-avoid-do-while,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-init-variables,
-  -cppcoreguidelines-macro-to-enum,
   -cppcoreguidelines-macro-usage,
-  -cppcoreguidelines-missing-std-forward,
   -cppcoreguidelines-narrowing-conversions,
   -cppcoreguidelines-non-private-member-variables-in-classes,
-  -cppcoreguidelines-owning-memory,
   -cppcoreguidelines-prefer-member-initializer,
   -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
   -cppcoreguidelines-pro-bounds-constant-array-index,
@@ -51,9 +40,7 @@ Checks: >-
   -cppcoreguidelines-pro-type-static-cast-downcast,
   -cppcoreguidelines-pro-type-union-access,
   -cppcoreguidelines-pro-type-vararg,
-  -cppcoreguidelines-rvalue-reference-param-not-moved,
   -cppcoreguidelines-special-member-functions,
-  -cppcoreguidelines-use-default-member-init,
   -cppcoreguidelines-virtual-class-destructor,
   -fuchsia-multiple-inheritance,
   -fuchsia-overloaded-operator,
@@ -73,32 +60,20 @@ Checks: >-
   -llvm-include-order,
   -llvm-qualified-auto,
   -llvmlibc-*,
-  -misc-const-correctness,
-  -misc-include-cleaner,
-  -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
+  -misc-no-recursion,
   -misc-unused-parameters,
-  -misc-use-anonymous-namespace,
-  -modernize-avoid-bind,
   -modernize-avoid-c-arrays,
+  -modernize-avoid-bind,
   -modernize-concat-nested-namespaces,
-  -modernize-macro-to-enum,
   -modernize-return-braced-init-list,
-  -modernize-type-traits,
   -modernize-use-auto,
-  -modernize-use-constraints,
   -modernize-use-default-member-init,
   -modernize-use-equals-default,
-  -modernize-use-nodiscard,
-  -modernize-use-nullptr,
-  -modernize-use-nodiscard,
-  -modernize-use-nullptr,
   -modernize-use-trailing-return-type,
+  -modernize-use-nodiscard,
   -mpi-*,
   -objc-*,
-  -performance-enum-size,
-  -readability-avoid-nested-conditional-operator,
-  -readability-container-contains,
   -readability-container-data-pointer,
   -readability-convert-member-functions-to-static,
   -readability-else-after-return,
@@ -107,14 +82,11 @@ Checks: >-
   -readability-isolate-declaration,
   -readability-magic-numbers,
   -readability-make-member-function-const,
-  -readability-named-parameter,
-  -readability-redundant-casting,
-  -readability-redundant-inline-specifier,
-  -readability-redundant-member-init,
   -readability-redundant-string-init,
   -readability-uppercase-literal-suffix,
   -readability-use-anyofallof,
 WarningsAsErrors: '*'
+AnalyzeTemporaryDtors: false
 FormatStyle:     google
 CheckOptions:
   - key:             google-readability-function-size.StatementThreshold

.dockerignore

@@ -75,9 +75,6 @@ target/
 # pyenv
 .python-version
 
-# asdf
-.tool-versions
-
 # celery beat schedule file
 celerybeat-schedule
 

.github/actions/build-image/action.yaml

@@ -46,7 +46,7 @@ runs:
 
     - name: Build and push to ghcr by digest
       id: build-ghcr
-      uses: docker/build-push-action@v6.10.0
+      uses: docker/build-push-action@v6.9.0
       env:
         DOCKER_BUILD_SUMMARY: false
         DOCKER_BUILD_RECORD_UPLOAD: false
@@ -72,7 +72,7 @@ runs:
 
     - name: Build and push to dockerhub by digest
       id: build-dockerhub
-      uses: docker/build-push-action@v6.10.0
+      uses: docker/build-push-action@v6.9.0
       env:
         DOCKER_BUILD_SUMMARY: false
         DOCKER_BUILD_RECORD_UPLOAD: false

.github/actions/restore-python/action.yml

@@ -22,7 +22,7 @@ runs:
         python-version: ${{ inputs.python-version }}
     - name: Restore Python virtual environment
       id: cache-venv
-      uses: actions/cache/restore@v4.2.0
+      uses: actions/cache/restore@v4.1.2
       with:
         path: venv
         # yamllint disable-line rule:line-length

.github/workflows/ci.yml

@@ -30,7 +30,7 @@ concurrency:
 jobs:
   common:
     name: Create common environment
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     outputs:
       cache-key: ${{ steps.cache-key.outputs.key }}
     steps:
@@ -46,7 +46,7 @@ jobs:
           python-version: ${{ env.DEFAULT_PYTHON }}
       - name: Restore Python virtual environment
         id: cache-venv
-        uses: actions/cache@v4.2.0
+        uses: actions/cache@v4.1.2
         with:
           path: venv
           # yamllint disable-line rule:line-length
@@ -62,7 +62,7 @@ jobs:
 
   black:
     name: Check black
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
     steps:
@@ -83,7 +83,7 @@ jobs:
 
   flake8:
     name: Check flake8
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
     steps:
@@ -104,7 +104,7 @@ jobs:
 
   pylint:
     name: Check pylint
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
     steps:
@@ -125,7 +125,7 @@ jobs:
 
   pyupgrade:
     name: Check pyupgrade
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
     steps:
@@ -146,7 +146,7 @@ jobs:
 
   ci-custom:
     name: Run script/ci-custom
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
     steps:
@@ -219,13 +219,13 @@ jobs:
           . venv/bin/activate
           pytest -vv --cov-report=xml --tb=native tests
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v5
+        uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
 
   clang-format:
     name: Check clang-format
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
     steps:
@@ -251,7 +251,7 @@ jobs:
 
   clang-tidy:
     name: ${{ matrix.name }}
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
       - black
@@ -290,6 +290,10 @@ jobs:
             name: Run script/clang-tidy for ESP32 IDF
             options: --environment esp32-idf-tidy --grep USE_ESP_IDF
             pio_cache_key: tidyesp32-idf
+          - id: clang-tidy
+            name: Run script/clang-tidy for LibreTiny
+            options: --environment bk72xx-arduino --grep USE_LIBRETINY
+            pio_cache_key: tidylibretiny
 
     steps:
       - name: Check out code from GitHub
@@ -302,18 +306,23 @@ jobs:
 
       - name: Cache platformio
         if: github.ref == 'refs/heads/dev'
-        uses: actions/cache@v4.2.0
+        uses: actions/cache@v4.1.2
         with:
           path: ~/.platformio
           key: platformio-${{ matrix.pio_cache_key }}
 
       - name: Cache platformio
         if: github.ref != 'refs/heads/dev'
-        uses: actions/cache/restore@v4.2.0
+        uses: actions/cache/restore@v4.1.2
         with:
           path: ~/.platformio
           key: platformio-${{ matrix.pio_cache_key }}
 
+      - name: Install clang-tidy
+        run: |
+          sudo apt-get update
+          sudo apt-get install clang-tidy-14
+
       - name: Register problem matchers
         run: |
           echo "::add-matcher::.github/workflows/matchers/gcc.json"
@@ -340,7 +349,7 @@ jobs:
         if: always()
 
   list-components:
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
     if: github.event_name == 'pull_request'
@@ -382,7 +391,7 @@ jobs:
 
   test-build-components:
     name: Component test ${{ matrix.file }}
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
       - list-components
@@ -416,7 +425,7 @@ jobs:
 
   test-build-components-splitter:
     name: Split components for testing into 20 groups maximum
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
       - list-components
@@ -434,7 +443,7 @@ jobs:
 
   test-build-components-split:
     name: Test split components
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
       - list-components
@@ -478,7 +487,7 @@ jobs:
 
   ci-status:
     name: CI Status
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     needs:
       - common
       - black

.github/workflows/release.yml

@@ -65,7 +65,7 @@ jobs:
           pip3 install build
           python3 -m build
       - name: Publish
-        uses: pypa/gh-action-pypi-publish@v1.12.3
+        uses: pypa/gh-action-pypi-publish@v1.10.3
 
   deploy-docker:
     name: Build ESPHome ${{ matrix.platform }}

.gitignore

@@ -75,9 +75,6 @@ cov.xml
 # pyenv
 .python-version
 
-# asdf
-.tool-versions
-
 # Environments
 .env
 .venv

CODEOWNERS

@@ -85,7 +85,6 @@ esphome/components/bmp581/* @kahrendt
 esphome/components/bp1658cj/* @Cossid
 esphome/components/bp5758d/* @Cossid
 esphome/components/button/* @esphome/core
-esphome/components/bytebuffer/* @clydebarrow
 esphome/components/canbus/* @danielschramm @mvturnho
 esphome/components/cap1188/* @mreditor97
 esphome/components/captive_portal/* @OttoWinter
@@ -131,7 +130,6 @@ esphome/components/ens160_base/* @latonita @vincentscode
 esphome/components/ens160_i2c/* @latonita
 esphome/components/ens160_spi/* @latonita
 esphome/components/ens210/* @itn3rd77
-esphome/components/es8311/* @kahrendt @kroimon
 esphome/components/esp32/* @esphome/core
 esphome/components/esp32_ble/* @Rapsssito @jesserockz
 esphome/components/esp32_ble_client/* @jesserockz
@@ -179,7 +177,6 @@ esphome/components/haier/text_sensor/* @paveldn
 esphome/components/havells_solar/* @sourabhjaiswal
 esphome/components/hbridge/fan/* @WeekendWarrior
 esphome/components/hbridge/light/* @DotNetDann
-esphome/components/hbridge/switch/* @dwmw2
 esphome/components/he60r/* @clydebarrow
 esphome/components/heatpumpir/* @rob-deutsch
 esphome/components/hitachi_ac424/* @sourabhjaiswal
@@ -355,8 +352,6 @@ esphome/components/sdl/* @clydebarrow
 esphome/components/sdm_meter/* @jesserockz @polyfaces
 esphome/components/sdp3x/* @Azimath
 esphome/components/seeed_mr24hpc1/* @limengdu
-esphome/components/seeed_mr60bha2/* @limengdu
-esphome/components/seeed_mr60fda2/* @limengdu
 esphome/components/selec_meter/* @sourabhjaiswal
 esphome/components/select/* @esphome/core
 esphome/components/sen0321/* @notjj
@@ -411,7 +406,6 @@ esphome/components/substitutions/* @esphome/core
 esphome/components/sun/* @OttoWinter
 esphome/components/sun_gtil2/* @Mat931
 esphome/components/switch/* @esphome/core
-esphome/components/switch/binary_sensor/* @ssieb
 esphome/components/t6615/* @tylermenezes
 esphome/components/tc74/* @sethgirvan
 esphome/components/tca9548a/* @andreashergert1984

docker/Dockerfile

@@ -32,14 +32,33 @@ RUN \
         python3-setuptools=66.1.1-1 \
         python3-venv=3.11.2-1+b1 \
         python3-wheel=0.38.4-2 \
-        iputils-ping=3:20221126-1+deb12u1 \
+        iputils-ping=3:20221126-1 \
         git=1:2.39.5-0+deb12u1 \
-        curl=7.88.1-10+deb12u8 \
+        curl=7.88.1-10+deb12u7 \
         openssh-client=1:9.2p1-2+deb12u3 \
         python3-cffi=1.15.1-5 \
         libcairo2=1.16.0-7 \
         libmagic1=1:5.44-3 \
         patch=2.7.6-7 \
+    && ( \
+        ( \
+            [ "$TARGETARCH$TARGETVARIANT" = "armv7" ] && \
+                apt-get install -y --no-install-recommends \
+                build-essential=12.9 \
+                python3-dev=3.11.2-1+b1 \
+                zlib1g-dev=1:1.2.13.dfsg-1 \
+                libjpeg-dev=1:2.1.5-2 \
+                libfreetype-dev=2.12.1+dfsg-5+deb12u3 \
+                libssl-dev=3.0.14-1~deb12u2 \
+                libffi-dev=3.4.4-1 \
+                libopenjp2-7=2.5.0-2 \
+                libtiff6=4.5.0-6+deb12u1 \
+                cargo=0.66.0+ds1-1 \
+                pkg-config=1.8.1-1 \
+                gcc-arm-linux-gnueabihf=4:12.2.0-3 \
+        ) \
+        || [ "$TARGETARCH$TARGETVARIANT" != "armv7" ] \
+    ) \
     && rm -rf \
         /tmp/* \
         /var/{cache,log}/* \
@@ -78,50 +97,15 @@ RUN \
 # tmpfs is for https://github.com/rust-lang/cargo/issues/8719
 
 COPY requirements.txt requirements_optional.txt /
-RUN --mount=type=tmpfs,target=/root/.cargo <<END-OF-RUN
-# Fail on any non-zero status
-set -e
-
-if [ "$TARGETARCH$TARGETVARIANT" = "armv7" ]
-then
-    curl -L https://www.piwheels.org/cp311/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl -o /tmp/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl
-    pip3 install --break-system-packages --no-cache-dir /tmp/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl
-    rm /tmp/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl
-    export PIP_EXTRA_INDEX_URL="https://www.piwheels.org/simple";
-fi
-
-# install build tools in case wheels are not available
-BUILD_DEPS="
-    build-essential=12.9
-    python3-dev=3.11.2-1+b1
-    zlib1g-dev=1:1.2.13.dfsg-1
-    libjpeg-dev=1:2.1.5-2
-    libfreetype-dev=2.12.1+dfsg-5+deb12u3
-    libssl-dev=3.0.15-1~deb12u1
-    libffi-dev=3.4.4-1
-    cargo=0.66.0+ds1-1
-    pkg-config=1.8.1-1
-"
-LIB_DEPS="
-    libtiff6=4.5.0-6+deb12u1
-    libopenjp2-7=2.5.0-2
-"
-if [ "$TARGETARCH$TARGETVARIANT" = "arm64" ] || [ "$TARGETARCH$TARGETVARIANT" = "armv7" ]
-then
-    apt-get update
-    apt-get install -y --no-install-recommends $BUILD_DEPS $LIB_DEPS
-fi
-
-CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse CARGO_HOME=/root/.cargo
-pip3 install --break-system-packages --no-cache-dir -r /requirements.txt -r /requirements_optional.txt
-
-if [ "$TARGETARCH$TARGETVARIANT" = "arm64" ] || [ "$TARGETARCH$TARGETVARIANT" = "armv7" ]
-then
-    apt-get remove -y --purge --auto-remove $BUILD_DEPS
-    rm -rf /tmp/* /var/{cache,log}/* /var/lib/apt/lists/*
-fi
-END-OF-RUN
-
+RUN --mount=type=tmpfs,target=/root/.cargo if [ "$TARGETARCH$TARGETVARIANT" = "armv7" ]; then \
+        curl -L https://www.piwheels.org/cp311/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl -o /tmp/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl \
+        && pip3 install --break-system-packages --no-cache-dir /tmp/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl \
+        && rm /tmp/cryptography-43.0.0-cp37-abi3-linux_armv7l.whl \
+        && export PIP_EXTRA_INDEX_URL="https://www.piwheels.org/simple"; \
+    fi; \
+    CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse CARGO_HOME=/root/.cargo \
+    pip3 install \
+    --break-system-packages --no-cache-dir -r /requirements.txt -r /requirements_optional.txt
 
 COPY script/platformio_install_deps.py platformio.ini /
 RUN /platformio_install_deps.py /platformio.ini --libraries
@@ -163,18 +147,6 @@ ENTRYPOINT ["/entrypoint.sh"]
 CMD ["dashboard", "/config"]
 
 
-ARG BUILD_VERSION=dev
-
-# Labels
-LABEL \
-    org.opencontainers.image.authors="The ESPHome Authors" \
-    org.opencontainers.image.title="ESPHome" \
-    org.opencontainers.image.description="ESPHome is a system to configure your microcontrollers by simple yet powerful configuration files and control them remotely through Home Automation systems" \
-    org.opencontainers.image.url="https://esphome.io/" \
-    org.opencontainers.image.documentation="https://esphome.io/" \
-    org.opencontainers.image.source="https://github.com/esphome/esphome" \
-    org.opencontainers.image.licenses="ESPHome" \
-    org.opencontainers.image.version=${BUILD_VERSION}
 
 
 # ======================= hassio-type image =======================
@@ -206,7 +178,7 @@ RUN if [ "$TARGETARCH$TARGETVARIANT" = "armv7" ]; then \
 # Labels
 LABEL \
     io.hass.name="ESPHome" \
-    io.hass.description="ESPHome is a system to configure your microcontrollers by simple yet powerful configuration files and control them remotely through Home Automation systems" \
+    io.hass.description="Manage and program ESP8266/ESP32 microcontrollers through YAML configuration files" \
     io.hass.type="addon" \
     io.hass.version="${BUILD_VERSION}"
     # io.hass.arch is inherited from addon-debian-base
@@ -221,22 +193,17 @@ ENV \
   PLATFORMIO_CORE_DIR=/esphome/.temp/platformio
 
 RUN \
-    curl -L https://apt.llvm.org/llvm-snapshot.gpg.key -o /etc/apt/trusted.gpg.d/apt.llvm.org.asc \
-    && echo "deb http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-18 main" > /etc/apt/sources.list.d/llvm.sources.list \
-    && apt-get update \
+    apt-get update \
     # Use pinned versions so that we get updates with build caching
     && apt-get install -y --no-install-recommends \
         clang-format-13=1:13.0.1-11+b2 \
+        clang-tidy-14=1:14.0.6-12 \
         patch=2.7.6-7 \
         software-properties-common=0.99.30-4.1~deb12u1 \
         nano=7.2-1+deb12u1 \
         build-essential=12.9 \
         python3-dev=3.11.2-1+b1 \
-    && if [ "$TARGETARCH$TARGETVARIANT" != "armv7" ]; then \
-    # move this up after armv7 is retired
-    apt-get install -y --no-install-recommends clang-tidy-18=1:18.1.8~++20240731024826+3b5b5c1ec4a3-1~exp1~20240731144843.145 ; \
-    fi; \
-    rm -rf \
+    && rm -rf \
         /tmp/* \
         /var/{cache,log}/* \
         /var/lib/apt/lists/*

esphome/__main__.py

@@ -20,8 +20,6 @@ from esphome.const import (
     CONF_DEASSERT_RTS_DTR,
     CONF_DISABLED,
     CONF_ESPHOME,
-    CONF_LEVEL,
-    CONF_LOG_TOPIC,
     CONF_LOGGER,
     CONF_MDNS,
     CONF_MQTT,
@@ -32,7 +30,6 @@ from esphome.const import (
     CONF_PLATFORMIO_OPTIONS,
     CONF_PORT,
     CONF_SUBSTITUTIONS,
-    CONF_TOPIC,
     PLATFORM_BK72XX,
     PLATFORM_ESP32,
     PLATFORM_ESP8266,
@@ -41,7 +38,7 @@ from esphome.const import (
     SECRETS_FILES,
 )
 from esphome.core import CORE, EsphomeError, coroutine
-from esphome.helpers import get_bool_env, indent, is_ip_address
+from esphome.helpers import indent, is_ip_address, get_bool_env
 from esphome.log import Fore, color, setup_log
 from esphome.util import (
     get_serial_ports,
@@ -98,12 +95,8 @@ def choose_upload_log_host(
         options.append((f"Over The Air ({CORE.address})", CORE.address))
         if default == "OTA":
             return CORE.address
-    if (
-        show_mqtt
-        and (mqtt_config := CORE.config.get(CONF_MQTT))
-        and mqtt_logging_enabled(mqtt_config)
-    ):
-        options.append((f"MQTT ({mqtt_config[CONF_BROKER]})", "MQTT"))
+    if show_mqtt and CONF_MQTT in CORE.config:
+        options.append((f"MQTT ({CORE.config['mqtt'][CONF_BROKER]})", "MQTT"))
         if default == "OTA":
             return "MQTT"
     if default is not None:
@@ -113,17 +106,6 @@ def choose_upload_log_host(
     return choose_prompt(options, purpose=purpose)
 
 
-def mqtt_logging_enabled(mqtt_config):
-    log_topic = mqtt_config[CONF_LOG_TOPIC]
-    if log_topic is None:
-        return False
-    if CONF_TOPIC not in log_topic:
-        return False
-    if log_topic.get(CONF_LEVEL, None) == "NONE":
-        return False
-    return True
-
-
 def get_port_type(port):
     if port.startswith("/") or port.startswith("COM"):
         return "SERIAL"
@@ -363,7 +345,7 @@ def upload_program(config, args, host):
 
     from esphome import espota2
 
-    remote_port = int(ota_conf[CONF_PORT])
+    remote_port = ota_conf[CONF_PORT]
     password = ota_conf.get(CONF_PASSWORD, "")
 
     if (
@@ -396,7 +378,7 @@ def show_logs(config, args, port):
 
             port = mqtt.get_esphome_device_ip(
                 config, args.username, args.password, args.client_id
-            )[0]
+            )
 
         from esphome.components.api.client import run_logs
 

esphome/components/adc/adc_sensor.cpp

@@ -1,13 +1,30 @@
-#ifdef USE_ESP32
-
 #include "adc_sensor.h"
+#include "esphome/core/helpers.h"
 #include "esphome/core/log.h"
 
+#ifdef USE_ESP8266
+#ifdef USE_ADC_SENSOR_VCC
+#include <Esp.h>
+ADC_MODE(ADC_VCC)
+#else
+#include <Arduino.h>
+#endif
+#endif
+
+#ifdef USE_RP2040
+#ifdef CYW43_USES_VSYS_PIN
+#include "pico/cyw43_arch.h"
+#endif
+#include <hardware/adc.h>
+#endif
+
 namespace esphome {
 namespace adc {
 
-static const char *const TAG = "adc.esp32";
+static const char *const TAG = "adc";
 
+// 13-bit for S2, 12-bit for all other ESP32 variants
+#ifdef USE_ESP32
 static const adc_bits_width_t ADC_WIDTH_MAX_SOC_BITS = static_cast<adc_bits_width_t>(ADC_WIDTH_MAX - 1);
 
 #ifndef SOC_ADC_RTC_MAX_BITWIDTH
@@ -15,15 +32,24 @@ static const adc_bits_width_t ADC_WIDTH_MAX_SOC_BITS = static_cast<adc_bits_widt
 static const int32_t SOC_ADC_RTC_MAX_BITWIDTH = 13;
 #else
 static const int32_t SOC_ADC_RTC_MAX_BITWIDTH = 12;
-#endif  // USE_ESP32_VARIANT_ESP32S2
-#endif  // SOC_ADC_RTC_MAX_BITWIDTH
+#endif
+#endif
 
-static const int ADC_MAX = (1 << SOC_ADC_RTC_MAX_BITWIDTH) - 1;
-static const int ADC_HALF = (1 << SOC_ADC_RTC_MAX_BITWIDTH) >> 1;
+static const int ADC_MAX = (1 << SOC_ADC_RTC_MAX_BITWIDTH) - 1;    // 4095 (12 bit) or 8191 (13 bit)
+static const int ADC_HALF = (1 << SOC_ADC_RTC_MAX_BITWIDTH) >> 1;  // 2048 (12 bit) or 4096 (13 bit)
+#endif
 
-void ADCSensor::setup() {
+#ifdef USE_RP2040
+extern "C"
+#endif
+    void
+    ADCSensor::setup() {
   ESP_LOGCONFIG(TAG, "Setting up ADC '%s'...", this->get_name().c_str());
+#if !defined(USE_ADC_SENSOR_VCC) && !defined(USE_RP2040)
+  this->pin_->setup();
+#endif
 
+#ifdef USE_ESP32
   if (this->channel1_ != ADC1_CHANNEL_MAX) {
     adc1_config_width(ADC_WIDTH_MAX_SOC_BITS);
     if (!this->autorange_) {
@@ -35,6 +61,7 @@ void ADCSensor::setup() {
     }
   }
 
+  // load characteristics for each attenuation
   for (int32_t i = 0; i <= ADC_ATTEN_DB_12_COMPAT; i++) {
     auto adc_unit = this->channel1_ != ADC1_CHANNEL_MAX ? ADC_UNIT_1 : ADC_UNIT_2;
     auto cal_value = esp_adc_cal_characterize(adc_unit, (adc_atten_t) i, ADC_WIDTH_MAX_SOC_BITS,
@@ -52,10 +79,31 @@ void ADCSensor::setup() {
         break;
     }
   }
+
+#endif  // USE_ESP32
+
+#ifdef USE_RP2040
+  static bool initialized = false;
+  if (!initialized) {
+    adc_init();
+    initialized = true;
+  }
+#endif
+
+  ESP_LOGCONFIG(TAG, "ADC '%s' setup finished!", this->get_name().c_str());
 }
 
 void ADCSensor::dump_config() {
   LOG_SENSOR("", "ADC Sensor", this);
+#if defined(USE_ESP8266) || defined(USE_LIBRETINY)
+#ifdef USE_ADC_SENSOR_VCC
+  ESP_LOGCONFIG(TAG, "  Pin: VCC");
+#else
+  LOG_PIN("  Pin: ", this->pin_);
+#endif
+#endif  // USE_ESP8266 || USE_LIBRETINY
+
+#ifdef USE_ESP32
   LOG_PIN("  Pin: ", this->pin_);
   if (this->autorange_) {
     ESP_LOGCONFIG(TAG, "  Attenuation: auto");
@@ -77,10 +125,55 @@ void ADCSensor::dump_config() {
         break;
     }
   }
+#endif  // USE_ESP32
+
+#ifdef USE_RP2040
+  if (this->is_temperature_) {
+    ESP_LOGCONFIG(TAG, "  Pin: Temperature");
+  } else {
+#ifdef USE_ADC_SENSOR_VCC
+    ESP_LOGCONFIG(TAG, "  Pin: VCC");
+#else
+    LOG_PIN("  Pin: ", this->pin_);
+#endif  // USE_ADC_SENSOR_VCC
+  }
+#endif  // USE_RP2040
   ESP_LOGCONFIG(TAG, "  Samples: %i", this->sample_count_);
   LOG_UPDATE_INTERVAL(this);
 }
 
+float ADCSensor::get_setup_priority() const { return setup_priority::DATA; }
+void ADCSensor::update() {
+  float value_v = this->sample();
+  ESP_LOGV(TAG, "'%s': Got voltage=%.4fV", this->get_name().c_str(), value_v);
+  this->publish_state(value_v);
+}
+
+void ADCSensor::set_sample_count(uint8_t sample_count) {
+  if (sample_count != 0) {
+    this->sample_count_ = sample_count;
+  }
+}
+
+#ifdef USE_ESP8266
+float ADCSensor::sample() {
+  uint32_t raw = 0;
+  for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
+#ifdef USE_ADC_SENSOR_VCC
+    raw += ESP.getVcc();  // NOLINT(readability-static-accessed-through-instance)
+#else
+    raw += analogRead(this->pin_->get_pin());  // NOLINT
+#endif
+  }
+  raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
+  if (this->output_raw_) {
+    return raw;
+  }
+  return raw / 1024.0f;
+}
+#endif
+
+#ifdef USE_ESP32
 float ADCSensor::sample() {
   if (!this->autorange_) {
     uint32_t sum = 0;
@@ -147,17 +240,93 @@ float ADCSensor::sample() {
   uint32_t mv2 = esp_adc_cal_raw_to_voltage(raw2, &this->cal_characteristics_[(int32_t) ADC_ATTEN_DB_2_5]);
   uint32_t mv0 = esp_adc_cal_raw_to_voltage(raw0, &this->cal_characteristics_[(int32_t) ADC_ATTEN_DB_0]);
 
+  // Contribution of each value, in range 0-2048 (12 bit ADC) or 0-4096 (13 bit ADC)
   uint32_t c12 = std::min(raw12, ADC_HALF);
   uint32_t c6 = ADC_HALF - std::abs(raw6 - ADC_HALF);
   uint32_t c2 = ADC_HALF - std::abs(raw2 - ADC_HALF);
   uint32_t c0 = std::min(ADC_MAX - raw0, ADC_HALF);
+  // max theoretical csum value is 4096*4 = 16384
   uint32_t csum = c12 + c6 + c2 + c0;
 
+  // each mv is max 3900; so max value is 3900*4096*4, fits in unsigned32
   uint32_t mv_scaled = (mv12 * c12) + (mv6 * c6) + (mv2 * c2) + (mv0 * c0);
   return mv_scaled / (float) (csum * 1000U);
 }
+#endif  // USE_ESP32
+
+#ifdef USE_RP2040
+float ADCSensor::sample() {
+  if (this->is_temperature_) {
+    adc_set_temp_sensor_enabled(true);
+    delay(1);
+    adc_select_input(4);
+    uint32_t raw = 0;
+    for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
+      raw += adc_read();
+    }
+    raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
+    adc_set_temp_sensor_enabled(false);
+    if (this->output_raw_) {
+      return raw;
+    }
+    return raw * 3.3f / 4096.0f;
+  } else {
+    uint8_t pin = this->pin_->get_pin();
+#ifdef CYW43_USES_VSYS_PIN
+    if (pin == PICO_VSYS_PIN) {
+      // Measuring VSYS on Raspberry Pico W needs to be wrapped with
+      // `cyw43_thread_enter()`/`cyw43_thread_exit()` as discussed in
+      // https://github.com/raspberrypi/pico-sdk/issues/1222, since Wifi chip and
+      // VSYS ADC both share GPIO29
+      cyw43_thread_enter();
+    }
+#endif  // CYW43_USES_VSYS_PIN
+
+    adc_gpio_init(pin);
+    adc_select_input(pin - 26);
+
+    uint32_t raw = 0;
+    for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
+      raw += adc_read();
+    }
+    raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
+
+#ifdef CYW43_USES_VSYS_PIN
+    if (pin == PICO_VSYS_PIN) {
+      cyw43_thread_exit();
+    }
+#endif  // CYW43_USES_VSYS_PIN
+
+    if (this->output_raw_) {
+      return raw;
+    }
+    float coeff = pin == PICO_VSYS_PIN ? 3.0 : 1.0;
+    return raw * 3.3f / 4096.0f * coeff;
+  }
+}
+#endif
+
+#ifdef USE_LIBRETINY
+float ADCSensor::sample() {
+  uint32_t raw = 0;
+  if (this->output_raw_) {
+    for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
+      raw += analogRead(this->pin_->get_pin());  // NOLINT
+    }
+    raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
+    return raw;
+  }
+  for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
+    raw += analogReadVoltage(this->pin_->get_pin());  // NOLINT
+  }
+  raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
+  return raw / 1000.0f;
+}
+#endif  // USE_LIBRETINY
+
+#ifdef USE_ESP8266
+std::string ADCSensor::unique_id() { return get_mac_address() + "-adc"; }
+#endif
 
 }  // namespace adc
 }  // namespace esphome
-
-#endif  // USE_ESP32

esphome/components/adc/adc_sensor.h

@@ -3,12 +3,13 @@
 #include "esphome/components/sensor/sensor.h"
 #include "esphome/components/voltage_sampler/voltage_sampler.h"
 #include "esphome/core/component.h"
+#include "esphome/core/defines.h"
 #include "esphome/core/hal.h"
 
 #ifdef USE_ESP32
 #include <esp_adc_cal.h>
 #include "driver/adc.h"
-#endif  // USE_ESP32
+#endif
 
 namespace esphome {
 namespace adc {
@@ -42,7 +43,7 @@ class ADCSensor : public sensor::Sensor, public PollingComponent, public voltage
     this->channel1_ = ADC1_CHANNEL_MAX;
   }
   void set_autorange(bool autorange) { this->autorange_ = autorange; }
-#endif  // USE_ESP32
+#endif
 
   /// Update ADC values
   void update() override;
@@ -58,11 +59,11 @@ class ADCSensor : public sensor::Sensor, public PollingComponent, public voltage
 
 #ifdef USE_ESP8266
   std::string unique_id() override;
-#endif  // USE_ESP8266
+#endif
 
 #ifdef USE_RP2040
   void set_is_temperature() { this->is_temperature_ = true; }
-#endif  // USE_RP2040
+#endif
 
  protected:
   InternalGPIOPin *pin_;
@@ -71,7 +72,7 @@ class ADCSensor : public sensor::Sensor, public PollingComponent, public voltage
 
 #ifdef USE_RP2040
   bool is_temperature_{false};
-#endif  // USE_RP2040
+#endif
 
 #ifdef USE_ESP32
   adc_atten_t attenuation_{ADC_ATTEN_DB_0};
@@ -82,8 +83,8 @@ class ADCSensor : public sensor::Sensor, public PollingComponent, public voltage
   esp_adc_cal_characteristics_t cal_characteristics_[SOC_ADC_ATTEN_NUM] = {};
 #else
   esp_adc_cal_characteristics_t cal_characteristics_[ADC_ATTEN_MAX] = {};
-#endif  // ESP_IDF_VERSION_MAJOR
-#endif  // USE_ESP32
+#endif
+#endif
 };
 
 }  // namespace adc

esphome/components/adc/adc_sensor_common.cpp

@@ -1,24 +0,0 @@
-#include "adc_sensor.h"
-#include "esphome/core/log.h"
-
-namespace esphome {
-namespace adc {
-
-static const char *const TAG = "adc.common";
-
-void ADCSensor::update() {
-  float value_v = this->sample();
-  ESP_LOGV(TAG, "'%s': Got voltage=%.4fV", this->get_name().c_str(), value_v);
-  this->publish_state(value_v);
-}
-
-void ADCSensor::set_sample_count(uint8_t sample_count) {
-  if (sample_count != 0) {
-    this->sample_count_ = sample_count;
-  }
-}
-
-float ADCSensor::get_setup_priority() const { return setup_priority::DATA; }
-
-}  // namespace adc
-}  // namespace esphome

esphome/components/adc/adc_sensor_esp8266.cpp

@@ -1,58 +0,0 @@
-#ifdef USE_ESP8266
-
-#include "adc_sensor.h"
-#include "esphome/core/helpers.h"
-#include "esphome/core/log.h"
-
-#ifdef USE_ADC_SENSOR_VCC
-#include <Esp.h>
-ADC_MODE(ADC_VCC)
-#else
-#include <Arduino.h>
-#endif  // USE_ADC_SENSOR_VCC
-
-namespace esphome {
-namespace adc {
-
-static const char *const TAG = "adc.esp8266";
-
-void ADCSensor::setup() {
-  ESP_LOGCONFIG(TAG, "Setting up ADC '%s'...", this->get_name().c_str());
-#ifndef USE_ADC_SENSOR_VCC
-  this->pin_->setup();
-#endif
-}
-
-void ADCSensor::dump_config() {
-  LOG_SENSOR("", "ADC Sensor", this);
-#ifdef USE_ADC_SENSOR_VCC
-  ESP_LOGCONFIG(TAG, "  Pin: VCC");
-#else
-  LOG_PIN("  Pin: ", this->pin_);
-#endif  // USE_ADC_SENSOR_VCC
-  ESP_LOGCONFIG(TAG, "  Samples: %i", this->sample_count_);
-  LOG_UPDATE_INTERVAL(this);
-}
-
-float ADCSensor::sample() {
-  uint32_t raw = 0;
-  for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
-#ifdef USE_ADC_SENSOR_VCC
-    raw += ESP.getVcc();  // NOLINT(readability-static-accessed-through-instance)
-#else
-    raw += analogRead(this->pin_->get_pin());  // NOLINT
-#endif  // USE_ADC_SENSOR_VCC
-  }
-  raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
-  if (this->output_raw_) {
-    return raw;
-  }
-  return raw / 1024.0f;
-}
-
-std::string ADCSensor::unique_id() { return get_mac_address() + "-adc"; }
-
-}  // namespace adc
-}  // namespace esphome
-
-#endif  // USE_ESP8266

esphome/components/adc/adc_sensor_libretiny.cpp

@@ -1,48 +0,0 @@
-#ifdef USE_LIBRETINY
-
-#include "adc_sensor.h"
-#include "esphome/core/log.h"
-
-namespace esphome {
-namespace adc {
-
-static const char *const TAG = "adc.libretiny";
-
-void ADCSensor::setup() {
-  ESP_LOGCONFIG(TAG, "Setting up ADC '%s'...", this->get_name().c_str());
-#ifndef USE_ADC_SENSOR_VCC
-  this->pin_->setup();
-#endif  // !USE_ADC_SENSOR_VCC
-}
-
-void ADCSensor::dump_config() {
-  LOG_SENSOR("", "ADC Sensor", this);
-#ifdef USE_ADC_SENSOR_VCC
-  ESP_LOGCONFIG(TAG, "  Pin: VCC");
-#else   // USE_ADC_SENSOR_VCC
-  LOG_PIN("  Pin: ", this->pin_);
-#endif  // USE_ADC_SENSOR_VCC
-  ESP_LOGCONFIG(TAG, "  Samples: %i", this->sample_count_);
-  LOG_UPDATE_INTERVAL(this);
-}
-
-float ADCSensor::sample() {
-  uint32_t raw = 0;
-  if (this->output_raw_) {
-    for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
-      raw += analogRead(this->pin_->get_pin());  // NOLINT
-    }
-    raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
-    return raw;
-  }
-  for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
-    raw += analogReadVoltage(this->pin_->get_pin());  // NOLINT
-  }
-  raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
-  return raw / 1000.0f;
-}
-
-}  // namespace adc
-}  // namespace esphome
-
-#endif  // USE_LIBRETINY

esphome/components/adc/adc_sensor_rp2040.cpp

@@ -1,93 +0,0 @@
-#ifdef USE_RP2040
-
-#include "adc_sensor.h"
-#include "esphome/core/log.h"
-
-#ifdef CYW43_USES_VSYS_PIN
-#include "pico/cyw43_arch.h"
-#endif  // CYW43_USES_VSYS_PIN
-#include <hardware/adc.h>
-
-namespace esphome {
-namespace adc {
-
-static const char *const TAG = "adc.rp2040";
-
-void ADCSensor::setup() {
-  ESP_LOGCONFIG(TAG, "Setting up ADC '%s'...", this->get_name().c_str());
-  static bool initialized = false;
-  if (!initialized) {
-    adc_init();
-    initialized = true;
-  }
-}
-
-void ADCSensor::dump_config() {
-  LOG_SENSOR("", "ADC Sensor", this);
-  if (this->is_temperature_) {
-    ESP_LOGCONFIG(TAG, "  Pin: Temperature");
-  } else {
-#ifdef USE_ADC_SENSOR_VCC
-    ESP_LOGCONFIG(TAG, "  Pin: VCC");
-#else
-    LOG_PIN("  Pin: ", this->pin_);
-#endif  // USE_ADC_SENSOR_VCC
-  }
-  ESP_LOGCONFIG(TAG, "  Samples: %i", this->sample_count_);
-  LOG_UPDATE_INTERVAL(this);
-}
-
-float ADCSensor::sample() {
-  if (this->is_temperature_) {
-    adc_set_temp_sensor_enabled(true);
-    delay(1);
-    adc_select_input(4);
-    uint32_t raw = 0;
-    for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
-      raw += adc_read();
-    }
-    raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
-    adc_set_temp_sensor_enabled(false);
-    if (this->output_raw_) {
-      return raw;
-    }
-    return raw * 3.3f / 4096.0f;
-  }
-
-  uint8_t pin = this->pin_->get_pin();
-#ifdef CYW43_USES_VSYS_PIN
-  if (pin == PICO_VSYS_PIN) {
-    // Measuring VSYS on Raspberry Pico W needs to be wrapped with
-    // `cyw43_thread_enter()`/`cyw43_thread_exit()` as discussed in
-    // https://github.com/raspberrypi/pico-sdk/issues/1222, since Wifi chip and
-    // VSYS ADC both share GPIO29
-    cyw43_thread_enter();
-  }
-#endif  // CYW43_USES_VSYS_PIN
-
-  adc_gpio_init(pin);
-  adc_select_input(pin - 26);
-
-  uint32_t raw = 0;
-  for (uint8_t sample = 0; sample < this->sample_count_; sample++) {
-    raw += adc_read();
-  }
-  raw = (raw + (this->sample_count_ >> 1)) / this->sample_count_;  // NOLINT(clang-analyzer-core.DivideZero)
-
-#ifdef CYW43_USES_VSYS_PIN
-  if (pin == PICO_VSYS_PIN) {
-    cyw43_thread_exit();
-  }
-#endif  // CYW43_USES_VSYS_PIN
-
-  if (this->output_raw_) {
-    return raw;
-  }
-  float coeff = pin == PICO_VSYS_PIN ? 3.0f : 1.0f;
-  return raw * 3.3f / 4096.0f * coeff;
-}
-
-}  // namespace adc
-}  // namespace esphome
-
-#endif  // USE_RP2040

esphome/components/alarm_control_panel/alarm_control_panel_call.cpp

@@ -72,9 +72,10 @@ void AlarmControlPanelCall::validate_() {
       this->state_.reset();
       return;
     }
-    if (state == ACP_STATE_DISARMED && !this->parent_->is_state_armed(this->parent_->get_state()) &&
-        this->parent_->get_state() != ACP_STATE_PENDING && this->parent_->get_state() != ACP_STATE_ARMING &&
-        this->parent_->get_state() != ACP_STATE_TRIGGERED) {
+    if (state == ACP_STATE_DISARMED &&
+        !(this->parent_->is_state_armed(this->parent_->get_state()) ||
+          this->parent_->get_state() == ACP_STATE_PENDING || this->parent_->get_state() == ACP_STATE_ARMING ||
+          this->parent_->get_state() == ACP_STATE_TRIGGERED)) {
       ESP_LOGW(TAG, "Cannot disarm when not armed");
       this->state_.reset();
       return;

esphome/components/animation/__init__.py

@@ -2,6 +2,7 @@ import logging
 
 from esphome import automation, core
 import esphome.codegen as cg
+from esphome.components import font
 import esphome.components.image as espImage
 from esphome.components.image import (
     CONF_USE_TRANSPARENCY,
@@ -130,7 +131,7 @@ ANIMATION_SCHEMA = cv.Schema(
     )
 )
 
-CONFIG_SCHEMA = ANIMATION_SCHEMA
+CONFIG_SCHEMA = cv.All(font.validate_pillow_installed, ANIMATION_SCHEMA)
 
 NEXT_FRAME_SCHEMA = automation.maybe_simple_id(
     {

esphome/components/apds9306/apds9306.cpp

@@ -122,8 +122,7 @@ void APDS9306::update() {
 
   this->status_clear_warning();
 
-  status &= 0b00001000;
-  if (!status) {  // No new data
+  if (!(status &= 0b00001000)) {  // No new data
     return;
   }
 

esphome/components/audio/audio.h

@@ -1,7 +1,7 @@
 #pragma once
 
-#include <cstddef>
 #include <cstdint>
+#include <stddef.h>
 
 namespace esphome {
 namespace audio {

esphome/components/binary_sensor/binary_sensor.h

@@ -58,7 +58,7 @@ class BinarySensor : public EntityBase, public EntityBase_DeviceClass {
   void publish_initial_state(bool state);
 
   /// The current reported state of the binary sensor.
-  bool state{false};
+  bool state;
 
   void add_filter(Filter *filter);
   void add_filters(const std::vector<Filter *> &filters);

esphome/components/bk72xx/__init__.py

@@ -15,7 +15,7 @@ from esphome.components.libretiny.const import (
 )
 from esphome.core import CORE
 
-from .boards import BK72XX_BOARD_PINS, BK72XX_BOARDS
+from .boards import BK72XX_BOARDS, BK72XX_BOARD_PINS
 
 CODEOWNERS = ["@kuba2k2"]
 AUTO_LOAD = ["libretiny"]

esphome/components/bme68x_bsec2/bme68x_bsec2.cpp

@@ -204,11 +204,11 @@ void BME68xBSEC2Component::update_subscription_() {
 }
 
 void BME68xBSEC2Component::run_() {
-  this->op_mode_ = this->bsec_settings_.op_mode;
   int64_t curr_time_ns = this->get_time_ns_();
-  if (curr_time_ns < this->bsec_settings_.next_call) {
+  if (curr_time_ns < this->next_call_ns_) {
     return;
   }
+  this->op_mode_ = this->bsec_settings_.op_mode;
   uint8_t status;
 
   ESP_LOGV(TAG, "Performing sensor run");
@@ -219,60 +219,57 @@ void BME68xBSEC2Component::run_() {
     ESP_LOGW(TAG, "Failed to fetch sensor control settings (BSEC2 error code %d)", this->bsec_status_);
     return;
   }
+  this->next_call_ns_ = this->bsec_settings_.next_call;
 
-  switch (this->bsec_settings_.op_mode) {
-    case BME68X_FORCED_MODE:
-      bme68x_get_conf(&bme68x_conf, &this->bme68x_);
+  if (this->bsec_settings_.trigger_measurement) {
+    bme68x_get_conf(&bme68x_conf, &this->bme68x_);
 
-      bme68x_conf.os_hum = this->bsec_settings_.humidity_oversampling;
-      bme68x_conf.os_temp = this->bsec_settings_.temperature_oversampling;
-      bme68x_conf.os_pres = this->bsec_settings_.pressure_oversampling;
-      bme68x_set_conf(&bme68x_conf, &this->bme68x_);
-      this->bme68x_heatr_conf_.enable = BME68X_ENABLE;
-      this->bme68x_heatr_conf_.heatr_temp = this->bsec_settings_.heater_temperature;
-      this->bme68x_heatr_conf_.heatr_dur = this->bsec_settings_.heater_duration;
-
-      // status = bme68x_set_op_mode(this->bsec_settings_.op_mode, &this->bme68x_);
-      status = bme68x_set_heatr_conf(BME68X_FORCED_MODE, &this->bme68x_heatr_conf_, &this->bme68x_);
-      status = bme68x_set_op_mode(BME68X_FORCED_MODE, &this->bme68x_);
-      this->op_mode_ = BME68X_FORCED_MODE;
-      ESP_LOGV(TAG, "Using forced mode");
-
-      break;
-    case BME68X_PARALLEL_MODE:
-      if (this->op_mode_ != this->bsec_settings_.op_mode) {
-        bme68x_get_conf(&bme68x_conf, &this->bme68x_);
-
-        bme68x_conf.os_hum = this->bsec_settings_.humidity_oversampling;
-        bme68x_conf.os_temp = this->bsec_settings_.temperature_oversampling;
-        bme68x_conf.os_pres = this->bsec_settings_.pressure_oversampling;
-        bme68x_set_conf(&bme68x_conf, &this->bme68x_);
+    bme68x_conf.os_hum = this->bsec_settings_.humidity_oversampling;
+    bme68x_conf.os_temp = this->bsec_settings_.temperature_oversampling;
+    bme68x_conf.os_pres = this->bsec_settings_.pressure_oversampling;
+    bme68x_set_conf(&bme68x_conf, &this->bme68x_);
 
+    switch (this->bsec_settings_.op_mode) {
+      case BME68X_FORCED_MODE:
         this->bme68x_heatr_conf_.enable = BME68X_ENABLE;
-        this->bme68x_heatr_conf_.heatr_temp_prof = this->bsec_settings_.heater_temperature_profile;
-        this->bme68x_heatr_conf_.heatr_dur_prof = this->bsec_settings_.heater_duration_profile;
-        this->bme68x_heatr_conf_.profile_len = this->bsec_settings_.heater_profile_len;
-        this->bme68x_heatr_conf_.shared_heatr_dur =
-            BSEC_TOTAL_HEAT_DUR -
-            (bme68x_get_meas_dur(BME68X_PARALLEL_MODE, &bme68x_conf, &this->bme68x_) / INT64_C(1000));
+        this->bme68x_heatr_conf_.heatr_temp = this->bsec_settings_.heater_temperature;
+        this->bme68x_heatr_conf_.heatr_dur = this->bsec_settings_.heater_duration;
 
-        status = bme68x_set_heatr_conf(BME68X_PARALLEL_MODE, &this->bme68x_heatr_conf_, &this->bme68x_);
+        status = bme68x_set_op_mode(this->bsec_settings_.op_mode, &this->bme68x_);
+        status = bme68x_set_heatr_conf(BME68X_FORCED_MODE, &this->bme68x_heatr_conf_, &this->bme68x_);
+        status = bme68x_set_op_mode(BME68X_FORCED_MODE, &this->bme68x_);
+        this->op_mode_ = BME68X_FORCED_MODE;
+        this->sleep_mode_ = false;
+        ESP_LOGV(TAG, "Using forced mode");
 
-        status = bme68x_set_op_mode(BME68X_PARALLEL_MODE, &this->bme68x_);
-        this->op_mode_ = BME68X_PARALLEL_MODE;
-        ESP_LOGV(TAG, "Using parallel mode");
-      }
-      break;
-    case BME68X_SLEEP_MODE:
-      if (this->op_mode_ != this->bsec_settings_.op_mode) {
-        bme68x_set_op_mode(BME68X_SLEEP_MODE, &this->bme68x_);
-        this->op_mode_ = BME68X_SLEEP_MODE;
-        ESP_LOGV(TAG, "Using sleep mode");
-      }
-      break;
-  }
+        break;
+      case BME68X_PARALLEL_MODE:
+        if (this->op_mode_ != this->bsec_settings_.op_mode) {
+          this->bme68x_heatr_conf_.enable = BME68X_ENABLE;
+          this->bme68x_heatr_conf_.heatr_temp_prof = this->bsec_settings_.heater_temperature_profile;
+          this->bme68x_heatr_conf_.heatr_dur_prof = this->bsec_settings_.heater_duration_profile;
+          this->bme68x_heatr_conf_.profile_len = this->bsec_settings_.heater_profile_len;
+          this->bme68x_heatr_conf_.shared_heatr_dur =
+              BSEC_TOTAL_HEAT_DUR -
+              (bme68x_get_meas_dur(BME68X_PARALLEL_MODE, &bme68x_conf, &this->bme68x_) / INT64_C(1000));
+
+          status = bme68x_set_heatr_conf(BME68X_PARALLEL_MODE, &this->bme68x_heatr_conf_, &this->bme68x_);
+
+          status = bme68x_set_op_mode(BME68X_PARALLEL_MODE, &this->bme68x_);
+          this->op_mode_ = BME68X_PARALLEL_MODE;
+          this->sleep_mode_ = false;
+          ESP_LOGV(TAG, "Using parallel mode");
+        }
+        break;
+      case BME68X_SLEEP_MODE:
+        if (!this->sleep_mode_) {
+          bme68x_set_op_mode(BME68X_SLEEP_MODE, &this->bme68x_);
+          this->sleep_mode_ = true;
+          ESP_LOGV(TAG, "Using sleep mode");
+        }
+        break;
+    }
 
-  if (this->bsec_settings_.trigger_measurement && this->bsec_settings_.op_mode != BME68X_SLEEP_MODE) {
     uint32_t meas_dur = 0;
     meas_dur = bme68x_get_meas_dur(this->op_mode_, &bme68x_conf, &this->bme68x_);
     ESP_LOGV(TAG, "Queueing read in %uus", meas_dur);

esphome/components/bme68x_bsec2/bme68x_bsec2.h

@@ -113,11 +113,13 @@ class BME68xBSEC2Component : public Component {
 
   struct bme68x_heatr_conf bme68x_heatr_conf_;
   uint8_t op_mode_;  // operating mode of sensor
+  bool sleep_mode_;
   bsec_library_return_t bsec_status_{BSEC_OK};
   int8_t bme68x_status_{BME68X_OK};
 
   int64_t last_time_ms_{0};
   uint32_t millis_overflow_counter_{0};
+  int64_t next_call_ns_{0};
 
   std::queue<std::function<void()>> queue_;
 

esphome/components/bytebuffer/__init__.py

@@ -1,5 +0,0 @@
-CODEOWNERS = ["@clydebarrow"]
-
-# Allows bytebuffer to be configured in yaml, to allow use of the C++ api.
-
-CONFIG_SCHEMA = {}

esphome/components/bytebuffer/bytebuffer.h

@@ -1,421 +0,0 @@
-#pragma once
-
-#include <utility>
-#include <vector>
-#include <cinttypes>
-#include <cstddef>
-#include "esphome/core/helpers.h"
-
-namespace esphome {
-namespace bytebuffer {
-
-enum Endian { LITTLE, BIG };
-
-/**
- * A class modelled on the Java ByteBuffer class. It wraps a vector of bytes and permits putting and getting
- * items of various sizes, with an automatically incremented position.
- *
- * There are three variables maintained pointing into the buffer:
- *
- * capacity: the maximum amount of data that can be stored - set on construction and cannot be changed
- * limit: the limit of the data currently available to get or put
- * position: the current insert or extract position
- *
- * 0 <= position <= limit <= capacity
- *
- * In addition a mark can be set to the current position with mark(). A subsequent call to reset() will restore
- * the position to the mark.
- *
- * The buffer can be marked to be little-endian (default) or big-endian. All subsequent operations will use that order.
- *
- * The flip() operation will reset the position to 0 and limit to the current position. This is useful for reading
- * data from a buffer after it has been written.
- *
- * The code is defined here in the header file rather than in a .cpp file, so that it does not get compiled if not used.
- * The templated functions ensure that only those typed functions actually used are compiled. The functions
- * are implicitly inline-able which will aid performance.
- */
-class ByteBuffer {
- public:
-  // Default constructor (compatibility with TEMPLATABLE_VALUE)
-  // Creates a zero-length ByteBuffer which is little use to anybody.
-  ByteBuffer() : ByteBuffer(std::vector<uint8_t>()) {}
-
-  /**
-   * Create a new Bytebuffer with the given capacity
-   */
-  ByteBuffer(size_t capacity, Endian endianness = LITTLE)
-      : data_(std::vector<uint8_t>(capacity)), endianness_(endianness), limit_(capacity){};
-
-  // templated functions to implement putting and getting data of various types. There are two flavours of all
-  // functions - one that uses the position as the offset, and updates the position accordingly, and one that
-  // takes an explicit offset and does not update the position.
-  // Separate temnplates are provided for types that fit into 32 bits and those that are bigger. These delegate
-  // the actual put/get to common code based around those sizes.
-  // This reduces the code size and execution time for smaller types. A similar structure for e.g. 16 bits is unlikely
-  // to provide any further benefit given that all target platforms are native 32 bit.
-
-  template<typename T>
-  T get(typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) <= sizeof(uint32_t)), T>::type * = 0) {
-    // integral types that fit into 32 bit
-    return static_cast<T>(this->get_uint32_(sizeof(T)));
-  }
-
-  template<typename T>
-  T get(size_t offset, typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) <= sizeof(uint32_t)), T>::type * = 0) {
-    return static_cast<T>(this->get_uint32_(offset, sizeof(T)));
-  }
-
-  template<typename T>
-  void put(const T &value, typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) <= sizeof(uint32_t)), T>::type * = 0) {
-    this->put_uint32_(static_cast<uint32_t>(value), sizeof(T));
-  }
-
-  template<typename T>
-  void put(const T &value, size_t offset, typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) <= sizeof(uint32_t)), T>::type * = 0) {
-    this->put_uint32_(static_cast<uint32_t>(value), offset, sizeof(T));
-  }
-
-  // integral types that do not fit into 32 bit (basically only 64 bit types)
-  template<typename T>
-  T get(typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    return static_cast<T>(this->get_uint64_(sizeof(T)));
-  }
-
-  template<typename T>
-  T get(size_t offset, typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    return static_cast<T>(this->get_uint64_(offset, sizeof(T)));
-  }
-
-  template<typename T>
-  void put(const T &value, typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    this->put_uint64_(value, sizeof(T));
-  }
-
-  template<typename T>
-  void put(const T &value, size_t offset, typename std::enable_if<std::is_integral<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    this->put_uint64_(static_cast<uint64_t>(value), offset, sizeof(T));
-  }
-
-  // floating point types. Caters for 32 and 64 bit floating point.
-  template<typename T>
-  T get(typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) == sizeof(uint32_t)), T>::type * = 0) {
-    return bit_cast<T>(this->get_uint32_(sizeof(T)));
-  }
-
-  template<typename T>
-  T get(typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    return bit_cast<T>(this->get_uint64_(sizeof(T)));
-  }
-
-  template<typename T>
-  T get(size_t offset, typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) == sizeof(uint32_t)), T>::type * = 0) {
-    return bit_cast<T>(this->get_uint32_(offset, sizeof(T)));
-  }
-
-  template<typename T>
-  T get(size_t offset, typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-        typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    return bit_cast<T>(this->get_uint64_(offset, sizeof(T)));
-  }
-  template<typename T>
-  void put(const T &value, typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) <= sizeof(uint32_t)), T>::type * = 0) {
-    this->put_uint32_(bit_cast<uint32_t>(value), sizeof(T));
-  }
-
-  template<typename T>
-  void put(const T &value, typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    this->put_uint64_(bit_cast<uint64_t>(value), sizeof(T));
-  }
-
-  template<typename T>
-  void put(const T &value, size_t offset, typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) <= sizeof(uint32_t)), T>::type * = 0) {
-    this->put_uint32_(bit_cast<uint32_t>(value), offset, sizeof(T));
-  }
-
-  template<typename T>
-  void put(const T &value, size_t offset, typename std::enable_if<std::is_floating_point<T>::value, T>::type * = 0,
-           typename std::enable_if<(sizeof(T) == sizeof(uint64_t)), T>::type * = 0) {
-    this->put_uint64_(bit_cast<uint64_t>(value), offset, sizeof(T));
-  }
-
-  template<typename T> static ByteBuffer wrap(T value, Endian endianness = LITTLE) {
-    ByteBuffer buffer = ByteBuffer(sizeof(T), endianness);
-    buffer.put(value);
-    buffer.flip();
-    return buffer;
-  }
-
-  static ByteBuffer wrap(std::vector<uint8_t> const &data, Endian endianness = LITTLE) {
-    ByteBuffer buffer = {data};
-    buffer.endianness_ = endianness;
-    return buffer;
-  }
-
-  static ByteBuffer wrap(const uint8_t *ptr, size_t len, Endian endianness = LITTLE) {
-    return wrap(std::vector<uint8_t>(ptr, ptr + len), endianness);
-  }
-
-  // convenience functions with explicit types named..
-  void put_float(float value) { this->put(value); }
-  void put_double(double value) { this->put(value); }
-
-  uint8_t get_uint8() { return this->data_[this->position_++]; }
-  // Get a 16 bit unsigned value, increment by 2
-  uint16_t get_uint16() { return this->get<uint16_t>(); }
-  // Get a 24 bit unsigned value, increment by 3
-  uint32_t get_uint24() { return this->get_uint32_(3); };
-  // Get a 32 bit unsigned value, increment by 4
-  uint32_t get_uint32() { return this->get<uint32_t>(); };
-  // Get a 64 bit unsigned value, increment by 8
-  uint64_t get_uint64() { return this->get<uint64_t>(); };
-  // Signed versions of the get functions
-  uint8_t get_int8() { return static_cast<int8_t>(this->get_uint8()); };
-  int16_t get_int16() { return this->get<uint16_t>(); }
-  int32_t get_int32() { return this->get<int32_t>(); }
-  int64_t get_int64() { return this->get<int64_t>(); }
-  // Get a float value, increment by 4
-  float get_float() { return this->get<float>(); }
-  // Get a double value, increment by 8
-  double get_double() { return this->get<double>(); }
-
-  // Get a bool value, increment by 1
-  bool get_bool() { return static_cast<bool>(this->get_uint8()); }
-
-  uint32_t get_int24(size_t offset) {
-    auto value = this->get_uint24(offset);
-    uint32_t mask = (~static_cast<uint32_t>(0)) << 23;
-    if ((value & mask) != 0)
-      value |= mask;
-    return value;
-  }
-
-  uint32_t get_int24() {
-    auto value = this->get_uint24();
-    uint32_t mask = (~static_cast<uint32_t>(0)) << 23;
-    if ((value & mask) != 0)
-      value |= mask;
-    return value;
-  }
-  std::vector<uint8_t> get_vector(size_t length, size_t offset) {
-    auto start = this->data_.begin() + offset;
-    return {start, start + length};
-  }
-
-  std::vector<uint8_t> get_vector(size_t length) {
-    auto result = this->get_vector(length, this->position_);
-    this->position_ += length;
-    return result;
-  }
-
-  // Convenience named functions
-  void put_uint8(uint8_t value) { this->data_[this->position_++] = value; }
-  void put_uint16(uint16_t value) { this->put(value); }
-  void put_uint24(uint32_t value) { this->put_uint32_(value, 3); }
-  void put_uint32(uint32_t value) { this->put(value); }
-  void put_uint64(uint64_t value) { this->put(value); }
-  // Signed versions of the put functions
-  void put_int8(int8_t value) { this->put_uint8(static_cast<uint8_t>(value)); }
-  void put_int16(int16_t value) { this->put(value); }
-  void put_int24(int32_t value) { this->put_uint32_(value, 3); }
-  void put_int32(int32_t value) { this->put(value); }
-  void put_int64(int64_t value) { this->put(value); }
-  // Extra put functions
-  void put_bool(bool value) { this->put_uint8(value); }
-
-  // versions of the above with an offset, these do not update the position
-
-  uint64_t get_uint64(size_t offset) { return this->get<uint64_t>(offset); }
-  uint32_t get_uint24(size_t offset) { return this->get_uint32_(offset, 3); };
-  double get_double(size_t offset) { return get<double>(offset); }
-
-  // Get one byte from the buffer, increment position by 1
-  uint8_t get_uint8(size_t offset) { return this->data_[offset]; }
-  // Get a 16 bit unsigned value, increment by 2
-  uint16_t get_uint16(size_t offset) { return get<uint16_t>(offset); }
-  // Get a 24 bit unsigned value, increment by 3
-  uint32_t get_uint32(size_t offset) { return this->get<uint32_t>(offset); };
-  // Get a 64 bit unsigned value, increment by 8
-  uint8_t get_int8(size_t offset) { return get<int8_t>(offset); }
-  int16_t get_int16(size_t offset) { return get<int16_t>(offset); }
-  int32_t get_int32(size_t offset) { return get<int32_t>(offset); }
-  int64_t get_int64(size_t offset) { return get<int64_t>(offset); }
-  // Get a float value, increment by 4
-  float get_float(size_t offset) { return get<float>(offset); }
-  // Get a double value, increment by 8
-
-  // Get a bool value, increment by 1
-  bool get_bool(size_t offset) { return this->get_uint8(offset); }
-
-  void put_uint8(uint8_t value, size_t offset) { this->data_[offset] = value; }
-  void put_uint16(uint16_t value, size_t offset) { this->put(value, offset); }
-  void put_uint24(uint32_t value, size_t offset) { this->put(value, offset); }
-  void put_uint32(uint32_t value, size_t offset) { this->put(value, offset); }
-  void put_uint64(uint64_t value, size_t offset) { this->put(value, offset); }
-  // Signed versions of the put functions
-  void put_int8(int8_t value, size_t offset) { this->put_uint8(static_cast<uint8_t>(value), offset); }
-  void put_int16(int16_t value, size_t offset) { this->put(value, offset); }
-  void put_int24(int32_t value, size_t offset) { this->put_uint32_(value, offset, 3); }
-  void put_int32(int32_t value, size_t offset) { this->put(value, offset); }
-  void put_int64(int64_t value, size_t offset) { this->put(value, offset); }
-  // Extra put functions
-  void put_float(float value, size_t offset) { this->put(value, offset); }
-  void put_double(double value, size_t offset) { this->put(value, offset); }
-  void put_bool(bool value, size_t offset) { this->put_uint8(value, offset); }
-  void put(const std::vector<uint8_t> &value, size_t offset) {
-    std::copy(value.begin(), value.end(), this->data_.begin() + offset);
-  }
-  void put_vector(const std::vector<uint8_t> &value, size_t offset) { this->put(value, offset); }
-  void put(const std::vector<uint8_t> &value) {
-    this->put_vector(value, this->position_);
-    this->position_ += value.size();
-  }
-  void put_vector(const std::vector<uint8_t> &value) { this->put(value); }
-
-  // Getters
-
-  inline size_t get_capacity() const { return this->data_.size(); }
-  inline size_t get_position() const { return this->position_; }
-  inline size_t get_limit() const { return this->limit_; }
-  inline size_t get_remaining() const { return this->get_limit() - this->get_position(); }
-  inline Endian get_endianness() const { return this->endianness_; }
-  inline void mark() { this->mark_ = this->position_; }
-  inline void big_endian() { this->endianness_ = BIG; }
-  inline void little_endian() { this->endianness_ = LITTLE; }
-  // retrieve a pointer to the underlying data.
-  std::vector<uint8_t> get_data() { return this->data_; };
-
-  void get_bytes(void *dest, size_t length) {
-    std::copy(this->data_.begin() + this->position_, this->data_.begin() + this->position_ + length, (uint8_t *) dest);
-    this->position_ += length;
-  }
-
-  void get_bytes(void *dest, size_t length, size_t offset) {
-    std::copy(this->data_.begin() + offset, this->data_.begin() + offset + length, (uint8_t *) dest);
-  }
-
-  void rewind() { this->position_ = 0; }
-  void reset() { this->position_ = this->mark_; }
-
-  void set_limit(size_t limit) { this->limit_ = limit; }
-  void set_position(size_t position) { this->position_ = position; }
-  void clear() {
-    this->limit_ = this->get_capacity();
-    this->position_ = 0;
-  }
-  void flip() {
-    this->limit_ = this->position_;
-    this->position_ = 0;
-  }
-
- protected:
-  uint64_t get_uint64_(size_t offset, size_t length) const {
-    uint64_t value = 0;
-    if (this->endianness_ == LITTLE) {
-      offset += length;
-      while (length-- != 0) {
-        value <<= 8;
-        value |= this->data_[--offset];
-      }
-    } else {
-      while (length-- != 0) {
-        value <<= 8;
-        value |= this->data_[offset++];
-      }
-    }
-    return value;
-  }
-
-  uint64_t get_uint64_(size_t length) {
-    auto result = this->get_uint64_(this->position_, length);
-    this->position_ += length;
-    return result;
-  }
-  uint32_t get_uint32_(size_t offset, size_t length) const {
-    uint32_t value = 0;
-    if (this->endianness_ == LITTLE) {
-      offset += length;
-      while (length-- != 0) {
-        value <<= 8;
-        value |= this->data_[--offset];
-      }
-    } else {
-      while (length-- != 0) {
-        value <<= 8;
-        value |= this->data_[offset++];
-      }
-    }
-    return value;
-  }
-
-  uint32_t get_uint32_(size_t length) {
-    auto result = this->get_uint32_(this->position_, length);
-    this->position_ += length;
-    return result;
-  }
-
-  /// Putters
-
-  void put_uint64_(uint64_t value, size_t length) {
-    this->put_uint64_(value, this->position_, length);
-    this->position_ += length;
-  }
-  void put_uint32_(uint32_t value, size_t length) {
-    this->put_uint32_(value, this->position_, length);
-    this->position_ += length;
-  }
-
-  void put_uint64_(uint64_t value, size_t offset, size_t length) {
-    if (this->endianness_ == LITTLE) {
-      while (length-- != 0) {
-        this->data_[offset++] = static_cast<uint8_t>(value);
-        value >>= 8;
-      }
-    } else {
-      offset += length;
-      while (length-- != 0) {
-        this->data_[--offset] = static_cast<uint8_t>(value);
-        value >>= 8;
-      }
-    }
-  }
-
-  void put_uint32_(uint32_t value, size_t offset, size_t length) {
-    if (this->endianness_ == LITTLE) {
-      while (length-- != 0) {
-        this->data_[offset++] = static_cast<uint8_t>(value);
-        value >>= 8;
-      }
-    } else {
-      offset += length;
-      while (length-- != 0) {
-        this->data_[--offset] = static_cast<uint8_t>(value);
-        value >>= 8;
-      }
-    }
-  }
-  ByteBuffer(std::vector<uint8_t> const &data) : data_(data), limit_(data.size()) {}
-
-  std::vector<uint8_t> data_;
-  Endian endianness_{LITTLE};
-  size_t position_{0};
-  size_t mark_{0};
-  size_t limit_{0};
-};
-
-}  // namespace bytebuffer
-}  // namespace esphome

esphome/components/climate/__init__.py

@@ -119,21 +119,10 @@ visual_temperature = cv.float_with_unit(
 )
 
 
-VISUAL_TEMPERATURE_STEP_SCHEMA = cv.Schema(
-    {
-        cv.Required(CONF_TARGET_TEMPERATURE): visual_temperature,
-        cv.Required(CONF_CURRENT_TEMPERATURE): visual_temperature,
-    }
-)
-
-
-def visual_temperature_step(value):
-
-    # Allow defining target/current temperature steps separately
+def single_visual_temperature(value):
     if isinstance(value, dict):
-        return VISUAL_TEMPERATURE_STEP_SCHEMA(value)
+        return value
 
-    # Otherwise, use the single value for both properties
     value = visual_temperature(value)
     return VISUAL_TEMPERATURE_STEP_SCHEMA(
         {
@@ -152,6 +141,16 @@ ControlTrigger = climate_ns.class_(
     "ControlTrigger", automation.Trigger.template(ClimateCall.operator("ref"))
 )
 
+VISUAL_TEMPERATURE_STEP_SCHEMA = cv.Any(
+    single_visual_temperature,
+    cv.Schema(
+        {
+            cv.Required(CONF_TARGET_TEMPERATURE): visual_temperature,
+            cv.Required(CONF_CURRENT_TEMPERATURE): visual_temperature,
+        }
+    ),
+)
+
 CLIMATE_SCHEMA = (
     cv.ENTITY_BASE_SCHEMA.extend(web_server.WEBSERVER_SORTING_SCHEMA)
     .extend(cv.MQTT_COMMAND_COMPONENT_SCHEMA)
@@ -163,7 +162,7 @@ CLIMATE_SCHEMA = (
                 {
                     cv.Optional(CONF_MIN_TEMPERATURE): cv.temperature,
                     cv.Optional(CONF_MAX_TEMPERATURE): cv.temperature,
-                    cv.Optional(CONF_TEMPERATURE_STEP): visual_temperature_step,
+                    cv.Optional(CONF_TEMPERATURE_STEP): VISUAL_TEMPERATURE_STEP_SCHEMA,
                     cv.Optional(CONF_MIN_HUMIDITY): cv.percentage_int,
                     cv.Optional(CONF_MAX_HUMIDITY): cv.percentage_int,
                 }

esphome/components/cse7766/cse7766.cpp

@@ -43,7 +43,7 @@ bool CSE7766Component::check_byte_() {
   uint8_t index = this->raw_data_index_;
   uint8_t byte = this->raw_data_[index];
   if (index == 0) {
-    return (byte == 0x55) || ((byte & 0xF0) == 0xF0) || (byte == 0xAA);
+    return !((byte != 0x55) && ((byte & 0xF0) != 0xF0) && (byte != 0xAA));
   }
 
   if (index == 1) {

esphome/components/datetime/__init__.py

@@ -70,6 +70,8 @@ def _validate_time_present(config):
 
 
 _DATETIME_SCHEMA = cv.ENTITY_BASE_SCHEMA.extend(
+    web_server.WEBSERVER_SORTING_SCHEMA,
+    cv.MQTT_COMMAND_COMPONENT_SCHEMA,
     cv.Schema(
         {
             cv.Optional(CONF_ON_VALUE): automation.validate_automation(
@@ -79,9 +81,7 @@ _DATETIME_SCHEMA = cv.ENTITY_BASE_SCHEMA.extend(
             ),
             cv.Optional(CONF_TIME_ID): cv.use_id(time.RealTimeClock),
         }
-    )
-    .extend(web_server.WEBSERVER_SORTING_SCHEMA)
-    .extend(cv.MQTT_COMMAND_COMPONENT_SCHEMA)
+    ),
 ).add_extra(_validate_time_present)
 
 

esphome/components/datetime/datetime_entity.cpp

@@ -60,7 +60,9 @@ ESPTime DateTimeEntity::state_as_esptime() const {
   obj.hour = this->hour_;
   obj.minute = this->minute_;
   obj.second = this->second_;
-  obj.recalc_timestamp_local();
+  obj.day_of_week = 1;  // Required to be valid for recalc_timestamp_local but not used.
+  obj.day_of_year = 1;  // Required to be valid for recalc_timestamp_local but not used.
+  obj.recalc_timestamp_local(false);
   return obj;
 }
 

esphome/components/debug/debug_component.cpp

@@ -1,12 +1,12 @@
 #include "debug_component.h"
 
 #include <algorithm>
-#include "esphome/core/log.h"
-#include "esphome/core/hal.h"
-#include "esphome/core/helpers.h"
-#include "esphome/core/version.h"
 #include <cinttypes>
 #include <climits>
+#include "esphome/core/hal.h"
+#include "esphome/core/helpers.h"
+#include "esphome/core/log.h"
+#include "esphome/core/version.h"
 
 namespace esphome {
 namespace debug {

esphome/components/deep_sleep/deep_sleep_esp32.cpp

@@ -52,11 +52,11 @@ void DeepSleepComponent::dump_config_platform_() {
 
 bool DeepSleepComponent::prepare_to_sleep_() {
   if (this->wakeup_pin_mode_ == WAKEUP_PIN_MODE_KEEP_AWAKE && this->wakeup_pin_ != nullptr &&
-      this->wakeup_pin_->digital_read()) {
+      !this->sleep_duration_.has_value() && this->wakeup_pin_->digital_read()) {
     // Defer deep sleep until inactive
     if (!this->next_enter_deep_sleep_) {
       this->status_set_warning();
-      ESP_LOGW(TAG, "Waiting wakeup pin state change to enter deep sleep...");
+      ESP_LOGW(TAG, "Waiting for pin_ to switch state to enter deep sleep...");
     }
     this->next_enter_deep_sleep_ = true;
     return false;

esphome/components/dfplayer/dfplayer.cpp

@@ -6,104 +6,7 @@ namespace dfplayer {
 
 static const char *const TAG = "dfplayer";
 
-void DFPlayer::next() {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Playing next track");
-  this->send_cmd_(0x01);
-}
-
-void DFPlayer::previous() {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Playing previous track");
-  this->send_cmd_(0x02);
-}
-void DFPlayer::play_mp3(uint16_t file) {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Playing file %d in mp3 folder", file);
-  this->send_cmd_(0x12, file);
-}
-
-void DFPlayer::play_file(uint16_t file) {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Playing file %d", file);
-  this->send_cmd_(0x03, file);
-}
-
-void DFPlayer::play_file_loop(uint16_t file) {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Playing file %d in loop", file);
-  this->send_cmd_(0x08, file);
-}
-
-void DFPlayer::play_folder_loop(uint16_t folder) {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Playing folder %d in loop", folder);
-  this->send_cmd_(0x17, folder);
-}
-
-void DFPlayer::volume_up() {
-  ESP_LOGD(TAG, "Increasing volume");
-  this->send_cmd_(0x04);
-}
-
-void DFPlayer::volume_down() {
-  ESP_LOGD(TAG, "Decreasing volume");
-  this->send_cmd_(0x05);
-}
-
-void DFPlayer::set_device(Device device) {
-  ESP_LOGD(TAG, "Setting device to %d", device);
-  this->send_cmd_(0x09, device);
-}
-
-void DFPlayer::set_volume(uint8_t volume) {
-  ESP_LOGD(TAG, "Setting volume to %d", volume);
-  this->send_cmd_(0x06, volume);
-}
-
-void DFPlayer::set_eq(EqPreset preset) {
-  ESP_LOGD(TAG, "Setting EQ to %d", preset);
-  this->send_cmd_(0x07, preset);
-}
-
-void DFPlayer::sleep() {
-  this->ack_reset_is_playing_ = true;
-  ESP_LOGD(TAG, "Putting DFPlayer to sleep");
-  this->send_cmd_(0x0A);
-}
-
-void DFPlayer::reset() {
-  this->ack_reset_is_playing_ = true;
-  ESP_LOGD(TAG, "Resetting DFPlayer");
-  this->send_cmd_(0x0C);
-}
-
-void DFPlayer::start() {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Starting playback");
-  this->send_cmd_(0x0D);
-}
-
-void DFPlayer::pause() {
-  this->ack_reset_is_playing_ = true;
-  ESP_LOGD(TAG, "Pausing playback");
-  this->send_cmd_(0x0E);
-}
-
-void DFPlayer::stop() {
-  this->ack_reset_is_playing_ = true;
-  ESP_LOGD(TAG, "Stopping playback");
-  this->send_cmd_(0x16);
-}
-
-void DFPlayer::random() {
-  this->ack_set_is_playing_ = true;
-  ESP_LOGD(TAG, "Playing random file");
-  this->send_cmd_(0x18);
-}
-
 void DFPlayer::play_folder(uint16_t folder, uint16_t file) {
-  ESP_LOGD(TAG, "Playing file %d in folder %d", file, folder);
   if (folder < 100 && file < 256) {
     this->ack_set_is_playing_ = true;
     this->send_cmd_(0x0F, (uint8_t) folder, (uint8_t) file);
@@ -126,7 +29,7 @@ void DFPlayer::send_cmd_(uint8_t cmd, uint16_t argument) {
 
   this->sent_cmd_ = cmd;
 
-  ESP_LOGV(TAG, "Send Command %#02x arg %#04x", cmd, argument);
+  ESP_LOGD(TAG, "Send Command %#02x arg %#04x", cmd, argument);
   this->write_array(buffer, 10);
 }
 
@@ -198,37 +101,9 @@ void DFPlayer::loop() {
             ESP_LOGV(TAG, "Nack");
             this->ack_set_is_playing_ = false;
             this->ack_reset_is_playing_ = false;
-            switch (argument) {
-              case 0x01:
-                ESP_LOGE(TAG, "Module is busy or uninitialized");
-                break;
-              case 0x02:
-                ESP_LOGE(TAG, "Module is in sleep mode");
-                break;
-              case 0x03:
-                ESP_LOGE(TAG, "Serial receive error");
-                break;
-              case 0x04:
-                ESP_LOGE(TAG, "Checksum incorrect");
-                break;
-              case 0x05:
-                ESP_LOGE(TAG, "Specified track is out of current track scope");
-                this->is_playing_ = false;
-                break;
-              case 0x06:
-                ESP_LOGE(TAG, "Specified track is not found");
-                this->is_playing_ = false;
-                break;
-              case 0x07:
-                ESP_LOGE(TAG, "Insertion error (an inserting operation only can be done when a track is being played)");
-                break;
-              case 0x08:
-                ESP_LOGE(TAG, "SD card reading failed (SD card pulled out or damaged)");
-                break;
-              case 0x09:
-                ESP_LOGE(TAG, "Entered into sleep mode");
-                this->is_playing_ = false;
-                break;
+            if (argument == 6) {
+              ESP_LOGV(TAG, "File not found");
+              this->is_playing_ = false;
             }
             break;
           case 0x41:
@@ -238,13 +113,12 @@ void DFPlayer::loop() {
             this->ack_set_is_playing_ = false;
             this->ack_reset_is_playing_ = false;
             break;
-          case 0x3D:
-            ESP_LOGV(TAG, "Playback finished");
+          case 0x3D:  // Playback finished
             this->is_playing_ = false;
             this->on_finished_playback_callback_.call();
             break;
           default:
-            ESP_LOGV(TAG, "Received unknown cmd %#02x arg %#04x", cmd, argument);
+            ESP_LOGD(TAG, "Command %#02x arg %#04x", cmd, argument);
         }
         this->sent_cmd_ = 0;
         this->read_pos_ = 0;

esphome/components/dfplayer/dfplayer.h

@@ -23,30 +23,64 @@ enum Device {
   TF_CARD = 2,
 };
 
-// See the datasheet here:
-// https://github.com/DFRobot/DFRobotDFPlayerMini/blob/master/doc/FN-M16P%2BEmbedded%2BMP3%2BAudio%2BModule%2BDatasheet.pdf
 class DFPlayer : public uart::UARTDevice, public Component {
  public:
   void loop() override;
 
-  void next();
-  void previous();
-  void play_mp3(uint16_t file);
-  void play_file(uint16_t file);
-  void play_file_loop(uint16_t file);
+  void next() {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x01);
+  }
+  void previous() {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x02);
+  }
+  void play_mp3(uint16_t file) {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x12, file);
+  }
+  void play_file(uint16_t file) {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x03, file);
+  }
+  void play_file_loop(uint16_t file) {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x08, file);
+  }
   void play_folder(uint16_t folder, uint16_t file);
-  void play_folder_loop(uint16_t folder);
-  void volume_up();
-  void volume_down();
-  void set_device(Device device);
-  void set_volume(uint8_t volume);
-  void set_eq(EqPreset preset);
-  void sleep();
-  void reset();
-  void start();
-  void pause();
-  void stop();
-  void random();
+  void play_folder_loop(uint16_t folder) {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x17, folder);
+  }
+  void volume_up() { this->send_cmd_(0x04); }
+  void volume_down() { this->send_cmd_(0x05); }
+  void set_device(Device device) { this->send_cmd_(0x09, device); }
+  void set_volume(uint8_t volume) { this->send_cmd_(0x06, volume); }
+  void set_eq(EqPreset preset) { this->send_cmd_(0x07, preset); }
+  void sleep() {
+    this->ack_reset_is_playing_ = true;
+    this->send_cmd_(0x0A);
+  }
+  void reset() {
+    this->ack_reset_is_playing_ = true;
+    this->send_cmd_(0x0C);
+  }
+  void start() {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x0D);
+  }
+  void pause() {
+    this->ack_reset_is_playing_ = true;
+    this->send_cmd_(0x0E);
+  }
+  void stop() {
+    this->ack_reset_is_playing_ = true;
+    this->send_cmd_(0x16);
+  }
+  void random() {
+    this->ack_set_is_playing_ = true;
+    this->send_cmd_(0x18);
+  }
 
   bool is_playing() { return is_playing_; }
   void dump_config() override;

esphome/components/dht/dht.cpp

@@ -135,8 +135,7 @@ bool HOT IRAM_ATTR DHT::read_sensor_(float *temperature, float *humidity, bool r
 
       // Wait for falling edge
       while (this->pin_->digital_read()) {
-        end_time = micros();
-        if (end_time - start_time > 90) {
+        if ((end_time = micros()) - start_time > 90) {
           if (i < 0) {
             error_code = 3;
           } else {

esphome/components/display/display.cpp

@@ -1,6 +1,6 @@
 #include "display.h"
-#include <utility>
 #include "display_color_utils.h"
+#include <utility>
 #include "esphome/core/hal.h"
 #include "esphome/core/log.h"
 
@@ -662,24 +662,20 @@ void DisplayOnPageChangeTrigger::process(DisplayPage *from, DisplayPage *to) {
   if ((this->from_ == nullptr || this->from_ == from) && (this->to_ == nullptr || this->to_ == to))
     this->trigger(from, to);
 }
-void Display::strftime(int x, int y, BaseFont *font, Color color, Color background, TextAlign align, const char *format,
-                       ESPTime time) {
+void Display::strftime(int x, int y, BaseFont *font, Color color, TextAlign align, const char *format, ESPTime time) {
   char buffer[64];
   size_t ret = time.strftime(buffer, sizeof(buffer), format);
   if (ret > 0)
-    this->print(x, y, font, color, align, buffer, background);
-}
-void Display::strftime(int x, int y, BaseFont *font, Color color, TextAlign align, const char *format, ESPTime time) {
-  this->strftime(x, y, font, color, COLOR_OFF, align, format, time);
+    this->print(x, y, font, color, align, buffer);
 }
 void Display::strftime(int x, int y, BaseFont *font, Color color, const char *format, ESPTime time) {
-  this->strftime(x, y, font, color, COLOR_OFF, TextAlign::TOP_LEFT, format, time);
+  this->strftime(x, y, font, color, TextAlign::TOP_LEFT, format, time);
 }
 void Display::strftime(int x, int y, BaseFont *font, TextAlign align, const char *format, ESPTime time) {
-  this->strftime(x, y, font, COLOR_ON, COLOR_OFF, align, format, time);
+  this->strftime(x, y, font, COLOR_ON, align, format, time);
 }
 void Display::strftime(int x, int y, BaseFont *font, const char *format, ESPTime time) {
-  this->strftime(x, y, font, COLOR_ON, COLOR_OFF, TextAlign::TOP_LEFT, format, time);
+  this->strftime(x, y, font, COLOR_ON, TextAlign::TOP_LEFT, format, time);
 }
 
 void Display::start_clipping(Rect rect) {

esphome/components/display/display.h

@@ -437,20 +437,6 @@ class Display : public PollingComponent {
    */
   void printf(int x, int y, BaseFont *font, const char *format, ...) __attribute__((format(printf, 5, 6)));
 
-  /** Evaluate the strftime-format `format` and print the result with the anchor point at [x,y] with `font`.
-   *
-   * @param x The x coordinate of the text alignment anchor point.
-   * @param y The y coordinate of the text alignment anchor point.
-   * @param font The font to draw the text with.
-   * @param color The color to draw the text with.
-   * @param background The background color to draw the text with.
-   * @param align The alignment of the text.
-   * @param format The format to use.
-   * @param ... The arguments to use for the text formatting.
-   */
-  void strftime(int x, int y, BaseFont *font, Color color, Color background, TextAlign align, const char *format,
-                ESPTime time) __attribute__((format(strftime, 8, 0)));
-
   /** Evaluate the strftime-format `format` and print the result with the anchor point at [x,y] with `font`.
    *
    * @param x The x coordinate of the text alignment anchor point.

esphome/components/display_menu_base/__init__.py

@@ -68,6 +68,8 @@ IsActiveCondition = display_menu_base_ns.class_(
     "IsActiveCondition", automation.Condition
 )
 
+MULTI_CONF = True
+
 MenuItemType = display_menu_base_ns.enum("MenuItemType")
 
 MENU_ITEM_TYPES = {

esphome/components/display_menu_base/display_menu_base.cpp

@@ -280,7 +280,7 @@ bool DisplayMenuComponent::cursor_down_() {
 bool DisplayMenuComponent::enter_menu_() {
   this->displayed_item_->on_leave();
   this->displayed_item_ = static_cast<MenuItemMenu *>(this->get_selected_item_());
-  this->selection_stack_.emplace_front(this->top_index_, this->cursor_index_);
+  this->selection_stack_.push_front({this->top_index_, this->cursor_index_});
   this->cursor_index_ = this->top_index_ = 0;
   this->displayed_item_->on_enter();
 

esphome/components/dsmr/dsmr.cpp

@@ -296,7 +296,7 @@ void Dsmr::dump_config() {
 }
 
 void Dsmr::set_decryption_key(const std::string &decryption_key) {
-  if (decryption_key.empty()) {
+  if (decryption_key.length() == 0) {
     ESP_LOGI(TAG, "Disabling decryption");
     this->decryption_key_.clear();
     if (this->crypt_telegram_ != nullptr) {

esphome/components/es8311/audio_dac.py

@@ -1,70 +0,0 @@
-import esphome.codegen as cg
-from esphome.components import i2c
-from esphome.components.audio_dac import AudioDac
-import esphome.config_validation as cv
-from esphome.const import CONF_BITS_PER_SAMPLE, CONF_ID, CONF_SAMPLE_RATE
-
-CODEOWNERS = ["@kroimon", "@kahrendt"]
-DEPENDENCIES = ["i2c"]
-
-es8311_ns = cg.esphome_ns.namespace("es8311")
-ES8311 = es8311_ns.class_("ES8311", AudioDac, cg.Component, i2c.I2CDevice)
-
-CONF_MIC_GAIN = "mic_gain"
-CONF_USE_MCLK = "use_mclk"
-CONF_USE_MICROPHONE = "use_microphone"
-
-es8311_resolution = es8311_ns.enum("ES8311Resolution")
-ES8311_BITS_PER_SAMPLE_ENUM = {
-    16: es8311_resolution.ES8311_RESOLUTION_16,
-    24: es8311_resolution.ES8311_RESOLUTION_24,
-    32: es8311_resolution.ES8311_RESOLUTION_32,
-}
-
-es8311_mic_gain = es8311_ns.enum("ES8311MicGain")
-ES8311_MIC_GAIN_ENUM = {
-    "MIN": es8311_mic_gain.ES8311_MIC_GAIN_MIN,
-    "0DB": es8311_mic_gain.ES8311_MIC_GAIN_0DB,
-    "6DB": es8311_mic_gain.ES8311_MIC_GAIN_6DB,
-    "12DB": es8311_mic_gain.ES8311_MIC_GAIN_12DB,
-    "18DB": es8311_mic_gain.ES8311_MIC_GAIN_18DB,
-    "24DB": es8311_mic_gain.ES8311_MIC_GAIN_24DB,
-    "30DB": es8311_mic_gain.ES8311_MIC_GAIN_30DB,
-    "36DB": es8311_mic_gain.ES8311_MIC_GAIN_36DB,
-    "42DB": es8311_mic_gain.ES8311_MIC_GAIN_42DB,
-    "MAX": es8311_mic_gain.ES8311_MIC_GAIN_MAX,
-}
-
-
-_validate_bits = cv.float_with_unit("bits", "bit")
-
-CONFIG_SCHEMA = (
-    cv.Schema(
-        {
-            cv.GenerateID(): cv.declare_id(ES8311),
-            cv.Optional(CONF_BITS_PER_SAMPLE, default="16bit"): cv.All(
-                _validate_bits, cv.enum(ES8311_BITS_PER_SAMPLE_ENUM)
-            ),
-            cv.Optional(CONF_MIC_GAIN, default="42DB"): cv.enum(
-                ES8311_MIC_GAIN_ENUM, upper=True
-            ),
-            cv.Optional(CONF_SAMPLE_RATE, default=16000): cv.int_range(min=1),
-            cv.Optional(CONF_USE_MCLK, default=True): cv.boolean,
-            cv.Optional(CONF_USE_MICROPHONE, default=False): cv.boolean,
-        }
-    )
-    .extend(cv.COMPONENT_SCHEMA)
-    .extend(i2c.i2c_device_schema(0x18))
-)
-
-
-async def to_code(config):
-    var = cg.new_Pvariable(config[CONF_ID])
-    await cg.register_component(var, config)
-    await i2c.register_i2c_device(var, config)
-
-    cg.add(var.set_bits_per_sample(config[CONF_BITS_PER_SAMPLE]))
-    cg.add(var.set_mic_gain(config[CONF_MIC_GAIN]))
-    cg.add(var.set_sample_frequency(config[CONF_SAMPLE_RATE]))
-    cg.add(var.set_use_mclk(config[CONF_USE_MCLK]))
-    cg.add(var.set_use_mic(config[CONF_USE_MICROPHONE]))

esphome/components/es8311/es8311.cpp

@@ -1,227 +0,0 @@
-#include "es8311.h"
-#include "es8311_const.h"
-#include "esphome/core/hal.h"
-#include "esphome/core/log.h"
-#include <cinttypes>
-
-namespace esphome {
-namespace es8311 {
-
-static const char *const TAG = "es8311";
-
-// Mark the component as failed; use only in setup
-#define ES8311_ERROR_FAILED(func) \
-  if (!(func)) { \
-    this->mark_failed(); \
-    return; \
-  }
-// Return false; use outside of setup
-#define ES8311_ERROR_CHECK(func) \
-  if (!(func)) { \
-    return false; \
-  }
-
-void ES8311::setup() {
-  ESP_LOGCONFIG(TAG, "Setting up ES8311...");
-
-  // Reset
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG00_RESET, 0x1F));
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG00_RESET, 0x00));
-
-  ES8311_ERROR_FAILED(this->configure_clock_());
-  ES8311_ERROR_FAILED(this->configure_format_());
-  ES8311_ERROR_FAILED(this->configure_mic_());
-
-  // Set initial volume
-  this->set_volume(0.75);  // 0.75 = 0xBF = 0dB
-
-  // Power up analog circuitry
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG0D_SYSTEM, 0x01));
-  // Enable analog PGA, enable ADC modulator
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG0E_SYSTEM, 0x02));
-  // Power up DAC
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG12_SYSTEM, 0x00));
-  // Enable output to HP drive
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG13_SYSTEM, 0x10));
-  // ADC Equalizer bypass, cancel DC offset in digital domain
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG1C_ADC, 0x6A));
-  // Bypass DAC equalizer
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG37_DAC, 0x08));
-  // Power On
-  ES8311_ERROR_FAILED(this->write_byte(ES8311_REG00_RESET, 0x80));
-}
-
-void ES8311::dump_config() {
-  ESP_LOGCONFIG(TAG, "ES8311 Audio Codec:");
-  ESP_LOGCONFIG(TAG, "  Use MCLK: %s", YESNO(this->use_mclk_));
-  ESP_LOGCONFIG(TAG, "  Use Microphone: %s", YESNO(this->use_mic_));
-  ESP_LOGCONFIG(TAG, "  DAC Bits per Sample: %" PRIu8, this->resolution_out_);
-  ESP_LOGCONFIG(TAG, "  Sample Rate: %" PRIu32, this->sample_frequency_);
-
-  if (this->is_failed()) {
-    ESP_LOGCONFIG(TAG, "  Failed to initialize!");
-    return;
-  }
-}
-
-bool ES8311::set_volume(float volume) {
-  volume = clamp(volume, 0.0f, 1.0f);
-  uint8_t reg32 = remap<uint8_t, float>(volume, 0.0f, 1.0f, 0, 255);
-  return this->write_byte(ES8311_REG32_DAC, reg32);
-}
-
-float ES8311::volume() {
-  uint8_t reg32;
-  this->read_byte(ES8311_REG32_DAC, &reg32);
-  return remap<float, uint8_t>(reg32, 0, 255, 0.0f, 1.0f);
-}
-
-uint8_t ES8311::calculate_resolution_value(ES8311Resolution resolution) {
-  switch (resolution) {
-    case ES8311_RESOLUTION_16:
-      return (3 << 2);
-    case ES8311_RESOLUTION_18:
-      return (2 << 2);
-    case ES8311_RESOLUTION_20:
-      return (1 << 2);
-    case ES8311_RESOLUTION_24:
-      return (0 << 2);
-    case ES8311_RESOLUTION_32:
-      return (4 << 2);
-    default:
-      return 0;
-  }
-}
-
-const ES8311Coefficient *ES8311::get_coefficient(uint32_t mclk, uint32_t rate) {
-  for (const auto &coefficient : ES8311_COEFFICIENTS) {
-    if (coefficient.mclk == mclk && coefficient.rate == rate)
-      return &coefficient;
-  }
-  return nullptr;
-}
-
-bool ES8311::configure_clock_() {
-  // Register 0x01: select clock source for internal MCLK and determine its frequency
-  uint8_t reg01 = 0x3F;  // Enable all clocks
-
-  uint32_t mclk_frequency = this->sample_frequency_ * this->mclk_multiple_;
-  if (!this->use_mclk_) {
-    reg01 |= BIT(7);  // Use SCLK
-    mclk_frequency = this->sample_frequency_ * (int) this->resolution_out_ * 2;
-  }
-  if (this->mclk_inverted_) {
-    reg01 |= BIT(6);  // Invert MCLK pin
-  }
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG01_CLK_MANAGER, reg01));
-
-  // Get clock coefficients from coefficient table
-  auto *coefficient = get_coefficient(mclk_frequency, this->sample_frequency_);
-  if (coefficient == nullptr) {
-    ESP_LOGE(TAG, "Unable to configure sample rate %" PRIu32 "Hz with %" PRIu32 "Hz MCLK", this->sample_frequency_,
-             mclk_frequency);
-    return false;
-  }
-
-  // Register 0x02
-  uint8_t reg02;
-  ES8311_ERROR_CHECK(this->read_byte(ES8311_REG02_CLK_MANAGER, &reg02));
-  reg02 &= 0x07;
-  reg02 |= (coefficient->pre_div - 1) << 5;
-  reg02 |= coefficient->pre_mult << 3;
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG02_CLK_MANAGER, reg02));
-
-  // Register 0x03
-  const uint8_t reg03 = (coefficient->fs_mode << 6) | coefficient->adc_osr;
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG03_CLK_MANAGER, reg03));
-
-  // Register 0x04
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG04_CLK_MANAGER, coefficient->dac_osr));
-
-  // Register 0x05
-  const uint8_t reg05 = ((coefficient->adc_div - 1) << 4) | (coefficient->dac_div - 1);
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG05_CLK_MANAGER, reg05));
-
-  // Register 0x06
-  uint8_t reg06;
-  ES8311_ERROR_CHECK(this->read_byte(ES8311_REG06_CLK_MANAGER, &reg06));
-  if (this->sclk_inverted_) {
-    reg06 |= BIT(5);
-  } else {
-    reg06 &= ~BIT(5);
-  }
-  reg06 &= 0xE0;
-  if (coefficient->bclk_div < 19) {
-    reg06 |= (coefficient->bclk_div - 1) << 0;
-  } else {
-    reg06 |= (coefficient->bclk_div) << 0;
-  }
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG06_CLK_MANAGER, reg06));
-
-  // Register 0x07
-  uint8_t reg07;
-  ES8311_ERROR_CHECK(this->read_byte(ES8311_REG07_CLK_MANAGER, &reg07));
-  reg07 &= 0xC0;
-  reg07 |= coefficient->lrck_h << 0;
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG07_CLK_MANAGER, reg07));
-
-  // Register 0x08
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG08_CLK_MANAGER, coefficient->lrck_l));
-
-  // Successfully configured the clock
-  return true;
-}
-
-bool ES8311::configure_format_() {
-  // Configure I2S mode and format
-  uint8_t reg00;
-  ES8311_ERROR_CHECK(this->read_byte(ES8311_REG00_RESET, &reg00));
-  reg00 &= 0xBF;
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG00_RESET, reg00));
-
-  // Configure SDP in resolution
-  uint8_t reg09 = calculate_resolution_value(this->resolution_in_);
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG09_SDPIN, reg09));
-
-  // Configure SDP out resolution
-  uint8_t reg0a = calculate_resolution_value(this->resolution_out_);
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG0A_SDPOUT, reg0a));
-
-  // Successfully configured the format
-  return true;
-}
-
-bool ES8311::configure_mic_() {
-  uint8_t reg14 = 0x1A;  // Enable analog MIC and max PGA gain
-  if (this->use_mic_) {
-    reg14 |= BIT(6);  // Enable PDM digital microphone
-  }
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG14_SYSTEM, reg14));
-
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG16_ADC, this->mic_gain_));  // ADC gain scale up
-  ES8311_ERROR_CHECK(this->write_byte(ES8311_REG17_ADC, 0xC8));             // Set ADC gain
-
-  // Successfully configured the microphones
-  return true;
-}
-
-bool ES8311::set_mute_state_(bool mute_state) {
-  uint8_t reg31;
-
-  this->is_muted_ = mute_state;
-
-  if (!this->read_byte(ES8311_REG31_DAC, &reg31)) {
-    return false;
-  }
-
-  if (mute_state) {
-    reg31 |= BIT(6) | BIT(5);
-  } else {
-    reg31 &= ~(BIT(6) | BIT(5));
-  }
-
-  return this->write_byte(ES8311_REG31_DAC, reg31);
-}
-
-}  // namespace es8311
-}  // namespace esphome

esphome/components/es8311/es8311.h

@@ -1,135 +0,0 @@
-#pragma once
-
-#include "esphome/components/audio_dac/audio_dac.h"
-#include "esphome/components/i2c/i2c.h"
-#include "esphome/core/component.h"
-
-namespace esphome {
-namespace es8311 {
-
-enum ES8311MicGain {
-  ES8311_MIC_GAIN_MIN = -1,
-  ES8311_MIC_GAIN_0DB,
-  ES8311_MIC_GAIN_6DB,
-  ES8311_MIC_GAIN_12DB,
-  ES8311_MIC_GAIN_18DB,
-  ES8311_MIC_GAIN_24DB,
-  ES8311_MIC_GAIN_30DB,
-  ES8311_MIC_GAIN_36DB,
-  ES8311_MIC_GAIN_42DB,
-  ES8311_MIC_GAIN_MAX
-};
-
-enum ES8311Resolution : uint8_t {
-  ES8311_RESOLUTION_16 = 16,
-  ES8311_RESOLUTION_18 = 18,
-  ES8311_RESOLUTION_20 = 20,
-  ES8311_RESOLUTION_24 = 24,
-  ES8311_RESOLUTION_32 = 32
-};
-
-struct ES8311Coefficient {
-  uint32_t mclk;     // mclk frequency
-  uint32_t rate;     // sample rate
-  uint8_t pre_div;   // the pre divider with range from 1 to 8
-  uint8_t pre_mult;  // the pre multiplier with x1, x2, x4 and x8 selection
-  uint8_t adc_div;   // adcclk divider
-  uint8_t dac_div;   // dacclk divider
-  uint8_t fs_mode;   // single speed (0) or double speed (1)
-  uint8_t lrck_h;    // adc lrck divider and dac lrck divider
-  uint8_t lrck_l;    //
-  uint8_t bclk_div;  // sclk divider
-  uint8_t adc_osr;   // adc osr
-  uint8_t dac_osr;   // dac osr
-};
-
-class ES8311 : public audio_dac::AudioDac, public Component, public i2c::I2CDevice {
- public:
-  /////////////////////////
-  // Component overrides //
-  /////////////////////////
-
-  void setup() override;
-  float get_setup_priority() const override { return setup_priority::DATA; }
-  void dump_config() override;
-
-  ////////////////////////
-  // AudioDac overrides //
-  ////////////////////////
-
-  /// @brief Writes the volume out to the DAC
-  /// @param volume floating point between 0.0 and 1.0
-  /// @return True if successful and false otherwise
-  bool set_volume(float volume) override;
-
-  /// @brief Gets the current volume out from the DAC
-  /// @return floating point between 0.0 and 1.0
-  float volume() override;
-
-  /// @brief Disables mute for audio out
-  /// @return True if successful and false otherwise
-  bool set_mute_off() override { return this->set_mute_state_(false); }
-
-  /// @brief Enables mute for audio out
-  /// @return True if successful and false otherwise
-  bool set_mute_on() override { return this->set_mute_state_(true); }
-
-  bool is_muted() override { return this->is_muted_; }
-
-  //////////////////////////////////
-  // ES8311 configuration setters //
-  //////////////////////////////////
-
-  void set_use_mclk(bool use_mclk) { this->use_mclk_ = use_mclk; }
-  void set_bits_per_sample(ES8311Resolution resolution) {
-    this->resolution_in_ = resolution;
-    this->resolution_out_ = resolution;
-  }
-  void set_sample_frequency(uint32_t sample_frequency) { this->sample_frequency_ = sample_frequency; }
-  void set_use_mic(bool use_mic) { this->use_mic_ = use_mic; }
-  void set_mic_gain(ES8311MicGain mic_gain) { this->mic_gain_ = mic_gain; }
-
- protected:
-  /// @brief Computes the register value for the configured resolution (bits per sample)
-  /// @param resolution bits per sample enum for both audio in and audio out
-  /// @return register value
-  static uint8_t calculate_resolution_value(ES8311Resolution resolution);
-
-  /// @brief Retrieves the appropriate registers values for the configured mclk and rate
-  /// @param mclk mlck frequency in Hz
-  /// @param rate sample rate frequency in Hz
-  /// @return ES8311Coeffecient containing appropriate register values to configure the ES8311 or nullptr if impossible
-  static const ES8311Coefficient *get_coefficient(uint32_t mclk, uint32_t rate);
-
-  /// @brief Configures the ES8311 registers for the chosen sample rate
-  /// @return True if successful and false otherwise
-  bool configure_clock_();
-
-  /// @brief Configures the ES8311 registers for the chosen bits per sample
-  /// @return True if successful and false otherwise
-  bool configure_format_();
-
-  /// @brief Configures the ES8311 microphone registers
-  /// @return True if successful and false otherwise
-  bool configure_mic_();
-
-  /// @brief Mutes or unmute the DAC audio out
-  /// @param mute_state True to mute, false to unmute
-  /// @return
-  bool set_mute_state_(bool mute_state);
-
-  bool use_mic_;
-  ES8311MicGain mic_gain_;
-
-  bool use_mclk_;                // true = use dedicated MCLK pin, false = use SCLK
-  bool sclk_inverted_{false};    // SCLK is inverted
-  bool mclk_inverted_{false};    // MCLK is inverted (ignored if use_mclk_ == false)
-  uint32_t mclk_multiple_{256};  // MCLK frequency is sample rate * mclk_multiple_ (ignored if use_mclk_ == false)
-
-  uint32_t sample_frequency_;  // in Hz
-  ES8311Resolution resolution_in_;
-  ES8311Resolution resolution_out_;
-};
-
-}  // namespace es8311
-}  // namespace esphome

esphome/components/es8311/es8311_const.h

@@ -1,195 +0,0 @@
-#pragma once
-
-#include "es8311.h"
-
-namespace esphome {
-namespace es8311 {
-
-// ES8311 register addresses
-static const uint8_t ES8311_REG00_RESET = 0x00;        // Reset
-static const uint8_t ES8311_REG01_CLK_MANAGER = 0x01;  // Clock Manager: select clk src for mclk, enable clock for codec
-static const uint8_t ES8311_REG02_CLK_MANAGER = 0x02;  // Clock Manager: clk divider and clk multiplier
-static const uint8_t ES8311_REG03_CLK_MANAGER = 0x03;  // Clock Manager: adc fsmode and osr
-static const uint8_t ES8311_REG04_CLK_MANAGER = 0x04;  // Clock Manager: dac osr
-static const uint8_t ES8311_REG05_CLK_MANAGER = 0x05;  // Clock Manager: clk divider for adc and dac
-static const uint8_t ES8311_REG06_CLK_MANAGER = 0x06;  // Clock Manager: bclk inverter BIT(5) and divider
-static const uint8_t ES8311_REG07_CLK_MANAGER = 0x07;  // Clock Manager: tri-state, lrck divider
-static const uint8_t ES8311_REG08_CLK_MANAGER = 0x08;  // Clock Manager: lrck divider
-static const uint8_t ES8311_REG09_SDPIN = 0x09;        // Serial Digital Port: DAC
-static const uint8_t ES8311_REG0A_SDPOUT = 0x0A;       // Serial Digital Port: ADC
-static const uint8_t ES8311_REG0B_SYSTEM = 0x0B;       // System
-static const uint8_t ES8311_REG0C_SYSTEM = 0x0C;       // System
-static const uint8_t ES8311_REG0D_SYSTEM = 0x0D;       // System: power up/down
-static const uint8_t ES8311_REG0E_SYSTEM = 0x0E;       // System: power up/down
-static const uint8_t ES8311_REG0F_SYSTEM = 0x0F;       // System: low power
-static const uint8_t ES8311_REG10_SYSTEM = 0x10;       // System
-static const uint8_t ES8311_REG11_SYSTEM = 0x11;       // System
-static const uint8_t ES8311_REG12_SYSTEM = 0x12;       // System: Enable DAC
-static const uint8_t ES8311_REG13_SYSTEM = 0x13;       // System
-static const uint8_t ES8311_REG14_SYSTEM = 0x14;       // System: select DMIC, select analog pga gain
-static const uint8_t ES8311_REG15_ADC = 0x15;          // ADC: adc ramp rate, dmic sense
-static const uint8_t ES8311_REG16_ADC = 0x16;          // ADC
-static const uint8_t ES8311_REG17_ADC = 0x17;          // ADC: volume
-static const uint8_t ES8311_REG18_ADC = 0x18;          // ADC: alc enable and winsize
-static const uint8_t ES8311_REG19_ADC = 0x19;          // ADC: alc maxlevel
-static const uint8_t ES8311_REG1A_ADC = 0x1A;          // ADC: alc automute
-static const uint8_t ES8311_REG1B_ADC = 0x1B;          // ADC: alc automute, adc hpf s1
-static const uint8_t ES8311_REG1C_ADC = 0x1C;          // ADC: equalizer, hpf s2
-static const uint8_t ES8311_REG1D_ADCEQ = 0x1D;        // ADCEQ: equalizer B0
-static const uint8_t ES8311_REG1E_ADCEQ = 0x1E;        // ADCEQ: equalizer B0
-static const uint8_t ES8311_REG1F_ADCEQ = 0x1F;        // ADCEQ: equalizer B0
-static const uint8_t ES8311_REG20_ADCEQ = 0x20;        // ADCEQ: equalizer B0
-static const uint8_t ES8311_REG21_ADCEQ = 0x21;        // ADCEQ: equalizer A1
-static const uint8_t ES8311_REG22_ADCEQ = 0x22;        // ADCEQ: equalizer A1
-static const uint8_t ES8311_REG23_ADCEQ = 0x23;        // ADCEQ: equalizer A1
-static const uint8_t ES8311_REG24_ADCEQ = 0x24;        // ADCEQ: equalizer A1
-static const uint8_t ES8311_REG25_ADCEQ = 0x25;        // ADCEQ: equalizer A2
-static const uint8_t ES8311_REG26_ADCEQ = 0x26;        // ADCEQ: equalizer A2
-static const uint8_t ES8311_REG27_ADCEQ = 0x27;        // ADCEQ: equalizer A2
-static const uint8_t ES8311_REG28_ADCEQ = 0x28;        // ADCEQ: equalizer A2
-static const uint8_t ES8311_REG29_ADCEQ = 0x29;        // ADCEQ: equalizer B1
-static const uint8_t ES8311_REG2A_ADCEQ = 0x2A;        // ADCEQ: equalizer B1
-static const uint8_t ES8311_REG2B_ADCEQ = 0x2B;        // ADCEQ: equalizer B1
-static const uint8_t ES8311_REG2C_ADCEQ = 0x2C;        // ADCEQ: equalizer B1
-static const uint8_t ES8311_REG2D_ADCEQ = 0x2D;        // ADCEQ: equalizer B2
-static const uint8_t ES8311_REG2E_ADCEQ = 0x2E;        // ADCEQ: equalizer B2
-static const uint8_t ES8311_REG2F_ADCEQ = 0x2F;        // ADCEQ: equalizer B2
-static const uint8_t ES8311_REG30_ADCEQ = 0x30;        // ADCEQ: equalizer B2
-static const uint8_t ES8311_REG31_DAC = 0x31;          // DAC: mute
-static const uint8_t ES8311_REG32_DAC = 0x32;          // DAC: volume
-static const uint8_t ES8311_REG33_DAC = 0x33;          // DAC: offset
-static const uint8_t ES8311_REG34_DAC = 0x34;          // DAC: drc enable, drc winsize
-static const uint8_t ES8311_REG35_DAC = 0x35;          // DAC: drc maxlevel, minilevel
-static const uint8_t ES8311_REG36_DAC = 0x36;          // DAC
-static const uint8_t ES8311_REG37_DAC = 0x37;          // DAC: ramprate
-static const uint8_t ES8311_REG38_DACEQ = 0x38;        // DACEQ: equalizer B0
-static const uint8_t ES8311_REG39_DACEQ = 0x39;        // DACEQ: equalizer B0
-static const uint8_t ES8311_REG3A_DACEQ = 0x3A;        // DACEQ: equalizer B0
-static const uint8_t ES8311_REG3B_DACEQ = 0x3B;        // DACEQ: equalizer B0
-static const uint8_t ES8311_REG3C_DACEQ = 0x3C;        // DACEQ: equalizer B1
-static const uint8_t ES8311_REG3D_DACEQ = 0x3D;        // DACEQ: equalizer B1
-static const uint8_t ES8311_REG3E_DACEQ = 0x3E;        // DACEQ: equalizer B1
-static const uint8_t ES8311_REG3F_DACEQ = 0x3F;        // DACEQ: equalizer B1
-static const uint8_t ES8311_REG40_DACEQ = 0x40;        // DACEQ: equalizer A1
-static const uint8_t ES8311_REG41_DACEQ = 0x41;        // DACEQ: equalizer A1
-static const uint8_t ES8311_REG42_DACEQ = 0x42;        // DACEQ: equalizer A1
-static const uint8_t ES8311_REG43_DACEQ = 0x43;        // DACEQ: equalizer A1
-static const uint8_t ES8311_REG44_GPIO = 0x44;         // GPIO: dac2adc for test
-static const uint8_t ES8311_REG45_GP = 0x45;           // GPIO: GP control
-static const uint8_t ES8311_REGFA_I2C = 0xFA;          // I2C: reset registers
-static const uint8_t ES8311_REGFC_FLAG = 0xFC;         // Flag
-static const uint8_t ES8311_REGFD_CHD1 = 0xFD;         // Chip: ID1
-static const uint8_t ES8311_REGFE_CHD2 = 0xFE;         // Chip: ID2
-static const uint8_t ES8311_REGFF_CHVER = 0xFF;        // Chip: Version
-
-// ES8311 clock divider coefficients
-static const ES8311Coefficient ES8311_COEFFICIENTS[] = {
-    // clang-format off
-
-  //   mclk,  rate, pre_  pre_  adc_  dac_  fs_   lrck  lrck bclk_  adc_  dac_
-  //                 div, mult,  div,  div, mode,   _h,   _l,  div,  osr,  osr
-
-  // 8k
-  {12288000,  8000, 0x06, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  {18432000,  8000, 0x03, 0x02, 0x03, 0x03, 0x00, 0x05, 0xff, 0x18, 0x10, 0x20},
-  {16384000,  8000, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 8192000,  8000, 0x04, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 6144000,  8000, 0x03, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 4096000,  8000, 0x02, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 3072000,  8000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 2048000,  8000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 1536000,  8000, 0x03, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 1024000,  8000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-
-  // 11.025k
-  {11289600, 11025, 0x04, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 5644800, 11025, 0x02, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 2822400, 11025, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 1411200, 11025, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-
-  // 12k
-  {12288000, 12000, 0x04, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 6144000, 12000, 0x02, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 3072000, 12000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 1536000, 12000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-
-  // 16k
-  {12288000, 16000, 0x03, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  {18432000, 16000, 0x03, 0x02, 0x03, 0x03, 0x00, 0x02, 0xff, 0x0c, 0x10, 0x20},
-  {16384000, 16000, 0x04, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 8192000, 16000, 0x02, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 6144000, 16000, 0x03, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 4096000, 16000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 3072000, 16000, 0x03, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 2048000, 16000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 1536000, 16000, 0x03, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-  { 1024000, 16000, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x20},
-
-  // 22.05k
-  {11289600, 22050, 0x02, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 5644800, 22050, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 2822400, 22050, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1411200, 22050, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-
-  // 24k
-  {12288000, 24000, 0x02, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  {18432000, 24000, 0x03, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 6144000, 24000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 3072000, 24000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1536000, 24000, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-
-  // 32k
-  {12288000, 32000, 0x03, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  {18432000, 32000, 0x03, 0x04, 0x03, 0x03, 0x00, 0x02, 0xff, 0x0c, 0x10, 0x10},
-  {16384000, 32000, 0x02, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 8192000, 32000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 6144000, 32000, 0x03, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 4096000, 32000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 3072000, 32000, 0x03, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 2048000, 32000, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1536000, 32000, 0x03, 0x08, 0x01, 0x01, 0x01, 0x00, 0x7f, 0x02, 0x10, 0x10},
-  { 1024000, 32000, 0x01, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-
-  // 44.1k
-  {11289600, 44100, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 5644800, 44100, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 2822400, 44100, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1411200, 44100, 0x01, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-
-  // 48k
-  {12288000, 48000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  {18432000, 48000, 0x03, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 6144000, 48000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 3072000, 48000, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1536000, 48000, 0x01, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-
-  // 64k
-  {12288000, 64000, 0x03, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  {18432000, 64000, 0x03, 0x04, 0x03, 0x03, 0x01, 0x01, 0x7f, 0x06, 0x10, 0x10},
-  {16384000, 64000, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 8192000, 64000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 6144000, 64000, 0x01, 0x04, 0x03, 0x03, 0x01, 0x01, 0x7f, 0x06, 0x10, 0x10},
-  { 4096000, 64000, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 3072000, 64000, 0x01, 0x08, 0x03, 0x03, 0x01, 0x01, 0x7f, 0x06, 0x10, 0x10},
-  { 2048000, 64000, 0x01, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1536000, 64000, 0x01, 0x08, 0x01, 0x01, 0x01, 0x00, 0xbf, 0x03, 0x18, 0x18},
-  { 1024000, 64000, 0x01, 0x08, 0x01, 0x01, 0x01, 0x00, 0x7f, 0x02, 0x10, 0x10},
-
-  // 88.2k
-  {11289600, 88200, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 5644800, 88200, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 2822400, 88200, 0x01, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1411200, 88200, 0x01, 0x08, 0x01, 0x01, 0x01, 0x00, 0x7f, 0x02, 0x10, 0x10},
-
-  // 96k
-  {12288000, 96000, 0x01, 0x02, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  {18432000, 96000, 0x03, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 6144000, 96000, 0x01, 0x04, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 3072000, 96000, 0x01, 0x08, 0x01, 0x01, 0x00, 0x00, 0xff, 0x04, 0x10, 0x10},
-  { 1536000, 96000, 0x01, 0x08, 0x01, 0x01, 0x01, 0x00, 0x7f, 0x02, 0x10, 0x10},
-
-    // clang-format on
-};
-
-}  // namespace es8311
-}  // namespace esphome

esphome/components/esp32/__init__.py

@@ -65,8 +65,6 @@ _LOGGER = logging.getLogger(__name__)
 CODEOWNERS = ["@esphome/core"]
 AUTO_LOAD = ["preferences"]
 
-CONF_RELEASE = "release"
-
 
 def set_core_data(config):
     CORE.data[KEY_ESP32] = {}
@@ -218,17 +216,11 @@ def _format_framework_arduino_version(ver: cv.Version) -> str:
     return f"~3.{ver.major}{ver.minor:02d}{ver.patch:02d}.0"
 
 
-def _format_framework_espidf_version(
-    ver: cv.Version, release: str, for_platformio: bool
-) -> str:
+def _format_framework_espidf_version(ver: cv.Version) -> str:
     # format the given arduino (https://github.com/espressif/esp-idf/releases) version to
     # a PIO platformio/framework-espidf value
     # List of package versions: https://api.registry.platformio.org/v3/packages/platformio/tool/framework-espidf
-    if for_platformio:
-        return f"platformio/framework-espidf@~3.{ver.major}{ver.minor:02d}{ver.patch:02d}.0"
-    if release:
-        return f"pioarduino/framework-espidf@https://github.com/pioarduino/esp-idf/releases/download/v{str(ver)}.{release}/esp-idf-v{str(ver)}.zip"
-    return f"pioarduino/framework-espidf@https://github.com/pioarduino/esp-idf/releases/download/v{str(ver)}/esp-idf-v{str(ver)}.zip"
+    return f"~3.{ver.major}{ver.minor:02d}{ver.patch:02d}.0"
 
 
 # NOTE: Keep this in mind when updating the recommended version:
@@ -249,33 +241,11 @@ ARDUINO_PLATFORM_VERSION = cv.Version(5, 4, 0)
 # The default/recommended esp-idf framework version
 #  - https://github.com/espressif/esp-idf/releases
 #  - https://api.registry.platformio.org/v3/packages/platformio/tool/framework-espidf
-RECOMMENDED_ESP_IDF_FRAMEWORK_VERSION = cv.Version(5, 1, 5)
+RECOMMENDED_ESP_IDF_FRAMEWORK_VERSION = cv.Version(4, 4, 8)
 # The platformio/espressif32 version to use for esp-idf frameworks
 #  - https://github.com/platformio/platform-espressif32/releases
 #  - https://api.registry.platformio.org/v3/packages/platformio/platform/espressif32
-ESP_IDF_PLATFORM_VERSION = cv.Version(51, 3, 7)
-
-# List based on https://registry.platformio.org/tools/platformio/framework-espidf/versions
-SUPPORTED_PLATFORMIO_ESP_IDF_5X = [
-    cv.Version(5, 3, 1),
-    cv.Version(5, 3, 0),
-    cv.Version(5, 2, 2),
-    cv.Version(5, 2, 1),
-    cv.Version(5, 1, 2),
-    cv.Version(5, 1, 1),
-    cv.Version(5, 1, 0),
-    cv.Version(5, 0, 2),
-    cv.Version(5, 0, 1),
-    cv.Version(5, 0, 0),
-]
-
-# pioarduino versions that don't require a release number
-# List based on https://github.com/pioarduino/esp-idf/releases
-SUPPORTED_PIOARDUINO_ESP_IDF_5X = [
-    cv.Version(5, 3, 1),
-    cv.Version(5, 3, 0),
-    cv.Version(5, 1, 5),
-]
+ESP_IDF_PLATFORM_VERSION = cv.Version(5, 4, 0)
 
 
 def _arduino_check_versions(value):
@@ -316,8 +286,8 @@ def _arduino_check_versions(value):
 def _esp_idf_check_versions(value):
     value = value.copy()
     lookups = {
-        "dev": (cv.Version(5, 1, 5), "https://github.com/espressif/esp-idf.git"),
-        "latest": (cv.Version(5, 1, 5), None),
+        "dev": (cv.Version(5, 1, 2), "https://github.com/espressif/esp-idf.git"),
+        "latest": (cv.Version(5, 1, 2), None),
         "recommended": (RECOMMENDED_ESP_IDF_FRAMEWORK_VERSION, None),
     }
 
@@ -335,51 +305,13 @@ def _esp_idf_check_versions(value):
     if version < cv.Version(4, 0, 0):
         raise cv.Invalid("Only ESP-IDF 4.0+ is supported.")
 
-    # flag this for later *before* we set value[CONF_PLATFORM_VERSION] below
-    has_platform_ver = CONF_PLATFORM_VERSION in value
+    value[CONF_VERSION] = str(version)
+    value[CONF_SOURCE] = source or _format_framework_espidf_version(version)
 
     value[CONF_PLATFORM_VERSION] = value.get(
         CONF_PLATFORM_VERSION, _parse_platform_version(str(ESP_IDF_PLATFORM_VERSION))
     )
 
-    if (
-        (is_platformio := _platform_is_platformio(value[CONF_PLATFORM_VERSION]))
-        and version.major >= 5
-        and version not in SUPPORTED_PLATFORMIO_ESP_IDF_5X
-    ):
-        raise cv.Invalid(
-            f"ESP-IDF {str(version)} not supported by platformio/espressif32"
-        )
-
-    if (
-        version.major < 5
-        or (
-            version in SUPPORTED_PLATFORMIO_ESP_IDF_5X
-            and version not in SUPPORTED_PIOARDUINO_ESP_IDF_5X
-        )
-    ) and not has_platform_ver:
-        raise cv.Invalid(
-            f"ESP-IDF {value[CONF_VERSION]} may be supported by platformio/espressif32; please specify '{CONF_PLATFORM_VERSION}'"
-        )
-
-    if (
-        not is_platformio
-        and CONF_RELEASE not in value
-        and version not in SUPPORTED_PIOARDUINO_ESP_IDF_5X
-    ):
-        raise cv.Invalid(
-            f"ESP-IDF {value[CONF_VERSION]} is not available with pioarduino; you may need to specify '{CONF_RELEASE}'"
-        )
-
-    value[CONF_VERSION] = str(version)
-    value[CONF_SOURCE] = source or _format_framework_espidf_version(
-        version, value.get(CONF_RELEASE, None), is_platformio
-    )
-
-    if value[CONF_SOURCE].startswith("http"):
-        # prefix is necessary or platformio will complain with a cryptic error
-        value[CONF_SOURCE] = f"framework-espidf@{value[CONF_SOURCE]}"
-
     if version != RECOMMENDED_ESP_IDF_FRAMEWORK_VERSION:
         _LOGGER.warning(
             "The selected ESP-IDF framework version is not the recommended one. "
@@ -391,12 +323,6 @@ def _esp_idf_check_versions(value):
 
 def _parse_platform_version(value):
     try:
-        ver = cv.Version.parse(cv.version_number(value))
-        if ver.major >= 50:  # a pioarduino version
-            if "-" in value:
-                # maybe a release candidate?...definitely not our default, just use it as-is...
-                return f"https://github.com/pioarduino/platform-espressif32.git#{value}"
-            return f"https://github.com/pioarduino/platform-espressif32.git#{ver.major}.{ver.minor:02d}.{ver.patch:02d}"
         # if platform version is a valid version constraint, prefix the default package
         cv.platformio_version_constraint(value)
         return f"platformio/espressif32@{value}"
@@ -404,14 +330,6 @@ def _parse_platform_version(value):
         return value
 
 
-def _platform_is_platformio(value):
-    try:
-        ver = cv.Version.parse(cv.version_number(value))
-        return ver.major < 50
-    except cv.Invalid:
-        return "platformio" in value
-
-
 def _detect_variant(value):
     board = value[CONF_BOARD]
     if board in BOARDS:
@@ -437,20 +355,24 @@ def _detect_variant(value):
 
 
 def final_validate(config):
-    if not (
-        pio_options := fv.full_config.get()[CONF_ESPHOME].get(CONF_PLATFORMIO_OPTIONS)
-    ):
-        # Not specified or empty
+    if CONF_PLATFORMIO_OPTIONS not in fv.full_config.get()[CONF_ESPHOME]:
         return config
 
     pio_flash_size_key = "board_upload.flash_size"
     pio_partitions_key = "board_build.partitions"
-    if CONF_PARTITIONS in config and pio_partitions_key in pio_options:
+    if (
+        CONF_PARTITIONS in config
+        and pio_partitions_key
+        in fv.full_config.get()[CONF_ESPHOME][CONF_PLATFORMIO_OPTIONS]
+    ):
         raise cv.Invalid(
             f"Do not specify '{pio_partitions_key}' in '{CONF_PLATFORMIO_OPTIONS}' with '{CONF_PARTITIONS}' in esp32"
         )
 
-    if pio_flash_size_key in pio_options:
+    if (
+        pio_flash_size_key
+        in fv.full_config.get()[CONF_ESPHOME][CONF_PLATFORMIO_OPTIONS]
+    ):
         raise cv.Invalid(
             f"Please specify {CONF_FLASH_SIZE} within esp32 configuration only"
         )
@@ -490,7 +412,6 @@ ESP_IDF_FRAMEWORK_SCHEMA = cv.All(
     cv.Schema(
         {
             cv.Optional(CONF_VERSION, default="recommended"): cv.string_strict,
-            cv.Optional(CONF_RELEASE): cv.string_strict,
             cv.Optional(CONF_SOURCE): cv.string_strict,
             cv.Optional(CONF_PLATFORM_VERSION): _parse_platform_version,
             cv.Optional(CONF_SDKCONFIG_OPTIONS, default={}): {
@@ -594,9 +515,10 @@ async def to_code(config):
         cg.add_build_flag("-DUSE_ESP_IDF")
         cg.add_build_flag("-DUSE_ESP32_FRAMEWORK_ESP_IDF")
         cg.add_build_flag("-Wno-nonnull-compare")
-
-        cg.add_platformio_option("platform_packages", [conf[CONF_SOURCE]])
-
+        cg.add_platformio_option(
+            "platform_packages",
+            [f"platformio/framework-espidf@{conf[CONF_SOURCE]}"],
+        )
         # platformio/toolchain-esp32ulp does not support linux_aarch64 yet and has not been updated for over 2 years
         # This is espressif's own published version which is more up to date.
         cg.add_platformio_option(

esphome/components/esp32/boards.py

@@ -1,12 +1,4 @@
-from .const import (
-    VARIANT_ESP32,
-    VARIANT_ESP32C2,
-    VARIANT_ESP32C3,
-    VARIANT_ESP32C6,
-    VARIANT_ESP32H2,
-    VARIANT_ESP32S2,
-    VARIANT_ESP32S3,
-)
+from .const import VARIANT_ESP32, VARIANT_ESP32C3, VARIANT_ESP32S2, VARIANT_ESP32S3
 
 ESP32_BASE_PINS = {
     "TX": 1,
@@ -1352,26 +1344,6 @@ done | sort
 """
 
 BOARDS = {
-    "4d_systems_esp32s3_gen4_r8n16": {
-        "name": "4D Systems GEN4-ESP32 16MB (ESP32S3-R8N16)",
-        "variant": VARIANT_ESP32S3,
-    },
-    "adafruit_camera_esp32s3": {
-        "name": "Adafruit pyCamera S3",
-        "variant": VARIANT_ESP32S3,
-    },
-    "adafruit_feather_esp32c6": {
-        "name": "Adafruit Feather ESP32-C6",
-        "variant": VARIANT_ESP32C6,
-    },
-    "adafruit_feather_esp32s2": {
-        "name": "Adafruit Feather ESP32-S2",
-        "variant": VARIANT_ESP32S2,
-    },
-    "adafruit_feather_esp32s2_reversetft": {
-        "name": "Adafruit Feather ESP32-S2 Reverse TFT",
-        "variant": VARIANT_ESP32S2,
-    },
     "adafruit_feather_esp32s2_tft": {
         "name": "Adafruit Feather ESP32-S2 TFT",
         "variant": VARIANT_ESP32S2,
@@ -1384,10 +1356,6 @@ BOARDS = {
         "name": "Adafruit Feather ESP32-S3 No PSRAM",
         "variant": VARIANT_ESP32S3,
     },
-    "adafruit_feather_esp32s3_reversetft": {
-        "name": "Adafruit Feather ESP32-S3 Reverse TFT",
-        "variant": VARIANT_ESP32S3,
-    },
     "adafruit_feather_esp32s3_tft": {
         "name": "Adafruit Feather ESP32-S3 TFT",
         "variant": VARIANT_ESP32S3,
@@ -1408,18 +1376,10 @@ BOARDS = {
         "name": "Adafruit MagTag 2.9",
         "variant": VARIANT_ESP32S2,
     },
-    "adafruit_matrixportal_esp32s3": {
-        "name": "Adafruit MatrixPortal ESP32-S3",
-        "variant": VARIANT_ESP32S3,
-    },
     "adafruit_metro_esp32s2": {
         "name": "Adafruit Metro ESP32-S2",
         "variant": VARIANT_ESP32S2,
     },
-    "adafruit_metro_esp32s3": {
-        "name": "Adafruit Metro ESP32-S3",
-        "variant": VARIANT_ESP32S3,
-    },
     "adafruit_qtpy_esp32c3": {
         "name": "Adafruit QT Py ESP32-C3",
         "variant": VARIANT_ESP32C3,
@@ -1432,18 +1392,10 @@ BOARDS = {
         "name": "Adafruit QT Py ESP32-S2",
         "variant": VARIANT_ESP32S2,
     },
-    "adafruit_qtpy_esp32s3_n4r2": {
-        "name": "Adafruit QT Py ESP32-S3 (4M Flash 2M PSRAM)",
-        "variant": VARIANT_ESP32S3,
-    },
     "adafruit_qtpy_esp32s3_nopsram": {
         "name": "Adafruit QT Py ESP32-S3 No PSRAM",
         "variant": VARIANT_ESP32S3,
     },
-    "adafruit_qualia_s3_rgb666": {
-        "name": "Adafruit Qualia ESP32-S3 RGB666",
-        "variant": VARIANT_ESP32S3,
-    },
     "airm2m_core_esp32c3": {
         "name": "AirM2M CORE ESP32C3",
         "variant": VARIANT_ESP32C3,
@@ -1452,30 +1404,14 @@ BOARDS = {
         "name": "ALKS ESP32",
         "variant": VARIANT_ESP32,
     },
-    "arduino_nano_esp32": {
-        "name": "Arduino Nano ESP32",
-        "variant": VARIANT_ESP32S3,
-    },
-    "atd147_s3": {
-        "name": "ArtronShop ATD1.47-S3",
-        "variant": VARIANT_ESP32S3,
-    },
     "atmegazero_esp32s2": {
         "name": "EspinalLab ATMegaZero ESP32-S2",
         "variant": VARIANT_ESP32S2,
     },
-    "aventen_s3_sync": {
-        "name": "Aventen S3 Sync",
-        "variant": VARIANT_ESP32S3,
-    },
     "az-delivery-devkit-v4": {
         "name": "AZ-Delivery ESP-32 Dev Kit C V4",
         "variant": VARIANT_ESP32,
     },
-    "bee_data_logger": {
-        "name": "Smart Bee Data Logger",
-        "variant": VARIANT_ESP32S3,
-    },
     "bee_motion_mini": {
         "name": "Smart Bee Motion Mini",
         "variant": VARIANT_ESP32C3,
@@ -1500,6 +1436,14 @@ BOARDS = {
         "name": "BPI-Leaf-S3",
         "variant": VARIANT_ESP32S3,
     },
+    "briki_abc_esp32": {
+        "name": "Briki ABC (MBC-WB) - ESP32",
+        "variant": VARIANT_ESP32,
+    },
+    "briki_mbc-wb_esp32": {
+        "name": "Briki MBC-WB - ESP32",
+        "variant": VARIANT_ESP32,
+    },
     "cnrs_aw2eth": {
         "name": "CNRS AW2ETH",
         "variant": VARIANT_ESP32,
@@ -1552,38 +1496,18 @@ BOARDS = {
         "name": "DFRobot Beetle ESP32-C3",
         "variant": VARIANT_ESP32C3,
     },
-    "dfrobot_firebeetle2_esp32e": {
-        "name": "DFRobot Firebeetle 2 ESP32-E",
-        "variant": VARIANT_ESP32,
-    },
     "dfrobot_firebeetle2_esp32s3": {
         "name": "DFRobot Firebeetle 2 ESP32-S3",
         "variant": VARIANT_ESP32S3,
     },
-    "dfrobot_romeo_esp32s3": {
-        "name": "DFRobot Romeo ESP32-S3",
-        "variant": VARIANT_ESP32S3,
-    },
     "dpu_esp32": {
         "name": "TAMC DPU ESP32",
         "variant": VARIANT_ESP32,
     },
-    "edgebox-esp-100": {
-        "name": "Seeed Studio Edgebox-ESP-100",
-        "variant": VARIANT_ESP32S3,
-    },
     "esp320": {
         "name": "Electronic SweetPeas ESP320",
         "variant": VARIANT_ESP32,
     },
-    "esp32-c2-devkitm-1": {
-        "name": "Espressif ESP32-C2-DevKitM-1",
-        "variant": VARIANT_ESP32C2,
-    },
-    "esp32-c3-devkitc-02": {
-        "name": "Espressif ESP32-C3-DevKitC-02",
-        "variant": VARIANT_ESP32C3,
-    },
     "esp32-c3-devkitm-1": {
         "name": "Espressif ESP32-C3-DevKitM-1",
         "variant": VARIANT_ESP32C3,
@@ -1592,14 +1516,6 @@ BOARDS = {
         "name": "Ai-Thinker ESP-C3-M1-I-Kit",
         "variant": VARIANT_ESP32C3,
     },
-    "esp32-c6-devkitc-1": {
-        "name": "Espressif ESP32-C6-DevKitC-1",
-        "variant": VARIANT_ESP32C6,
-    },
-    "esp32-c6-devkitm-1": {
-        "name": "Espressif ESP32-C6-DevKitM-1",
-        "variant": VARIANT_ESP32C6,
-    },
     "esp32cam": {
         "name": "AI Thinker ESP32-CAM",
         "variant": VARIANT_ESP32,
@@ -1628,14 +1544,6 @@ BOARDS = {
         "name": "OLIMEX ESP32-GATEWAY",
         "variant": VARIANT_ESP32,
     },
-    "esp32-h2-devkitm-1": {
-        "name": "Espressif ESP32-H2-DevKit",
-        "variant": VARIANT_ESP32H2,
-    },
-    "esp32-pico-devkitm-2": {
-        "name": "Espressif ESP32-PICO-DevKitM-2",
-        "variant": VARIANT_ESP32,
-    },
     "esp32-poe-iso": {
         "name": "OLIMEX ESP32-PoE-ISO",
         "variant": VARIANT_ESP32,
@@ -1672,22 +1580,10 @@ BOARDS = {
         "name": "Espressif ESP32-S3-DevKitC-1-N8 (8 MB QD, No PSRAM)",
         "variant": VARIANT_ESP32S3,
     },
-    "esp32-s3-devkitm-1": {
-        "name": "Espressif ESP32-S3-DevKitM-1",
+    "esp32-s3-korvo-2": {
+        "name": "Espressif ESP32-S3-Korvo-2",
         "variant": VARIANT_ESP32S3,
     },
-    "esp32s3_powerfeather": {
-        "name": "ESP32-S3 PowerFeather",
-        "variant": VARIANT_ESP32S3,
-    },
-    "esp32s3usbotg": {
-        "name": "Espressif ESP32-S3-USB-OTG",
-        "variant": VARIANT_ESP32S3,
-    },
-    "esp32-solo1": {
-        "name": "Espressif Generic ESP32-solo1 4M Flash",
-        "variant": VARIANT_ESP32,
-    },
     "esp32thing": {
         "name": "SparkFun ESP32 Thing",
         "variant": VARIANT_ESP32,
@@ -1756,9 +1652,9 @@ BOARDS = {
         "name": "Heltec WiFi Kit 32",
         "variant": VARIANT_ESP32,
     },
-    "heltec_wifi_kit_32_V3": {
-        "name": "Heltec WiFi Kit 32 (V3)",
-        "variant": VARIANT_ESP32S3,
+    "heltec_wifi_kit_32_v2": {
+        "name": "Heltec WiFi Kit 32 (V2)",
+        "variant": VARIANT_ESP32,
     },
     "heltec_wifi_lora_32": {
         "name": "Heltec WiFi LoRa 32",
@@ -1768,10 +1664,6 @@ BOARDS = {
         "name": "Heltec WiFi LoRa 32 (V2)",
         "variant": VARIANT_ESP32,
     },
-    "heltec_wifi_lora_32_V3": {
-        "name": "Heltec WiFi LoRa 32 (V3)",
-        "variant": VARIANT_ESP32S3,
-    },
     "heltec_wireless_stick_lite": {
         "name": "Heltec Wireless Stick Lite",
         "variant": VARIANT_ESP32,
@@ -1816,14 +1708,6 @@ BOARDS = {
         "name": "oddWires IoT-Bus Proteus",
         "variant": VARIANT_ESP32,
     },
-    "ioxesp32": {
-        "name": "ArtronShop IOXESP32",
-        "variant": VARIANT_ESP32,
-    },
-    "ioxesp32ps": {
-        "name": "ArtronShop IOXESP32PS",
-        "variant": VARIANT_ESP32,
-    },
     "kb32-ft": {
         "name": "MakerAsia KB32-FT",
         "variant": VARIANT_ESP32,
@@ -1836,26 +1720,10 @@ BOARDS = {
         "name": "Labplus mPython",
         "variant": VARIANT_ESP32,
     },
-    "lilka_v2": {
-        "name": "Lilka v2",
-        "variant": VARIANT_ESP32S3,
-    },
-    "lilygo-t-display": {
-        "name": "LilyGo T-Display",
-        "variant": VARIANT_ESP32,
-    },
-    "lilygo-t-display-s3": {
-        "name": "LilyGo T-Display-S3",
-        "variant": VARIANT_ESP32S3,
-    },
     "lionbit": {
         "name": "Lion:Bit Dev Board",
         "variant": VARIANT_ESP32,
     },
-    "lionbits3": {
-        "name": "Lion:Bit S3 STEM Dev Board",
-        "variant": VARIANT_ESP32S3,
-    },
     "lolin32_lite": {
         "name": "WEMOS LOLIN32 Lite",
         "variant": VARIANT_ESP32,
@@ -1884,18 +1752,10 @@ BOARDS = {
         "name": "WEMOS LOLIN S2 PICO",
         "variant": VARIANT_ESP32S2,
     },
-    "lolin_s3_mini": {
-        "name": "WEMOS LOLIN S3 Mini",
-        "variant": VARIANT_ESP32S3,
-    },
     "lolin_s3": {
         "name": "WEMOS LOLIN S3",
         "variant": VARIANT_ESP32S3,
     },
-    "lolin_s3_pro": {
-        "name": "WEMOS LOLIN S3 PRO",
-        "variant": VARIANT_ESP32S3,
-    },
     "lopy4": {
         "name": "Pycom LoPy4",
         "variant": VARIANT_ESP32,
@@ -1908,18 +1768,10 @@ BOARDS = {
         "name": "M5Stack-ATOM",
         "variant": VARIANT_ESP32,
     },
-    "m5stack-atoms3": {
-        "name": "M5Stack AtomS3",
-        "variant": VARIANT_ESP32S3,
-    },
     "m5stack-core2": {
         "name": "M5Stack Core2",
         "variant": VARIANT_ESP32,
     },
-    "m5stack-core-esp32-16M": {
-        "name": "M5Stack Core ESP32 16M",
-        "variant": VARIANT_ESP32,
-    },
     "m5stack-core-esp32": {
         "name": "M5Stack Core ESP32",
         "variant": VARIANT_ESP32,
@@ -1928,10 +1780,6 @@ BOARDS = {
         "name": "M5Stack-Core Ink",
         "variant": VARIANT_ESP32,
     },
-    "m5stack-cores3": {
-        "name": "M5Stack CoreS3",
-        "variant": VARIANT_ESP32S3,
-    },
     "m5stack-fire": {
         "name": "M5Stack FIRE",
         "variant": VARIANT_ESP32,
@@ -1940,14 +1788,6 @@ BOARDS = {
         "name": "M5Stack GREY ESP32",
         "variant": VARIANT_ESP32,
     },
-    "m5stack_paper": {
-        "name": "M5Stack Paper",
-        "variant": VARIANT_ESP32,
-    },
-    "m5stack-stamps3": {
-        "name": "M5Stack StampS3",
-        "variant": VARIANT_ESP32S3,
-    },
     "m5stack-station": {
         "name": "M5Stack Station",
         "variant": VARIANT_ESP32,
@@ -1956,10 +1796,6 @@ BOARDS = {
         "name": "M5Stack Timer CAM",
         "variant": VARIANT_ESP32,
     },
-    "m5stamp-pico": {
-        "name": "M5Stamp-Pico",
-        "variant": VARIANT_ESP32,
-    },
     "m5stick-c": {
         "name": "M5Stick-C",
         "variant": VARIANT_ESP32,
@@ -1996,26 +1832,10 @@ BOARDS = {
         "name": "Deparment of Alchemy MiniMain ESP32-S2",
         "variant": VARIANT_ESP32S2,
     },
-    "motorgo_mini_1": {
-        "name": "MotorGo Mini 1 (ESP32-S3)",
-        "variant": VARIANT_ESP32S3,
-    },
-    "namino_arancio": {
-        "name": "Namino Arancio",
-        "variant": VARIANT_ESP32S3,
-    },
-    "namino_rosso": {
-        "name": "Namino Rosso",
-        "variant": VARIANT_ESP32S3,
-    },
     "nano32": {
         "name": "MakerAsia Nano32",
         "variant": VARIANT_ESP32,
     },
-    "nebulas3": {
-        "name": "Kinetic Dynamics Nebula S3",
-        "variant": VARIANT_ESP32S3,
-    },
     "nina_w10": {
         "name": "u-blox NINA-W10 series",
         "variant": VARIANT_ESP32,
@@ -2076,22 +1896,10 @@ BOARDS = {
         "name": "Munich Labs RedPill ESP32-S3",
         "variant": VARIANT_ESP32S3,
     },
-    "roboheart_hercules": {
-        "name": "RoboHeart Hercules",
-        "variant": VARIANT_ESP32,
-    },
     "seeed_xiao_esp32c3": {
         "name": "Seeed Studio XIAO ESP32C3",
         "variant": VARIANT_ESP32C3,
     },
-    "seeed_xiao_esp32s3": {
-        "name": "Seeed Studio XIAO ESP32S3",
-        "variant": VARIANT_ESP32S3,
-    },
-    "sensebox_mcu_esp32s2": {
-        "name": "senseBox MCU-S2 ESP32-S2",
-        "variant": VARIANT_ESP32S2,
-    },
     "sensesiot_weizen": {
         "name": "LOGISENSES Senses Weizen",
         "variant": VARIANT_ESP32,
@@ -2104,10 +1912,6 @@ BOARDS = {
         "name": "S.ODI Ultra v1",
         "variant": VARIANT_ESP32,
     },
-    "sparkfun_esp32c6_thing_plus": {
-        "name": "Sparkfun ESP32-C6 Thing Plus",
-        "variant": VARIANT_ESP32C6,
-    },
     "sparkfun_esp32_iot_redboard": {
         "name": "SparkFun ESP32 IoT RedBoard",
         "variant": VARIANT_ESP32,
@@ -2200,10 +2004,6 @@ BOARDS = {
         "name": "Unexpected Maker FeatherS3",
         "variant": VARIANT_ESP32S3,
     },
-    "um_nanos3": {
-        "name": "Unexpected Maker NanoS3",
-        "variant": VARIANT_ESP32S3,
-    },
     "um_pros3": {
         "name": "Unexpected Maker PROS3",
         "variant": VARIANT_ESP32S3,
@@ -2240,14 +2040,6 @@ BOARDS = {
         "name": "uPesy ESP32 Wrover DevKit",
         "variant": VARIANT_ESP32,
     },
-    "valtrack_v4_mfw_esp32_c3": {
-        "name": "Valetron Systems VALTRACK-V4MVF",
-        "variant": VARIANT_ESP32C3,
-    },
-    "valtrack_v4_vts_esp32_c3": {
-        "name": "Valetron Systems VALTRACK-V4VTS",
-        "variant": VARIANT_ESP32C3,
-    },
     "vintlabs-devkit-v1": {
         "name": "VintLabs ESP32 Devkit",
         "variant": VARIANT_ESP32,

esphome/components/esp32/gpio.py

@@ -67,10 +67,8 @@ def _translate_pin(value):
             "This variable only supports pin numbers, not full pin schemas "
             "(with inverted and mode)."
         )
-    if isinstance(value, int) and not isinstance(value, bool):
+    if isinstance(value, int):
         return value
-    if not isinstance(value, str):
-        raise cv.Invalid(f"Invalid pin number: {value}")
     try:
         return int(value)
     except ValueError:

esphome/components/esp32_ble/__init__.py

@@ -2,10 +2,8 @@ from esphome import automation
 import esphome.codegen as cg
 from esphome.components.esp32 import add_idf_sdkconfig_option, const, get_esp32_variant
 import esphome.config_validation as cv
-from esphome.const import CONF_ENABLE_ON_BOOT, CONF_ESPHOME, CONF_ID, CONF_NAME
+from esphome.const import CONF_ENABLE_ON_BOOT, CONF_ID
 from esphome.core import CORE
-from esphome.core.config import CONF_NAME_ADD_MAC_SUFFIX
-import esphome.final_validate as fv
 
 DEPENDENCIES = ["esp32"]
 CODEOWNERS = ["@jesserockz", "@Rapsssito"]
@@ -52,7 +50,6 @@ TX_POWER_LEVELS = {
 CONFIG_SCHEMA = cv.Schema(
     {
         cv.GenerateID(): cv.declare_id(ESP32BLE),
-        cv.Optional(CONF_NAME): cv.All(cv.string, cv.Length(max=20)),
         cv.Optional(CONF_IO_CAPABILITY, default="none"): cv.enum(
             IO_CAPABILITY, lower=True
         ),
@@ -70,22 +67,7 @@ def validate_variant(_):
         raise cv.Invalid(f"{variant} does not support Bluetooth")
 
 
-def final_validation(config):
-    validate_variant(config)
-    if (name := config.get(CONF_NAME)) is not None:
-        full_config = fv.full_config.get()
-        max_length = 20
-        if full_config[CONF_ESPHOME][CONF_NAME_ADD_MAC_SUFFIX]:
-            max_length -= 7  # "-AABBCC" is appended when add mac suffix option is used
-        if len(name) > max_length:
-            raise cv.Invalid(
-                f"Name '{name}' is too long, maximum length is {max_length} characters"
-            )
-
-    return config
-
-
-FINAL_VALIDATE_SCHEMA = final_validation
+FINAL_VALIDATE_SCHEMA = validate_variant
 
 
 async def to_code(config):
@@ -93,8 +75,6 @@ async def to_code(config):
     cg.add(var.set_enable_on_boot(config[CONF_ENABLE_ON_BOOT]))
     cg.add(var.set_io_capability(config[CONF_IO_CAPABILITY]))
     cg.add(var.set_advertising_cycle_time(config[CONF_ADVERTISING_CYCLE_TIME]))
-    if (name := config.get(CONF_NAME)) is not None:
-        cg.add(var.set_name(name))
     await cg.register_component(var, config)
 
     if CORE.using_esp_idf:

esphome/components/esp32_ble/ble.cpp

@@ -27,9 +27,6 @@ namespace esp32_ble {
 
 static const char *const TAG = "esp32_ble";
 
-static RAMAllocator<BLEEvent> EVENT_ALLOCATOR(  // NOLINT(cppcoreguidelines-avoid-non-const-global-variables)
-    RAMAllocator<BLEEvent>::ALLOW_FAILURE | RAMAllocator<BLEEvent>::ALLOC_INTERNAL);
-
 void ESP32BLE::setup() {
   global_ble = this;
   ESP_LOGCONFIG(TAG, "Setting up BLE...");
@@ -191,20 +188,12 @@ bool ESP32BLE::ble_setup_() {
     }
   }
 
-  std::string name;
-  if (this->name_.has_value()) {
-    name = this->name_.value();
+  std::string name = App.get_name();
+  if (name.length() > 20) {
     if (App.is_name_add_mac_suffix_enabled()) {
-      name += "-" + get_mac_address().substr(6);
-    }
-  } else {
-    name = App.get_name();
-    if (name.length() > 20) {
-      if (App.is_name_add_mac_suffix_enabled()) {
-        name.erase(name.begin() + 13, name.end() - 7);  // Remove characters between 13 and the mac address
-      } else {
-        name = name.substr(0, 20);
-      }
+      name.erase(name.begin() + 13, name.end() - 7);  // Remove characters between 13 and the mac address
+    } else {
+      name = name.substr(0, 20);
     }
   }
 
@@ -325,8 +314,7 @@ void ESP32BLE::loop() {
       default:
         break;
     }
-    ble_event->~BLEEvent();
-    EVENT_ALLOCATOR.deallocate(ble_event, 1);
+    delete ble_event;  // NOLINT(cppcoreguidelines-owning-memory)
     ble_event = this->ble_events_.pop();
   }
   if (this->advertising_ != nullptr) {
@@ -335,14 +323,9 @@ void ESP32BLE::loop() {
 }
 
 void ESP32BLE::gap_event_handler(esp_gap_ble_cb_event_t event, esp_ble_gap_cb_param_t *param) {
-  BLEEvent *new_event = EVENT_ALLOCATOR.allocate(1);
-  if (new_event == nullptr) {
-    // Memory too fragmented to allocate new event. Can only drop it until memory comes back
-    return;
-  }
-  new (new_event) BLEEvent(event, param);
+  BLEEvent *new_event = new BLEEvent(event, param);  // NOLINT(cppcoreguidelines-owning-memory)
   global_ble->ble_events_.push(new_event);
-}  // NOLINT(clang-analyzer-unix.Malloc)
+}  // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
 
 void ESP32BLE::real_gap_event_handler_(esp_gap_ble_cb_event_t event, esp_ble_gap_cb_param_t *param) {
   ESP_LOGV(TAG, "(BLE) gap_event_handler - %d", event);
@@ -353,14 +336,9 @@ void ESP32BLE::real_gap_event_handler_(esp_gap_ble_cb_event_t event, esp_ble_gap
 
 void ESP32BLE::gatts_event_handler(esp_gatts_cb_event_t event, esp_gatt_if_t gatts_if,
                                    esp_ble_gatts_cb_param_t *param) {
-  BLEEvent *new_event = EVENT_ALLOCATOR.allocate(1);
-  if (new_event == nullptr) {
-    // Memory too fragmented to allocate new event. Can only drop it until memory comes back
-    return;
-  }
-  new (new_event) BLEEvent(event, gatts_if, param);
+  BLEEvent *new_event = new BLEEvent(event, gatts_if, param);  // NOLINT(cppcoreguidelines-owning-memory)
   global_ble->ble_events_.push(new_event);
-}  // NOLINT(clang-analyzer-unix.Malloc)
+}  // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
 
 void ESP32BLE::real_gatts_event_handler_(esp_gatts_cb_event_t event, esp_gatt_if_t gatts_if,
                                          esp_ble_gatts_cb_param_t *param) {
@@ -372,14 +350,9 @@ void ESP32BLE::real_gatts_event_handler_(esp_gatts_cb_event_t event, esp_gatt_if
 
 void ESP32BLE::gattc_event_handler(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if,
                                    esp_ble_gattc_cb_param_t *param) {
-  BLEEvent *new_event = EVENT_ALLOCATOR.allocate(1);
-  if (new_event == nullptr) {
-    // Memory too fragmented to allocate new event. Can only drop it until memory comes back
-    return;
-  }
-  new (new_event) BLEEvent(event, gattc_if, param);
+  BLEEvent *new_event = new BLEEvent(event, gattc_if, param);  // NOLINT(cppcoreguidelines-owning-memory)
   global_ble->ble_events_.push(new_event);
-}  // NOLINT(clang-analyzer-unix.Malloc)
+}  // NOLINT(clang-analyzer-cplusplus.NewDeleteLeaks)
 
 void ESP32BLE::real_gattc_event_handler_(esp_gattc_cb_event_t event, esp_gatt_if_t gattc_if,
                                          esp_ble_gattc_cb_param_t *param) {

esphome/components/esp32_ble/ble.h

@@ -90,7 +90,6 @@ class ESP32BLE : public Component {
   void loop() override;
   void dump_config() override;
   float get_setup_priority() const override;
-  void set_name(const std::string &name) { this->name_ = name; }
 
   void advertising_start();
   void advertising_set_service_data(const std::vector<uint8_t> &data);
@@ -132,7 +131,6 @@ class ESP32BLE : public Component {
   esp_ble_io_cap_t io_cap_{ESP_IO_CAP_NONE};
   uint32_t advertising_cycle_time_;
   bool enable_on_boot_;
-  optional<std::string> name_;
 };
 
 // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)

esphome/components/esp32_ble/ble_advertising.cpp

@@ -83,7 +83,7 @@ esp_err_t BLEAdvertising::services_advertisement_() {
   esp_err_t err;
 
   this->advertising_data_.set_scan_rsp = false;
-  this->advertising_data_.include_name = true;
+  this->advertising_data_.include_name = !this->scan_response_;
   this->advertising_data_.include_txpower = !this->scan_response_;
   err = esp_ble_gap_config_adv_data(&this->advertising_data_);
   if (err != ESP_OK) {

esphome/components/esp32_ble/ble_uuid.cpp

@@ -34,7 +34,7 @@ ESPBTUUID ESPBTUUID::from_raw(const uint8_t *data) {
 ESPBTUUID ESPBTUUID::from_raw_reversed(const uint8_t *data) {
   ESPBTUUID ret;
   ret.uuid_.len = ESP_UUID_LEN_128;
-  for (uint8_t i = 0; i < ESP_UUID_LEN_128; i++)
+  for (int i = 0; i < ESP_UUID_LEN_128; i++)
     ret.uuid_.uuid.uuid128[ESP_UUID_LEN_128 - 1 - i] = data[i];
   return ret;
 }
@@ -43,30 +43,30 @@ ESPBTUUID ESPBTUUID::from_raw(const std::string &data) {
   if (data.length() == 4) {
     ret.uuid_.len = ESP_UUID_LEN_16;
     ret.uuid_.uuid.uuid16 = 0;
-    for (uint i = 0; i < data.length(); i += 2) {
+    for (int i = 0; i < data.length();) {
       uint8_t msb = data.c_str()[i];
       uint8_t lsb = data.c_str()[i + 1];
-      uint8_t lsb_shift = i <= 2 ? (2 - i) * 4 : 0;
 
       if (msb > '9')
         msb -= 7;
       if (lsb > '9')
         lsb -= 7;
-      ret.uuid_.uuid.uuid16 += (((msb & 0x0F) << 4) | (lsb & 0x0F)) << lsb_shift;
+      ret.uuid_.uuid.uuid16 += (((msb & 0x0F) << 4) | (lsb & 0x0F)) << (2 - i) * 4;
+      i += 2;
     }
   } else if (data.length() == 8) {
     ret.uuid_.len = ESP_UUID_LEN_32;
     ret.uuid_.uuid.uuid32 = 0;
-    for (uint i = 0; i < data.length(); i += 2) {
+    for (int i = 0; i < data.length();) {
       uint8_t msb = data.c_str()[i];
       uint8_t lsb = data.c_str()[i + 1];
-      uint8_t lsb_shift = i <= 6 ? (6 - i) * 4 : 0;
 
       if (msb > '9')
         msb -= 7;
       if (lsb > '9')
         lsb -= 7;
-      ret.uuid_.uuid.uuid32 += (((msb & 0x0F) << 4) | (lsb & 0x0F)) << lsb_shift;
+      ret.uuid_.uuid.uuid32 += (((msb & 0x0F) << 4) | (lsb & 0x0F)) << (6 - i) * 4;
+      i += 2;
     }
   } else if (data.length() == 16) {  // how we can have 16 byte length string reprezenting 128 bit uuid??? needs to be
                                      // investigated (lack of time)
@@ -77,7 +77,7 @@ ESPBTUUID ESPBTUUID::from_raw(const std::string &data) {
     // UUID format.
     ret.uuid_.len = ESP_UUID_LEN_128;
     int n = 0;
-    for (uint i = 0; i < data.length(); i += 2) {
+    for (int i = 0; i < data.length();) {
       if (data.c_str()[i] == '-')
         i++;
       uint8_t msb = data.c_str()[i];
@@ -88,6 +88,7 @@ ESPBTUUID ESPBTUUID::from_raw(const std::string &data) {
       if (lsb > '9')
         lsb -= 7;
       ret.uuid_.uuid.uuid128[15 - n++] = ((msb & 0x0F) << 4) | (lsb & 0x0F);
+      i += 2;
     }
   } else {
     ESP_LOGE(TAG, "ERROR: UUID value not 2, 4, 16 or 36 bytes - %s", data.c_str());
@@ -154,7 +155,7 @@ bool ESPBTUUID::operator==(const ESPBTUUID &uuid) const {
         }
         break;
       case ESP_UUID_LEN_128:
-        for (uint8_t i = 0; i < ESP_UUID_LEN_128; i++) {
+        for (int i = 0; i < ESP_UUID_LEN_128; i++) {
           if (uuid.uuid_.uuid.uuid128[i] != this->uuid_.uuid.uuid128[i]) {
             return false;
           }

esphome/components/esp32_ble_client/ble_client_base.h

@@ -35,7 +35,7 @@ class BLEClientBase : public espbt::ESPBTClient, public Component {
   void gap_event_handler(esp_gap_ble_cb_event_t event, esp_ble_gap_cb_param_t *param) override;
   void connect() override;
   esp_err_t pair();
-  void disconnect() override;
+  void disconnect();
   void release_services();
 
   bool connected() { return this->state_ == espbt::ClientState::ESTABLISHED; }

esphome/components/esp32_ble_tracker/esp32_ble_tracker.cpp

@@ -65,9 +65,6 @@ void ESP32BLETracker::setup() {
       [this](ota::OTAState state, float progress, uint8_t error, ota::OTAComponent *comp) {
         if (state == ota::OTA_STARTED) {
           this->stop_scan();
-          for (auto *client : this->clients_) {
-            client->disconnect();
-          }
         }
       });
 #endif
@@ -432,7 +429,7 @@ void ESPBTDevice::parse_scan_rst(const esp_ble_gap_cb_param_t::ble_scan_result_e
 
 #ifdef ESPHOME_LOG_HAS_VERY_VERBOSE
   ESP_LOGVV(TAG, "Parse Result:");
-  const char *address_type;
+  const char *address_type = "";
   switch (this->address_type_) {
     case BLE_ADDR_TYPE_PUBLIC:
       address_type = "PUBLIC";
@@ -446,9 +443,6 @@ void ESPBTDevice::parse_scan_rst(const esp_ble_gap_cb_param_t::ble_scan_result_e
     case BLE_ADDR_TYPE_RPA_RANDOM:
       address_type = "RPA_RANDOM";
       break;
-    default:
-      address_type = "UNKNOWN";
-      break;
   }
   ESP_LOGVV(TAG, "  Address: %02X:%02X:%02X:%02X:%02X:%02X (%s)", this->address_[0], this->address_[1],
             this->address_[2], this->address_[3], this->address_[4], this->address_[5], address_type);

esphome/components/esp32_ble_tracker/esp32_ble_tracker.h

@@ -11,9 +11,9 @@
 
 #ifdef USE_ESP32
 
-#include <esp_bt_defs.h>
 #include <esp_gap_ble_api.h>
 #include <esp_gattc_api.h>
+#include <esp_bt_defs.h>
 
 #include <freertos/FreeRTOS.h>
 #include <freertos/semphr.h>
@@ -172,7 +172,6 @@ class ESPBTClient : public ESPBTDeviceListener {
                                    esp_ble_gattc_cb_param_t *param) = 0;
   virtual void gap_event_handler(esp_gap_ble_cb_event_t event, esp_ble_gap_cb_param_t *param) = 0;
   virtual void connect() = 0;
-  virtual void disconnect() = 0;
   virtual void set_state(ClientState st) { this->state_ = st; }
   ClientState state() const { return state_; }
   int app_id;

esphome/components/esp32_camera_web_server/camera_web_server.h

@@ -11,7 +11,7 @@
 #include "esphome/core/helpers.h"
 #include "esphome/core/preferences.h"
 
-struct httpd_req;  // NOLINT(readability-identifier-naming)
+struct httpd_req;
 
 namespace esphome {
 namespace esp32_camera_web_server {

esphome/components/esp32_rmt_led_strip/light.py

@@ -1,9 +1,9 @@
 from dataclasses import dataclass
 
-from esphome import pins
 import esphome.codegen as cg
-from esphome.components import esp32_rmt, light
 import esphome.config_validation as cv
+from esphome import pins
+from esphome.components import esp32_rmt, light
 from esphome.const import (
     CONF_CHIPSET,
     CONF_IS_RGBW,
@@ -103,7 +103,7 @@ CONFIG_SCHEMA = cv.All(
                 default="0 us",
             ): cv.positive_time_period_nanoseconds,
         }
-    ).extend(cv.COMPONENT_SCHEMA),
+    ),
     cv.has_exactly_one_key(CONF_CHIPSET, CONF_BIT0_HIGH),
 )
 

esphome/components/esp8266/__init__.py

@@ -1,13 +1,10 @@
 import logging
 import os
 
-import esphome.codegen as cg
-import esphome.config_validation as cv
 from esphome.const import (
     CONF_BOARD,
     CONF_BOARD_FLASH_MODE,
     CONF_FRAMEWORK,
-    CONF_PLATFORM_VERSION,
     CONF_SOURCE,
     CONF_VERSION,
     KEY_CORE,
@@ -15,22 +12,27 @@ from esphome.const import (
     KEY_TARGET_FRAMEWORK,
     KEY_TARGET_PLATFORM,
     PLATFORM_ESP8266,
+    CONF_PLATFORM_VERSION,
 )
 from esphome.core import CORE, coroutine_with_priority
+import esphome.config_validation as cv
+import esphome.codegen as cg
 from esphome.helpers import copy_file_if_changed
 
-from .boards import BOARDS, ESP8266_LD_SCRIPTS
 from .const import (
-    CONF_EARLY_PIN_INIT,
     CONF_RESTORE_FROM_FLASH,
+    CONF_EARLY_PIN_INIT,
     KEY_BOARD,
     KEY_ESP8266,
     KEY_FLASH_SIZE,
     KEY_PIN_INITIAL_STATES,
     esp8266_ns,
 )
+from .boards import BOARDS, ESP8266_LD_SCRIPTS
+
 from .gpio import PinInitialState, add_pin_initial_states_array
 
+
 CODEOWNERS = ["@esphome/core"]
 _LOGGER = logging.getLogger(__name__)
 AUTO_LOAD = ["preferences"]

esphome/components/esp8266/gpio.py

@@ -1,9 +1,6 @@
-from dataclasses import dataclass
 import logging
+from dataclasses import dataclass
 
-from esphome import pins
-import esphome.codegen as cg
-import esphome.config_validation as cv
 from esphome.const import (
     CONF_ANALOG,
     CONF_ID,
@@ -17,7 +14,10 @@ from esphome.const import (
     CONF_PULLUP,
     PLATFORM_ESP8266,
 )
+from esphome import pins
 from esphome.core import CORE, coroutine_with_priority
+import esphome.config_validation as cv
+import esphome.codegen as cg
 
 from . import boards
 from .const import KEY_BOARD, KEY_ESP8266, KEY_PIN_INITIAL_STATES, esp8266_ns
@@ -48,10 +48,8 @@ def _translate_pin(value):
             "This variable only supports pin numbers, not full pin schemas "
             "(with inverted and mode)."
         )
-    if isinstance(value, int) and not isinstance(value, bool):
+    if isinstance(value, int):
         return value
-    if not isinstance(value, str):
-        raise cv.Invalid(f"Invalid pin number: {value}")
     try:
         return int(value)
     except ValueError:

esphome/components/esphome/ota/__init__.py

@@ -1,9 +1,10 @@
 import logging
 
 import esphome.codegen as cg
-from esphome.components.ota import BASE_OTA_SCHEMA, OTAComponent, ota_to_code
-from esphome.config_helpers import merge_config
 import esphome.config_validation as cv
+import esphome.final_validate as fv
+from esphome.components.ota import BASE_OTA_SCHEMA, ota_to_code, OTAComponent
+from esphome.config_helpers import merge_config
 from esphome.const import (
     CONF_ESPHOME,
     CONF_ID,
@@ -17,7 +18,6 @@ from esphome.const import (
     CONF_VERSION,
 )
 from esphome.core import coroutine_with_priority
-import esphome.final_validate as fv
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -124,6 +124,7 @@ FINAL_VALIDATE_SCHEMA = ota_esphome_final_validate
 @coroutine_with_priority(52.0)
 async def to_code(config):
     var = cg.new_Pvariable(config[CONF_ID])
+    await ota_to_code(var, config)
     cg.add(var.set_port(config[CONF_PORT]))
     if CONF_PASSWORD in config:
         cg.add(var.set_auth_password(config[CONF_PASSWORD]))
@@ -131,4 +132,3 @@ async def to_code(config):
     cg.add_define("USE_OTA_VERSION", config[CONF_VERSION])
 
     await cg.register_component(var, config)
-    await ota_to_code(var, config)

esphome/components/ethernet/__init__.py

@@ -1,4 +1,3 @@
-import logging
 from esphome import pins
 import esphome.codegen as cg
 from esphome.components.esp32 import add_idf_sdkconfig_option, get_esp32_variant
@@ -24,7 +23,6 @@ from esphome.const import (
     CONF_MISO_PIN,
     CONF_MOSI_PIN,
     CONF_PAGE_ID,
-    CONF_POLLING_INTERVAL,
     CONF_RESET_PIN,
     CONF_SPI,
     CONF_STATIC_IP,
@@ -32,16 +30,13 @@ from esphome.const import (
     CONF_TYPE,
     CONF_USE_ADDRESS,
     CONF_VALUE,
-    KEY_CORE,
-    KEY_FRAMEWORK_VERSION,
 )
-from esphome.core import CORE, TimePeriodMilliseconds, coroutine_with_priority
+from esphome.core import CORE, coroutine_with_priority
 import esphome.final_validate as fv
 
 CONFLICTS_WITH = ["wifi"]
 DEPENDENCIES = ["esp32"]
 AUTO_LOAD = ["network"]
-LOGGER = logging.getLogger(__name__)
 
 ethernet_ns = cg.esphome_ns.namespace("ethernet")
 PHYRegister = ethernet_ns.struct("PHYRegister")
@@ -68,7 +63,6 @@ ETHERNET_TYPES = {
 }
 
 SPI_ETHERNET_TYPES = ["W5500"]
-SPI_ETHERNET_DEFAULT_POLLING_INTERVAL = TimePeriodMilliseconds(milliseconds=10)
 
 emac_rmii_clock_mode_t = cg.global_ns.enum("emac_rmii_clock_mode_t")
 emac_rmii_clock_gpio_t = cg.global_ns.enum("emac_rmii_clock_gpio_t")
@@ -106,24 +100,6 @@ EthernetComponent = ethernet_ns.class_("EthernetComponent", cg.Component)
 ManualIP = ethernet_ns.struct("ManualIP")
 
 
-def _is_framework_spi_polling_mode_supported():
-    # SPI Ethernet without IRQ feature is added in
-    # esp-idf >= (5.3+ ,5.2.1+, 5.1.4) and arduino-esp32 >= 3.0.0
-    framework_version = CORE.data[KEY_CORE][KEY_FRAMEWORK_VERSION]
-    if CORE.using_esp_idf:
-        if framework_version >= cv.Version(5, 3, 0):
-            return True
-        if cv.Version(5, 3, 0) > framework_version >= cv.Version(5, 2, 1):
-            return True
-        if cv.Version(5, 2, 0) > framework_version >= cv.Version(5, 1, 4):
-            return True
-        return False
-    if CORE.using_arduino:
-        return framework_version >= cv.Version(3, 0, 0)
-    # fail safe: Unknown framework
-    return False
-
-
 def _validate(config):
     if CONF_USE_ADDRESS not in config:
         if CONF_MANUAL_IP in config:
@@ -131,27 +107,6 @@ def _validate(config):
         else:
             use_address = CORE.name + config[CONF_DOMAIN]
         config[CONF_USE_ADDRESS] = use_address
-    if config[CONF_TYPE] in SPI_ETHERNET_TYPES:
-        if _is_framework_spi_polling_mode_supported():
-            if CONF_POLLING_INTERVAL in config and CONF_INTERRUPT_PIN in config:
-                raise cv.Invalid(
-                    f"Cannot specify more than one of {CONF_INTERRUPT_PIN}, {CONF_POLLING_INTERVAL}"
-                )
-            if CONF_POLLING_INTERVAL not in config and CONF_INTERRUPT_PIN not in config:
-                config[CONF_POLLING_INTERVAL] = SPI_ETHERNET_DEFAULT_POLLING_INTERVAL
-        else:
-            if CONF_POLLING_INTERVAL in config:
-                raise cv.Invalid(
-                    "In this version of the framework "
-                    f"({CORE.target_framework} {CORE.data[KEY_CORE][KEY_FRAMEWORK_VERSION]}), "
-                    f"'{CONF_POLLING_INTERVAL}' is not supported."
-                )
-            if CONF_INTERRUPT_PIN not in config:
-                raise cv.Invalid(
-                    "In this version of the framework "
-                    f"({CORE.target_framework} {CORE.data[KEY_CORE][KEY_FRAMEWORK_VERSION]}), "
-                    f"'{CONF_INTERRUPT_PIN}' is a required option for [ethernet]."
-                )
     return config
 
 
@@ -202,11 +157,6 @@ SPI_SCHEMA = BASE_SCHEMA.extend(
             cv.Optional(CONF_CLOCK_SPEED, default="26.67MHz"): cv.All(
                 cv.frequency, cv.int_range(int(8e6), int(80e6))
             ),
-            # Set default value (SPI_ETHERNET_DEFAULT_POLLING_INTERVAL) at _validate()
-            cv.Optional(CONF_POLLING_INTERVAL): cv.All(
-                cv.positive_time_period_milliseconds,
-                cv.Range(min=TimePeriodMilliseconds(milliseconds=1)),
-            ),
         }
     ),
 )
@@ -284,10 +234,6 @@ async def to_code(config):
         cg.add(var.set_cs_pin(config[CONF_CS_PIN]))
         if CONF_INTERRUPT_PIN in config:
             cg.add(var.set_interrupt_pin(config[CONF_INTERRUPT_PIN]))
-        else:
-            cg.add(var.set_polling_interval(config[CONF_POLLING_INTERVAL]))
-        if _is_framework_spi_polling_mode_supported():
-            cg.add_define("USE_ETHERNET_SPI_POLLING_SUPPORT")
         if CONF_RESET_PIN in config:
             cg.add(var.set_reset_pin(config[CONF_RESET_PIN]))
         cg.add(var.set_clock_speed(config[CONF_CLOCK_SPEED]))

esphome/components/ethernet/ethernet_component.cpp

@@ -116,9 +116,6 @@ void EthernetComponent::setup() {
   eth_w5500_config_t w5500_config = ETH_W5500_DEFAULT_CONFIG(spi_handle);
 #endif
   w5500_config.int_gpio_num = this->interrupt_pin_;
-#ifdef USE_ETHERNET_SPI_POLLING_SUPPORT
-  w5500_config.poll_period_ms = this->polling_interval_;
-#endif
   phy_config.phy_addr = this->phy_addr_spi_;
   phy_config.reset_gpio_num = this->reset_pin_;
 
@@ -330,14 +327,7 @@ void EthernetComponent::dump_config() {
   ESP_LOGCONFIG(TAG, "  MISO Pin: %u", this->miso_pin_);
   ESP_LOGCONFIG(TAG, "  MOSI Pin: %u", this->mosi_pin_);
   ESP_LOGCONFIG(TAG, "  CS Pin: %u", this->cs_pin_);
-#ifdef USE_ETHERNET_SPI_POLLING_SUPPORT
-  if (this->polling_interval_ != 0) {
-    ESP_LOGCONFIG(TAG, "  Polling Interval: %lu ms", this->polling_interval_);
-  } else
-#endif
-  {
-    ESP_LOGCONFIG(TAG, "  IRQ Pin: %d", this->interrupt_pin_);
-  }
+  ESP_LOGCONFIG(TAG, "  IRQ Pin: %u", this->interrupt_pin_);
   ESP_LOGCONFIG(TAG, "  Reset Pin: %d", this->reset_pin_);
   ESP_LOGCONFIG(TAG, "  Clock Speed: %d MHz", this->clock_speed_ / 1000000);
 #else
@@ -546,9 +536,6 @@ void EthernetComponent::set_cs_pin(uint8_t cs_pin) { this->cs_pin_ = cs_pin; }
 void EthernetComponent::set_interrupt_pin(uint8_t interrupt_pin) { this->interrupt_pin_ = interrupt_pin; }
 void EthernetComponent::set_reset_pin(uint8_t reset_pin) { this->reset_pin_ = reset_pin; }
 void EthernetComponent::set_clock_speed(int clock_speed) { this->clock_speed_ = clock_speed; }
-#ifdef USE_ETHERNET_SPI_POLLING_SUPPORT
-void EthernetComponent::set_polling_interval(uint32_t polling_interval) { this->polling_interval_ = polling_interval; }
-#endif
 #else
 void EthernetComponent::set_phy_addr(uint8_t phy_addr) { this->phy_addr_ = phy_addr; }
 void EthernetComponent::set_power_pin(int power_pin) { this->power_pin_ = power_pin; }

esphome/components/ethernet/ethernet_component.h

@@ -67,9 +67,6 @@ class EthernetComponent : public Component {
   void set_interrupt_pin(uint8_t interrupt_pin);
   void set_reset_pin(uint8_t reset_pin);
   void set_clock_speed(int clock_speed);
-#ifdef USE_ETHERNET_SPI_POLLING_SUPPORT
-  void set_polling_interval(uint32_t polling_interval);
-#endif
 #else
   void set_phy_addr(uint8_t phy_addr);
   void set_power_pin(int power_pin);
@@ -111,13 +108,10 @@ class EthernetComponent : public Component {
   uint8_t miso_pin_;
   uint8_t mosi_pin_;
   uint8_t cs_pin_;
-  int interrupt_pin_{-1};
+  uint8_t interrupt_pin_;
   int reset_pin_{-1};
   int phy_addr_spi_{-1};
   int clock_speed_;
-#ifdef USE_ETHERNET_SPI_POLLING_SUPPORT
-  uint32_t polling_interval_{0};
-#endif
 #else
   uint8_t phy_addr_{0};
   int power_pin_{-1};

esphome/components/ezo/ezo.cpp

@@ -111,11 +111,11 @@ void EZOSensor::loop() {
   if (buf[0] == 1) {
     std::string payload = reinterpret_cast<char *>(&buf[1]);
     if (!payload.empty()) {
-      auto start_location = payload.find(',');
       switch (to_run->command_type) {
         case EzoCommandType::EZO_READ: {
           // some sensors return multiple comma-separated values, terminate string after first one
-          if (start_location != std::string::npos) {
+          int start_location = 0;
+          if ((start_location = payload.find(',')) != std::string::npos) {
             payload.erase(start_location);
           }
           auto val = parse_number<float>(payload);
@@ -126,37 +126,49 @@ void EZOSensor::loop() {
           }
           break;
         }
-        case EzoCommandType::EZO_LED:
+        case EzoCommandType::EZO_LED: {
           this->led_callback_.call(payload.back() == '1');
           break;
-        case EzoCommandType::EZO_DEVICE_INFORMATION:
-          if (start_location != std::string::npos) {
+        }
+        case EzoCommandType::EZO_DEVICE_INFORMATION: {
+          int start_location = 0;
+          if ((start_location = payload.find(',')) != std::string::npos) {
             this->device_infomation_callback_.call(payload.substr(start_location + 1));
           }
           break;
-        case EzoCommandType::EZO_SLOPE:
-          if (start_location != std::string::npos) {
+        }
+        case EzoCommandType::EZO_SLOPE: {
+          int start_location = 0;
+          if ((start_location = payload.find(',')) != std::string::npos) {
             this->slope_callback_.call(payload.substr(start_location + 1));
           }
           break;
-        case EzoCommandType::EZO_CALIBRATION:
-          if (start_location != std::string::npos) {
+        }
+        case EzoCommandType::EZO_CALIBRATION: {
+          int start_location = 0;
+          if ((start_location = payload.find(',')) != std::string::npos) {
             this->calibration_callback_.call(payload.substr(start_location + 1));
           }
           break;
-        case EzoCommandType::EZO_T:
-          if (start_location != std::string::npos) {
+        }
+        case EzoCommandType::EZO_T: {
+          int start_location = 0;
+          if ((start_location = payload.find(',')) != std::string::npos) {
             this->t_callback_.call(payload.substr(start_location + 1));
           }
           break;
-        case EzoCommandType::EZO_CUSTOM:
+        }
+        case EzoCommandType::EZO_CUSTOM: {
           this->custom_callback_.call(payload);
           break;
-        default:
+        }
+        default: {
           break;
+        }
       }
     }
   }
+
   this->commands_.pop_front();
 }
 
@@ -166,7 +178,7 @@ void EZOSensor::add_command_(const std::string &command, EzoCommandType command_
   ezo_command->command_type = command_type;
   ezo_command->delay_ms = delay_ms;
   this->commands_.push_back(std::move(ezo_command));
-}
+};
 
 void EZOSensor::set_calibration_point_(EzoCalibrationType type, float value) {
   std::string payload = str_sprintf("Cal,%s,%0.2f", EZO_CALIBRATION_TYPE_STRINGS[type], value);

esphome/components/font/__init__.py

@@ -5,8 +5,7 @@ import os
 from pathlib import Path
 import re
 
-import freetype
-import glyphsets
+from packaging import version
 import requests
 
 from esphome import core, external_files
@@ -44,21 +43,6 @@ GlyphData = font_ns.struct("GlyphData")
 CONF_BPP = "bpp"
 CONF_EXTRAS = "extras"
 CONF_FONTS = "fonts"
-CONF_GLYPHSETS = "glyphsets"
-CONF_IGNORE_MISSING_GLYPHS = "ignore_missing_glyphs"
-
-
-# Cache loaded freetype fonts
-class FontCache(dict):
-    def __missing__(self, key):
-        try:
-            res = self[key] = freetype.Face(key)
-            return res
-        except freetype.FT_Exception as e:
-            raise cv.Invalid(f"Could not load Font file {key}: {e}") from e
-
-
-FONT_CACHE = FontCache()
 
 
 def glyph_comparator(x, y):
@@ -75,109 +59,57 @@ def glyph_comparator(x, y):
         return -1
     if len(x_) > len(y_):
         return 1
-    return 0
+    raise cv.Invalid(f"Found duplicate glyph {x}")
 
 
-def flatten(lists) -> list:
-    """
-    Given a list of lists, flatten it to a single list of all elements of all lists.
-    This wraps itertools.chain.from_iterable to make it more readable, and return a list
-    rather than a single use iterable.
-    """
-    from itertools import chain
+def validate_glyphs(value):
+    if isinstance(value, list):
+        value = cv.Schema([cv.string])(value)
+    value = cv.Schema([cv.string])(list(value))
 
-    return list(chain.from_iterable(lists))
+    value.sort(key=functools.cmp_to_key(glyph_comparator))
+    return value
 
 
-def check_missing_glyphs(file, codepoints, warning: bool = False):
-    """
-    Check that the given font file actually contains the requested glyphs
-    :param file: A Truetype font file
-    :param codepoints: A list of codepoints to check
-    :param warning: If true, log a warning instead of raising an exception
-    """
+font_map = {}
 
-    font = FONT_CACHE[file]
-    missing = [chr(x) for x in codepoints if font.get_char_index(x) == 0]
-    if missing:
-        # Only list up to 10 missing glyphs
-        missing.sort(key=functools.cmp_to_key(glyph_comparator))
-        count = len(missing)
-        missing = missing[:10]
-        missing_str = "\n    ".join(
-            f"{x} ({x.encode('unicode_escape')})" for x in missing
+
+def merge_glyphs(config):
+    glyphs = []
+    glyphs.extend(config[CONF_GLYPHS])
+    font_list = [(EFont(config[CONF_FILE], config[CONF_SIZE], config[CONF_GLYPHS]))]
+    if extras := config.get(CONF_EXTRAS):
+        extra_fonts = list(
+            map(
+                lambda x: EFont(x[CONF_FILE], config[CONF_SIZE], x[CONF_GLYPHS]), extras
+            )
         )
-        if count > 10:
-            missing_str += f"\n    and {count - 10} more."
-        message = f"Font {Path(file).name} is missing {count} glyph{'s' if count != 1 else ''}:\n    {missing_str}"
-        if warning:
-            _LOGGER.warning(message)
-        else:
-            raise cv.Invalid(message)
-
-
-def validate_glyphs(config):
-    """
-    Check for duplicate codepoints, then check that all requested codepoints actually
-    have glyphs defined in the appropriate font file.
-    """
-
-    # Collect all glyph codepoints and flatten to a list of chars
-    glyphspoints = flatten(
-        [x[CONF_GLYPHS] for x in config[CONF_EXTRAS]] + config[CONF_GLYPHS]
-    )
-    # Convert a list of strings to a list of chars (one char strings)
-    glyphspoints = flatten([list(x) for x in glyphspoints])
-    if len(set(glyphspoints)) != len(glyphspoints):
-        duplicates = {x for x in glyphspoints if glyphspoints.count(x) > 1}
-        dup_str = ", ".join(f"{x} ({x.encode('unicode_escape')})" for x in duplicates)
-        raise cv.Invalid(
-            f"Found duplicate glyph{'s' if len(duplicates) != 1 else ''}: {dup_str}"
-        )
-    # convert to codepoints
-    glyphspoints = {ord(x) for x in glyphspoints}
-    fileconf = config[CONF_FILE]
-    setpoints = set(
-        flatten([glyphsets.unicodes_per_glyphset(x) for x in config[CONF_GLYPHSETS]])
-    )
-    # Make setpoints and glyphspoints disjoint
-    setpoints.difference_update(glyphspoints)
-    if fileconf[CONF_TYPE] == TYPE_LOCAL_BITMAP:
-        # Pillow only allows 256 glyphs per bitmap font. Not sure if that is a Pillow limitation
-        # or a file format limitation
-        if any(x >= 256 for x in setpoints.copy().union(glyphspoints)):
-            raise cv.Invalid("Codepoints in bitmap fonts must be in the range 0-255")
-    else:
-        # for TT fonts, check that glyphs are actually present
-        # Check extras against their own font, exclude from parent font codepoints
-        for extra in config[CONF_EXTRAS]:
-            points = {ord(x) for x in flatten(extra[CONF_GLYPHS])}
-            glyphspoints.difference_update(points)
-            setpoints.difference_update(points)
-            check_missing_glyphs(extra[CONF_FILE][CONF_PATH], points)
-
-        # A named glyph that can't be provided is an error
-        check_missing_glyphs(fileconf[CONF_PATH], glyphspoints)
-        # A missing glyph from a set is a warning.
-        if not config[CONF_IGNORE_MISSING_GLYPHS]:
-            check_missing_glyphs(fileconf[CONF_PATH], setpoints, warning=True)
-
-    # Populate the default after the above checks so that use of the default doesn't trigger errors
-    if not config[CONF_GLYPHS] and not config[CONF_GLYPHSETS]:
-        if fileconf[CONF_TYPE] == TYPE_LOCAL_BITMAP:
-            config[CONF_GLYPHS] = [DEFAULT_GLYPHS]
-        else:
-            # set a default glyphset, intersected with what the font actually offers
-            font = FONT_CACHE[fileconf[CONF_PATH]]
-            config[CONF_GLYPHS] = [
-                chr(x)
-                for x in glyphsets.unicodes_per_glyphset(DEFAULT_GLYPHSET)
-                if font.get_char_index(x) != 0
-            ]
-
+        font_list.extend(extra_fonts)
+        for extra in extras:
+            glyphs.extend(extra[CONF_GLYPHS])
+        validate_glyphs(glyphs)
+    font_map[config[CONF_ID]] = font_list
     return config
 
 
+def validate_pillow_installed(value):
+    try:
+        import PIL
+    except ImportError as err:
+        raise cv.Invalid(
+            "Please install the pillow python package to use this feature. "
+            '(pip install "pillow==10.4.0")'
+        ) from err
+
+    if version.parse(PIL.__version__) != version.parse("10.4.0"):
+        raise cv.Invalid(
+            "Please update your pillow installation to 10.4.0. "
+            '(pip install "pillow==10.4.0")'
+        )
+
+    return value
+
+
 FONT_EXTENSIONS = (".ttf", ".woff", ".otf")
 
 
@@ -188,7 +120,7 @@ def validate_truetype_file(value):
         )
     if not any(map(value.lower().endswith, FONT_EXTENSIONS)):
         raise cv.Invalid(f"Only {FONT_EXTENSIONS} files are supported.")
-    return CORE.relative_config_path(cv.file_(value))
+    return cv.file_(value)
 
 
 TYPE_LOCAL = "local"
@@ -207,10 +139,6 @@ LOCAL_BITMAP_SCHEMA = cv.Schema(
     }
 )
 
-FULLPATH_SCHEMA = cv.maybe_simple_value(
-    {cv.Required(CONF_PATH): cv.string}, key=CONF_PATH
-)
-
 CONF_ITALIC = "italic"
 FONT_WEIGHTS = {
     "thin": 100,
@@ -239,13 +167,13 @@ def _compute_local_font_path(value: dict) -> Path:
     return base_dir / key
 
 
-def get_font_path(value, font_type) -> Path:
-    if font_type == TYPE_GFONTS:
+def get_font_path(value, type) -> Path:
+    if type == TYPE_GFONTS:
         name = f"{value[CONF_FAMILY]}@{value[CONF_WEIGHT]}@{value[CONF_ITALIC]}@v1"
         return external_files.compute_local_file_dir(DOMAIN) / f"{name}.ttf"
-    if font_type == TYPE_WEB:
+    if type == TYPE_WEB:
         return _compute_local_font_path(value) / "font.ttf"
-    assert False
+    return None
 
 
 def download_gfont(value):
@@ -275,7 +203,7 @@ def download_gfont(value):
     _LOGGER.debug("download_gfont: ttf_url=%s", ttf_url)
 
     external_files.download_content(ttf_url, path)
-    return FULLPATH_SCHEMA(path)
+    return value
 
 
 def download_web_font(value):
@@ -284,7 +212,7 @@ def download_web_font(value):
 
     external_files.download_content(url, path)
     _LOGGER.debug("download_web_font: path=%s", path)
-    return FULLPATH_SCHEMA(path)
+    return value
 
 
 EXTERNAL_FONT_SCHEMA = cv.Schema(
@@ -297,6 +225,7 @@ EXTERNAL_FONT_SCHEMA = cv.Schema(
     }
 )
 
+
 GFONTS_SCHEMA = cv.All(
     EXTERNAL_FONT_SCHEMA.extend(
         {
@@ -330,10 +259,10 @@ def validate_file_shorthand(value):
         }
         if weight is not None:
             data[CONF_WEIGHT] = weight[1:]
-        return font_file_schema(data)
+        return FILE_SCHEMA(data)
 
     if value.startswith("http://") or value.startswith("https://"):
-        return font_file_schema(
+        return FILE_SCHEMA(
             {
                 CONF_TYPE: TYPE_WEB,
                 CONF_URL: value,
@@ -341,15 +270,14 @@ def validate_file_shorthand(value):
         )
 
     if value.endswith(".pcf") or value.endswith(".bdf"):
-        value = convert_bitmap_to_pillow_font(
-            CORE.relative_config_path(cv.file_(value))
+        return FILE_SCHEMA(
+            {
+                CONF_TYPE: TYPE_LOCAL_BITMAP,
+                CONF_PATH: value,
+            }
         )
-        return {
-            CONF_TYPE: TYPE_LOCAL_BITMAP,
-            CONF_PATH: value,
-        }
 
-    return font_file_schema(
+    return FILE_SCHEMA(
         {
             CONF_TYPE: TYPE_LOCAL,
             CONF_PATH: value,
@@ -367,37 +295,31 @@ TYPED_FILE_SCHEMA = cv.typed_schema(
 )
 
 
-def font_file_schema(value):
+def _file_schema(value):
     if isinstance(value, str):
         return validate_file_shorthand(value)
     return TYPED_FILE_SCHEMA(value)
 
 
-# Default if no glyphs or glyphsets are provided
-DEFAULT_GLYPHSET = "GF_Latin_Kernel"
-# default for bitmap fonts
+FILE_SCHEMA = cv.All(_file_schema)
+
 DEFAULT_GLYPHS = (
     ' !"%()+=,-.:/?0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_abcdefghijklmnopqrstuvwxyz°'
 )
-
 CONF_RAW_GLYPH_ID = "raw_glyph_id"
 
 FONT_SCHEMA = cv.Schema(
     {
         cv.Required(CONF_ID): cv.declare_id(Font),
-        cv.Required(CONF_FILE): font_file_schema,
-        cv.Optional(CONF_GLYPHS, default=[]): cv.ensure_list(cv.string_strict),
-        cv.Optional(CONF_GLYPHSETS, default=[]): cv.ensure_list(
-            cv.one_of(*glyphsets.defined_glyphsets())
-        ),
-        cv.Optional(CONF_IGNORE_MISSING_GLYPHS, default=False): cv.boolean,
+        cv.Required(CONF_FILE): FILE_SCHEMA,
+        cv.Optional(CONF_GLYPHS, default=DEFAULT_GLYPHS): validate_glyphs,
         cv.Optional(CONF_SIZE, default=20): cv.int_range(min=1),
         cv.Optional(CONF_BPP, default=1): cv.one_of(1, 2, 4, 8),
-        cv.Optional(CONF_EXTRAS, default=[]): cv.ensure_list(
+        cv.Optional(CONF_EXTRAS): cv.ensure_list(
             cv.Schema(
                 {
-                    cv.Required(CONF_FILE): font_file_schema,
-                    cv.Required(CONF_GLYPHS): cv.ensure_list(cv.string_strict),
+                    cv.Required(CONF_FILE): FILE_SCHEMA,
+                    cv.Required(CONF_GLYPHS): validate_glyphs,
                 }
             )
         ),
@@ -406,7 +328,7 @@ FONT_SCHEMA = cv.Schema(
     },
 )
 
-CONFIG_SCHEMA = cv.All(FONT_SCHEMA, validate_glyphs)
+CONFIG_SCHEMA = cv.All(validate_pillow_installed, FONT_SCHEMA, merge_glyphs)
 
 
 # PIL doesn't provide a consistent interface for both TrueType and bitmap
@@ -422,7 +344,7 @@ class TrueTypeFontWrapper:
         return offset_x, offset_y
 
     def getmask(self, glyph, **kwargs):
-        return self.font.getmask(str(glyph), **kwargs)
+        return self.font.getmask(glyph, **kwargs)
 
     def getmetrics(self, glyphs):
         return self.font.getmetrics()
@@ -437,7 +359,7 @@ class BitmapFontWrapper:
         return 0, 0
 
     def getmask(self, glyph, **kwargs):
-        return self.font.getmask(str(glyph), **kwargs)
+        return self.font.getmask(glyph, **kwargs)
 
     def getmetrics(self, glyphs):
         max_height = 0
@@ -445,20 +367,28 @@ class BitmapFontWrapper:
             mask = self.getmask(glyph, mode="1")
             _, height = mask.size
             max_height = max(max_height, height)
-        return max_height, 0
+        return (max_height, 0)
 
 
 class EFont:
-    def __init__(self, file, size, codepoints):
-        self.codepoints = codepoints
-        path = file[CONF_PATH]
-        self.name = Path(path).name
+    def __init__(self, file, size, glyphs):
+        self.glyphs = glyphs
         ftype = file[CONF_TYPE]
         if ftype == TYPE_LOCAL_BITMAP:
-            self.font = load_bitmap_font(path)
+            font = load_bitmap_font(CORE.relative_config_path(file[CONF_PATH]))
+        elif ftype == TYPE_LOCAL:
+            path = CORE.relative_config_path(file[CONF_PATH])
+            font = load_ttf_font(path, size)
+        elif ftype in (TYPE_GFONTS, TYPE_WEB):
+            path = get_font_path(file, ftype)
+            font = load_ttf_font(path, size)
         else:
-            self.font = load_ttf_font(path, size)
-        self.ascent, self.descent = self.font.getmetrics(codepoints)
+            raise cv.Invalid(f"Could not load font: unknown type: {ftype}")
+        self.font = font
+        self.ascent, self.descent = font.getmetrics(glyphs)
+
+    def has_glyph(self, glyph):
+        return glyph in self.glyphs
 
 
 def convert_bitmap_to_pillow_font(filepath):
@@ -470,7 +400,6 @@ def convert_bitmap_to_pillow_font(filepath):
 
     copy_file_if_changed(filepath, local_bitmap_font_file)
 
-    local_pil_font_file = local_bitmap_font_file.with_suffix(".pil")
     with open(local_bitmap_font_file, "rb") as fp:
         try:
             try:
@@ -480,22 +409,28 @@ def convert_bitmap_to_pillow_font(filepath):
                 p = BdfFontFile.BdfFontFile(fp)
 
             # Convert to pillow-formatted fonts, which have a .pil and .pbm extension.
-            p.save(local_pil_font_file)
+            p.save(local_bitmap_font_file)
         except (SyntaxError, OSError) as err:
             raise core.EsphomeError(
                 f"Failed to parse as bitmap font: '{filepath}': {err}"
             )
 
-    return str(local_pil_font_file)
+    local_pil_font_file = os.path.splitext(local_bitmap_font_file)[0] + ".pil"
+    return cv.file_(local_pil_font_file)
 
 
 def load_bitmap_font(filepath):
     from PIL import ImageFont
 
+    # Convert bpf and pcf files to pillow fonts, first.
+    pil_font_path = convert_bitmap_to_pillow_font(filepath)
+
     try:
-        font = ImageFont.load(str(filepath))
+        font = ImageFont.load(str(pil_font_path))
     except Exception as e:
-        raise core.EsphomeError(f"Failed to load bitmap font file: {filepath}: {e}")
+        raise core.EsphomeError(
+            f"Failed to load bitmap font file: {pil_font_path} : {e}"
+        )
 
     return BitmapFontWrapper(font)
 
@@ -506,7 +441,7 @@ def load_ttf_font(path, size):
     try:
         font = ImageFont.truetype(str(path), size)
     except Exception as e:
-        raise core.EsphomeError(f"Could not load TrueType file {path}: {e}")
+        raise core.EsphomeError(f"Could not load truetype file {path}: {e}")
 
     return TrueTypeFontWrapper(font)
 
@@ -521,35 +456,14 @@ class GlyphInfo:
 
 
 async def to_code(config):
-    """
-    Collect all glyph codepoints, construct a map from a codepoint to a font file.
-    Codepoints are either explicit (glyphs key in top level or extras) or part of a glyphset.
-    Codepoints listed in extras use the extra font and override codepoints from glyphsets.
-    Achieve this by processing the base codepoints first, then the extras
-    """
-
-    # get the codepoints from glyphsets and flatten to a set of chrs.
-    point_set: set[str] = {
-        chr(x)
-        for x in flatten(
-            [glyphsets.unicodes_per_glyphset(x) for x in config[CONF_GLYPHSETS]]
-        )
-    }
-    # get the codepoints from the glyphs key, flatten to a list of chrs and combine with the points from glyphsets
-    point_set.update(flatten(config[CONF_GLYPHS]))
-    size = config[CONF_SIZE]
-    # Create the codepoint to font file map
-    base_font = EFont(config[CONF_FILE], size, point_set)
-    point_font_map: dict[str, EFont] = {c: base_font for c in point_set}
-    # process extras, updating the map and extending the codepoint list
-    for extra in config[CONF_EXTRAS]:
-        extra_points = flatten(extra[CONF_GLYPHS])
-        point_set.update(extra_points)
-        extra_font = EFont(extra[CONF_FILE], size, extra_points)
-        point_font_map.update({c: extra_font for c in extra_points})
-
-    codepoints = list(point_set)
-    codepoints.sort(key=functools.cmp_to_key(glyph_comparator))
+    glyph_to_font_map = {}
+    font_list = font_map[config[CONF_ID]]
+    glyphs = []
+    for font in font_list:
+        glyphs.extend(font.glyphs)
+        for glyph in font.glyphs:
+            glyph_to_font_map[glyph] = font
+    glyphs.sort(key=functools.cmp_to_key(glyph_comparator))
     glyph_args = {}
     data = []
     bpp = config[CONF_BPP]
@@ -559,11 +473,10 @@ async def to_code(config):
     else:
         mode = "L"
         scale = 256 // (1 << bpp)
-    # create the data array for all glyphs
-    for codepoint in codepoints:
-        font = point_font_map[codepoint]
-        mask = font.font.getmask(codepoint, mode=mode)
-        offset_x, offset_y = font.font.getoffset(codepoint)
+    for glyph in glyphs:
+        font = glyph_to_font_map[glyph].font
+        mask = font.getmask(glyph, mode=mode)
+        offset_x, offset_y = font.getoffset(glyph)
         width, height = mask.size
         glyph_data = [0] * ((height * width * bpp + 7) // 8)
         pos = 0
@@ -574,34 +487,31 @@ async def to_code(config):
                     if pixel & (1 << (bpp - bit_num - 1)):
                         glyph_data[pos // 8] |= 0x80 >> (pos % 8)
                     pos += 1
-        glyph_args[codepoint] = GlyphInfo(len(data), offset_x, offset_y, width, height)
+        glyph_args[glyph] = GlyphInfo(len(data), offset_x, offset_y, width, height)
         data += glyph_data
 
     rhs = [HexInt(x) for x in data]
     prog_arr = cg.progmem_array(config[CONF_RAW_DATA_ID], rhs)
 
-    # Create the glyph table that points to data in the above array.
     glyph_initializer = []
-    for codepoint in codepoints:
+    for glyph in glyphs:
         glyph_initializer.append(
             cg.StructInitializer(
                 GlyphData,
                 (
                     "a_char",
-                    cg.RawExpression(
-                        f"(const uint8_t *){cpp_string_escape(codepoint)}"
-                    ),
+                    cg.RawExpression(f"(const uint8_t *){cpp_string_escape(glyph)}"),
                 ),
                 (
                     "data",
                     cg.RawExpression(
-                        f"{str(prog_arr)} + {str(glyph_args[codepoint].data_len)}"
+                        f"{str(prog_arr)} + {str(glyph_args[glyph].data_len)}"
                     ),
                 ),
-                ("offset_x", glyph_args[codepoint].offset_x),
-                ("offset_y", glyph_args[codepoint].offset_y),
-                ("width", glyph_args[codepoint].width),
-                ("height", glyph_args[codepoint].height),
+                ("offset_x", glyph_args[glyph].offset_x),
+                ("offset_y", glyph_args[glyph].offset_y),
+                ("width", glyph_args[glyph].width),
+                ("height", glyph_args[glyph].height),
             )
         )
 
@@ -611,7 +521,7 @@ async def to_code(config):
         config[CONF_ID],
         glyphs,
         len(glyph_initializer),
-        base_font.ascent,
-        base_font.ascent + base_font.descent,
+        font_list[0].ascent,
+        font_list[0].ascent + font_list[0].descent,
         bpp,
     )

esphome/components/font/font.cpp

@@ -133,11 +133,9 @@ void Font::print(int x_start, int y_start, display::Display *display, Color colo
     auto diff_r = (float) color.r - (float) background.r;
     auto diff_g = (float) color.g - (float) background.g;
     auto diff_b = (float) color.b - (float) background.b;
-    auto diff_w = (float) color.w - (float) background.w;
     auto b_r = (float) background.r;
     auto b_g = (float) background.g;
-    auto b_b = (float) background.b;
-    auto b_w = (float) background.w;
+    auto b_b = (float) background.g;
     for (int glyph_y = y_start + scan_y1; glyph_y != max_y; glyph_y++) {
       for (int glyph_x = x_at + scan_x1; glyph_x != max_x; glyph_x++) {
         uint8_t pixel = 0;
@@ -155,8 +153,8 @@ void Font::print(int x_start, int y_start, display::Display *display, Color colo
           display->draw_pixel_at(glyph_x, glyph_y, color);
         } else if (pixel != 0) {
           auto on = (float) pixel / (float) bpp_max;
-          auto blended = Color((uint8_t) (diff_r * on + b_r), (uint8_t) (diff_g * on + b_g),
-                               (uint8_t) (diff_b * on + b_b), (uint8_t) (diff_w * on + b_w));
+          auto blended =
+              Color((uint8_t) (diff_r * on + b_r), (uint8_t) (diff_g * on + b_g), (uint8_t) (diff_b * on + b_b));
           display->draw_pixel_at(glyph_x, glyph_y, blended);
         }
       }

esphome/components/gp8403/output/__init__.py

@@ -16,7 +16,7 @@ CONFIG_SCHEMA = output.FLOAT_OUTPUT_SCHEMA.extend(
     {
         cv.GenerateID(): cv.declare_id(GP8403Output),
         cv.GenerateID(CONF_GP8403_ID): cv.use_id(GP8403),
-        cv.Required(CONF_CHANNEL): cv.int_range(min=0, max=1),
+        cv.Required(CONF_CHANNEL): cv.one_of(0, 1),
     }
 ).extend(cv.COMPONENT_SCHEMA)
 

esphome/components/graphical_display_menu/__init__.py

@@ -36,8 +36,6 @@ CODEOWNERS = ["@MrMDavidson"]
 
 AUTO_LOAD = ["display_menu_base"]
 
-MULTI_CONF = True
-
 CONFIG_SCHEMA = DISPLAY_MENU_BASE_SCHEMA.extend(
     cv.Schema(
         {

esphome/components/haier/hon_climate.cpp

@@ -35,9 +35,7 @@ void HonClimate::set_beeper_state(bool state) {
   if (state != this->settings_.beeper_state) {
     this->settings_.beeper_state = state;
 #ifdef USE_SWITCH
-    if (this->beeper_switch_ != nullptr) {
-      this->beeper_switch_->publish_state(state);
-    }
+    this->beeper_switch_->publish_state(state);
 #endif
     this->hon_rtc_.save(&this->settings_);
   }
@@ -47,17 +45,10 @@ bool HonClimate::get_beeper_state() const { return this->settings_.beeper_state;
 
 void HonClimate::set_quiet_mode_state(bool state) {
   if (state != this->get_quiet_mode_state()) {
-    if ((this->mode != ClimateMode::CLIMATE_MODE_OFF) && (this->mode != ClimateMode::CLIMATE_MODE_FAN_ONLY)) {
-      this->quiet_mode_state_ = state ? SwitchState::PENDING_ON : SwitchState::PENDING_OFF;
-      this->force_send_control_ = true;
-    } else {
-      this->quiet_mode_state_ = state ? SwitchState::ON : SwitchState::OFF;
-    }
+    this->quiet_mode_state_ = state ? SwitchState::PENDING_ON : SwitchState::PENDING_OFF;
     this->settings_.quiet_mode_state = state;
 #ifdef USE_SWITCH
-    if (this->quiet_mode_switch_ != nullptr) {
-      this->quiet_mode_switch_->publish_state(state);
-    }
+    this->quiet_mode_switch_->publish_state(state);
 #endif
     this->hon_rtc_.save(&this->settings_);
   }
@@ -518,7 +509,7 @@ void HonClimate::initialization() {
   }
   this->current_vertical_swing_ = this->settings_.last_vertiacal_swing;
   this->current_horizontal_swing_ = this->settings_.last_horizontal_swing;
-  this->quiet_mode_state_ = this->settings_.quiet_mode_state ? SwitchState::ON : SwitchState::OFF;
+  this->quiet_mode_state_ = this->settings_.quiet_mode_state ? SwitchState::PENDING_ON : SwitchState::PENDING_OFF;
 }
 
 haier_protocol::HaierMessage HonClimate::get_control_message() {
@@ -941,7 +932,7 @@ haier_protocol::HandlerError HonClimate::process_status_message_(const uint8_t *
       if (this->mode == CLIMATE_MODE_OFF) {
         // AC just turned on from remote need to turn off display
         this->force_send_control_ = true;
-      } else if ((((uint8_t) this->display_status_) & 0b10) == 0) {
+      } else if ((((uint8_t) this->health_mode_) & 0b10) == 0) {
         this->display_status_ = disp_status ? SwitchState::ON : SwitchState::OFF;
       }
     }
@@ -1013,11 +1004,6 @@ haier_protocol::HandlerError HonClimate::process_status_message_(const uint8_t *
       if (new_quiet_mode != this->get_quiet_mode_state()) {
         this->quiet_mode_state_ = new_quiet_mode ? SwitchState::ON : SwitchState::OFF;
         this->settings_.quiet_mode_state = new_quiet_mode;
-#ifdef USE_SWITCH
-        if (this->quiet_mode_switch_ != nullptr) {
-          this->quiet_mode_switch_->publish_state(new_quiet_mode);
-        }
-#endif  // USE_SWITCH
         this->hon_rtc_.save(&this->settings_);
       }
     }
@@ -1083,17 +1069,19 @@ void HonClimate::fill_control_messages_queue_() {
   climate_control = this->current_hvac_settings_;
   // Beeper command
   {
-    this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                          (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                              (uint8_t) hon_protocol::DataParameters::BEEPER_STATUS,
-                                          this->get_beeper_state() ? ZERO_BUF : ONE_BUF, 2);
+    this->control_messages_queue_.push(
+        haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                     (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                         (uint8_t) hon_protocol::DataParameters::BEEPER_STATUS,
+                                     this->get_beeper_state() ? ZERO_BUF : ONE_BUF, 2));
   }
   // Health mode
   {
-    this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                          (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                              (uint8_t) hon_protocol::DataParameters::HEALTH_MODE,
-                                          this->get_health_mode() ? ONE_BUF : ZERO_BUF, 2);
+    this->control_messages_queue_.push(
+        haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                     (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                         (uint8_t) hon_protocol::DataParameters::HEALTH_MODE,
+                                     this->get_health_mode() ? ONE_BUF : ZERO_BUF, 2));
     this->health_mode_ = (SwitchState) ((uint8_t) this->health_mode_ & 0b01);
   }
   // Climate mode
@@ -1111,46 +1099,51 @@ void HonClimate::fill_control_messages_queue_() {
       case CLIMATE_MODE_HEAT_COOL:
         new_power = true;
         buffer[1] = (uint8_t) hon_protocol::ConditioningMode::AUTO;
-        this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                              (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                  (uint8_t) hon_protocol::DataParameters::AC_MODE,
-                                              buffer, 2);
+        this->control_messages_queue_.push(
+            haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                         (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                             (uint8_t) hon_protocol::DataParameters::AC_MODE,
+                                         buffer, 2));
         fan_mode_buf[1] = this->other_modes_fan_speed_;
         break;
       case CLIMATE_MODE_HEAT:
         new_power = true;
         buffer[1] = (uint8_t) hon_protocol::ConditioningMode::HEAT;
-        this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                              (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                  (uint8_t) hon_protocol::DataParameters::AC_MODE,
-                                              buffer, 2);
+        this->control_messages_queue_.push(
+            haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                         (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                             (uint8_t) hon_protocol::DataParameters::AC_MODE,
+                                         buffer, 2));
         fan_mode_buf[1] = this->other_modes_fan_speed_;
         break;
       case CLIMATE_MODE_DRY:
         new_power = true;
         buffer[1] = (uint8_t) hon_protocol::ConditioningMode::DRY;
-        this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                              (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                  (uint8_t) hon_protocol::DataParameters::AC_MODE,
-                                              buffer, 2);
+        this->control_messages_queue_.push(
+            haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                         (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                             (uint8_t) hon_protocol::DataParameters::AC_MODE,
+                                         buffer, 2));
         fan_mode_buf[1] = this->other_modes_fan_speed_;
         break;
       case CLIMATE_MODE_FAN_ONLY:
         new_power = true;
         buffer[1] = (uint8_t) hon_protocol::ConditioningMode::FAN;
-        this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                              (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                  (uint8_t) hon_protocol::DataParameters::AC_MODE,
-                                              buffer, 2);
+        this->control_messages_queue_.push(
+            haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                         (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                             (uint8_t) hon_protocol::DataParameters::AC_MODE,
+                                         buffer, 2));
         fan_mode_buf[1] = this->other_modes_fan_speed_;  // Auto doesn't work in fan only mode
         break;
       case CLIMATE_MODE_COOL:
         new_power = true;
         buffer[1] = (uint8_t) hon_protocol::ConditioningMode::COOL;
-        this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                              (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                  (uint8_t) hon_protocol::DataParameters::AC_MODE,
-                                              buffer, 2);
+        this->control_messages_queue_.push(
+            haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                         (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                             (uint8_t) hon_protocol::DataParameters::AC_MODE,
+                                         buffer, 2));
         fan_mode_buf[1] = this->other_modes_fan_speed_;
         break;
       default:
@@ -1160,10 +1153,11 @@ void HonClimate::fill_control_messages_queue_() {
   }
   // Climate power
   {
-    this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                          (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                              (uint8_t) hon_protocol::DataParameters::AC_POWER,
-                                          new_power ? ONE_BUF : ZERO_BUF, 2);
+    this->control_messages_queue_.push(
+        haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                     (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                         (uint8_t) hon_protocol::DataParameters::AC_POWER,
+                                     new_power ? ONE_BUF : ZERO_BUF, 2));
   }
   // CLimate preset
   {
@@ -1205,32 +1199,36 @@ void HonClimate::fill_control_messages_queue_() {
     }
     auto presets = this->traits_.get_supported_presets();
     if (quiet_mode_buf[1] != 0xFF) {
-      this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                            (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                (uint8_t) hon_protocol::DataParameters::QUIET_MODE,
-                                            quiet_mode_buf, 2);
+      this->control_messages_queue_.push(
+          haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                       (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                           (uint8_t) hon_protocol::DataParameters::QUIET_MODE,
+                                       quiet_mode_buf, 2));
     }
     if ((fast_mode_buf[1] != 0xFF) && ((presets.find(climate::ClimatePreset::CLIMATE_PRESET_BOOST) != presets.end()))) {
-      this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                            (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                (uint8_t) hon_protocol::DataParameters::FAST_MODE,
-                                            fast_mode_buf, 2);
+      this->control_messages_queue_.push(
+          haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                       (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                           (uint8_t) hon_protocol::DataParameters::FAST_MODE,
+                                       fast_mode_buf, 2));
     }
     if ((away_mode_buf[1] != 0xFF) && ((presets.find(climate::ClimatePreset::CLIMATE_PRESET_AWAY) != presets.end()))) {
-      this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                            (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                (uint8_t) hon_protocol::DataParameters::TEN_DEGREE,
-                                            away_mode_buf, 2);
+      this->control_messages_queue_.push(
+          haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                       (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                           (uint8_t) hon_protocol::DataParameters::TEN_DEGREE,
+                                       away_mode_buf, 2));
     }
   }
   // Target temperature
   if (climate_control.target_temperature.has_value() && (this->mode != ClimateMode::CLIMATE_MODE_FAN_ONLY)) {
     uint8_t buffer[2] = {0x00, 0x00};
     buffer[1] = ((uint8_t) climate_control.target_temperature.value()) - 16;
-    this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                          (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                              (uint8_t) hon_protocol::DataParameters::SET_POINT,
-                                          buffer, 2);
+    this->control_messages_queue_.push(
+        haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                     (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                         (uint8_t) hon_protocol::DataParameters::SET_POINT,
+                                     buffer, 2));
   }
   // Vertical swing mode
   if (climate_control.swing_mode.has_value()) {
@@ -1250,14 +1248,16 @@ void HonClimate::fill_control_messages_queue_() {
       case CLIMATE_SWING_BOTH:
         break;
     }
-    this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                          (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                              (uint8_t) hon_protocol::DataParameters::HORIZONTAL_SWING_MODE,
-                                          horizontal_swing_buf, 2);
-    this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                          (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                              (uint8_t) hon_protocol::DataParameters::VERTICAL_SWING_MODE,
-                                          vertical_swing_buf, 2);
+    this->control_messages_queue_.push(
+        haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                     (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                         (uint8_t) hon_protocol::DataParameters::HORIZONTAL_SWING_MODE,
+                                     horizontal_swing_buf, 2));
+    this->control_messages_queue_.push(
+        haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                     (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                         (uint8_t) hon_protocol::DataParameters::VERTICAL_SWING_MODE,
+                                     vertical_swing_buf, 2));
   }
   // Fan mode
   if (climate_control.fan_mode.has_value()) {
@@ -1280,10 +1280,11 @@ void HonClimate::fill_control_messages_queue_() {
         break;
     }
     if (fan_mode_buf[1] != 0xFF) {
-      this->control_messages_queue_.emplace(haier_protocol::FrameType::CONTROL,
-                                            (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
-                                                (uint8_t) hon_protocol::DataParameters::FAN_MODE,
-                                            fan_mode_buf, 2);
+      this->control_messages_queue_.push(
+          haier_protocol::HaierMessage(haier_protocol::FrameType::CONTROL,
+                                       (uint16_t) hon_protocol::SubcommandsControl::SET_SINGLE_PARAMETER +
+                                           (uint8_t) hon_protocol::DataParameters::FAN_MODE,
+                                       fan_mode_buf, 2));
     }
   }
 }

esphome/components/hbridge/switch/__init__.py

@@ -1,44 +0,0 @@
-from esphome import pins
-import esphome.codegen as cg
-from esphome.components import switch
-import esphome.config_validation as cv
-from esphome.const import CONF_OPTIMISTIC, CONF_PULSE_LENGTH, CONF_WAIT_TIME
-
-from .. import hbridge_ns
-
-HBridgeSwitch = hbridge_ns.class_("HBridgeSwitch", switch.Switch, cg.Component)
-
-CODEOWNERS = ["@dwmw2"]
-
-CONF_OFF_PIN = "off_pin"
-CONF_ON_PIN = "on_pin"
-
-CONFIG_SCHEMA = (
-    switch.switch_schema(HBridgeSwitch)
-    .extend(
-        {
-            cv.Required(CONF_ON_PIN): pins.gpio_output_pin_schema,
-            cv.Required(CONF_OFF_PIN): pins.gpio_output_pin_schema,
-            cv.Optional(
-                CONF_PULSE_LENGTH, default="100ms"
-            ): cv.positive_time_period_milliseconds,
-            cv.Optional(CONF_WAIT_TIME): cv.positive_time_period_milliseconds,
-            cv.Optional(CONF_OPTIMISTIC, default=False): cv.boolean,
-        }
-    )
-    .extend(cv.COMPONENT_SCHEMA)
-)
-
-
-async def to_code(config):
-    var = await switch.new_switch(config)
-    await cg.register_component(var, config)
-
-    on_pin = await cg.gpio_pin_expression(config[CONF_ON_PIN])
-    cg.add(var.set_on_pin(on_pin))
-    off_pin = await cg.gpio_pin_expression(config[CONF_OFF_PIN])
-    cg.add(var.set_off_pin(off_pin))
-    cg.add(var.set_pulse_length(config[CONF_PULSE_LENGTH]))
-    cg.add(var.set_optimistic(config[CONF_OPTIMISTIC]))
-    if wait_time := config.get(CONF_WAIT_TIME):
-        cg.add(var.set_wait_time(wait_time))

esphome/components/hbridge/switch/hbridge_switch.cpp

@@ -1,95 +0,0 @@
-#include "hbridge_switch.h"
-#include "esphome/core/log.h"
-
-#include <cinttypes>
-
-namespace esphome {
-namespace hbridge {
-
-static const char *const TAG = "switch.hbridge";
-
-float HBridgeSwitch::get_setup_priority() const { return setup_priority::HARDWARE; }
-void HBridgeSwitch::setup() {
-  ESP_LOGCONFIG(TAG, "Setting up H-Bridge Switch '%s'...", this->name_.c_str());
-
-  optional<bool> initial_state = this->get_initial_state_with_restore_mode().value_or(false);
-
-  // Like GPIOSwitch does, set the pin state both before and after pin setup()
-  this->on_pin_->digital_write(false);
-  this->on_pin_->setup();
-  this->on_pin_->digital_write(false);
-
-  this->off_pin_->digital_write(false);
-  this->off_pin_->setup();
-  this->off_pin_->digital_write(false);
-
-  if (initial_state.has_value())
-    this->write_state(initial_state);
-}
-
-void HBridgeSwitch::dump_config() {
-  LOG_SWITCH("", "H-Bridge Switch", this);
-  LOG_PIN("  On Pin: ", this->on_pin_);
-  LOG_PIN("  Off Pin: ", this->off_pin_);
-  ESP_LOGCONFIG(TAG, "  Pulse length: %" PRId32 " ms", this->pulse_length_);
-  if (this->wait_time_)
-    ESP_LOGCONFIG(TAG, "  Wait time %" PRId32 " ms", this->wait_time_);
-}
-
-void HBridgeSwitch::write_state(bool state) {
-  this->desired_state_ = state;
-  if (!this->timer_running_)
-    this->timer_fn_();
-}
-
-void HBridgeSwitch::timer_fn_() {
-  uint32_t next_timeout = 0;
-
-  while ((uint8_t) this->desired_state_ != this->relay_state_) {
-    switch (this->relay_state_) {
-      case RELAY_STATE_ON:
-      case RELAY_STATE_OFF:
-      case RELAY_STATE_UNKNOWN:
-        if (this->desired_state_) {
-          this->on_pin_->digital_write(true);
-          this->relay_state_ = RELAY_STATE_SWITCHING_ON;
-        } else {
-          this->off_pin_->digital_write(true);
-          this->relay_state_ = RELAY_STATE_SWITCHING_OFF;
-        }
-        next_timeout = this->pulse_length_;
-        if (!this->optimistic_)
-          this->publish_state(this->desired_state_);
-        break;
-
-      case RELAY_STATE_SWITCHING_ON:
-        this->on_pin_->digital_write(false);
-        this->relay_state_ = RELAY_STATE_ON;
-        if (this->optimistic_)
-          this->publish_state(true);
-        next_timeout = this->wait_time_;
-        break;
-
-      case RELAY_STATE_SWITCHING_OFF:
-        this->off_pin_->digital_write(false);
-        this->relay_state_ = RELAY_STATE_OFF;
-        if (this->optimistic_)
-          this->publish_state(false);
-        next_timeout = this->wait_time_;
-        break;
-    }
-
-    if (next_timeout) {
-      this->timer_running_ = true;
-      this->set_timeout(next_timeout, [this]() { this->timer_fn_(); });
-      return;
-    }
-
-    // In the case where ON/OFF state has been reached but we need to
-    // immediately change back again to reach desired_state_, we loop.
-  }
-  this->timer_running_ = false;
-}
-
-}  // namespace hbridge
-}  // namespace esphome

esphome/components/hbridge/switch/hbridge_switch.h

@@ -1,50 +0,0 @@
-#pragma once
-
-#include "esphome/core/component.h"
-#include "esphome/core/hal.h"
-#include "esphome/components/switch/switch.h"
-
-#include <vector>
-
-namespace esphome {
-namespace hbridge {
-
-enum RelayState : uint8_t {
-  RELAY_STATE_OFF = 0,
-  RELAY_STATE_ON = 1,
-  RELAY_STATE_SWITCHING_ON = 2,
-  RELAY_STATE_SWITCHING_OFF = 3,
-  RELAY_STATE_UNKNOWN = 4,
-};
-
-class HBridgeSwitch : public switch_::Switch, public Component {
- public:
-  void set_on_pin(GPIOPin *pin) { this->on_pin_ = pin; }
-  void set_off_pin(GPIOPin *pin) { this->off_pin_ = pin; }
-  void set_pulse_length(uint32_t pulse_length) { this->pulse_length_ = pulse_length; }
-  void set_wait_time(uint32_t wait_time) { this->wait_time_ = wait_time; }
-  void set_optimistic(bool optimistic) { this->optimistic_ = optimistic; }
-
-  // ========== INTERNAL METHODS ==========
-  // (In most use cases you won't need these)
-  float get_setup_priority() const override;
-
-  void setup() override;
-  void dump_config() override;
-
- protected:
-  void write_state(bool state) override;
-  void timer_fn_();
-
-  bool timer_running_{false};
-  bool desired_state_{false};
-  RelayState relay_state_{RELAY_STATE_UNKNOWN};
-  GPIOPin *on_pin_{nullptr};
-  GPIOPin *off_pin_{nullptr};
-  uint32_t pulse_length_{0};
-  uint32_t wait_time_{0};
-  bool optimistic_{false};
-};
-
-}  // namespace hbridge
-}  // namespace esphome

esphome/components/hitachi_ac344/hitachi_ac344.cpp

@@ -133,10 +133,8 @@ bool HitachiClimate::get_swing_v_() {
 }
 
 void HitachiClimate::set_swing_h_(uint8_t position) {
-  if (position > HITACHI_AC344_SWINGH_LEFT_MAX) {
-    set_swing_h_(HITACHI_AC344_SWINGH_MIDDLE);
-    return;
-  }
+  if (position > HITACHI_AC344_SWINGH_LEFT_MAX)
+    return set_swing_h_(HITACHI_AC344_SWINGH_MIDDLE);
   set_bits(&remote_state_[HITACHI_AC344_SWINGH_BYTE], HITACHI_AC344_SWINGH_OFFSET, HITACHI_AC344_SWINGH_SIZE, position);
   set_button_(HITACHI_AC344_BUTTON_SWINGH);
 }

esphome/components/hitachi_ac424/hitachi_ac424.cpp

@@ -133,10 +133,8 @@ bool HitachiClimate::get_swing_v_() {
 }
 
 void HitachiClimate::set_swing_h_(uint8_t position) {
-  if (position > HITACHI_AC424_SWINGH_LEFT_MAX) {
-    set_swing_h_(HITACHI_AC424_SWINGH_MIDDLE);
-    return;
-  }
+  if (position > HITACHI_AC424_SWINGH_LEFT_MAX)
+    return set_swing_h_(HITACHI_AC424_SWINGH_MIDDLE);
   set_bits(&remote_state_[HITACHI_AC424_SWINGH_BYTE], HITACHI_AC424_SWINGH_OFFSET, HITACHI_AC424_SWINGH_SIZE, position);
   set_button_(HITACHI_AC424_BUTTON_SWINGH);
 }

esphome/components/homeassistant/number/homeassistant_number.cpp

@@ -27,7 +27,6 @@ void HomeassistantNumber::min_retrieved_(const std::string &min) {
   auto min_value = parse_number<float>(min);
   if (!min_value.has_value()) {
     ESP_LOGE(TAG, "'%s': Can't convert 'min' value '%s' to number!", this->entity_id_.c_str(), min.c_str());
-    return;
   }
   ESP_LOGD(TAG, "'%s': Min retrieved: %s", get_name().c_str(), min.c_str());
   this->traits.set_min_value(min_value.value());
@@ -37,7 +36,6 @@ void HomeassistantNumber::max_retrieved_(const std::string &max) {
   auto max_value = parse_number<float>(max);
   if (!max_value.has_value()) {
     ESP_LOGE(TAG, "'%s': Can't convert 'max' value '%s' to number!", this->entity_id_.c_str(), max.c_str());
-    return;
   }
   ESP_LOGD(TAG, "'%s': Max retrieved: %s", get_name().c_str(), max.c_str());
   this->traits.set_max_value(max_value.value());
@@ -47,7 +45,6 @@ void HomeassistantNumber::step_retrieved_(const std::string &step) {
   auto step_value = parse_number<float>(step);
   if (!step_value.has_value()) {
     ESP_LOGE(TAG, "'%s': Can't convert 'step' value '%s' to number!", this->entity_id_.c_str(), step.c_str());
-    return;
   }
   ESP_LOGD(TAG, "'%s': Step Retrieved %s", get_name().c_str(), step.c_str());
   this->traits.set_step(step_value.value());

esphome/components/honeywellabp2_i2c/honeywellabp2.cpp

@@ -15,7 +15,7 @@ static const char *const TAG = "honeywellabp2";
 void HONEYWELLABP2Sensor::read_sensor_data() {
   if (this->read(raw_data_, 7) != i2c::ERROR_OK) {
     ESP_LOGE(TAG, "Communication with ABP2 failed!");
-    this->status_set_warning("couldn't read sensor data");
+    this->mark_failed();
     return;
   }
   float press_counts = encode_uint24(raw_data_[1], raw_data_[2], raw_data_[3]);  // calculate digital pressure counts
@@ -25,13 +25,12 @@ void HONEYWELLABP2Sensor::read_sensor_data() {
                           (this->max_pressure_ - this->min_pressure_)) +
                          this->min_pressure_;
   this->last_temperature_ = (temp_counts * 200 / 16777215) - 50;
-  this->status_clear_warning();
 }
 
 void HONEYWELLABP2Sensor::start_measurement() {
   if (this->write(i2c_cmd_, 3) != i2c::ERROR_OK) {
     ESP_LOGE(TAG, "Communication with ABP2 failed!");
-    this->status_set_warning("couldn't start measurement");
+    this->mark_failed();
     return;
   }
   this->measurement_running_ = true;
@@ -40,7 +39,7 @@ void HONEYWELLABP2Sensor::start_measurement() {
 bool HONEYWELLABP2Sensor::is_measurement_ready() {
   if (this->read(raw_data_, 1) != i2c::ERROR_OK) {
     ESP_LOGE(TAG, "Communication with ABP2 failed!");
-    this->status_set_warning("couldn't check measurement");
+    this->mark_failed();
     return false;
   }
   if ((raw_data_[0] & (0x1 << STATUS_BIT_BUSY)) > 0) {
@@ -53,7 +52,7 @@ bool HONEYWELLABP2Sensor::is_measurement_ready() {
 void HONEYWELLABP2Sensor::measurement_timeout() {
   ESP_LOGE(TAG, "Timeout!");
   this->measurement_running_ = false;
-  this->status_set_warning("measurement timed out");
+  this->mark_failed();
 }
 
 float HONEYWELLABP2Sensor::get_pressure() { return this->last_pressure_; }
@@ -80,7 +79,7 @@ void HONEYWELLABP2Sensor::update() {
   ESP_LOGV(TAG, "Update Honeywell ABP2 Sensor");
 
   this->start_measurement();
-  this->set_timeout("meas_timeout", 100, [this] { this->measurement_timeout(); });
+  this->set_timeout("meas_timeout", 50, [this] { this->measurement_timeout(); });
 }
 
 void HONEYWELLABP2Sensor::dump_config() {

esphome/components/host/gpio.py

@@ -1,8 +1,5 @@
 import logging
 
-from esphome import pins
-import esphome.codegen as cg
-import esphome.config_validation as cv
 from esphome.const import (
     CONF_ID,
     CONF_INPUT,
@@ -14,6 +11,9 @@ from esphome.const import (
     CONF_PULLDOWN,
     CONF_PULLUP,
 )
+from esphome import pins
+import esphome.config_validation as cv
+import esphome.codegen as cg
 
 from .const import host_ns
 
@@ -28,10 +28,8 @@ def _translate_pin(value):
             "This variable only supports pin numbers, not full pin schemas "
             "(with inverted and mode)."
         )
-    if isinstance(value, int) and not isinstance(value, bool):
+    if isinstance(value, int):
         return value
-    if not isinstance(value, str):
-        raise cv.Invalid(f"Invalid pin number: {value}")
     try:
         return int(value)
     except ValueError:

esphome/components/http_request/__init__.py

@@ -6,7 +6,6 @@ from esphome.const import (
     CONF_ESP8266_DISABLE_SSL_SUPPORT,
     CONF_ID,
     CONF_METHOD,
-    CONF_ON_ERROR,
     CONF_TIMEOUT,
     CONF_TRIGGER_ID,
     CONF_URL,
@@ -186,13 +185,6 @@ HTTP_REQUEST_ACTION_SCHEMA = cv.Schema(
         cv.Optional(CONF_ON_RESPONSE): automation.validate_automation(
             {cv.GenerateID(CONF_TRIGGER_ID): cv.declare_id(HttpRequestResponseTrigger)}
         ),
-        cv.Optional(CONF_ON_ERROR): automation.validate_automation(
-            {
-                cv.GenerateID(CONF_TRIGGER_ID): cv.declare_id(
-                    automation.Trigger.template()
-                )
-            }
-        ),
         cv.Optional(CONF_MAX_RESPONSE_BUFFER_SIZE, default="1kB"): cv.validate_bytes,
     }
 )
@@ -280,9 +272,5 @@ async def http_request_action_to_code(config, action_id, template_arg, args):
             ],
             conf,
         )
-    for conf in config.get(CONF_ON_ERROR, []):
-        trigger = cg.new_Pvariable(conf[CONF_TRIGGER_ID])
-        cg.add(var.register_error_trigger(trigger))
-        await automation.build_automation(trigger, [], conf)
 
     return var

esphome/components/http_request/http_request.h

@@ -22,63 +22,6 @@ struct Header {
   const char *value;
 };
 
-// Some common HTTP status codes
-enum HttpStatus {
-  HTTP_STATUS_OK = 200,
-  HTTP_STATUS_NO_CONTENT = 204,
-  HTTP_STATUS_PARTIAL_CONTENT = 206,
-
-  /* 3xx - Redirection */
-  HTTP_STATUS_MULTIPLE_CHOICES = 300,
-  HTTP_STATUS_MOVED_PERMANENTLY = 301,
-  HTTP_STATUS_FOUND = 302,
-  HTTP_STATUS_SEE_OTHER = 303,
-  HTTP_STATUS_NOT_MODIFIED = 304,
-  HTTP_STATUS_TEMPORARY_REDIRECT = 307,
-  HTTP_STATUS_PERMANENT_REDIRECT = 308,
-
-  /* 4XX - CLIENT ERROR */
-  HTTP_STATUS_BAD_REQUEST = 400,
-  HTTP_STATUS_UNAUTHORIZED = 401,
-  HTTP_STATUS_FORBIDDEN = 403,
-  HTTP_STATUS_NOT_FOUND = 404,
-  HTTP_STATUS_METHOD_NOT_ALLOWED = 405,
-  HTTP_STATUS_NOT_ACCEPTABLE = 406,
-  HTTP_STATUS_LENGTH_REQUIRED = 411,
-
-  /* 5xx - Server Error */
-  HTTP_STATUS_INTERNAL_ERROR = 500
-};
-
-/**
- * @brief Returns true if the HTTP status code is a redirect.
- *
- * @param status the HTTP status code to check
- * @return true if the status code is a redirect, false otherwise
- */
-inline bool is_redirect(int const status) {
-  switch (status) {
-    case HTTP_STATUS_MOVED_PERMANENTLY:
-    case HTTP_STATUS_FOUND:
-    case HTTP_STATUS_SEE_OTHER:
-    case HTTP_STATUS_TEMPORARY_REDIRECT:
-    case HTTP_STATUS_PERMANENT_REDIRECT:
-      return true;
-    default:
-      return false;
-  }
-}
-
-/**
- * @brief Checks if the given HTTP status code indicates a successful request.
- *
- * A successful request is one where the status code is in the range 200-299
- *
- * @param status the HTTP status code to check
- * @return true if the status code indicates a successful request, false otherwise
- */
-inline bool is_success(int const status) { return status >= HTTP_STATUS_OK && status < HTTP_STATUS_MULTIPLE_CHOICES; }
-
 class HttpRequestComponent;
 
 class HttpContainer : public Parented<HttpRequestComponent> {
@@ -135,8 +78,8 @@ class HttpRequestComponent : public Component {
 
  protected:
   const char *useragent_{nullptr};
-  bool follow_redirects_{};
-  uint16_t redirect_limit_{};
+  bool follow_redirects_;
+  uint16_t redirect_limit_;
   uint16_t timeout_{4500};
   uint32_t watchdog_timeout_{0};
 };
@@ -157,8 +100,6 @@ template<typename... Ts> class HttpRequestSendAction : public Action<Ts...> {
 
   void register_response_trigger(HttpRequestResponseTrigger *trigger) { this->response_triggers_.push_back(trigger); }
 
-  void register_error_trigger(Trigger<> *trigger) { this->error_triggers_.push_back(trigger); }
-
   void set_max_response_buffer_size(size_t max_response_buffer_size) {
     this->max_response_buffer_size_ = max_response_buffer_size;
   }
@@ -188,8 +129,6 @@ template<typename... Ts> class HttpRequestSendAction : public Action<Ts...> {
     auto container = this->parent_->start(this->url_.value(x...), this->method_.value(x...), body, headers);
 
     if (container == nullptr) {
-      for (auto *trigger : this->error_triggers_)
-        trigger->trigger();
       return;
     }
 
@@ -241,8 +180,7 @@ template<typename... Ts> class HttpRequestSendAction : public Action<Ts...> {
   std::map<const char *, TemplatableValue<const char *, Ts...>> headers_{};
   std::map<const char *, TemplatableValue<std::string, Ts...>> json_{};
   std::function<void(Ts..., JsonObject)> json_func_{nullptr};
-  std::vector<HttpRequestResponseTrigger *> response_triggers_{};
-  std::vector<Trigger<> *> error_triggers_{};
+  std::vector<HttpRequestResponseTrigger *> response_triggers_;
 
   size_t max_response_buffer_size_{SIZE_MAX};
 };

esphome/components/http_request/http_request_arduino.cpp

@@ -104,9 +104,7 @@ std::shared_ptr<HttpContainer> HttpRequestArduino::start(std::string url, std::s
   static const size_t HEADER_COUNT = sizeof(header_keys) / sizeof(header_keys[0]);
   container->client_.collectHeaders(header_keys, HEADER_COUNT);
 
-  App.feed_wdt();
   container->status_code = container->client_.sendRequest(method.c_str(), body.c_str());
-  App.feed_wdt();
   if (container->status_code < 0) {
     ESP_LOGW(TAG, "HTTP Request failed; URL: %s; Error: %s", url.c_str(),
              HTTPClient::errorToString(container->status_code).c_str());
@@ -115,10 +113,11 @@ std::shared_ptr<HttpContainer> HttpRequestArduino::start(std::string url, std::s
     return nullptr;
   }
 
-  if (!is_success(container->status_code)) {
+  if (container->status_code < 200 || container->status_code >= 300) {
     ESP_LOGE(TAG, "HTTP Request failed; URL: %s; Code: %d", url.c_str(), container->status_code);
     this->status_momentary_error("failed", 1000);
-    // Still return the container, so it can be used to get the status code and error message
+    container->end();
+    return nullptr;
   }
 
   int content_length = container->client_.getSize();

esphome/components/http_request/http_request_idf.cpp

@@ -6,6 +6,7 @@
 #include "esphome/components/watchdog/watchdog.h"
 
 #include "esphome/core/application.h"
+#include "esphome/core/defines.h"
 #include "esphome/core/log.h"
 
 #if CONFIG_MBEDTLS_CERTIFICATE_BUNDLE
@@ -117,17 +118,20 @@ std::shared_ptr<HttpContainer> HttpRequestIDF::start(std::string url, std::strin
     return nullptr;
   }
 
-  App.feed_wdt();
+  auto is_ok = [](int code) { return code >= HttpStatus_Ok && code < HttpStatus_MultipleChoices; };
+
   container->content_length = esp_http_client_fetch_headers(client);
-  App.feed_wdt();
   container->status_code = esp_http_client_get_status_code(client);
-  App.feed_wdt();
-  if (is_success(container->status_code)) {
+  if (is_ok(container->status_code)) {
     container->duration_ms = millis() - start;
     return container;
   }
 
   if (this->follow_redirects_) {
+    auto is_redirect = [](int code) {
+      return code == HttpStatus_MovedPermanently || code == HttpStatus_Found || code == HttpStatus_SeeOther ||
+             code == HttpStatus_TemporaryRedirect || code == HttpStatus_PermanentRedirect;
+    };
     auto num_redirects = this->redirect_limit_;
     while (is_redirect(container->status_code) && num_redirects > 0) {
       err = esp_http_client_set_redirection(client);
@@ -138,9 +142,9 @@ std::shared_ptr<HttpContainer> HttpRequestIDF::start(std::string url, std::strin
         return nullptr;
       }
 #if ESPHOME_LOG_LEVEL >= ESPHOME_LOG_LEVEL_VERBOSE
-      char redirect_url[256]{};
-      if (esp_http_client_get_url(client, redirect_url, sizeof(redirect_url) - 1) == ESP_OK) {
-        ESP_LOGV(TAG, "redirecting to url: %s", redirect_url);
+      char url[256]{};
+      if (esp_http_client_get_url(client, url, sizeof(url) - 1) == ESP_OK) {
+        ESP_LOGV(TAG, "redirecting to url: %s", url);
       }
 #endif
       err = esp_http_client_open(client, 0);
@@ -151,12 +155,9 @@ std::shared_ptr<HttpContainer> HttpRequestIDF::start(std::string url, std::strin
         return nullptr;
       }
 
-      App.feed_wdt();
       container->content_length = esp_http_client_fetch_headers(client);
-      App.feed_wdt();
       container->status_code = esp_http_client_get_status_code(client);
-      App.feed_wdt();
-      if (is_success(container->status_code)) {
+      if (is_ok(container->status_code)) {
         container->duration_ms = millis() - start;
         return container;
       }
@@ -171,7 +172,8 @@ std::shared_ptr<HttpContainer> HttpRequestIDF::start(std::string url, std::strin
 
   ESP_LOGE(TAG, "HTTP Request failed; URL: %s; Code: %d", url.c_str(), container->status_code);
   this->status_momentary_error("failed", 1000);
-  return container;
+  esp_http_client_cleanup(client);
+  return nullptr;
 }
 
 int HttpContainerIDF::read(uint8_t *buf, size_t max_len) {

esphome/components/http_request/ota/ota_http_request.cpp

@@ -106,7 +106,7 @@ uint8_t OtaHttpRequestComponent::do_ota_() {
 
   auto container = this->parent_->get(url_with_auth);
 
-  if (container == nullptr || container->status_code != HTTP_STATUS_OK) {
+  if (container == nullptr) {
     return OTA_CONNECTION_ERROR;
   }
 

esphome/components/http_request/update/http_request_update.cpp

@@ -31,7 +31,7 @@ void HttpRequestUpdate::setup() {
 void HttpRequestUpdate::update() {
   auto container = this->request_parent_->get(this->source_url_);
 
-  if (container == nullptr || container->status_code != HTTP_STATUS_OK) {
+  if (container == nullptr) {
     std::string msg = str_sprintf("Failed to fetch manifest from %s", this->source_url_.c_str());
     this->status_set_error(msg.c_str());
     return;

esphome/components/hx711/hx711.cpp

@@ -53,7 +53,7 @@ bool HX711Sensor::read_sensor_(uint32_t *result) {
     }
 
     // Cycle clock pin for gain setting
-    for (uint8_t i = 0; i < static_cast<uint8_t>(this->gain_); i++) {
+    for (uint8_t i = 0; i < this->gain_; i++) {
       this->sck_pin_->digital_write(true);
       delayMicroseconds(1);
       this->sck_pin_->digital_write(false);

esphome/components/hx711/hx711.h

@@ -9,7 +9,7 @@
 namespace esphome {
 namespace hx711 {
 
-enum HX711Gain : uint8_t {
+enum HX711Gain {
   HX711_GAIN_128 = 1,
   HX711_GAIN_32 = 2,
   HX711_GAIN_64 = 3,

esphome/components/i2c/i2c_bus_esp_idf.cpp

@@ -17,14 +17,14 @@ void IDFI2CBus::setup() {
   ESP_LOGCONFIG(TAG, "Setting up I2C bus...");
   static i2c_port_t next_port = I2C_NUM_0;
   port_ = next_port;
-#if SOC_I2C_NUM > 1
+#if I2C_NUM_MAX > 1
   next_port = (next_port == I2C_NUM_0) ? I2C_NUM_1 : I2C_NUM_MAX;
 #else
   next_port = I2C_NUM_MAX;
 #endif
 
   if (port_ == I2C_NUM_MAX) {
-    ESP_LOGE(TAG, "Too many I2C buses configured. Max %u supported.", SOC_I2C_NUM);
+    ESP_LOGE(TAG, "Too many I2C buses configured");
     this->mark_failed();
     return;
   }

esphome/components/i2s_audio/__init__.py

@@ -8,7 +8,7 @@ from esphome.components.esp32.const import (
     VARIANT_ESP32S3,
 )
 import esphome.config_validation as cv
-from esphome.const import CONF_BITS_PER_SAMPLE, CONF_CHANNEL, CONF_ID, CONF_SAMPLE_RATE
+from esphome.const import CONF_CHANNEL, CONF_ID, CONF_SAMPLE_RATE
 from esphome.cpp_generator import MockObjClass
 import esphome.final_validate as fv
 
@@ -25,11 +25,13 @@ CONF_I2S_LRCLK_PIN = "i2s_lrclk_pin"
 CONF_I2S_AUDIO = "i2s_audio"
 CONF_I2S_AUDIO_ID = "i2s_audio_id"
 
+CONF_BITS_PER_SAMPLE = "bits_per_sample"
 CONF_I2S_MODE = "i2s_mode"
 CONF_PRIMARY = "primary"
 CONF_SECONDARY = "secondary"
 
 CONF_USE_APLL = "use_apll"
+CONF_BITS_PER_SAMPLE = "bits_per_sample"
 CONF_BITS_PER_CHANNEL = "bits_per_channel"
 CONF_MONO = "mono"
 CONF_LEFT = "left"

esphome/components/i2s_audio/speaker/__init__.py

@@ -24,10 +24,9 @@ I2SAudioSpeaker = i2s_audio_ns.class_(
     "I2SAudioSpeaker", cg.Component, speaker.Speaker, I2SAudioOut
 )
 
-CONF_BUFFER_DURATION = "buffer_duration"
+
 CONF_DAC_TYPE = "dac_type"
 CONF_I2S_COMM_FMT = "i2s_comm_fmt"
-CONF_NEVER = "never"
 
 i2s_dac_mode_t = cg.global_ns.enum("i2s_dac_mode_t")
 INTERNAL_DAC_OPTIONS = {
@@ -74,12 +73,8 @@ BASE_SCHEMA = (
     .extend(
         {
             cv.Optional(
-                CONF_BUFFER_DURATION, default="500ms"
+                CONF_TIMEOUT, default="500ms"
             ): cv.positive_time_period_milliseconds,
-            cv.Optional(CONF_TIMEOUT, default="500ms"): cv.Any(
-                cv.positive_time_period_milliseconds,
-                cv.one_of(CONF_NEVER, lower=True),
-            ),
         }
     )
     .extend(cv.COMPONENT_SCHEMA)
@@ -121,6 +116,4 @@ async def to_code(config):
     else:
         cg.add(var.set_dout_pin(config[CONF_I2S_DOUT_PIN]))
         cg.add(var.set_i2s_comm_fmt(config[CONF_I2S_COMM_FMT]))
-    if config[CONF_TIMEOUT] != CONF_NEVER:
-        cg.add(var.set_timeout(config[CONF_TIMEOUT]))
-    cg.add(var.set_buffer_duration(config[CONF_BUFFER_DURATION]))
+    cg.add(var.set_timeout(config[CONF_TIMEOUT]))

esphome/components/i2s_audio/speaker/i2s_audio_speaker.cpp

@@ -13,35 +13,33 @@
 namespace esphome {
 namespace i2s_audio {
 
-static const uint8_t DMA_BUFFER_DURATION_MS = 15;
+static const size_t DMA_BUFFER_SIZE = 512;
 static const size_t DMA_BUFFERS_COUNT = 4;
-
-static const size_t TASK_DELAY_MS = DMA_BUFFER_DURATION_MS * DMA_BUFFERS_COUNT / 2;
-
+static const size_t FRAMES_IN_ALL_DMA_BUFFERS = DMA_BUFFER_SIZE * DMA_BUFFERS_COUNT;
+static const size_t RING_BUFFER_SAMPLES = 8192;
+static const size_t TASK_DELAY_MS = 10;
 static const size_t TASK_STACK_SIZE = 4096;
 static const ssize_t TASK_PRIORITY = 23;
 
-static const size_t I2S_EVENT_QUEUE_COUNT = DMA_BUFFERS_COUNT + 1;
-
 static const char *const TAG = "i2s_audio.speaker";
 
 enum SpeakerEventGroupBits : uint32_t {
-  COMMAND_START = (1 << 0),            // starts the speaker task
-  COMMAND_STOP = (1 << 1),             // stops the speaker task
-  COMMAND_STOP_GRACEFULLY = (1 << 2),  // Stops the speaker task once all data has been written
+  COMMAND_START = (1 << 0),                           // Starts the main task purpose
+  COMMAND_STOP = (1 << 1),                            // stops the main task
+  COMMAND_STOP_GRACEFULLY = (1 << 2),                 // Stops the task once all data has been written
+  MESSAGE_RING_BUFFER_AVAILABLE_TO_WRITE = (1 << 5),  // Locks the ring buffer when not set
   STATE_STARTING = (1 << 10),
   STATE_RUNNING = (1 << 11),
   STATE_STOPPING = (1 << 12),
   STATE_STOPPED = (1 << 13),
-  ERR_TASK_FAILED_TO_START = (1 << 14),
-  ERR_ESP_INVALID_STATE = (1 << 15),
-  ERR_ESP_NOT_SUPPORTED = (1 << 16),
+  ERR_INVALID_FORMAT = (1 << 14),
+  ERR_TASK_FAILED_TO_START = (1 << 15),
+  ERR_ESP_INVALID_STATE = (1 << 16),
   ERR_ESP_INVALID_ARG = (1 << 17),
   ERR_ESP_INVALID_SIZE = (1 << 18),
   ERR_ESP_NO_MEM = (1 << 19),
   ERR_ESP_FAIL = (1 << 20),
-  ALL_ERR_ESP_BITS = ERR_ESP_INVALID_STATE | ERR_ESP_NOT_SUPPORTED | ERR_ESP_INVALID_ARG | ERR_ESP_INVALID_SIZE |
-                     ERR_ESP_NO_MEM | ERR_ESP_FAIL,
+  ALL_ERR_ESP_BITS = ERR_ESP_INVALID_STATE | ERR_ESP_INVALID_ARG | ERR_ESP_INVALID_SIZE | ERR_ESP_NO_MEM | ERR_ESP_FAIL,
   ALL_BITS = 0x00FFFFFF,  // All valid FreeRTOS event group bits
 };
 
@@ -56,8 +54,6 @@ static esp_err_t err_bit_to_esp_err(uint32_t bit) {
       return ESP_ERR_INVALID_SIZE;
     case SpeakerEventGroupBits::ERR_ESP_NO_MEM:
       return ESP_ERR_NO_MEM;
-    case SpeakerEventGroupBits::ERR_ESP_NOT_SUPPORTED:
-      return ESP_ERR_NOT_SUPPORTED;
     default:
       return ESP_FAIL;
   }
@@ -95,7 +91,9 @@ static const std::vector<int16_t> Q15_VOLUME_SCALING_FACTORS = {
 void I2SAudioSpeaker::setup() {
   ESP_LOGCONFIG(TAG, "Setting up I2S Audio Speaker...");
 
-  this->event_group_ = xEventGroupCreate();
+  if (this->event_group_ == nullptr) {
+    this->event_group_ = xEventGroupCreate();
+  }
 
   if (this->event_group_ == nullptr) {
     ESP_LOGE(TAG, "Failed to create event group");
@@ -138,19 +136,19 @@ void I2SAudioSpeaker::loop() {
     xEventGroupClearBits(this->event_group_, SpeakerEventGroupBits::ERR_TASK_FAILED_TO_START);
   }
 
-  if (event_group_bits & SpeakerEventGroupBits::ALL_ERR_ESP_BITS) {
-    uint32_t error_bits = event_group_bits & SpeakerEventGroupBits::ALL_ERR_ESP_BITS;
-    ESP_LOGW(TAG, "Error writing to I2S: %s", esp_err_to_name(err_bit_to_esp_err(error_bits)));
-    this->status_set_warning();
-  }
-
-  if (event_group_bits & SpeakerEventGroupBits::ERR_ESP_NOT_SUPPORTED) {
+  if (event_group_bits & SpeakerEventGroupBits::ERR_INVALID_FORMAT) {
     this->status_set_error("Failed to adjust I2S bus to match the incoming audio");
     ESP_LOGE(TAG,
              "Incompatible audio format: sample rate = %" PRIu32 ", channels = %" PRIu8 ", bits per sample = %" PRIu8,
              this->audio_stream_info_.sample_rate, this->audio_stream_info_.channels,
              this->audio_stream_info_.bits_per_sample);
   }
+
+  if (event_group_bits & SpeakerEventGroupBits::ALL_ERR_ESP_BITS) {
+    uint32_t error_bits = event_group_bits & SpeakerEventGroupBits::ALL_ERR_ESP_BITS;
+    ESP_LOGW(TAG, "Error writing to I2S: %s", esp_err_to_name(err_bit_to_esp_err(error_bits)));
+    this->status_set_warning();
+  }
 }
 
 void I2SAudioSpeaker::set_volume(float volume) {
@@ -201,17 +199,23 @@ size_t I2SAudioSpeaker::play(const uint8_t *data, size_t length, TickType_t tick
     this->start();
   }
 
-  size_t bytes_written = 0;
-  if ((this->state_ == speaker::STATE_RUNNING) && (this->audio_ring_buffer_.use_count() == 1)) {
-    // Only one owner of the ring buffer (the speaker task), so the ring buffer is allocated and no other components are
-    // attempting to write to it.
+  // Wait for the ring buffer to be available
+  uint32_t event_bits =
+      xEventGroupWaitBits(this->event_group_, SpeakerEventGroupBits::MESSAGE_RING_BUFFER_AVAILABLE_TO_WRITE, pdFALSE,
+                          pdFALSE, pdMS_TO_TICKS(TASK_DELAY_MS));
 
-    // Temporarily share ownership of the ring buffer so it won't be deallocated while writing
-    std::shared_ptr<RingBuffer> temp_ring_buffer = this->audio_ring_buffer_;
-    bytes_written = temp_ring_buffer->write_without_replacement((void *) data, length, ticks_to_wait);
+  if (event_bits & SpeakerEventGroupBits::MESSAGE_RING_BUFFER_AVAILABLE_TO_WRITE) {
+    // Ring buffer is available to write
+
+    // Lock the ring buffer, write to it, then unlock it
+    xEventGroupClearBits(this->event_group_, SpeakerEventGroupBits::MESSAGE_RING_BUFFER_AVAILABLE_TO_WRITE);
+    size_t bytes_written = this->audio_ring_buffer_->write_without_replacement((void *) data, length, ticks_to_wait);
+    xEventGroupSetBits(this->event_group_, SpeakerEventGroupBits::MESSAGE_RING_BUFFER_AVAILABLE_TO_WRITE);
+
+    return bytes_written;
   }
 
-  return bytes_written;
+  return 0;
 }
 
 bool I2SAudioSpeaker::has_buffered_data() const {
@@ -239,31 +243,35 @@ void I2SAudioSpeaker::speaker_task(void *params) {
   xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::STATE_STARTING);
 
   audio::AudioStreamInfo audio_stream_info = this_speaker->audio_stream_info_;
+  const ssize_t bytes_per_sample = audio_stream_info.get_bytes_per_sample();
+  const uint8_t number_of_channels = audio_stream_info.channels;
 
-  const uint32_t bytes_per_ms =
-      audio_stream_info.channels * audio_stream_info.get_bytes_per_sample() * audio_stream_info.sample_rate / 1000;
+  const size_t dma_buffers_size = FRAMES_IN_ALL_DMA_BUFFERS * bytes_per_sample * number_of_channels;
 
-  const size_t dma_buffers_size = DMA_BUFFERS_COUNT * DMA_BUFFER_DURATION_MS * bytes_per_ms;
-
-  // Ensure ring buffer is at least as large as the total size of the DMA buffers
-  const size_t ring_buffer_size =
-      std::max((uint32_t) dma_buffers_size, this_speaker->buffer_duration_ms_ * bytes_per_ms);
-
-  if (this_speaker->send_esp_err_to_event_group_(this_speaker->allocate_buffers_(dma_buffers_size, ring_buffer_size))) {
+  if (this_speaker->send_esp_err_to_event_group_(
+          this_speaker->allocate_buffers_(dma_buffers_size, RING_BUFFER_SAMPLES * bytes_per_sample))) {
     // Failed to allocate buffers
     xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::ERR_ESP_NO_MEM);
     this_speaker->delete_task_(dma_buffers_size);
   }
 
-  if (!this_speaker->send_esp_err_to_event_group_(this_speaker->start_i2s_driver_(audio_stream_info))) {
+  if (this_speaker->send_esp_err_to_event_group_(this_speaker->start_i2s_driver_())) {
+    // Failed to start I2S driver
+    this_speaker->delete_task_(dma_buffers_size);
+  } else {
+    // Ring buffer is allocated, so indicate its can be written to
+    xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::MESSAGE_RING_BUFFER_AVAILABLE_TO_WRITE);
+  }
+
+  if (!this_speaker->send_esp_err_to_event_group_(this_speaker->reconfigure_i2s_stream_info_(audio_stream_info))) {
+    // Successfully set the I2S stream info, ready to write audio data to the I2S port
+
     xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::STATE_RUNNING);
 
     bool stop_gracefully = false;
     uint32_t last_data_received_time = millis();
-    bool tx_dma_underflow = false;
 
-    while (!this_speaker->timeout_.has_value() ||
-           (millis() - last_data_received_time) <= this_speaker->timeout_.value()) {
+    while ((millis() - last_data_received_time) <= this_speaker->timeout_) {
       event_group_bits = xEventGroupGetBits(this_speaker->event_group_);
 
       if (event_group_bits & SpeakerEventGroupBits::COMMAND_STOP) {
@@ -273,24 +281,12 @@ void I2SAudioSpeaker::speaker_task(void *params) {
         stop_gracefully = true;
       }
 
-      if (this_speaker->audio_stream_info_ != audio_stream_info) {
-        // Audio stream info has changed, stop the speaker task so it will restart with the proper settings.
-
-        break;
-      }
-
-      i2s_event_t i2s_event;
-      while (xQueueReceive(this_speaker->i2s_event_queue_, &i2s_event, 0)) {
-        if (i2s_event.type == I2S_EVENT_TX_Q_OVF) {
-          tx_dma_underflow = true;
-        }
-      }
-
       size_t bytes_to_read = dma_buffers_size;
       size_t bytes_read = this_speaker->audio_ring_buffer_->read((void *) this_speaker->data_buffer_, bytes_to_read,
                                                                  pdMS_TO_TICKS(TASK_DELAY_MS));
 
       if (bytes_read > 0) {
+        last_data_received_time = millis();
         size_t bytes_written = 0;
 
         if ((audio_stream_info.bits_per_sample == 16) && (this_speaker->q15_volume_factor_ < INT16_MAX)) {
@@ -311,28 +307,34 @@ void I2SAudioSpeaker::speaker_task(void *params) {
         if (bytes_written != bytes_read) {
           xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::ERR_ESP_INVALID_SIZE);
         }
-        tx_dma_underflow = false;
-        last_data_received_time = millis();
+
       } else {
         // No data received
-        if (stop_gracefully && tx_dma_underflow) {
+
+        if (stop_gracefully) {
           break;
         }
+
+        i2s_zero_dma_buffer(this_speaker->parent_->get_port());
       }
     }
-
-    xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::STATE_STOPPING);
-
-    i2s_driver_uninstall(this_speaker->parent_->get_port());
-
-    this_speaker->parent_->unlock();
+  } else {
+    // Couldn't configure the I2S port to be compatible with the incoming audio
+    xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::ERR_INVALID_FORMAT);
   }
+  i2s_zero_dma_buffer(this_speaker->parent_->get_port());
 
+  xEventGroupSetBits(this_speaker->event_group_, SpeakerEventGroupBits::STATE_STOPPING);
+
+  i2s_stop(this_speaker->parent_->get_port());
+  i2s_driver_uninstall(this_speaker->parent_->get_port());
+
+  this_speaker->parent_->unlock();
   this_speaker->delete_task_(dma_buffers_size);
 }
 
 void I2SAudioSpeaker::start() {
-  if (!this->is_ready() || this->is_failed() || this->status_has_error())
+  if (this->is_failed() || this->status_has_error())
     return;
   if ((this->state_ == speaker::STATE_STARTING) || (this->state_ == speaker::STATE_RUNNING))
     return;
@@ -383,9 +385,6 @@ bool I2SAudioSpeaker::send_esp_err_to_event_group_(esp_err_t err) {
     case ESP_ERR_NO_MEM:
       xEventGroupSetBits(this->event_group_, SpeakerEventGroupBits::ERR_ESP_NO_MEM);
       return true;
-    case ESP_ERR_NOT_SUPPORTED:
-      xEventGroupSetBits(this->event_group_, SpeakerEventGroupBits::ERR_ESP_NOT_SUPPORTED);
-      return true;
     default:
       xEventGroupSetBits(this->event_group_, SpeakerEventGroupBits::ERR_ESP_FAIL);
       return true;
@@ -403,8 +402,8 @@ esp_err_t I2SAudioSpeaker::allocate_buffers_(size_t data_buffer_size, size_t rin
     return ESP_ERR_NO_MEM;
   }
 
-  if (this->audio_ring_buffer_.use_count() == 0) {
-    // Allocate ring buffer. Uses a shared_ptr to ensure it isn't improperly deallocated.
+  if (this->audio_ring_buffer_ == nullptr) {
+    // Allocate ring buffer
     this->audio_ring_buffer_ = RingBuffer::create(ring_buffer_size);
   }
 
@@ -415,44 +414,20 @@ esp_err_t I2SAudioSpeaker::allocate_buffers_(size_t data_buffer_size, size_t rin
   return ESP_OK;
 }
 
-esp_err_t I2SAudioSpeaker::start_i2s_driver_(audio::AudioStreamInfo &audio_stream_info) {
-  if ((this->i2s_mode_ & I2S_MODE_SLAVE) && (this->sample_rate_ != audio_stream_info.sample_rate)) {  // NOLINT
-    //  Can't reconfigure I2S bus, so the sample rate must match the configured value
-    return ESP_ERR_NOT_SUPPORTED;
-  }
-
-  if ((i2s_bits_per_sample_t) audio_stream_info.bits_per_sample > this->bits_per_sample_) {
-    // Currently can't handle the case when the incoming audio has more bits per sample than the configured value
-    return ESP_ERR_NOT_SUPPORTED;
-  }
-
+esp_err_t I2SAudioSpeaker::start_i2s_driver_() {
   if (!this->parent_->try_lock()) {
     return ESP_ERR_INVALID_STATE;
   }
 
-  i2s_channel_fmt_t channel = this->channel_;
-
-  if (audio_stream_info.channels == 1) {
-    if (this->channel_ == I2S_CHANNEL_FMT_ONLY_LEFT) {
-      channel = I2S_CHANNEL_FMT_ONLY_LEFT;
-    } else {
-      channel = I2S_CHANNEL_FMT_ONLY_RIGHT;
-    }
-  } else if (audio_stream_info.channels == 2) {
-    channel = I2S_CHANNEL_FMT_RIGHT_LEFT;
-  }
-
-  int dma_buffer_length = DMA_BUFFER_DURATION_MS * this->sample_rate_ / 1000;
-
   i2s_driver_config_t config = {
     .mode = (i2s_mode_t) (this->i2s_mode_ | I2S_MODE_TX),
-    .sample_rate = audio_stream_info.sample_rate,
+    .sample_rate = this->sample_rate_,
     .bits_per_sample = this->bits_per_sample_,
-    .channel_format = channel,
+    .channel_format = this->channel_,
     .communication_format = this->i2s_comm_fmt_,
     .intr_alloc_flags = ESP_INTR_FLAG_LEVEL1,
     .dma_buf_count = DMA_BUFFERS_COUNT,
-    .dma_buf_len = dma_buffer_length,
+    .dma_buf_len = DMA_BUFFER_SIZE,
     .use_apll = this->use_apll_,
     .tx_desc_auto_clear = true,
     .fixed_mclk = I2S_PIN_NO_CHANGE,
@@ -473,8 +448,7 @@ esp_err_t I2SAudioSpeaker::start_i2s_driver_(audio::AudioStreamInfo &audio_strea
   }
 #endif
 
-  esp_err_t err =
-      i2s_driver_install(this->parent_->get_port(), &config, I2S_EVENT_QUEUE_COUNT, &this->i2s_event_queue_);
+  esp_err_t err = i2s_driver_install(this->parent_->get_port(), &config, 0, nullptr);
   if (err != ESP_OK) {
     // Failed to install the driver, so unlock the I2S port
     this->parent_->unlock();
@@ -503,8 +477,41 @@ esp_err_t I2SAudioSpeaker::start_i2s_driver_(audio::AudioStreamInfo &audio_strea
   return err;
 }
 
+esp_err_t I2SAudioSpeaker::reconfigure_i2s_stream_info_(audio::AudioStreamInfo &audio_stream_info) {
+  if (this->i2s_mode_ & I2S_MODE_MASTER) {
+    // ESP controls for the the I2S bus, so adjust the sample rate and bits per sample to match the incoming audio
+    this->sample_rate_ = audio_stream_info.sample_rate;
+    this->bits_per_sample_ = (i2s_bits_per_sample_t) audio_stream_info.bits_per_sample;
+  } else if (this->sample_rate_ != audio_stream_info.sample_rate) {
+    // Can't reconfigure I2S bus, so the sample rate must match the configured value
+    return ESP_ERR_INVALID_ARG;
+  }
+
+  if ((i2s_bits_per_sample_t) audio_stream_info.bits_per_sample > this->bits_per_sample_) {
+    // Currently can't handle the case when the incoming audio has more bits per sample than the configured value
+    return ESP_ERR_INVALID_ARG;
+  }
+
+  if (audio_stream_info.channels == 1) {
+    return i2s_set_clk(this->parent_->get_port(), this->sample_rate_, this->bits_per_sample_, I2S_CHANNEL_MONO);
+  } else if (audio_stream_info.channels == 2) {
+    return i2s_set_clk(this->parent_->get_port(), this->sample_rate_, this->bits_per_sample_, I2S_CHANNEL_STEREO);
+  }
+
+  return ESP_ERR_INVALID_ARG;
+}
+
 void I2SAudioSpeaker::delete_task_(size_t buffer_size) {
-  this->audio_ring_buffer_.reset();  // Releases onwership of the shared_ptr
+  if (this->audio_ring_buffer_ != nullptr) {
+    xEventGroupWaitBits(this->event_group_,
+                        MESSAGE_RING_BUFFER_AVAILABLE_TO_WRITE,  // Bit message to read
+                        pdFALSE,                                 // Don't clear the bits on exit
+                        pdTRUE,                                  // Don't wait for all the bits,
+                        portMAX_DELAY);                          // Block indefinitely until a command bit is set
+
+    this->audio_ring_buffer_.reset();  // Deallocates the ring buffer stored in the unique_ptr
+    this->audio_ring_buffer_ = nullptr;
+  }
 
   if (this->data_buffer_ != nullptr) {
     ExternalRAMAllocator<uint8_t> allocator(ExternalRAMAllocator<uint8_t>::ALLOW_FAILURE);

esphome/components/i2s_audio/speaker/i2s_audio_speaker.h

@@ -7,7 +7,6 @@
 #include <driver/i2s.h>
 
 #include <freertos/event_groups.h>
-#include <freertos/queue.h>
 #include <freertos/FreeRTOS.h>
 
 #include "esphome/components/audio/audio.h"
@@ -23,12 +22,11 @@ namespace i2s_audio {
 
 class I2SAudioSpeaker : public I2SAudioOut, public speaker::Speaker, public Component {
  public:
-  float get_setup_priority() const override { return esphome::setup_priority::PROCESSOR; }
+  float get_setup_priority() const override { return esphome::setup_priority::LATE; }
 
   void setup() override;
   void loop() override;
 
-  void set_buffer_duration(uint32_t buffer_duration_ms) { this->buffer_duration_ms_ = buffer_duration_ms; }
   void set_timeout(uint32_t ms) { this->timeout_ = ms; }
   void set_dout_pin(uint8_t pin) { this->dout_pin_ = pin; }
 #if SOC_I2S_SUPPORTS_DAC
@@ -91,15 +89,24 @@ class I2SAudioSpeaker : public I2SAudioOut, public speaker::Speaker, public Comp
   esp_err_t allocate_buffers_(size_t data_buffer_size, size_t ring_buffer_size);
 
   /// @brief Starts the ESP32 I2S driver.
-  /// Attempts to lock the I2S port, starts the I2S driver using the passed in stream information, and sets the data out
-  /// pin. If it fails, it will unlock the I2S port and uninstall the driver, if necessary.
-  /// @param audio_stream_info Stream information for the I2S driver.
-  /// @return ESP_ERR_NOT_ALLOWED if the I2S port can't play the incoming audio stream.
-  ///         ESP_ERR_INVALID_STATE if the I2S port is already locked.
-  ///         ESP_ERR_INVALID_ARG if nstalling the driver or setting the data outpin fails due to a parameter error.
+  /// Attempts to lock the I2S port, starts the I2S driver, and sets the data out pin. If it fails, it will unlock
+  /// the I2S port and uninstall the driver, if necessary.
+  /// @return ESP_ERR_INVALID_STATE if the I2S port is already locked.
+  ///         ESP_ERR_INVALID_ARG if installing the driver or setting the data out pin fails due to a parameter error.
   ///         ESP_ERR_NO_MEM if the driver fails to install due to a memory allocation error.
-  ///         ESP_FAIL if setting the data out pin fails due to an IO error ESP_OK if successful
-  esp_err_t start_i2s_driver_(audio::AudioStreamInfo &audio_stream_info);
+  ///         ESP_FAIL if setting the data out pin fails due to an IO error
+  ///         ESP_OK if successful
+  esp_err_t start_i2s_driver_();
+
+  /// @brief Adjusts the I2S driver configuration to match the incoming audio stream.
+  /// Modifies I2S driver's sample rate, bits per sample, and number of channel settings. If the I2S is in secondary
+  /// mode, it only modifies the number of channels.
+  /// @param audio_stream_info  Describes the incoming audio stream
+  /// @return ESP_ERR_INVALID_ARG if there is a parameter error, if there is more than 2 channels in the stream, or if
+  ///           the audio settings are incompatible with the configuration.
+  ///         ESP_ERR_NO_MEM if the driver fails to reconfigure due to a memory allocation error.
+  ///         ESP_OK if successful.
+  esp_err_t reconfigure_i2s_stream_info_(audio::AudioStreamInfo &audio_stream_info);
 
   /// @brief Deletes the speaker's task.
   /// Deallocates the data_buffer_ and audio_ring_buffer_, if necessary, and deletes the task. Should only be called by
@@ -110,14 +117,10 @@ class I2SAudioSpeaker : public I2SAudioOut, public speaker::Speaker, public Comp
   TaskHandle_t speaker_task_handle_{nullptr};
   EventGroupHandle_t event_group_{nullptr};
 
-  QueueHandle_t i2s_event_queue_;
-
   uint8_t *data_buffer_;
-  std::shared_ptr<RingBuffer> audio_ring_buffer_;
+  std::unique_ptr<RingBuffer> audio_ring_buffer_;
 
-  uint32_t buffer_duration_ms_;
-
-  optional<uint32_t> timeout_;
+  uint32_t timeout_;
   uint8_t dout_pin_;
 
   bool task_created_{false};

esphome/components/ili9xxx/display.py

@@ -1,6 +1,6 @@
 from esphome import core, pins
 import esphome.codegen as cg
-from esphome.components import display, spi
+from esphome.components import display, font, spi
 from esphome.components.display import validate_rotation
 import esphome.config_validation as cv
 from esphome.const import (
@@ -147,6 +147,7 @@ def _validate(config):
 
 
 CONFIG_SCHEMA = cv.All(
+    font.validate_pillow_installed,
     display.FULL_DISPLAY_SCHEMA.extend(
         {
             cv.GenerateID(): cv.declare_id(ILI9XXXDisplay),
@@ -195,10 +196,6 @@ CONFIG_SCHEMA = cv.All(
     _validate,
 )
 
-FINAL_VALIDATE_SCHEMA = spi.final_validate_device_schema(
-    "ili9xxx", require_miso=False, require_mosi=True
-)
-
 
 async def to_code(config):
     rhs = MODELS[config[CONF_MODEL]].new()

esphome/components/ili9xxx/ili9xxx_display.cpp

@@ -313,9 +313,8 @@ void ILI9XXXDisplay::draw_pixels_at(int x_start, int y_start, int w, int h, cons
   // do color conversion pixel-by-pixel into the buffer and draw it later. If this is happening the user has not
   // configured the renderer well.
   if (this->rotation_ != display::DISPLAY_ROTATION_0_DEGREES || bitness != display::COLOR_BITNESS_565 || !big_endian) {
-    display::Display::draw_pixels_at(x_start, y_start, w, h, ptr, order, bitness, big_endian, x_offset, y_offset,
-                                     x_pad);
-    return;
+    return display::Display::draw_pixels_at(x_start, y_start, w, h, ptr, order, bitness, big_endian, x_offset, y_offset,
+                                            x_pad);
   }
   this->set_addr_window_(x_start, y_start, x_start + w - 1, y_start + h - 1);
   // x_ and y_offset are offsets into the source buffer, unrelated to our own offsets into the display.

esphome/components/image/__init__.py

@@ -10,6 +10,7 @@ import puremagic
 
 from esphome import core, external_files
 import esphome.codegen as cg
+from esphome.components import font
 import esphome.config_validation as cv
 from esphome.const import (
     CONF_DITHER,
@@ -232,7 +233,7 @@ IMAGE_SCHEMA = cv.Schema(
     )
 )
 
-CONFIG_SCHEMA = IMAGE_SCHEMA
+CONFIG_SCHEMA = cv.All(font.validate_pillow_installed, IMAGE_SCHEMA)
 
 
 def load_svg_image(file: bytes, resize: tuple[int, int]):

esphome/components/internal_temperature/internal_temperature.cpp

@@ -8,13 +8,8 @@ extern "C" {
 uint8_t temprature_sens_read();
 }
 #elif defined(USE_ESP32_VARIANT_ESP32C3) || defined(USE_ESP32_VARIANT_ESP32C6) || \
-    defined(USE_ESP32_VARIANT_ESP32S2) || defined(USE_ESP32_VARIANT_ESP32S3) || defined(USE_ESP32_VARIANT_ESP32H2) || \
-    defined(USE_ESP32_VARIANT_ESP32C2)
-#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
+    defined(USE_ESP32_VARIANT_ESP32S2) || defined(USE_ESP32_VARIANT_ESP32S3)
 #include "driver/temp_sensor.h"
-#else
-#include "driver/temperature_sensor.h"
-#endif  // ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
 #endif  // USE_ESP32_VARIANT
 #endif  // USE_ESP32
 #ifdef USE_RP2040
@@ -30,13 +25,6 @@ namespace esphome {
 namespace internal_temperature {
 
 static const char *const TAG = "internal_temperature";
-#ifdef USE_ESP32
-#if (ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0)) && \
-    (defined(USE_ESP32_VARIANT_ESP32C3) || defined(USE_ESP32_VARIANT_ESP32C6) || defined(USE_ESP32_VARIANT_ESP32S2) || \
-     defined(USE_ESP32_VARIANT_ESP32S3) || defined(USE_ESP32_VARIANT_ESP32H2) || defined(USE_ESP32_VARIANT_ESP32C2))
-static temperature_sensor_handle_t tsensNew = NULL;
-#endif  // ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0) && USE_ESP32_VARIANT
-#endif  // USE_ESP32
 
 void InternalTemperatureSensor::update() {
   float temperature = NAN;
@@ -48,9 +36,7 @@ void InternalTemperatureSensor::update() {
   temperature = (raw - 32) / 1.8f;
   success = (raw != 128);
 #elif defined(USE_ESP32_VARIANT_ESP32C3) || defined(USE_ESP32_VARIANT_ESP32C6) || \
-    defined(USE_ESP32_VARIANT_ESP32S2) || defined(USE_ESP32_VARIANT_ESP32S3) || defined(USE_ESP32_VARIANT_ESP32H2) || \
-    defined(USE_ESP32_VARIANT_ESP32C2)
-#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
+    defined(USE_ESP32_VARIANT_ESP32S2) || defined(USE_ESP32_VARIANT_ESP32S3)
   temp_sensor_config_t tsens = TSENS_CONFIG_DEFAULT();
   temp_sensor_set_config(tsens);
   temp_sensor_start();
@@ -61,13 +47,6 @@ void InternalTemperatureSensor::update() {
   esp_err_t result = temp_sensor_read_celsius(&temperature);
   temp_sensor_stop();
   success = (result == ESP_OK);
-#else
-  esp_err_t result = temperature_sensor_get_celsius(tsensNew, &temperature);
-  success = (result == ESP_OK);
-  if (!success) {
-    ESP_LOGE(TAG, "Failed to get temperature: %d", result);
-  }
-#endif  // ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
 #endif  // USE_ESP32_VARIANT
 #endif  // USE_ESP32
 #ifdef USE_RP2040
@@ -96,32 +75,6 @@ void InternalTemperatureSensor::update() {
   }
 }
 
-void InternalTemperatureSensor::setup() {
-#ifdef USE_ESP32
-#if (ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0)) && \
-    (defined(USE_ESP32_VARIANT_ESP32C3) || defined(USE_ESP32_VARIANT_ESP32C6) || defined(USE_ESP32_VARIANT_ESP32S2) || \
-     defined(USE_ESP32_VARIANT_ESP32S3) || defined(USE_ESP32_VARIANT_ESP32H2) || defined(USE_ESP32_VARIANT_ESP32C2))
-  ESP_LOGCONFIG(TAG, "Setting up temperature sensor...");
-
-  temperature_sensor_config_t tsens_config = TEMPERATURE_SENSOR_CONFIG_DEFAULT(-10, 80);
-
-  esp_err_t result = temperature_sensor_install(&tsens_config, &tsensNew);
-  if (result != ESP_OK) {
-    ESP_LOGE(TAG, "Failed to install temperature sensor: %d", result);
-    this->mark_failed();
-    return;
-  }
-
-  result = temperature_sensor_enable(tsensNew);
-  if (result != ESP_OK) {
-    ESP_LOGE(TAG, "Failed to enable temperature sensor: %d", result);
-    this->mark_failed();
-    return;
-  }
-#endif  // ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0) && USE_ESP32_VARIANT
-#endif  // USE_ESP32
-}
-
 void InternalTemperatureSensor::dump_config() { LOG_SENSOR("", "Internal Temperature Sensor", this); }
 
 }  // namespace internal_temperature

esphome/components/internal_temperature/internal_temperature.h

@@ -8,7 +8,6 @@ namespace internal_temperature {
 
 class InternalTemperatureSensor : public sensor::Sensor, public PollingComponent {
  public:
-  void setup() override;
   void dump_config() override;
 
   void update() override;

esphome/components/ld2420/ld2420.cpp

@@ -180,7 +180,7 @@ void LD2420Component::apply_config_action() {
 }
 
 void LD2420Component::factory_reset_action() {
-  ESP_LOGCONFIG(TAG, "Setting factory defaults...");
+  ESP_LOGCONFIG(TAG, "Setiing factory defaults...");
   if (this->set_config_mode(true) == LD2420_ERROR_TIMEOUT) {
     ESP_LOGE(TAG, "LD2420 module has failed to respond, check baud rate and serial connections.");
     this->mark_failed();

esphome/components/libretiny/core.cpp

@@ -6,9 +6,6 @@
 #include "esphome/core/helpers.h"
 #include "preferences.h"
 
-void setup();
-void loop();
-
 namespace esphome {
 
 void IRAM_ATTR HOT yield() { ::yield(); }
@@ -27,7 +24,7 @@ void arch_init() {
 
 void arch_restart() {
   lt_reboot();
-  while (1) {
+  while (true) {
   }
 }
 void IRAM_ATTR HOT arch_feed_wdt() { lt_wdt_feed(); }

esphome/components/libretiny/gpio.py

@@ -1,8 +1,8 @@
 import logging
 
-from esphome import pins
 import esphome.codegen as cg
 import esphome.config_validation as cv
+from esphome import pins
 from esphome.const import (
     CONF_ANALOG,
     CONF_ID,
@@ -103,10 +103,8 @@ def _translate_pin(value):
             "This variable only supports pin numbers, not full pin schemas "
             "(with inverted and mode)."
         )
-    if isinstance(value, int) and not isinstance(value, bool):
+    if isinstance(value, int):
         return value
-    if not isinstance(value, str):
-        raise cv.Invalid(f"Invalid pin number: {value}")
     try:
         return int(value)
     except ValueError:

esphome/components/libretiny/lt_component.cpp

@@ -11,12 +11,12 @@ static const char *const TAG = "lt.component";
 
 void LTComponent::dump_config() {
   ESP_LOGCONFIG(TAG, "LibreTiny:");
-  ESP_LOGCONFIG(TAG, "  Version: %s", LT_BANNER_STR + 10);
+  ESP_LOGCONFIG(TAG, "  Version: %s", &LT_BANNER_STR[10]);
   ESP_LOGCONFIG(TAG, "  Loglevel: %u", LT_LOGLEVEL);
 
 #ifdef USE_TEXT_SENSOR
   if (this->version_ != nullptr) {
-    this->version_->publish_state(LT_BANNER_STR + 10);
+    this->version_->publish_state(&LT_BANNER_STR[10]);
   }
 #endif  // USE_TEXT_SENSOR
 }