sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-28 13:43:54 +00:00
Code Issues Releases Wiki Activity

[esp32_ble_server] Use early returns in is_created() and is_failed() methods

Browse Source
This commit is contained in:
J. Nick Koston
2025-10-06 11:55:04 -05:00
parent a7f556c25f
commit c3ac3736cf
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
esphome/components/esp32_ble_server/ble_characteristic.cpp
View File

@@ -125,26 +125,25 @@ bool BLECharacteristic::is_created() {
if (this->state_ != CREATING_DEPENDENTS)
return false;
bool created = true;
for (auto *descriptor : this->descriptors_) {
created &= descriptor->is_created();
if (!descriptor->is_created())
return false;
}
if (created)
this->state_ = CREATED;
return this->state_ == CREATED;
this->state_ = CREATED;
return true;
}
bool BLECharacteristic::is_failed() {
if (this->state_ == FAILED)
return true;
bool failed = false;
for (auto *descriptor : this->descriptors_) {
failed |= descriptor->is_failed();
if (descriptor->is_failed()) {
this->state_ = FAILED;
return true;
}
}
if (failed)
this->state_ = FAILED;
return this->state_ == FAILED;
return false;
}
void BLECharacteristic::set_broadcast_property(bool value) {