sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-02-08 00:31:58 +00:00
Code Issues Releases Wiki Activity

bot review

Browse Source
This commit is contained in:
J. Nick Koston
2026-01-30 00:03:13 -06:00
parent 3703755e03
commit 91ad54d864
3 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
esphome/components/time/posix_tz.cpp
View File

@@ -274,6 +274,8 @@ static int __attribute__((noinline)) days_from_year_start(int year, int month, i
}
// Calculate days from epoch to Jan 1 of given year
// Note: Only valid for years >= 1970. Pre-1970 timestamps are not supported
// as they are extremely rare for IoT devices.
static int64_t __attribute__((noinline)) days_to_year_start(int year) {
int64_t days = 0;
for (int y = 1970; y < year; y++) {

8
esphome/core/time.cpp
View File

@@ -86,6 +86,12 @@ static bool expect_char(const char *&p, const char *end, char expected) {
return true;
}
// Helper to skip trailing whitespace (for backward compatibility with sscanf)
static void skip_trailing_whitespace(const char *&p, const char *end) {
while (p < end && (*p == ' ' || *p == '\t' || *p == '\n' || *p == '\r'))
p++;
}
bool ESPTime::strptime(const char *time_to_parse, size_t len, ESPTime &esp_time) {
// Supported formats:
// YYYY-MM-DD HH:MM:SS (19 chars)
@@ -150,6 +156,7 @@ bool ESPTime::strptime(const char *time_to_parse, size_t len, ESPTime &esp_time)
return false;
esp_time.second = v6;
skip_trailing_whitespace(p, end);
return p == end; // YYYY-MM-DD HH:MM:SS
}
@@ -177,6 +184,7 @@ bool ESPTime::strptime(const char *time_to_parse, size_t len, ESPTime &esp_time)
return false;
esp_time.second = v3;
skip_trailing_whitespace(p, end);
return p == end; // HH:MM:SS
}

7
tests/components/time/posix_tz_parser.cpp
View File

@@ -421,13 +421,12 @@ TEST(PosixTzParser, PlainDay365LeapYear) {
EXPECT_EQ(day, 31);
}
TEST(PosixTzParser, PlainDay365NonLeapYear) {
// Day 365 in non-leap year would be Jan 1 of next year (out of range)
// But our function should handle it gracefully
TEST(PosixTzParser, PlainDay364NonLeapYear) {
// Day 364 (0-indexed) is Dec 31 in non-leap year (last valid day)
int month, day;
internal::day_of_year_to_month_day(364, 2025, month, day);
EXPECT_EQ(month, 12);
EXPECT_EQ(day, 31); // Day 364 is Dec 31 in non-leap year
EXPECT_EQ(day, 31);
}
// ============================================================================