sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-02-08 00:31:58 +00:00
Code Issues Releases Wiki Activity

[ota] Fix ESP32-S3 OTA crash with hardware SHA acceleration on IDF 5.5.x

Browse Source
This commit is contained in:
J. Nick Koston
2026-01-06 00:09:14 -10:00
parent 22cb0da903
commit 84e382387d
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
esphome/components/esphome/ota/ota_esphome.cpp
View File

@@ -558,13 +558,11 @@ bool ESPHomeOTAComponent::handle_auth_send_() {
// [1+hex_size...1+2*hex_size-1]: cnonce (hex_size bytes) - client's nonce
// [1+2*hex_size...1+3*hex_size-1]: response (hex_size bytes) - client's hash
// CRITICAL ESP32-S3 HARDWARE SHA ACCELERATION: Hash object must stay in same stack frame
// (no passing to other functions). All hash operations must happen in this function.
sha256::SHA256 hasher;
const size_t hex_size = hasher.get_size() * 2;
const size_t nonce_len = hasher.get_size() / 4;
const size_t auth_buf_size = 1 + 3 * hex_size;
// Allocate auth buffer before creating SHA256 hasher to avoid potential
// heap/DMA interactions on ESP32-S3 with hardware SHA acceleration
constexpr size_t hex_size = SHA256_HEX_SIZE;
constexpr size_t nonce_len = 8; // SHA256 digest size (32) / 4
constexpr size_t auth_buf_size = 1 + 3 * hex_size;
this->auth_buf_ = std::make_unique<uint8_t[]>(auth_buf_size);
this->auth_buf_pos_ = 0;
@@ -575,6 +573,10 @@ bool ESPHomeOTAComponent::handle_auth_send_() {
return false;
}
// CRITICAL ESP32-S3 HARDWARE SHA ACCELERATION: Hash object must stay in same stack frame
// (no passing to other functions). All hash operations must happen in this function.
// Create hasher AFTER heap allocations to avoid potential cache/DMA interference.
sha256::SHA256 hasher;
hasher.init();
hasher.add(buf, nonce_len);
hasher.calculate();