sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-03-14 06:38:17 +00:00
Code Issues Releases Wiki Activity

fix: streamline lamp list initialization in build_lamp_list_from_list_str_ to avoid redundant declarations

Browse Source
This commit is contained in:
Oliver Kleinecke 2025-02-18 16:57:52 +01:00
parent 89d6011d73
commit 7b88b8eb4f
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
esphome/components/dynamic_lamp/dynamic_lamp.cpp
View File

@ -270,23 +270,19 @@ bool DynamicLampComponent::add_timer(std::string lamp_list_str, bool timer_activ
LampList DynamicLampComponent::build_lamp_list_from_list_str_(std::string lamp_list_str) {
std::string delimiter = ",";
std::vector<uint8_t> lamp_list_vector = this->split_to_int_array_(s, delimiter);
LampList lamp_list;
lamp_list[0] = 0;
lamp_list[1] = 0;
if (lamp_list_vector.size() > 16) {
ESP_LOGW(TAG, "Too many lamps in list, only 16 supported!");
this->status_set_warning();
LampList lamp_list;
lamp_list[0] = 0;
lamp_list[1] = 0;
return lamp_list();
}
LampList lamp_list;
return lamp_list;
}
for (uint8_t i = 0; i < lamp_list_vector.size(); i++) {
if (lamp_list_vector[i] > 15) {
ESP_LOGW(TAG, "Lamp index %" PRIu8 " is out of range, only [0-15] supported!", lamp_list_vector[i]);
this->status_set_warning();
LampList lamp_list;
lamp_list[0] = 0;
lamp_list[1] = 0;
return lamp_list();
return lamp_list;
}
switch (lamp_list_vector[i]) {
case 0: