sascha/devlib
1
0
Fork 0
mirror of https://github.com/ARM-software/devlib.git synced 2025-01-31 02:00:45 +00:00
Code Issues Releases Wiki Activity

module/cpufreq: Fix typo

Browse Source 
Fix per-cpu/global cpufreq governor tunable setting by replacing a
"pass" into a "continue".

Also name some futures to improve error reporting.
This commit is contained in:
Douglas Raillard 2022-08-09 12:02:33 +01:00 committed by Marc Bonnici
parent fefdf29ed8
commit 492284f46d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
devlib/module/cpufreq.py
View File

@ -163,6 +163,7 @@ class CpufreqModule(Module):
set_per_cpu_tunables(cpu) set_per_cpu_tunables(cpu)
for cpu in domains for cpu in domains
) )
per_cpu_tunables.__qualname__ = 'CpufreqModule.use_governor.<locals>.per_cpu_tunables'
# Non-per-cpu tunables have to be set one after the other, for each # Non-per-cpu tunables have to be set one after the other, for each
# governor that we had to deal with. # governor that we had to deal with.
@ -175,6 +176,7 @@ class CpufreqModule(Module):
self.set_governor_tunables.asyn(cpu, gov, per_cpu=False, **tunables) self.set_governor_tunables.asyn(cpu, gov, per_cpu=False, **tunables)
for gov, (cpu, tunables) in global_tunables.items() for gov, (cpu, tunables) in global_tunables.items()
) )
global_tunables.__qualname__ = 'CpufreqModule.use_governor.<locals>.global_tunables'
# Set the governor first # Set the governor first
await self.target.async_manager.concurrently( await self.target.async_manager.concurrently(
@ -280,7 +282,7 @@ class CpufreqModule(Module):
for tunable, value in kwargs.items(): for tunable, value in kwargs.items():
if tunable in valid_tunables: if tunable in valid_tunables:
if per_cpu is not None and gov_per_cpu != per_cpu: if per_cpu is not None and gov_per_cpu != per_cpu:
pass continue
if gov_per_cpu: if gov_per_cpu:
path = '/sys/devices/system/cpu/{}/cpufreq/{}/{}'.format(cpu, governor, tunable) path = '/sys/devices/system/cpu/{}/cpufreq/{}/{}'.format(cpu, governor, tunable)