From 492284f46dcb3b9a4633f6c284c76d36a20e8ba2 Mon Sep 17 00:00:00 2001 From: Douglas Raillard Date: Tue, 9 Aug 2022 12:02:33 +0100 Subject: [PATCH] module/cpufreq: Fix typo Fix per-cpu/global cpufreq governor tunable setting by replacing a "pass" into a "continue". Also name some futures to improve error reporting. --- devlib/module/cpufreq.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/devlib/module/cpufreq.py b/devlib/module/cpufreq.py index 0910c43..cf4d11d 100644 --- a/devlib/module/cpufreq.py +++ b/devlib/module/cpufreq.py @@ -163,6 +163,7 @@ class CpufreqModule(Module): set_per_cpu_tunables(cpu) for cpu in domains ) + per_cpu_tunables.__qualname__ = 'CpufreqModule.use_governor..per_cpu_tunables' # Non-per-cpu tunables have to be set one after the other, for each # governor that we had to deal with. @@ -175,6 +176,7 @@ class CpufreqModule(Module): self.set_governor_tunables.asyn(cpu, gov, per_cpu=False, **tunables) for gov, (cpu, tunables) in global_tunables.items() ) + global_tunables.__qualname__ = 'CpufreqModule.use_governor..global_tunables' # Set the governor first await self.target.async_manager.concurrently( @@ -280,7 +282,7 @@ class CpufreqModule(Module): for tunable, value in kwargs.items(): if tunable in valid_tunables: if per_cpu is not None and gov_per_cpu != per_cpu: - pass + continue if gov_per_cpu: path = '/sys/devices/system/cpu/{}/cpufreq/{}/{}'.format(cpu, governor, tunable)