Bump to 2.4

https://github.com/travis-ci/apt-source-whitelist/issues/71

.travis.yml

@@ -3,12 +3,23 @@ python:
   - "3.4"
   - "3.3"
   - "2.7"
+addons:
+  apt:
+    sources:
+      - fish-shell/release-2
+    packages:
+      - bash
+      - zsh
+      - fish
+      - tcsh
+env:
+  - FUNCTIONAL=true BARE=true
 install:
+  - pip install coveralls
   - pip install -r requirements.txt
   - python setup.py develop
-  - pip install coveralls
   - rm -rf build
 script:
   - export COVERAGE_PYTHON_VERSION=python-${TRAVIS_PYTHON_VERSION:0:1}
-  - coverage run --source=thefuck,tests -m py.test -v
+  - coverage run --source=thefuck,tests -m py.test -v --capture=sys
 after_success: coveralls

README.md

@@ -141,13 +141,15 @@ using the matched rule and runs it. Rules enabled by default are as follows:
 * `cpp11` – adds missing `-std=c++11` to `g++` or `clang++`;
 * `django_south_ghost` – adds `--delete-ghost-migrations` to failed because ghosts django south migration;
 * `django_south_merge` – adds `--merge` to inconsistent django south migration;
-* `dry` – fixes repetitions like "git git push";
+* `docker_not_command` – fixes wrong docker commands like `docker tags`;
+* `dry` – fixes repetitions like `git git push`;
 * `fix_alt_space` – replaces Alt+Space with Space character;
 * `git_add` – fixes *"Did you forget to 'git add'?"*;
 * `git_branch_delete` – changes `git branch -d` to `git branch -D`;
 * `git_branch_list` – catches `git branch list` in place of `git branch` and removes created branch;
 * `git_checkout` – fixes branch name or creates new branch;
 * `git_diff_staged` – adds `--staged` to previous `git diff` with unexpected output;
+* `git_fix_stash` – fixes `git stash` commands (misspelled subcommand and missing `save`);
 * `git_not_command` – fixes wrong git commands like `git brnch`;
 * `git_pull` – sets upstream before executing previous `git pull`;
 * `git_pull_clone` – clones instead of pulling when the repo does not exist;
@@ -155,14 +157,15 @@ using the matched rule and runs it. Rules enabled by default are as follows:
 * `git_push_pull` – runs `git pull` when `push` was rejected;
 * `git_stash` – stashes you local modifications before rebasing or switching branch;
 * `go_run` – appends `.go` extension when compiling/running Go programs
-* `grep_recursive` – adds `-r` when you trying to grep directory;
+* `grep_recursive` – adds `-r` when you trying to `grep` directory;
+* `gulp_not_task` – fixes misspelled gulp tasks;
 * `has_exists_script` – prepends `./` when script/binary exists;
-* `heroku_no_command` – fixes wrong heroku commands like `heroku log`;
+* `heroku_no_command` – fixes wrong `heroku` commands like `heroku log`;
 * `history` – tries to replace command with most similar command from history;
 * `java` – removes `.java` extension when running Java programs;
 * `javac` – appends missing `.java` when compiling Java files;
 * `lein_not_task` – fixes wrong `lein` tasks like `lein rpl`;
-* `ls_lah` – adds -lah to ls;
+* `ls_lah` – adds `-lah` to `ls`;
 * `man` – changes manual section;
 * `man_no_space` – fixes man commands without spaces, for example `mandiff`;
 * `mercurial` – fixes wrong `hg` commands;
@@ -170,7 +173,7 @@ using the matched rule and runs it. Rules enabled by default are as follows:
 * `no_command` – fixes wrong console commands, for example `vom/vim`;
 * `no_such_file` – creates missing directories with `mv` and `cp` commands;
 * `open` – prepends `http` to address passed to `open`;
-* `pip_unknown_command` – fixes wrong pip commands, for example `pip instatl/pip install`;
+* `pip_unknown_command` – fixes wrong `pip` commands, for example `pip instatl/pip install`;
 * `python_command` – prepends `python` when you trying to run not executable/without `./` python script;
 * `python_execute` – appends missing `.py` when executing Python files;
 * `quotation_marks` – fixes uneven usage of `'` and `"` when containing args'
@@ -180,9 +183,9 @@ using the matched rule and runs it. Rules enabled by default are as follows:
 * `ssh_known_hosts` – removes host from `known_hosts` on warning;
 * `sudo` – prepends `sudo` to previous command if it failed because of permissions;
 * `switch_layout` – switches command from your local layout to en;
-* `systemctl` – correctly orders parameters of confusing systemctl;
+* `systemctl` – correctly orders parameters of confusing `systemctl`;
 * `test.py` – runs `py.test` instead of `test.py`;
-* `tmux` – fixes tmux commands;
+* `tmux` – fixes `tmux` commands;
 * `whois` – fixes `whois` command.
 
 Enabled by default only on specific platforms:
@@ -289,11 +292,17 @@ pip install -r requirements.txt
 python setup.py develop
 ```
 
-Run tests:
+Run unit tests:
 
 ```bash
 py.test
 ```
 
+Run unit and functional tests (requires docker):
+
+```bash
+FUNCTIONAL=true py.test
+```
+
 ## License MIT
 Project License can be found [here](LICENSE.md).

requirements.txt

@@ -3,3 +3,4 @@ mock
 pytest-mock
 wheel
 setuptools>=17.1
+pexpect

setup.cfg

@@ -1,2 +1,4 @@
 [bdist_wheel]
 universal = 1
+[metadata]
+description-file = README.md

setup.py

@@ -11,7 +11,7 @@ elif (3, 0) < sys.version_info < (3, 3):
           ' ({}.{} detected).'.format(*sys.version_info[:2]))
     sys.exit(-1)
 
-VERSION = '2.3'
+VERSION = '2.4'
 
 install_requires = ['psutil', 'colorama', 'six']
 extras_require = {':python_version<"3.4"': ['pathlib']}

tests/functional/plots.py

@@ -0,0 +1,42 @@
+def with_confirmation(proc):
+    """Ensures that command can be fixed when confirmation enabled."""
+    proc.sendline(u'mkdir -p ~/.thefuck')
+    proc.sendline(u'echo "require_confirmation = True" > ~/.thefuck/settings.py')
+
+    proc.sendline(u'ehco test')
+
+    proc.sendline(u'fuck')
+    proc.expect(u'echo test')
+    proc.expect(u'enter')
+    proc.expect_exact(u'ctrl+c')
+    proc.send('\n')
+
+    proc.expect(u'test')
+
+
+def refuse_with_confirmation(proc):
+    """Ensures that fix can be refused when confirmation enabled."""
+    proc.sendline(u'mkdir -p ~/.thefuck')
+    proc.sendline(u'echo "require_confirmation = True" > ~/.thefuck/settings.py')
+
+    proc.sendline(u'ehco test')
+
+    proc.sendline(u'fuck')
+    proc.expect(u'echo test')
+    proc.expect(u'enter')
+    proc.expect_exact(u'ctrl+c')
+    proc.send('\003')
+
+    proc.expect(u'Aborted')
+
+
+def without_confirmation(proc):
+    """Ensures that command can be fixed when confirmation disabled."""
+    proc.sendline(u'mkdir -p ~/.thefuck')
+    proc.sendline(u'echo "require_confirmation = False" > ~/.thefuck/settings.py')
+
+    proc.sendline(u'ehco test')
+
+    proc.sendline(u'fuck')
+    proc.expect(u'echo test')
+    proc.expect(u'test')

tests/functional/test_bash.py

@@ -0,0 +1,42 @@
+import pytest
+from tests.functional.plots import with_confirmation, without_confirmation, \
+    refuse_with_confirmation
+from tests.functional.utils import spawn, functional, images
+
+containers = images(('ubuntu-python3-bash', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python3 python3-pip python3-dev
+RUN pip3 install -U setuptools
+RUN ln -s /usr/bin/pip3 /usr/bin/pip
+'''),
+                    ('ubuntu-python2-bash', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python python-pip python-dev
+RUN pip2 install -U pip setuptools
+'''))
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'bash') as proc:
+        proc.sendline(u'eval $(thefuck-alias)')
+        with_confirmation(proc)
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_refuse_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'bash') as proc:
+        proc.sendline(u'eval $(thefuck-alias)')
+        refuse_with_confirmation(proc)
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_without_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'bash') as proc:
+        proc.sendline(u'eval $(thefuck-alias)')
+        without_confirmation(proc)

tests/functional/test_fish.py

@@ -0,0 +1,51 @@
+import pytest
+from tests.functional.plots import with_confirmation, without_confirmation, \
+    refuse_with_confirmation
+from tests.functional.utils import spawn, functional, images, bare
+
+containers = images(('ubuntu-python3-fish', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python3 python3-pip python3-dev fish
+RUN pip3 install -U setuptools
+RUN ln -s /usr/bin/pip3 /usr/bin/pip
+'''),
+                    ('ubuntu-python2-fish', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python python-pip python-dev fish
+RUN pip2 install -U pip setuptools
+'''))
+
+
+@functional
+@pytest.mark.skipif(
+    bool(bare), reason='https://github.com/travis-ci/apt-source-whitelist/issues/71')
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'fish') as proc:
+        proc.sendline(u'thefuck-alias > ~/.config/fish/config.fish')
+        proc.sendline(u'fish')
+        with_confirmation(proc)
+
+
+@functional
+@pytest.mark.skipif(
+    bool(bare), reason='https://github.com/travis-ci/apt-source-whitelist/issues/71')
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_refuse_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'fish') as proc:
+        proc.sendline(u'thefuck-alias > ~/.config/fish/config.fish')
+        proc.sendline(u'fish')
+        refuse_with_confirmation(proc)
+
+
+@functional
+@pytest.mark.skipif(
+    bool(bare), reason='https://github.com/travis-ci/apt-source-whitelist/issues/71')
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_without_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'fish') as proc:
+        proc.sendline(u'thefuck-alias > ~/.config/fish/config.fish')
+        proc.sendline(u'fish')
+        without_confirmation(proc)

tests/functional/test_tcsh.py

@@ -0,0 +1,45 @@
+import pytest
+from tests.functional.utils import spawn, functional, images
+from tests.functional.plots import with_confirmation, without_confirmation, \
+    refuse_with_confirmation
+
+containers = images(('ubuntu-python3-tcsh', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python3 python3-pip python3-dev tcsh
+RUN pip3 install -U setuptools
+RUN ln -s /usr/bin/pip3 /usr/bin/pip
+'''),
+                    ('ubuntu-python2-tcsh', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python python-pip python-dev tcsh
+RUN pip2 install -U pip setuptools
+'''))
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'tcsh') as proc:
+        proc.sendline(u'tcsh')
+        proc.sendline(u'eval `thefuck-alias`')
+        with_confirmation(proc)
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_refuse_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'tcsh') as proc:
+        proc.sendline(u'tcsh')
+        proc.sendline(u'eval `thefuck-alias`')
+        refuse_with_confirmation(proc)
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_without_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'tcsh') as proc:
+        proc.sendline(u'tcsh')
+        proc.sendline(u'eval `thefuck-alias`')
+        without_confirmation(proc)

tests/functional/test_zsh.py

@@ -0,0 +1,42 @@
+import pytest
+from tests.functional.utils import spawn, functional, images
+from tests.functional.plots import with_confirmation, without_confirmation, \
+    refuse_with_confirmation
+
+containers = images(('ubuntu-python3-zsh', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python3 python3-pip python3-dev zsh
+RUN pip3 install -U setuptools
+RUN ln -s /usr/bin/pip3 /usr/bin/pip
+'''),
+                    ('ubuntu-python2-zsh', u'''
+FROM ubuntu:latest
+RUN apt-get update
+RUN apt-get install -yy python python-pip python-dev zsh
+RUN pip2 install -U pip setuptools
+'''))
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'zsh') as proc:
+        proc.sendline(u'eval $(thefuck-alias)')
+        with_confirmation(proc)
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_refuse_with_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'zsh') as proc:
+        proc.sendline(u'eval $(thefuck-alias)')
+        refuse_with_confirmation(proc)
+
+
+@functional
+@pytest.mark.parametrize('tag, dockerfile', containers)
+def test_without_confirmation(tag, dockerfile):
+    with spawn(tag, dockerfile, u'zsh') as proc:
+        proc.sendline(u'eval $(thefuck-alias)')
+        without_confirmation(proc)

tests/functional/utils.py

@@ -0,0 +1,54 @@
+import os
+from contextlib import contextmanager
+import subprocess
+import shutil
+from tempfile import mkdtemp
+from pathlib import Path
+import sys
+import pexpect
+import pytest
+
+root = str(Path(__file__).parent.parent.parent.resolve())
+bare = os.environ.get('BARE')
+enabled = os.environ.get('FUNCTIONAL')
+
+
+def build_container(tag, dockerfile):
+    tmpdir = mkdtemp()
+    with Path(tmpdir).joinpath('Dockerfile').open('w') as file:
+        file.write(dockerfile)
+    if subprocess.call(['docker', 'build', '--tag={}'.format(tag), tmpdir],
+                       cwd=root) != 0:
+        raise Exception("Can't build a container")
+    shutil.rmtree(tmpdir)
+
+
+@contextmanager
+def spawn(tag, dockerfile, cmd):
+    if bare:
+        proc = pexpect.spawnu(cmd)
+    else:
+        tag = 'thefuck/{}'.format(tag)
+        build_container(tag, dockerfile)
+        proc = pexpect.spawnu('docker run --volume {}:/src --tty=true '
+                              '--interactive=true {} {}'.format(root, tag, cmd))
+        proc.sendline('pip install /src')
+
+    proc.logfile = sys.stdout
+
+    try:
+        yield proc
+    finally:
+        proc.terminate(force=bare)
+
+
+def images(*items):
+    if bare:
+        return [items[0]]
+    else:
+        return items
+
+
+functional = pytest.mark.skipif(
+    not enabled,
+    reason='Functional tests are disabled by default.')

tests/rules/test_docker_not_command.py

@@ -0,0 +1,129 @@
+import pytest
+from io import BytesIO
+from tests.utils import Command
+from thefuck.rules.docker_not_command import get_new_command, match
+
+
+@pytest.fixture
+def docker_help(mocker):
+    help = b'''Usage: docker [OPTIONS] COMMAND [arg...]
+
+A self-sufficient runtime for linux containers.
+
+Options:
+
+  --api-cors-header=                   Set CORS headers in the remote API
+  -b, --bridge=                        Attach containers to a network bridge
+  --bip=                               Specify network bridge IP
+  -D, --debug=false                    Enable debug mode
+  -d, --daemon=false                   Enable daemon mode
+  --default-gateway=                   Container default gateway IPv4 address
+  --default-gateway-v6=                Container default gateway IPv6 address
+  --default-ulimit=[]                  Set default ulimits for containers
+  --dns=[]                             DNS server to use
+  --dns-search=[]                      DNS search domains to use
+  -e, --exec-driver=native             Exec driver to use
+  --exec-opt=[]                        Set exec driver options
+  --exec-root=/var/run/docker          Root of the Docker execdriver
+  --fixed-cidr=                        IPv4 subnet for fixed IPs
+  --fixed-cidr-v6=                     IPv6 subnet for fixed IPs
+  -G, --group=docker                   Group for the unix socket
+  -g, --graph=/var/lib/docker          Root of the Docker runtime
+  -H, --host=[]                        Daemon socket(s) to connect to
+  -h, --help=false                     Print usage
+  --icc=true                           Enable inter-container communication
+  --insecure-registry=[]               Enable insecure registry communication
+  --ip=0.0.0.0                         Default IP when binding container ports
+  --ip-forward=true                    Enable net.ipv4.ip_forward
+  --ip-masq=true                       Enable IP masquerading
+  --iptables=true                      Enable addition of iptables rules
+  --ipv6=false                         Enable IPv6 networking
+  -l, --log-level=info                 Set the logging level
+  --label=[]                           Set key=value labels to the daemon
+  --log-driver=json-file               Default driver for container logs
+  --log-opt=map[]                      Set log driver options
+  --mtu=0                              Set the containers network MTU
+  -p, --pidfile=/var/run/docker.pid    Path to use for daemon PID file
+  --registry-mirror=[]                 Preferred Docker registry mirror
+  -s, --storage-driver=                Storage driver to use
+  --selinux-enabled=false              Enable selinux support
+  --storage-opt=[]                     Set storage driver options
+  --tls=false                          Use TLS; implied by --tlsverify
+  --tlscacert=~/.docker/ca.pem         Trust certs signed only by this CA
+  --tlscert=~/.docker/cert.pem         Path to TLS certificate file
+  --tlskey=~/.docker/key.pem           Path to TLS key file
+  --tlsverify=false                    Use TLS and verify the remote
+  --userland-proxy=true                Use userland proxy for loopback traffic
+  -v, --version=false                  Print version information and quit
+
+Commands:
+    attach    Attach to a running container
+    build     Build an image from a Dockerfile
+    commit    Create a new image from a container's changes
+    cp        Copy files/folders from a container's filesystem to the host path
+    create    Create a new container
+    diff      Inspect changes on a container's filesystem
+    events    Get real time events from the server
+    exec      Run a command in a running container
+    export    Stream the contents of a container as a tar archive
+    history   Show the history of an image
+    images    List images
+    import    Create a new filesystem image from the contents of a tarball
+    info      Display system-wide information
+    inspect   Return low-level information on a container or image
+    kill      Kill a running container
+    load      Load an image from a tar archive
+    login     Register or log in to a Docker registry server
+    logout    Log out from a Docker registry server
+    logs      Fetch the logs of a container
+    pause     Pause all processes within a container
+    port      Lookup the public-facing port that is NAT-ed to PRIVATE_PORT
+    ps        List containers
+    pull      Pull an image or a repository from a Docker registry server
+    push      Push an image or a repository to a Docker registry server
+    rename    Rename an existing container
+    restart   Restart a running container
+    rm        Remove one or more containers
+    rmi       Remove one or more images
+    run       Run a command in a new container
+    save      Save an image to a tar archive
+    search    Search for an image on the Docker Hub
+    start     Start a stopped container
+    stats     Display a stream of a containers' resource usage statistics
+    stop      Stop a running container
+    tag       Tag an image into a repository
+    top       Lookup the running processes of a container
+    unpause   Unpause a paused container
+    version   Show the Docker version information
+    wait      Block until a container stops, then print its exit code
+
+Run 'docker COMMAND --help' for more information on a command.
+'''
+    mock = mocker.patch('subprocess.Popen')
+    mock.return_value.stdout = BytesIO(help)
+    return mock
+
+
+def stderr(cmd):
+    return "docker: '{}' is not a docker command.\n" \
+           "See 'docker --help'.".format(cmd)
+
+
+def test_match():
+    assert match(Command('docker pes', stderr=stderr('pes')), None)
+
+
+@pytest.mark.parametrize('script, stderr', [
+    ('docker ps', ''),
+    ('cat pes', stderr('pes'))])
+def test_not_match(script, stderr):
+    assert not match(Command(script, stderr=stderr), None)
+
+
+@pytest.mark.usefixtures('docker_help')
+@pytest.mark.parametrize('wrong, fixed', [
+    ('pes', 'ps'),
+    ('tags', 'tag')])
+def test_get_new_command(wrong, fixed):
+    command = Command('docker {}'.format(wrong), stderr=stderr(wrong))
+    assert get_new_command(command, None) == 'docker {}'.format(fixed)

tests/rules/test_git_checkout.py

@@ -14,7 +14,7 @@ def did_not_match(target, did_you_forget=False):
 
 @pytest.fixture
 def get_branches(mocker):
-    return mocker.patch('thefuck.rules.git_checkout')
+    return mocker.patch('thefuck.rules.git_checkout.get_branches')
 
 
 @pytest.mark.parametrize('command', [
@@ -40,12 +40,14 @@ def test_not_match(command):
     ([],
      Command('git commit unknown', stderr=did_not_match('unknown')),
      'git branch unknown && git commit unknown'),
-    (['master'],
-     Command(script='git checkout mster', stderr=did_not_match('mster')),
-     'git checkout master'),
-    (['master'],
-     Command(script='git commit mster', stderr=did_not_match('mster')),
-     'git commit master')])
+    (['test-random-branch-123'],
+     Command(script='git checkout tst-rdm-brnch-123',
+             stderr=did_not_match('tst-rdm-brnch-123')),
+     'git checkout test-random-branch-123'),
+    (['test-random-branch-123'],
+     Command(script='git commit tst-rdm-brnch-123',
+             stderr=did_not_match('tst-rdm-brnch-123')),
+     'git commit test-random-branch-123')])
 def test_get_new_command(branches, command, new_command, get_branches):
     get_branches.return_value = branches
     assert get_new_command(command, None) == new_command

tests/rules/test_git_fix_stash.py

@@ -0,0 +1,31 @@
+import pytest
+from thefuck.rules.git_fix_stash import match, get_new_command
+from tests.utils import Command
+
+
+git_stash_err = '''
+usage: git stash list [<options>]
+   or: git stash show [<stash>]
+   or: git stash drop [-q|--quiet] [<stash>]
+   or: git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]
+   or: git stash branch <branchname> [<stash>]
+   or: git stash [save [--patch] [-k|--[no-]keep-index] [-q|--quiet]
+		       [-u|--include-untracked] [-a|--all] [<message>]]
+   or: git stash clear
+'''
+
+
+@pytest.mark.parametrize('wrong', [
+    'git stash opp',
+    'git stash Some message',
+    'git stash saev Some message'])
+def test_match(wrong):
+    assert match(Command(wrong, stderr=git_stash_err), None)
+
+
+@pytest.mark.parametrize('wrong,fixed', [
+    ('git stash opp', 'git stash pop'),
+    ('git stash Some message', 'git stash save Some message'),
+    ('git stash saev Some message', 'git stash save Some message')])
+def test_get_new_command(wrong, fixed):
+    assert get_new_command(Command(wrong, stderr=git_stash_err), None) == fixed

tests/rules/test_gulp_not_task.py

@@ -0,0 +1,28 @@
+import pytest
+from tests.utils import Command
+from thefuck.rules.gulp_not_task import match, get_new_command
+
+
+def stdout(task):
+    return '''[00:41:11] Using gulpfile gulpfile.js
+[00:41:11] Task '{}' is not in your gulpfile
+[00:41:11] Please check the documentation for proper gulpfile formatting
+'''.format(task)
+
+
+def test_match():
+    assert match(Command('gulp srve', stdout('srve')), None)
+
+
+@pytest.mark.parametrize('script, stdout', [
+    ('gulp serve', ''),
+    ('cat srve', stdout('srve'))])
+def test_not_march(script, stdout):
+    assert not match(Command(script, stdout), None)
+
+
+def test_get_new_command(mocker):
+    mocker.patch('thefuck.rules.gulp_not_task.get_gulp_tasks', return_value=[
+        'serve', 'build', 'default'])
+    command = Command('gulp srve', stdout('srve'))
+    assert get_new_command(command, None) == 'gulp serve'

tests/test_utils.py

@@ -1,7 +1,7 @@
 import pytest
 from mock import Mock
 from thefuck.utils import git_support, sudo_support, wrap_settings,\
-    memoize, get_closest, get_all_executables
+    memoize, get_closest, get_all_executables, replace_argument
 from thefuck.types import Settings
 from tests.utils import Command
 
@@ -92,3 +92,10 @@ def test_get_all_callables():
     assert 'vim' in all_callables
     assert 'fsck' in all_callables
     assert 'fuck' not in all_callables
+
+
+@pytest.mark.parametrize('args, result', [
+    (('apt-get instol vim', 'instol', 'install'), 'apt-get install vim'),
+    (('git brnch', 'brnch', 'branch'), 'git branch')])
+def test_replace_argument(args, result):
+    assert replace_argument(*args) == result

thefuck/logs.py

@@ -1,4 +1,5 @@
-from pprint import pformat
+from contextlib import contextmanager
+from datetime import datetime
 import sys
 from traceback import format_exception
 import colorama
@@ -62,3 +63,12 @@ def debug(msg, settings):
             reset=color(colorama.Style.RESET_ALL, settings),
             blue=color(colorama.Fore.BLUE, settings),
             bold=color(colorama.Style.BRIGHT, settings)))
+
+
+@contextmanager
+def debug_time(msg, settings):
+    started = datetime.now()
+    try:
+        yield
+    finally:
+        debug('{} took: {}'.format(msg, datetime.now() - started), settings)

thefuck/main.py

@@ -80,25 +80,25 @@ def get_command(settings, args):
         return
 
     script = shells.from_shell(script)
-    logs.debug(u'Call: {}'.format(script), settings)
-
     env = dict(os.environ)
     env.update(settings.env)
-    logs.debug(u'Executing with env: {}'.format(env), settings)
 
-    result = Popen(script, shell=True, stdout=PIPE, stderr=PIPE, env=env)
-    if wait_output(settings, result):
-        return types.Command(script, result.stdout.read().decode('utf-8'),
-                             result.stderr.read().decode('utf-8'))
+    with logs.debug_time(u'Call: {}; with env: {};'.format(script, env),
+                         settings):
+        result = Popen(script, shell=True, stdout=PIPE, stderr=PIPE, env=env)
+        if wait_output(settings, result):
+            return types.Command(script, result.stdout.read().decode('utf-8'),
+                                 result.stderr.read().decode('utf-8'))
 
 
 def get_matched_rule(command, rules, settings):
     """Returns first matched rule for command."""
     for rule in rules:
         try:
-            logs.debug(u'Trying rule: {}'.format(rule.name), settings)
-            if rule.match(command, settings):
-                return rule
+            with logs.debug_time(u'Trying rule: {};'.format(rule.name),
+                                 settings):
+                if rule.match(command, settings):
+                    return rule
         except Exception:
             logs.rule_failed(rule, sys.exc_info(), settings)
 
@@ -134,25 +134,26 @@ def main():
     colorama.init()
     user_dir = setup_user_dir()
     settings = conf.get_settings(user_dir)
-    logs.debug(u'Run with settings: {}'.format(pformat(settings)), settings)
+    with logs.debug_time('Total', settings):
+        logs.debug(u'Run with settings: {}'.format(pformat(settings)), settings)
 
-    command = get_command(settings, sys.argv)
-    if command:
-        logs.debug(u'Received stdout: {}'.format(command.stdout), settings)
-        logs.debug(u'Received stderr: {}'.format(command.stderr), settings)
+        command = get_command(settings, sys.argv)
+        if command:
+            logs.debug(u'Received stdout: {}'.format(command.stdout), settings)
+            logs.debug(u'Received stderr: {}'.format(command.stderr), settings)
 
-        rules = get_rules(user_dir, settings)
-        logs.debug(
-            u'Loaded rules: {}'.format(', '.join(rule.name for rule in rules)),
-            settings)
+            rules = get_rules(user_dir, settings)
+            logs.debug(
+                u'Loaded rules: {}'.format(', '.join(rule.name for rule in rules)),
+                settings)
 
-        matched_rule = get_matched_rule(command, rules, settings)
-        if matched_rule:
-            logs.debug(u'Matched rule: {}'.format(matched_rule.name), settings)
-            run_rule(matched_rule, command, settings)
-            return
+            matched_rule = get_matched_rule(command, rules, settings)
+            if matched_rule:
+                logs.debug(u'Matched rule: {}'.format(matched_rule.name), settings)
+                run_rule(matched_rule, command, settings)
+                return
 
-    logs.failed('No fuck given', settings)
+        logs.failed('No fuck given', settings)
 
 
 def print_alias():

thefuck/rules/brew_install.py

@@ -1,7 +1,7 @@
 import os
 import re
 from subprocess import check_output
-from thefuck.utils import get_closest
+from thefuck.utils import get_closest, replace_argument
 
 # Formulars are base on each local system's status
 
@@ -40,4 +40,4 @@ def get_new_command(command, settings):
                                    command.stderr)[0]
     exist_formula = _get_similar_formula(not_exist_formula)
 
-    return command.script.replace(not_exist_formula, exist_formula, 1)
+    return replace_argument(command.script, not_exist_formula, exist_formula)

thefuck/rules/brew_unknown_command.py

@@ -1,7 +1,7 @@
 import os
 import re
 import subprocess
-from thefuck.utils import get_closest
+from thefuck.utils import get_closest, replace_argument
 
 BREW_CMD_PATH = '/Library/Homebrew/cmd'
 TAP_PATH = '/Library/Taps'
@@ -99,4 +99,4 @@ def get_new_command(command, settings):
                             command.stderr)[0]
     new_cmd = _get_similar_command(broken_cmd)
 
-    return command.script.replace(broken_cmd, new_cmd, 1)
+    return replace_argument(command.script, broken_cmd, new_cmd)

thefuck/rules/cargo_no_command.py

@@ -1,4 +1,5 @@
 import re
+from thefuck.utils import replace_argument
 
 
 def match(command, settings):
@@ -11,4 +12,4 @@ def get_new_command(command, settings):
     broken = command.script.split()[1]
     fix = re.findall(r'Did you mean `([^`]*)`', command.stderr)[0]
 
-    return command.script.replace(broken, fix, 1)
+    return replace_argument(command.script, broken, fix)

thefuck/rules/composer_not_command.py

@@ -1,4 +1,5 @@
 import re
+from thefuck.utils import replace_argument
 
 
 def match(command, settings):
@@ -12,4 +13,4 @@ def get_new_command(command, settings):
     new_cmd = re.findall(r'Did you mean this\?[^\n]*\n\s*([^\n]*)', command.stderr)
     if not new_cmd:
         new_cmd = re.findall(r'Did you mean one of these\?[^\n]*\n\s*([^\n]*)', command.stderr)
-    return command.script.replace(broken_cmd, new_cmd[0].strip(), 1)
+    return replace_argument(command.script, broken_cmd, new_cmd[0].strip())

thefuck/rules/docker_not_command.py

@@ -0,0 +1,27 @@
+from itertools import dropwhile, takewhile, islice
+import re
+import subprocess
+from thefuck.utils import get_closest, sudo_support, replace_argument
+
+
+@sudo_support
+def match(command, settings):
+    return command.script.startswith('docker') \
+           and 'is not a docker command' in command.stderr
+
+
+def get_docker_commands():
+    proc = subprocess.Popen('docker', stdout=subprocess.PIPE)
+    lines = [line.decode('utf-8') for line in proc.stdout.readlines()]
+    lines = dropwhile(lambda line: not line.startswith('Commands:'), lines)
+    lines = islice(lines, 1, None)
+    lines = list(takewhile(lambda line: line != '\n', lines))
+    return [line.strip().split(' ')[0] for line in lines]
+
+
+@sudo_support
+def get_new_command(command, settings):
+    wrong_command = re.findall(
+        r"docker: '(\w+)' is not a docker command.", command.stderr)[0]
+    fixed_command = get_closest(wrong_command, get_docker_commands())
+    return replace_argument(command.script, wrong_command, fixed_command)

thefuck/rules/git_branch_delete.py

@@ -1,4 +1,5 @@
 from thefuck import utils
+from thefuck.utils import replace_argument
 
 
 @utils.git_support
@@ -9,4 +10,4 @@ def match(command, settings):
 
 @utils.git_support
 def get_new_command(command, settings):
-    return command.script.replace('-d', '-D')
+    return replace_argument(command.script, '-d', '-D')

thefuck/rules/git_checkout.py

@@ -1,6 +1,7 @@
 import re
 import subprocess
 from thefuck import shells, utils
+from thefuck.utils import replace_argument
 
 
 @utils.git_support
@@ -30,7 +31,7 @@ def get_new_command(command, settings):
     closest_branch = utils.get_closest(missing_file, get_branches(),
                                        fallback_to_first=False)
     if closest_branch:
-        return command.script.replace(missing_file, closest_branch, 1)
+        return replace_argument(command.script, missing_file, closest_branch)
     else:
         return shells.and_('git branch {}', '{}').format(
             missing_file, command.script)

thefuck/rules/git_diff_staged.py

@@ -1,4 +1,5 @@
 from thefuck import utils
+from thefuck.utils import replace_argument
 
 
 @utils.git_support
@@ -9,4 +10,4 @@ def match(command, settings):
 
 @utils.git_support
 def get_new_command(command, settings):
-    return command.script.replace(' diff', ' diff --staged')
+    return replace_argument(command.script, 'diff', 'diff --staged')

thefuck/rules/git_fix_stash.py

@@ -0,0 +1,32 @@
+from thefuck import utils
+from thefuck.utils import replace_argument
+
+
+@utils.git_support
+def match(command, settings):
+    return (command.script.split()[1] == 'stash'
+            and 'usage:' in command.stderr)
+
+# git's output here is too complicated to be parsed (see the test file)
+stash_commands = (
+    'apply',
+    'branch',
+    'clear',
+    'drop',
+    'list',
+    'pop',
+    'save',
+    'show')
+
+
+@utils.git_support
+def get_new_command(command, settings):
+    stash_cmd = command.script.split()[2]
+    fixed = utils.get_closest(stash_cmd, stash_commands, fallback_to_first=False)
+
+    if fixed is not None:
+        return replace_argument(command.script, stash_cmd, fixed)
+    else:
+        cmd = command.script.split()
+        cmd.insert(2, 'save')
+        return ' '.join(cmd)

thefuck/rules/git_not_command.py

@@ -1,5 +1,5 @@
 import re
-from thefuck.utils import get_closest, git_support
+from thefuck.utils import get_closest, git_support, replace_argument
 
 
 @git_support
@@ -23,5 +23,5 @@ def get_new_command(command, settings):
                             command.stderr)[0]
     new_cmd = get_closest(broken_cmd,
                           _get_all_git_matched_commands(command.stderr))
-    return command.script.replace(broken_cmd, new_cmd, 1)
+    return replace_argument(command.script, broken_cmd, new_cmd)
 

thefuck/rules/git_pull_clone.py

@@ -1,4 +1,5 @@
 from thefuck import utils
+from thefuck.utils import replace_argument
 
 
 @utils.git_support
@@ -9,4 +10,4 @@ def match(command, settings):
 
 @utils.git_support
 def get_new_command(command, settings):
-    return command.script.replace(' pull ', ' clone ')
+    return replace_argument(command.script, 'pull', 'clone')

thefuck/rules/git_push_force.py

@@ -1,4 +1,5 @@
 from thefuck import utils
+from thefuck.utils import replace_argument
 
 
 @utils.git_support
@@ -11,7 +12,7 @@ def match(command, settings):
 
 @utils.git_support
 def get_new_command(command, settings):
-    return command.script.replace('push', 'push --force')
+    return replace_argument(command.script, 'push', 'push --force')
 
 
 enabled_by_default = False

thefuck/rules/git_push_pull.py

@@ -1,5 +1,6 @@
 from thefuck import utils
 from thefuck.shells import and_
+from thefuck.utils import replace_argument
 
 
 @utils.git_support
@@ -12,5 +13,5 @@ def match(command, settings):
 
 @utils.git_support
 def get_new_command(command, settings):
-    return and_(command.script.replace('push', 'pull'),
+    return and_(replace_argument(command.script, 'push', 'pull'),
                 command.script)

thefuck/rules/gulp_not_task.py

@@ -0,0 +1,22 @@
+import re
+import subprocess
+from thefuck.utils import get_closest, replace_argument
+
+
+def match(command, script):
+    return command.script.startswith('gulp')\
+        and 'is not in your gulpfile' in command.stdout
+
+
+def get_gulp_tasks():
+    proc = subprocess.Popen(['gulp', '--tasks-simple'],
+                            stdout=subprocess.PIPE)
+    return [line.decode('utf-8')[:-1]
+            for line in proc.stdout.readlines()]
+
+
+def get_new_command(command, script):
+    wrong_task = re.findall(r"Task '(\w+)' is not in your gulpfile",
+                            command.stdout)[0]
+    fixed_task = get_closest(wrong_task, get_gulp_tasks())
+    return replace_argument(command.script, wrong_task, fixed_task)

thefuck/rules/heroku_not_command.py

@@ -1,5 +1,5 @@
 import re
-from thefuck.utils import get_closest
+from thefuck.utils import get_closest, replace_argument
 
 
 def match(command, settings):
@@ -17,4 +17,4 @@ def _get_suggests(stderr):
 def get_new_command(command, settings):
     wrong = re.findall(r'`(\w+)` is not a heroku command', command.stderr)[0]
     correct = get_closest(wrong, _get_suggests(command.stderr))
-    return command.script.replace(' {}'.format(wrong), ' {}'.format(correct), 1)
+    return replace_argument(command.script, wrong, correct)

thefuck/rules/lein_not_task.py

@@ -1,5 +1,5 @@
 import re
-from thefuck.utils import sudo_support
+from thefuck.utils import sudo_support, replace_argument
 
 
 @sudo_support
@@ -15,4 +15,4 @@ def get_new_command(command, settings):
                             command.stderr)[0]
     new_cmd = re.findall(r'Did you mean this\?\n\s*([^\n]*)',
                          command.stderr)[0]
-    return command.script.replace(broken_cmd, new_cmd, 1)
+    return replace_argument(command.script, broken_cmd, new_cmd)

thefuck/rules/no_command.py

@@ -1,5 +1,5 @@
 from difflib import get_close_matches
-from thefuck.utils import sudo_support, get_all_executables
+from thefuck.utils import sudo_support, get_all_executables, get_closest
 
 
 @sudo_support
@@ -12,8 +12,7 @@ def match(command, settings):
 @sudo_support
 def get_new_command(command, settings):
     old_command = command.script.split(' ')[0]
-    new_command = get_close_matches(old_command,
-                                    get_all_executables())[0]
+    new_command = get_closest(old_command, get_all_executables())
     return ' '.join([new_command] + command.script.split(' ')[1:])
 
 

thefuck/rules/pip_unknown_command.py

@@ -1,4 +1,5 @@
 import re
+from thefuck.utils import replace_argument
 
 
 def match(command, settings):
@@ -12,4 +13,4 @@ def get_new_command(command, settings):
                             command.stderr)[0]
     new_cmd = re.findall(r'maybe you meant \"([a-z]+)\"', command.stderr)[0]
 
-    return command.script.replace(broken_cmd, new_cmd, 1)
+    return replace_argument(command.script, broken_cmd, new_cmd)

thefuck/rules/sudo.py

@@ -13,7 +13,7 @@ patterns = ['permission denied',
             'must be root',
             'need to be root',
             'need root',
-            'only root can do that',
+            'only root can ',
             'You don\'t have access to the history DB.',
             'authentication is required']
 

thefuck/rules/tmux.py

@@ -1,4 +1,4 @@
-from thefuck.utils import get_closest
+from thefuck.utils import get_closest, replace_argument
 import re
 
 
@@ -17,4 +17,4 @@ def get_new_command(command, settings):
 
     new_cmd = get_closest(old_cmd, suggestions)
 
-    return command.script.replace(old_cmd, new_cmd)
+    return replace_argument(command.script, old_cmd, new_cmd)

thefuck/shells.py

@@ -194,7 +194,7 @@ class Tcsh(Generic):
     def app_alias(self, fuck):
         return ("alias {0} 'setenv TF_ALIAS {0} && "
                 "set fucked_cmd=`history -h 2 | head -n 1` && "
-                "eval `thefuck ${fucked_cmd}`'").format(fuck)
+                "eval `thefuck ${{fucked_cmd}}`'").format(fuck)
 
     def _parse_alias(self, alias):
         name, value = alias.split("\t", 1)

thefuck/utils.py

@@ -148,3 +148,14 @@ def get_all_executables():
             for exe in _safe(lambda: list(Path(path).iterdir()), [])
             if not _safe(exe.is_dir, True)] + [
                 alias for alias in get_aliases() if alias != tf_alias]
+
+
+def replace_argument(script, from_, to):
+    """Replaces command line argument."""
+    replaced_in_the_end = re.sub(u' {}$'.format(from_), u' {}'.format(to),
+                                 script, count=1)
+    if replaced_in_the_end != script:
+        return replaced_in_the_end
+    else:
+        return script.replace(
+            u' {} '.format(from_), u' {} '.format(to), 1)

tox.ini

@@ -3,4 +3,4 @@ envlist = py27,py33,py34
 
 [testenv]
 deps = -rrequirements.txt
-commands = py.test
+commands = py.test -v --capture=sys