sascha/workload-automation
1
0
Fork 0
mirror of https://github.com/ARM-software/workload-automation.git synced 2025-02-07 05:31:21 +00:00
Code Issues Releases Wiki Activity

config/core: Fix handling of depreciated parameters

Browse Source 
Provide warning to user when attempting to set a depreciated
parameter instead of during validation and only raise the warning
if a value has been explicitly provided.
This commit is contained in:
Marc Bonnici 2020-06-11 11:51:41 +01:00
parent 443358f513
commit f664a00bdc
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
wa/framework/configuration/core.py
View File

@ -290,6 +290,9 @@ class ConfigurationPoint(object):
def set_value(self, obj, value=None, check_mandatory=True): def set_value(self, obj, value=None, check_mandatory=True):
if self.deprecated: if self.deprecated:
if value is not None:
msg = 'Depreciated parameter supplied for "{}" in "{}". The value will be ignored.'
logger.warning(msg.format(self.name, obj.name))
return return
if value is None: if value is None:
if self.default is not None: if self.default is not None:
@ -312,11 +315,9 @@ class ConfigurationPoint(object):
setattr(obj, self.name, value) setattr(obj, self.name, value)
def validate(self, obj, check_mandatory=True): def validate(self, obj, check_mandatory=True):
value = getattr(obj, self.name, None)
if self.deprecated: if self.deprecated:
msg = 'Depreciated parameter supplied for "{}" in "{}". The value will be ignored.'
logger.warning(msg.format(self.name, obj.name))
return return
value = getattr(obj, self.name, None)
if value is not None: if value is not None:
self.validate_value(obj.name, value) self.validate_value(obj.name, value)
else: else: