From e1518e8c5d34ba86e6059f9960728bf746a02c89 Mon Sep 17 00:00:00 2001 From: Marc Bonnici Date: Thu, 31 May 2018 09:55:01 +0100 Subject: [PATCH] fw/rt_config: Refactor and fix method calls to resolve 'max'/'min' Previously incorrect method calls were used to try and convert 'max' and 'min' into their corresponding frequencies, now call the correct methods and refactor the conversion into a separate method. --- wa/framework/target/runtime_config.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/wa/framework/target/runtime_config.py b/wa/framework/target/runtime_config.py index 6f62860b..ae63a7f8 100644 --- a/wa/framework/target/runtime_config.py +++ b/wa/framework/target/runtime_config.py @@ -542,13 +542,9 @@ class CpufreqRuntimeConfig(RuntimeConfig): config.get('governor'), config.get('governor_tunables')) - frequency = config.get('frequency') - if frequency == 'min': - frequency = self.target.cpufreq.get_min_frequency(cpu) - elif frequency == 'max': - frequency = self.target.cpufreq.get_max_frequency(cpu) + freq = self._resolve_freq(config.get('frequency'), cpu) self.configure_frequency(cpu, - frequency, + freq, config.get('min_frequency'), config.get('max_frequency'), config.get('governor')) @@ -582,6 +578,13 @@ class CpufreqRuntimeConfig(RuntimeConfig): else: self._set_min_max_frequencies(cpu, min_freq, max_freq) + def _resolve_freq(self, value, cpu): + if value == 'min': + value = self.target.cpufreq.get_min_available_frequency(cpu) + elif value == 'max': + value = self.target.cpufreq.get_max_available_frequency(cpu) + return value + def _set_frequency(self, cpu, freq, governor): if not governor: governor = self.target.cpufreq.get_governor(cpu)