From 548eb99bdc6931e5c2e9d685b95f2821dcdb5359 Mon Sep 17 00:00:00 2001 From: Marc Bonnici Date: Fri, 4 Aug 2017 14:17:57 +0100 Subject: [PATCH 1/3] workloads/rt-app: Removed absoulte path in documentation Removed dynamically populated existing configs path from doc string as this is also used to generate the online documentation and therefore should not be an absolute path. --- wlauto/workloads/rt_app/__init__.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/wlauto/workloads/rt_app/__init__.py b/wlauto/workloads/rt_app/__init__.py index 9bc492f7..f570d273 100644 --- a/wlauto/workloads/rt_app/__init__.py +++ b/wlauto/workloads/rt_app/__init__.py @@ -99,7 +99,8 @@ class RtApp(Workload): } } - Please refer to the exising configs in ``%s`` for more examples. + Please refer to the existing configs in ``$WA_ROOT/wlauto/workloads/rt_app/use_case`` + for more examples. The version of rt-app currently used with this workload contains enhancements and modifications done by Linaro. The source code for this version may be obtained here: @@ -110,7 +111,7 @@ class RtApp(Workload): https://github.com/scheduler-tools/rt-app - """ % PACKAGED_USE_CASE_DIRECTORY + """ parameters = [ Parameter('config', kind=str, default='taskset', From f9db0a37986ba113616a7cce19c918aee82a0f9c Mon Sep 17 00:00:00 2001 From: Marc Bonnici Date: Fri, 4 Aug 2017 14:23:46 +0100 Subject: [PATCH 2/3] workloads/rt-app: Fixes typos --- wlauto/workloads/rt_app/__init__.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/wlauto/workloads/rt_app/__init__.py b/wlauto/workloads/rt_app/__init__.py index f570d273..1ef8a20d 100644 --- a/wlauto/workloads/rt_app/__init__.py +++ b/wlauto/workloads/rt_app/__init__.py @@ -40,7 +40,7 @@ class RtApp(Workload): name = 'rt-app' description = """ - A test application that simulates cofigurable real-time periodic load. + A test application that simulates configurable real-time periodic load. rt-app is a test application that starts multiple periodic threads in order to simulate a real-time periodic load. It supports SCHED_OTHER, SCHED_FIFO, @@ -117,19 +117,19 @@ class RtApp(Workload): Parameter('config', kind=str, default='taskset', description=''' Use case configuration file to run with rt-app. This may be - either the name of one of the "standard" configuratons included + either the name of one of the "standard" configurations included with the workload. or a path to a custom JSON file provided by the user. Either way, the ".json" extension is implied and will be added automatically if not specified in the argument. - The following is th list of standard configuraionts currently + The following is the list of standard configurations currently included with the workload: {} '''.format(', '.join(os.listdir(PACKAGED_USE_CASE_DIRECTORY)))), Parameter('duration', kind=int, description=''' Duration of the workload execution in Seconds. If specified, this - will override the corresponing parameter in the JSON config. + will override the corresponding parameter in the JSON config. '''), Parameter('taskset_mask', kind=int, description='Constrain execution to specific CPUs.'), @@ -141,7 +141,7 @@ class RtApp(Workload): Parameter('force_install', kind=bool, default=False, description=""" If set to ``True``, rt-app binary will always be deployed to the - target device at the begining of the run, regardless of whether it + target device at the beginning of the run, regardless of whether it was already installed there. """), ] From 16b302679a3de6ba7b31ae4373fbd9bf176b9b03 Mon Sep 17 00:00:00 2001 From: Marc Bonnici Date: Fri, 4 Aug 2017 15:39:18 +0100 Subject: [PATCH 3/3] workloads/appshare: Fixes missing new line in doc string --- wlauto/workloads/appshare/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/wlauto/workloads/appshare/__init__.py b/wlauto/workloads/appshare/__init__.py index d8bb649b..0c3e81b2 100755 --- a/wlauto/workloads/appshare/__init__.py +++ b/wlauto/workloads/appshare/__init__.py @@ -43,6 +43,7 @@ class AppShare(AndroidUxPerfWorkload): screen UI is dependent on an existing connection. Test description: + 1. GooglePhotos is started in offline access mode 1.1. The welcome screen is dismissed 1.2. Any promotion popup is dismissed