1
0
mirror of https://github.com/ARM-software/workload-automation.git synced 2025-02-20 11:58:55 +00:00

fw/target/descriptor: fixes

- fix TargetDescription._set to set lists rather than dicts for params
  to be consistent with how params are set after creation (should
  probably get rid of this entirely...)
- fix the comment describing the structure of TARGETS
This commit is contained in:
Sergei Trofimov 2018-03-01 16:32:12 +00:00 committed by Marc Bonnici
parent 879dfc7700
commit 9303c70727

View File

@ -117,10 +117,10 @@ class TargetDescription(object):
def _set(self, attr, vals):
if vals is None:
vals = {}
vals = []
elif isiterable(vals):
if not hasattr(vals, 'iteritems'):
vals = {v.name: v for v in vals}
if hasattr(vals, 'values'):
vals = v.values()
else:
msg = '{} must be iterable; got "{}"'
raise ValueError(msg.format(attr, vals))
@ -374,7 +374,7 @@ CONNECTION_PARAMS['ChromeOsConnection'] = \
CONNECTION_PARAMS[AdbConnection] + CONNECTION_PARAMS[SshConnection]
# name --> ((target_class, conn_class), params_list, defaults, assistant_class)
# name --> ((target_class, conn_class), params_list, defaults)
TARGETS = {
'linux': ((LinuxTarget, SshConnection), COMMON_TARGET_PARAMS, None),
'android': ((AndroidTarget, AdbConnection), COMMON_TARGET_PARAMS +