1
0
mirror of https://github.com/ARM-software/workload-automation.git synced 2024-10-06 02:41:11 +01:00

Pylint fixes

- apklaunch: ignore package (re-)assignment outside init.
- applaunch: factored out part of result processing into a separate
  method.
This commit is contained in:
Sergei Trofimov 2016-01-22 12:11:01 +00:00
parent 98b19328de
commit 85fb5e3684
2 changed files with 17 additions and 14 deletions

View File

@ -41,7 +41,7 @@ class ApkLaunchWorkload(Workload):
def setup(self, context):
apk_file = context.resolver.get(File(self, self.apk_file))
self.package = ApkInfo(apk_file).package
self.package = ApkInfo(apk_file).package # pylint: disable=attribute-defined-outside-init
self.logger.info('Installing {}'.format(apk_file))
return self.device.install(apk_file)

View File

@ -138,19 +138,7 @@ class ApplaunchWorkload(Workload):
scheduler_used = scheduler[scheduler.index("[") + 1:scheduler.index("]")]
metric_suffix = '_' + scheduler_used
for filename in result_files:
host_result_file = os.path.join(context.output_directory, filename)
device_result_file = self.device.path.join(self.device.working_directory, filename)
self.device.pull_file(device_result_file, host_result_file)
with open(host_result_file) as fh:
if filename == 'time.result':
values = [v / 1000 for v in map(int, fh.read().split())]
_add_metric(context, 'time' + metric_suffix, values, 'Seconds')
else:
metric = filename.replace('.result', '').lower()
numbers = iter(map(int, fh.read().split()))
deltas = [(after - before) / 1000000 for before, after in zip(numbers, numbers)]
_add_metric(context, metric, deltas, 'Joules')
self._extract_results_from_file(context, filename, metric_suffix)
def teardown(self, context):
if self.set_launcher_affinity:
@ -178,6 +166,21 @@ class ApplaunchWorkload(Workload):
command = 'taskset -p 0x{:X} {}'.format(self._old_launcher_affinity, self._launcher_pid)
self.device.execute(command, busybox=True, as_root=True)
def _extract_results_from_file(self, context, filename, metric_suffix):
host_result_file = os.path.join(context.output_directory, filename)
device_result_file = self.device.path.join(self.device.working_directory, filename)
self.device.pull_file(device_result_file, host_result_file)
with open(host_result_file) as fh:
if filename == 'time.result':
values = [v / 1000 for v in map(int, fh.read().split())]
_add_metric(context, 'time' + metric_suffix, values, 'Seconds')
else:
metric = filename.replace('.result', '').lower()
numbers = iter(map(int, fh.read().split()))
deltas = [(after - before) / 1000000 for before, after in zip(numbers, numbers)]
_add_metric(context, metric, deltas, 'Joules')
def _add_metric(context, metric, values, units):
mean, sd = get_meansd(values)