sascha/workload-automation
1
0
Fork 0
mirror of https://github.com/ARM-software/workload-automation.git synced 2025-09-03 03:42:35 +01:00
Code Issues Releases Wiki Activity

output_processors: Move variable initialization to __init__

Browse Source 
In the case of a failure in the initialization of one output_processor the
remaining `initialize` methods may not get called causing variables to
not be initialized correctly.
This commit is contained in:
Marc Bonnici
2018-09-20 17:04:55 +01:00
parent 5dcac0c8ef
commit 6632223ac5
3 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
wa/output_processors/csvproc.py
View File

@@ -49,6 +49,11 @@ class CsvReportProcessor(OutputProcessor):
"""),
]
def __init__(self, *args, **kwargs):
super(CsvReportProcessor, self).__init__(*args, **kwargs)
self.outputs_so_far = []
self.artifact_added = False
def validate(self):
super(CsvReportProcessor, self).validate()
if self.use_all_classifiers and self.extra_columns:
@@ -56,11 +61,6 @@ class CsvReportProcessor(OutputProcessor):
'use_all_classifiers is True'
raise ConfigError(msg)
def initialize(self, context):
# pylint: disable=attribute-defined-outside-init
self.outputs_so_far = []
self.artifact_added = False
# pylint: disable=unused-argument
def process_job_output(self, output, target_info, run_output):
self.outputs_so_far.append(output)