From 30471613dec75f34a702528c6e3ae19766d71c04 Mon Sep 17 00:00:00 2001 From: Marc Bonnici Date: Tue, 3 Jul 2018 14:09:34 +0100 Subject: [PATCH] wa/output_processors: pylint fixes --- wa/output_processors/cpustates.py | 5 ++--- wa/output_processors/csvproc.py | 5 ++--- wa/output_processors/sqlite.py | 4 ++-- wa/output_processors/status.py | 3 +-- wa/output_processors/targz.py | 4 +--- wa/output_processors/uxperf.py | 1 + 6 files changed, 9 insertions(+), 13 deletions(-) diff --git a/wa/output_processors/cpustates.py b/wa/output_processors/cpustates.py index ecab9b80..70e63e9e 100755 --- a/wa/output_processors/cpustates.py +++ b/wa/output_processors/cpustates.py @@ -13,13 +13,11 @@ # limitations under the License. # -import os from collections import OrderedDict from devlib.utils.csvutil import csvwriter from wa import OutputProcessor, Parameter -from wa.utils.types import list_of_strings from wa.utils.cpustates import report_power_stats @@ -90,7 +88,7 @@ class CpuStatesProcessor(OutputProcessor): def initialize(self): self.iteration_reports = OrderedDict() - def process_job_output(self, output, target_info, run_output): + def process_job_output(self, output, target_info, run_output): #pylint: disable=unused-argument trace_file = output.get_artifact_path('trace-cmd-txt') if not trace_file: self.logger.warning('Text trace does not appear to have been generated; skipping this iteration.') @@ -112,6 +110,7 @@ class CpuStatesProcessor(OutputProcessor): iteration_id = (output.id, output.label, output.iteration) self.iteration_reports[iteration_id] = reports + #pylint: disable=too-many-locals,unused-argument def process_run_output(self, output, target_info): if not self.iteration_reports: self.logger.warning('No power state reports generated.') diff --git a/wa/output_processors/csvproc.py b/wa/output_processors/csvproc.py index 4f26a6cd..6c7c0ce0 100644 --- a/wa/output_processors/csvproc.py +++ b/wa/output_processors/csvproc.py @@ -13,8 +13,6 @@ # limitations under the License. # -import sys - from devlib.utils.csvutil import csvwriter from wa import OutputProcessor, Parameter @@ -62,6 +60,7 @@ class CsvReportProcessor(OutputProcessor): self.outputs_so_far = [] # pylint: disable=attribute-defined-outside-init self.artifact_added = False + #pylint: disable=unused-argument def process_job_output(self, output, target_info, run_output): self.outputs_so_far.append(output) self._write_outputs(self.outputs_so_far, run_output) @@ -69,7 +68,7 @@ class CsvReportProcessor(OutputProcessor): run_output.add_artifact('run_result_csv', 'results.csv', 'export') self.artifact_added = True - def process_run_output(self, output, target_info): + def process_run_output(self, output, target_info): #pylint: disable=unused-argument self.outputs_so_far.append(output) self._write_outputs(self.outputs_so_far, output) if not self.artifact_added: diff --git a/wa/output_processors/sqlite.py b/wa/output_processors/sqlite.py index 0b2f2076..935c84c1 100644 --- a/wa/output_processors/sqlite.py +++ b/wa/output_processors/sqlite.py @@ -115,7 +115,7 @@ class SqliteResultProcessor(OutputProcessor): self._spec_oid = None self._run_initialized = False - def export_job_output(self, job_output, target_info, run_output): + def export_job_output(self, job_output, target_info, run_output): #pylint: disable=unused-argument if not self._run_initialized: self._init_run(run_output) @@ -128,7 +128,7 @@ class SqliteResultProcessor(OutputProcessor): with self._open_connection() as conn: conn.executemany('INSERT INTO metrics VALUES (?,?,?,?,?,?)', metrics) - def export_run_output(self, run_output, target_info): + def export_run_output(self, run_output, target_info): #pylint: disable=unused-argument if not self._run_initialized: self._init_run(run_output) diff --git a/wa/output_processors/status.py b/wa/output_processors/status.py index 8b3e69dc..5a6dcb5d 100644 --- a/wa/output_processors/status.py +++ b/wa/output_processors/status.py @@ -30,7 +30,7 @@ class StatusTxtReporter(OutputProcessor): """ - def process_run_output(self, output, target_info): + def process_run_output(self, output, target_info): #pylint: disable=unused-argument counter = Counter() for jo in output.jobs: counter[jo.status] += 1 @@ -55,4 +55,3 @@ class StatusTxtReporter(OutputProcessor): write_table(status_lines, wfh, align='<<>><') output.add_artifact('run_status_summary', 'status.txt', 'export') - diff --git a/wa/output_processors/targz.py b/wa/output_processors/targz.py index 17e8f39e..8dac5c1c 100644 --- a/wa/output_processors/targz.py +++ b/wa/output_processors/targz.py @@ -61,7 +61,7 @@ class TargzProcessor(OutputProcessor): self.logger.debug('Registering RUN_FINALIZED handler.') signal.connect(self.delete_output_directory, signal.RUN_FINALIZED, priority=-100) - def export_run_output(self, run_output, target_info): + def export_run_output(self, run_output, target_info): #pylint: disable=unused-argument if self.outfile: outfile_path = self.outfile.format(**run_output.info.to_pod()) else: @@ -74,5 +74,3 @@ class TargzProcessor(OutputProcessor): def delete_output_directory(self, context): self.logger.debug('Deleting output directory') shutil.rmtree(context.run_output.basepath) - - diff --git a/wa/output_processors/uxperf.py b/wa/output_processors/uxperf.py index 830ec502..843c5e36 100644 --- a/wa/output_processors/uxperf.py +++ b/wa/output_processors/uxperf.py @@ -30,6 +30,7 @@ class UxperfProcessor(OutputProcessor): a agenda file by setting ``markers_enabled`` for the workload to ``True``. ''' + #pylint: disable=too-many-locals,unused-argument def process_job_output(self, output, target_info, job_output): logcat = output.get_artifact('logcat') if not logcat: