From 2cd355195fed8918022288140240626ad5aea0e9 Mon Sep 17 00:00:00 2001 From: Marc Bonnici Date: Fri, 1 Jun 2018 10:47:40 +0100 Subject: [PATCH] fw/rt_config: Fix validation checks Remove unnecessary validation checks and fix remaining so they don't fail under certain combinations of parameters. --- wa/framework/target/runtime_config.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/wa/framework/target/runtime_config.py b/wa/framework/target/runtime_config.py index ccefef16..7d2b2f84 100644 --- a/wa/framework/target/runtime_config.py +++ b/wa/framework/target/runtime_config.py @@ -528,12 +528,9 @@ class CpufreqRuntimeConfig(RuntimeConfig): msg = 'CPU{}: Can\'t set both cpu frequency and maximum frequency' raise ConfigError(msg.format(cpu)) - if maxf and minf > maxf: + if (maxf and minf) and self._resolve_freq(minf, cpu) > self._resolve_freq(maxf, cpu): msg = 'CPU{}: min_frequency "{}" cannot be greater than max_frequency "{}"' raise ConfigError(msg.format(cpu, minf, maxf)) - if maxf and freq > maxf: - msg = 'CPU{}: cpu frequency "{}" cannot be greater than max_frequency "{}"' - raise ConfigError(msg.format(cpu, freq, maxf)) def commit(self): for cpu in self.config: