From 2276ae0c5b54fa7a3bc3bd990eeae75956a078cb Mon Sep 17 00:00:00 2001 From: Sergei Trofimov Date: Fri, 17 Apr 2015 15:56:28 +0100 Subject: [PATCH] Fixing config processing for extensions with non-identifier names. Internally, WA expects extension names to be valid Python identifiers. When this is not the case, conversion takes place when loading configuration for the extension (e.g. "trace-cmd" gets converted to "trace_cmd"). The conversion is intended to be transparent to the user, so configuration stores values as they are provided by the user, however it needs to perform the conversion internally, e.g. when querying ExtensionLoader. This conversion was missing when performing a lookup of one of the internal structures, which was causing earlier-collected settings to not be propagated into the final config. --- wlauto/core/configuration.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wlauto/core/configuration.py b/wlauto/core/configuration.py index 432e55ae..9564934b 100644 --- a/wlauto/core/configuration.py +++ b/wlauto/core/configuration.py @@ -668,7 +668,7 @@ class RunConfiguration(object): raw_list = self._raw_config.get(attr_name, []) for extname in raw_list: default_config = self.ext_loader.get_default_config(extname) - ext_config[extname] = self._raw_config.get(extname, default_config) + ext_config[extname] = self._raw_config.get(identifier(extname), default_config) list_name = '_global_{}'.format(attr_name) setattr(self, list_name, raw_list) setattr(self, attr_name, ext_config)