sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-11-01 23:51:47 +00:00
Code Issues Releases Wiki Activity

preen

Browse Source
This commit is contained in:
J. Nick Koston
2025-10-30 15:20:50 -05:00
parent 3552d29167
commit f86c74ff02
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
esphome/components/select/select_call.cpp
View File

@@ -13,7 +13,7 @@ SelectCall &SelectCall::set_option(const std::string &option) {
SelectCall &SelectCall::set_option(const char *option) { return with_operation(SELECT_OP_SET).with_option(option); } SelectCall &SelectCall::set_option(const char *option) { return with_operation(SELECT_OP_SET).with_option(option); }
SelectCall &SelectCall::set_index(size_t index) { return with_operation(SELECT_OP_SET_INDEX).with_index(index); } SelectCall &SelectCall::set_index(size_t index) { return with_operation(SELECT_OP_SET).with_index(index); }
SelectCall &SelectCall::select_next(bool cycle) { return with_operation(SELECT_OP_NEXT).with_cycle(cycle); } SelectCall &SelectCall::select_next(bool cycle) { return with_operation(SELECT_OP_NEXT).with_cycle(cycle); }
@@ -61,7 +61,8 @@ optional<size_t> SelectCall::calculate_target_index_(const char *name) {
return options.size() - 1; return options.size() - 1;
} }
if (this->operation_ == SELECT_OP_SET || this->operation_ == SELECT_OP_SET_INDEX) { if (this->operation_ == SELECT_OP_SET) {
ESP_LOGD(TAG, "'%s' - Setting", name);
if (!this->index_.has_value()) { if (!this->index_.has_value()) {
ESP_LOGW(TAG, "'%s' - No option set", name); ESP_LOGW(TAG, "'%s' - No option set", name);
return {}; return {};
@@ -71,9 +72,6 @@ optional<size_t> SelectCall::calculate_target_index_(const char *name) {
ESP_LOGW(TAG, "'%s' - Index value %zu out of bounds", name, idx); ESP_LOGW(TAG, "'%s' - Index value %zu out of bounds", name, idx);
return {}; return {};
} }
if (this->operation_ == SELECT_OP_SET) {
ESP_LOGD(TAG, "'%s' - Setting", name);
}
return idx; return idx;
} }

1
esphome/components/select/select_call.h
View File

@@ -10,7 +10,6 @@ class Select;
enum SelectOperation { enum SelectOperation {
SELECT_OP_NONE, SELECT_OP_NONE,
SELECT_OP_SET, SELECT_OP_SET,
SELECT_OP_SET_INDEX,
SELECT_OP_NEXT, SELECT_OP_NEXT,
SELECT_OP_PREVIOUS, SELECT_OP_PREVIOUS,
SELECT_OP_FIRST, SELECT_OP_FIRST,