mirror of
https://github.com/esphome/esphome.git
synced 2025-10-03 18:42:23 +01:00
Apply suggestions from code review
This commit is contained in:
@@ -31,7 +31,6 @@ CODEOWNERS = ["@jesserockz", "@clydebarrow", "@Rapsssito"]
|
|||||||
DEPENDENCIES = ["esp32"]
|
DEPENDENCIES = ["esp32"]
|
||||||
DOMAIN = "esp32_ble_server"
|
DOMAIN = "esp32_ble_server"
|
||||||
|
|
||||||
|
|
||||||
CONF_ADVERTISE = "advertise"
|
CONF_ADVERTISE = "advertise"
|
||||||
CONF_APPEARANCE = "appearance"
|
CONF_APPEARANCE = "appearance"
|
||||||
CONF_BROADCAST = "broadcast"
|
CONF_BROADCAST = "broadcast"
|
||||||
@@ -505,7 +504,6 @@ async def to_code_characteristic(service_var, char_conf):
|
|||||||
parse_properties(char_conf),
|
parse_properties(char_conf),
|
||||||
),
|
),
|
||||||
)
|
)
|
||||||
|
|
||||||
if CONF_ON_WRITE in char_conf:
|
if CONF_ON_WRITE in char_conf:
|
||||||
on_write_conf = char_conf[CONF_ON_WRITE]
|
on_write_conf = char_conf[CONF_ON_WRITE]
|
||||||
cg.add_define("USE_ESP32_BLE_SERVER_CHARACTERISTIC_ON_WRITE")
|
cg.add_define("USE_ESP32_BLE_SERVER_CHARACTERISTIC_ON_WRITE")
|
||||||
@@ -585,7 +583,6 @@ async def to_code(config):
|
|||||||
[(cg.uint16, "id")],
|
[(cg.uint16, "id")],
|
||||||
config[CONF_ON_DISCONNECT],
|
config[CONF_ON_DISCONNECT],
|
||||||
)
|
)
|
||||||
|
|
||||||
cg.add_define("USE_ESP32_BLE_SERVER")
|
cg.add_define("USE_ESP32_BLE_SERVER")
|
||||||
cg.add_define("USE_ESP32_BLE_ADVERTISING")
|
cg.add_define("USE_ESP32_BLE_ADVERTISING")
|
||||||
add_idf_sdkconfig_option("CONFIG_BT_ENABLED", True)
|
add_idf_sdkconfig_option("CONFIG_BT_ENABLED", True)
|
||||||
|
Reference in New Issue
Block a user