sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-31 15:12:06 +00:00
Code Issues Releases Wiki Activity

Merge branch 'loop_fix' into integration

Browse Source
This commit is contained in:
J. Nick Koston
2025-07-22 23:52:08 -10:00
parent bfae905a2b 77c8363946
commit dee58804e8
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
esphome/core/application.cpp
View File

@@ -271,16 +271,26 @@ void Application::calculate_looping_components_() {
// Pre-reserve vector to avoid reallocations // Pre-reserve vector to avoid reallocations
this->looping_components_.reserve(total_looping); this->looping_components_.reserve(total_looping);
// Add all components with loop override // Add all components with loop override that aren't already LOOP_DONE
// When called at start of setup, all components are in CONSTRUCTION state // Some components (like logger) may call disable_loop() during initialization
// so none will be LOOP_DONE yet - they'll all go in the active section // before setup runs, so we need to respect their LOOP_DONE state
for (auto *obj : this->components_) { for (auto *obj : this->components_) {
if (obj->has_overridden_loop()) { if (obj->has_overridden_loop() &&
(obj->get_component_state() & COMPONENT_STATE_MASK) != COMPONENT_STATE_LOOP_DONE) {
this->looping_components_.push_back(obj); this->looping_components_.push_back(obj);
} }
} }
this->looping_components_active_end_ = this->looping_components_.size(); this->looping_components_active_end_ = this->looping_components_.size();
// Then add any components that are already LOOP_DONE to the inactive section
// This handles components that called disable_loop() during initialization
for (auto *obj : this->components_) {
if (obj->has_overridden_loop() &&
(obj->get_component_state() & COMPONENT_STATE_MASK) == COMPONENT_STATE_LOOP_DONE) {
this->looping_components_.push_back(obj);
}
}
} }
void Application::disable_component_loop_(Component *component) { void Application::disable_component_loop_(Component *component) {