mirror of
https://github.com/esphome/esphome.git
synced 2025-09-09 06:42:20 +01:00
comments
This commit is contained in:
@@ -759,6 +759,11 @@ void Scheduler::recycle_item_(std::unique_ptr<SchedulerItem> item) {
|
|||||||
if (!item)
|
if (!item)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
|
// Pool size of 8 is a balance between memory usage and performance:
|
||||||
|
// - Small enough to not waste memory on simple configs (1-2 timers)
|
||||||
|
// - Large enough to handle complex setups with multiple sensors/components
|
||||||
|
// - Prevents system-wide stalls from heap allocation/deallocation that can
|
||||||
|
// disrupt task synchronization and cause dropped events
|
||||||
static constexpr size_t MAX_POOL_SIZE = 8;
|
static constexpr size_t MAX_POOL_SIZE = 8;
|
||||||
if (this->scheduler_item_pool_.size() < MAX_POOL_SIZE) {
|
if (this->scheduler_item_pool_.size() < MAX_POOL_SIZE) {
|
||||||
// Clear callback to release captured resources
|
// Clear callback to release captured resources
|
||||||
|
@@ -322,7 +322,14 @@ class Scheduler {
|
|||||||
#endif /* ESPHOME_THREAD_SINGLE */
|
#endif /* ESPHOME_THREAD_SINGLE */
|
||||||
uint32_t to_remove_{0};
|
uint32_t to_remove_{0};
|
||||||
|
|
||||||
// Memory pool for recycling SchedulerItem objects
|
// Memory pool for recycling SchedulerItem objects to reduce heap churn.
|
||||||
|
// Design decisions:
|
||||||
|
// - std::vector is used instead of a fixed array because many systems only need 1-2 scheduler items
|
||||||
|
// - The vector grows dynamically up to MAX_POOL_SIZE (8) only when needed, saving memory on simple setups
|
||||||
|
// - This approach balances memory efficiency for simple configs with performance for complex ones
|
||||||
|
// - The pool significantly reduces heap fragmentation which is critical because heap allocation/deallocation
|
||||||
|
// can stall the entire system, causing timing issues and dropped events for any components that need
|
||||||
|
// to synchronize between tasks (see https://github.com/esphome/backlog/issues/52)
|
||||||
std::vector<std::unique_ptr<SchedulerItem>> scheduler_item_pool_;
|
std::vector<std::unique_ptr<SchedulerItem>> scheduler_item_pool_;
|
||||||
|
|
||||||
#ifdef ESPHOME_THREAD_MULTI_ATOMICS
|
#ifdef ESPHOME_THREAD_MULTI_ATOMICS
|
||||||
|
Reference in New Issue
Block a user