sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-31 15:12:06 +00:00
Code Issues Releases Wiki Activity

dashboard: Run get_serial_ports in the executor

Browse Source 
get_serial_ports does blocking I/O and should not be running
in tornado event loop
This commit is contained in:
J. Nick Koston
2023-11-12 18:17:17 -06:00
parent 53f3385c49
commit cad53556a5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
esphome/dashboard/dashboard.py
View File

@@ -509,8 +509,8 @@ class EsphomeUpdateAllHandler(EsphomeCommandWebSocket):
class SerialPortRequestHandler(BaseHandler): class SerialPortRequestHandler(BaseHandler):
@authenticated @authenticated
def get(self): async def get(self):
ports = get_serial_ports() ports = await tornado.ioloop.IOLoop.run_in_executor(None, get_serial_ports)
data = [] data = []
for port in ports: for port in ports:
desc = port.description desc = port.description