From 772450f1b3ebf07100da4606e4e614fe9ae50ff0 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Thu, 2 Oct 2025 11:43:27 +0200 Subject: [PATCH 1/2] no mod --- esphome/components/logger/logger.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/esphome/components/logger/logger.h b/esphome/components/logger/logger.h index 7d4c14df0b..867b8949b3 100644 --- a/esphome/components/logger/logger.h +++ b/esphome/components/logger/logger.h @@ -355,9 +355,12 @@ class Logger : public Component { buffer[pos++] = '['; copy_string(buffer, pos, tag); buffer[pos++] = ':'; - buffer[pos++] = '0' + (line / 100) % 10; - buffer[pos++] = '0' + (line / 10) % 10; - buffer[pos++] = '0' + line % 10; + int hundreds = line / 100; + line -= hundreds * 100; + int tens = line / 10; + buffer[pos++] = '0' + hundreds; + buffer[pos++] = '0' + tens; + buffer[pos++] = '0' + (line - tens * 10); buffer[pos++] = ']'; #if defined(USE_ESP32) || defined(USE_LIBRETINY) || defined(USE_ZEPHYR) From a4cb14a76a854568102d3f34ddcc474bed885e59 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Thu, 2 Oct 2025 13:18:19 +0200 Subject: [PATCH 2/2] Apply Copilot review suggestion: use remainder variable instead of modifying line parameter --- esphome/components/logger/logger.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/esphome/components/logger/logger.h b/esphome/components/logger/logger.h index 867b8949b3..a1f3df97dd 100644 --- a/esphome/components/logger/logger.h +++ b/esphome/components/logger/logger.h @@ -356,11 +356,11 @@ class Logger : public Component { copy_string(buffer, pos, tag); buffer[pos++] = ':'; int hundreds = line / 100; - line -= hundreds * 100; - int tens = line / 10; + int remainder = line - hundreds * 100; + int tens = remainder / 10; buffer[pos++] = '0' + hundreds; buffer[pos++] = '0' + tens; - buffer[pos++] = '0' + (line - tens * 10); + buffer[pos++] = '0' + (remainder - tens * 10); buffer[pos++] = ']'; #if defined(USE_ESP32) || defined(USE_LIBRETINY) || defined(USE_ZEPHYR)