From c1b5139f011d40c7a1b454a83c238bd1b83fc79d Mon Sep 17 00:00:00 2001 From: Oliver Kleinecke Date: Sat, 15 Feb 2025 14:23:58 +0100 Subject: [PATCH] fix: update output management in DynamicLamp to use pointers for consistency --- esphome/components/dynamic_lamp/dynamic_lamp.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/esphome/components/dynamic_lamp/dynamic_lamp.cpp b/esphome/components/dynamic_lamp/dynamic_lamp.cpp index 01b4af31b0..79c21c5c61 100644 --- a/esphome/components/dynamic_lamp/dynamic_lamp.cpp +++ b/esphome/components/dynamic_lamp/dynamic_lamp.cpp @@ -34,10 +34,10 @@ void DynamicLamp::begin() { } /* keep example for future reference this->add_lamp_("First Lamp"); - this->add_lamp_output_("First Lamp", this->available_outputs_[0]); - this->add_lamp_output_("First Lamp", this->available_outputs_[1]); - this->add_lamp_output_("First Lamp", this->available_outputs_[2]); - this->add_lamp_output_("First Lamp", this->available_outputs_[3]); + this->add_lamp_output_("First Lamp", &this->available_outputs_[0]); + this->add_lamp_output_("First Lamp", &this->available_outputs_[1]); + this->add_lamp_output_("First Lamp", &this->available_outputs_[2]); + this->add_lamp_output_("First Lamp", &this->available_outputs_[3]); */ } @@ -91,11 +91,6 @@ void DynamicLamp::dump_config() { ESP_LOGCONFIG(TAG, "Using output with id %s as output number %" PRIu8 "", this->available_outputs_[i].output_id.c_str(), i); } } - this->add_lamp("First Lamp"); - this->add_output_to_lamp("First Lamp", &this->available_outputs_[0]); - this->add_output_to_lamp("First Lamp", &this->available_outputs_[1]); - this->add_output_to_lamp("First Lamp", &this->available_outputs_[2]); - this->add_output_to_lamp("First Lamp", &this->available_outputs_[3]); } void DynamicLamp::set_save_mode(uint8_t save_mode) {