From ba18bb6a4fedb7946c0a462957fdbfe960bb1eb3 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Fri, 17 Oct 2025 18:18:15 -1000 Subject: [PATCH] template all the things --- script/ci_memory_impact_comment.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/script/ci_memory_impact_comment.py b/script/ci_memory_impact_comment.py index 961c304e40..5a399639f5 100755 --- a/script/ci_memory_impact_comment.py +++ b/script/ci_memory_impact_comment.py @@ -148,9 +148,11 @@ def prepare_symbol_changes_data( all_symbols = set(target_symbols.keys()) | set(pr_symbols.keys()) # Track changes - changed_symbols = [] - new_symbols = [] - removed_symbols = [] + changed_symbols: list[ + tuple[str, int, int, int] + ] = [] # (symbol, target_size, pr_size, delta) + new_symbols: list[tuple[str, int]] = [] # (symbol, size) + removed_symbols: list[tuple[str, int]] = [] # (symbol, size) for symbol in all_symbols: target_size = target_symbols.get(symbol, 0) @@ -201,7 +203,9 @@ def prepare_component_breakdown_data( all_components = set(target_analysis.keys()) | set(pr_analysis.keys()) # Filter to components that have changed (ignoring noise) - changed_components = [] + changed_components: list[ + tuple[str, int, int, int] + ] = [] # (comp, target_flash, pr_flash, delta) for comp in all_components: target_mem = target_analysis.get(comp, {}) pr_mem = pr_analysis.get(comp, {})