From b9f1611145d7efc5ea53bc0047cd9fcea85a6f6a Mon Sep 17 00:00:00 2001 From: Oliver Kleinecke Date: Wed, 19 Feb 2025 12:51:29 +0100 Subject: [PATCH] fix: ensure active lamp check in add_timer function to prevent ignoring inactive lamps --- esphome/components/dynamic_lamp/dynamic_lamp.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/esphome/components/dynamic_lamp/dynamic_lamp.cpp b/esphome/components/dynamic_lamp/dynamic_lamp.cpp index 4f5f5b3a70..9753b42f04 100644 --- a/esphome/components/dynamic_lamp/dynamic_lamp.cpp +++ b/esphome/components/dynamic_lamp/dynamic_lamp.cpp @@ -243,7 +243,7 @@ bool DynamicLampComponent::add_timer(std::string lamp_list_str, bool timer_activ DynamicLampTimer new_timer; unsigned char lamp_list_bytes[2] = {0, 0}; for (uint8_t i = 0; i < lamp_list.size(); i++) { - if (!this->active_lamps_[i].active) { + if (lamp_list[i] && !this->active_lamps_[i].active) { ESP_LOGW(TAG, "Ignoring lamp number %" PRIu8 " as there is no active lamp with that index!", i); continue; }