From 403b6e32e3fbfb1201e6680177b6332c84884ce2 Mon Sep 17 00:00:00 2001 From: Vegetto Date: Tue, 6 Apr 2021 14:31:38 +0200 Subject: [PATCH 1/2] fixes #858 - esphome crashes with neolightbus and RMT (#1667) Co-authored-by: Otto Winter --- esphome/components/neopixelbus/neopixelbus_light.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/esphome/components/neopixelbus/neopixelbus_light.h b/esphome/components/neopixelbus/neopixelbus_light.h index 46601d8345..2f279e1c9b 100644 --- a/esphome/components/neopixelbus/neopixelbus_light.h +++ b/esphome/components/neopixelbus/neopixelbus_light.h @@ -68,7 +68,8 @@ class NeoPixelBusLightOutputBase : public light::AddressableLight { void add_leds(uint16_t count_pixels) { this->add_leds(new NeoPixelBus(count_pixels)); } void add_leds(NeoPixelBus *controller) { this->controller_ = controller; - this->controller_->Begin(); + // controller gets initialised in setup() - avoid calling twice (crashes with RMT) + // this->controller_->Begin(); } // ========== INTERNAL METHODS ========== From 3b4ea0ed0ae01a31310596095a140513e822513c Mon Sep 17 00:00:00 2001 From: Jesse Hills <3060199+jesserockz@users.noreply.github.com> Date: Sun, 9 May 2021 22:37:31 +1200 Subject: [PATCH 2/2] Bump version to v1.17.2 --- esphome/const.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/esphome/const.py b/esphome/const.py index 237a356c74..8f9c80e2e3 100644 --- a/esphome/const.py +++ b/esphome/const.py @@ -2,7 +2,7 @@ MAJOR_VERSION = 1 MINOR_VERSION = 17 -PATCH_VERSION = "1" +PATCH_VERSION = "2" __short_version__ = f"{MAJOR_VERSION}.{MINOR_VERSION}" __version__ = f"{__short_version__}.{PATCH_VERSION}"