sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-02 19:32:19 +01:00
Code Issues Releases Wiki Activity

Ensure that all uses of strncpy in wifi component are safe. (#5636)

Browse Source
This commit is contained in:
Kevin P. Fleming
2023-10-31 17:30:42 -04:00
committed by GitHub
parent 193bac94f4
commit b03eb5ea0a
4 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
esphome/components/wifi/wifi_component.cpp
View File

@@ -261,8 +261,8 @@ void WiFiComponent::set_sta(const WiFiAP &ap) {
void WiFiComponent::clear_sta() { this->sta_.clear(); }
void WiFiComponent::save_wifi_sta(const std::string &ssid, const std::string &password) {
SavedWifiSettings save{};
strncpy(save.ssid, ssid.c_str(), sizeof(save.ssid));
strncpy(save.password, password.c_str(), sizeof(save.password));
strncpy(save.ssid, ssid.c_str(), sizeof(save.ssid) - 1);
strncpy(save.password, password.c_str(), sizeof(save.password) - 1);
this->pref_.save(&save);
// ensure it's written immediately
global_preferences->sync();