sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-04 20:32:21 +01:00
Code Issues Releases Wiki Activity

[api] Fix string lifetime issue in fill_and_encode_entity_info for dynamic object_id (#10482)

Browse Source
This commit is contained in:
J. Nick Koston
2025-08-28 13:40:36 -05:00
committed by GitHub
parent 75595b08be
commit a92a08c2de
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
esphome/components/api/api_connection.h
View File

@@ -303,11 +303,13 @@ class APIConnection final : public APIServerConnection {
msg.key = entity->get_object_id_hash(); msg.key = entity->get_object_id_hash();
// Try to use static reference first to avoid allocation // Try to use static reference first to avoid allocation
StringRef static_ref = entity->get_object_id_ref_for_api_(); StringRef static_ref = entity->get_object_id_ref_for_api_();
// Store dynamic string outside the if-else to maintain lifetime
std::string object_id;
if (!static_ref.empty()) { if (!static_ref.empty()) {
msg.set_object_id(static_ref); msg.set_object_id(static_ref);
} else { } else {
// Dynamic case - need to allocate // Dynamic case - need to allocate
std::string object_id = entity->get_object_id(); object_id = entity->get_object_id();
msg.set_object_id(StringRef(object_id)); msg.set_object_id(StringRef(object_id));
} }