sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-02 03:12:20 +01:00
Code Issues Releases Wiki Activity

[safe_mode] Reduce flash usage by 184 bytes through code optimization (#10284)

Browse Source
This commit is contained in:
J. Nick Koston
2025-08-19 16:57:24 -05:00
committed by GitHub
parent 2aaf951357
commit a8775ba60b
1 changed files with 36 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
esphome/components/safe_mode/safe_mode.cpp
View File

@@ -15,11 +15,11 @@ namespace safe_mode {
static const char *const TAG = "safe_mode"; static const char *const TAG = "safe_mode";
void SafeModeComponent::dump_config() { void SafeModeComponent::dump_config() {
ESP_LOGCONFIG(TAG, "Safe Mode:");
ESP_LOGCONFIG(TAG, ESP_LOGCONFIG(TAG,
" Boot considered successful after %" PRIu32 " seconds\n" "Safe Mode:\n"
" Invoke after %u boot attempts\n" " Successful after: %" PRIu32 "s\n"
" Remain for %" PRIu32 " seconds", " Invoke after: %u attempts\n"
" Duration: %" PRIu32 "s",
this->safe_mode_boot_is_good_after_ / 1000, // because milliseconds this->safe_mode_boot_is_good_after_ / 1000, // because milliseconds
this->safe_mode_num_attempts_, this->safe_mode_num_attempts_,
this->safe_mode_enable_time_ / 1000); // because milliseconds this->safe_mode_enable_time_ / 1000); // because milliseconds
@@ -27,7 +27,7 @@ void SafeModeComponent::dump_config() {
if (this->safe_mode_rtc_value_ > 1 && this->safe_mode_rtc_value_ != SafeModeComponent::ENTER_SAFE_MODE_MAGIC) { if (this->safe_mode_rtc_value_ > 1 && this->safe_mode_rtc_value_ != SafeModeComponent::ENTER_SAFE_MODE_MAGIC) {
auto remaining_restarts = this->safe_mode_num_attempts_ - this->safe_mode_rtc_value_; auto remaining_restarts = this->safe_mode_num_attempts_ - this->safe_mode_rtc_value_;
if (remaining_restarts) { if (remaining_restarts) {
ESP_LOGW(TAG, "Last reset occurred too quickly; will be invoked in %" PRIu32 " restarts", remaining_restarts); ESP_LOGW(TAG, "Last reset too quick; invoke in %" PRIu32 " restarts", remaining_restarts);
} else { } else {
ESP_LOGW(TAG, "SAFE MODE IS ACTIVE"); ESP_LOGW(TAG, "SAFE MODE IS ACTIVE");
} }
@@ -72,26 +72,33 @@ bool SafeModeComponent::should_enter_safe_mode(uint8_t num_attempts, uint32_t en
this->safe_mode_boot_is_good_after_ = boot_is_good_after; this->safe_mode_boot_is_good_after_ = boot_is_good_after;
this->safe_mode_num_attempts_ = num_attempts; this->safe_mode_num_attempts_ = num_attempts;
this->rtc_ = global_preferences->make_preference<uint32_t>(233825507UL, false); this->rtc_ = global_preferences->make_preference<uint32_t>(233825507UL, false);
this->safe_mode_rtc_value_ = this->read_rtc_();
bool is_manual_safe_mode = this->safe_mode_rtc_value_ == SafeModeComponent::ENTER_SAFE_MODE_MAGIC; uint32_t rtc_val = this->read_rtc_();
this->safe_mode_rtc_value_ = rtc_val;
if (is_manual_safe_mode) { bool is_manual = rtc_val == SafeModeComponent::ENTER_SAFE_MODE_MAGIC;
ESP_LOGI(TAG, "Safe mode invoked manually");
if (is_manual) {
ESP_LOGI(TAG, "Manual mode");
} else { } else {
ESP_LOGCONFIG(TAG, "There have been %" PRIu32 " suspected unsuccessful boot attempts", this->safe_mode_rtc_value_); ESP_LOGCONFIG(TAG, "Unsuccessful boot attempts: %" PRIu32, rtc_val);
}
if (rtc_val < num_attempts && !is_manual) {
// increment counter
this->write_rtc_(rtc_val + 1);
return false;
} }
if (this->safe_mode_rtc_value_ >= num_attempts || is_manual_safe_mode) {
this->clean_rtc(); this->clean_rtc();
if (!is_manual_safe_mode) { if (!is_manual) {
ESP_LOGE(TAG, "Boot loop detected. Proceeding"); ESP_LOGE(TAG, "Boot loop detected");
} }
this->status_set_error(); this->status_set_error();
this->set_timeout(enable_time, []() { this->set_timeout(enable_time, []() {
ESP_LOGW(TAG, "Safe mode enable time has elapsed -- restarting"); ESP_LOGW(TAG, "Timeout, restarting");
App.reboot(); App.reboot();
}); });
@@ -104,11 +111,6 @@ bool SafeModeComponent::should_enter_safe_mode(uint8_t num_attempts, uint32_t en
this->safe_mode_callback_.call(); this->safe_mode_callback_.call();
return true; return true;
} else {
// increment counter
this->write_rtc_(this->safe_mode_rtc_value_ + 1);
return false;
}
} }
void SafeModeComponent::write_rtc_(uint32_t val) { void SafeModeComponent::write_rtc_(uint32_t val) {