From a30c248c93deb87eba6ba4bc7c515e0a4b297922 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Wed, 15 Nov 2023 09:28:25 -0600 Subject: [PATCH] Ensure posix_spawn is used to execute ping when available We want to avoid the memory copy when possible, and python will not try posix_spawn unless close_fds=False https://github.com/rtomayko/posix-spawn#linux --- esphome/dashboard/dashboard.py | 1 + 1 file changed, 1 insertion(+) diff --git a/esphome/dashboard/dashboard.py b/esphome/dashboard/dashboard.py index 950386d969..2373030447 100644 --- a/esphome/dashboard/dashboard.py +++ b/esphome/dashboard/dashboard.py @@ -1068,6 +1068,7 @@ async def _async_ping_host(host: str) -> bool: stdin=asyncio.subprocess.DEVNULL, stdout=asyncio.subprocess.DEVNULL, stderr=asyncio.subprocess.DEVNULL, + close_fds=False, # Required for posix_spawn ) await process.wait() return process.returncode == 0