[core] os.path -> Path (#10654)

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@home-assistant.io>

tests/dashboard/test_web_server_paths.py

@@ -13,14 +13,14 @@ from esphome.dashboard import web_server
 def test_get_base_frontend_path_production() -> None:
     """Test get_base_frontend_path in production mode."""
     mock_module = MagicMock()
-    mock_module.where.return_value = "/usr/local/lib/esphome_dashboard"
+    mock_module.where.return_value = Path("/usr/local/lib/esphome_dashboard")
 
     with (
         patch.dict(os.environ, {}, clear=True),
         patch.dict("sys.modules", {"esphome_dashboard": mock_module}),
     ):
         result = web_server.get_base_frontend_path()
-        assert result == "/usr/local/lib/esphome_dashboard"
+        assert result == Path("/usr/local/lib/esphome_dashboard")
         mock_module.where.assert_called_once()
 
 
@@ -31,13 +31,12 @@ def test_get_base_frontend_path_dev_mode() -> None:
     with patch.dict(os.environ, {"ESPHOME_DASHBOARD_DEV": test_path}):
         result = web_server.get_base_frontend_path()
 
-        # The function uses os.path.abspath which doesn't resolve symlinks
-        # We need to match that behavior
+        # The function uses Path.resolve() which resolves symlinks
         # The actual function adds "/" to the path, so we simulate that
         test_path_with_slash = test_path if test_path.endswith("/") else test_path + "/"
-        expected = os.path.abspath(
-            os.path.join(os.getcwd(), test_path_with_slash, "esphome_dashboard")
-        )
+        expected = (
+            Path(os.getcwd()) / test_path_with_slash / "esphome_dashboard"
+        ).resolve()
         assert result == expected
 
 
@@ -48,8 +47,8 @@ def test_get_base_frontend_path_dev_mode_with_trailing_slash() -> None:
     with patch.dict(os.environ, {"ESPHOME_DASHBOARD_DEV": test_path}):
         result = web_server.get_base_frontend_path()
 
-        # The function uses os.path.abspath which doesn't resolve symlinks
-        expected = os.path.abspath(str(Path.cwd() / test_path / "esphome_dashboard"))
+        # The function uses Path.resolve() which resolves symlinks
+        expected = (Path.cwd() / test_path / "esphome_dashboard").resolve()
         assert result == expected
 
 
@@ -60,76 +59,72 @@ def test_get_base_frontend_path_dev_mode_relative_path() -> None:
     with patch.dict(os.environ, {"ESPHOME_DASHBOARD_DEV": test_path}):
         result = web_server.get_base_frontend_path()
 
-        # The function uses os.path.abspath which doesn't resolve symlinks
-        # We need to match that behavior
+        # The function uses Path.resolve() which resolves symlinks
         # The actual function adds "/" to the path, so we simulate that
         test_path_with_slash = test_path if test_path.endswith("/") else test_path + "/"
-        expected = os.path.abspath(
-            os.path.join(os.getcwd(), test_path_with_slash, "esphome_dashboard")
-        )
+        expected = (
+            Path(os.getcwd()) / test_path_with_slash / "esphome_dashboard"
+        ).resolve()
         assert result == expected
-        assert Path(result).is_absolute()
+        assert result.is_absolute()
 
 
 def test_get_static_path_single_component() -> None:
     """Test get_static_path with single path component."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = "/base/frontend"
+        mock_base.return_value = Path("/base/frontend")
 
         result = web_server.get_static_path("file.js")
 
-        assert result == os.path.join("/base/frontend", "static", "file.js")
+        assert result == Path("/base/frontend") / "static" / "file.js"
 
 
 def test_get_static_path_multiple_components() -> None:
     """Test get_static_path with multiple path components."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = "/base/frontend"
+        mock_base.return_value = Path("/base/frontend")
 
         result = web_server.get_static_path("js", "esphome", "index.js")
 
-        assert result == os.path.join(
-            "/base/frontend", "static", "js", "esphome", "index.js"
+        assert (
+            result == Path("/base/frontend") / "static" / "js" / "esphome" / "index.js"
         )
 
 
 def test_get_static_path_empty_args() -> None:
     """Test get_static_path with no arguments."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = "/base/frontend"
+        mock_base.return_value = Path("/base/frontend")
 
         result = web_server.get_static_path()
 
-        assert result == os.path.join("/base/frontend", "static")
+        assert result == Path("/base/frontend") / "static"
 
 
 def test_get_static_path_with_pathlib_path() -> None:
     """Test get_static_path with Path objects."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = "/base/frontend"
+        mock_base.return_value = Path("/base/frontend")
 
         path_obj = Path("js") / "app.js"
         result = web_server.get_static_path(str(path_obj))
 
-        assert result == os.path.join("/base/frontend", "static", "js", "app.js")
+        assert result == Path("/base/frontend") / "static" / "js" / "app.js"
 
 
 def test_get_static_file_url_production() -> None:
     """Test get_static_file_url in production mode."""
     web_server.get_static_file_url.cache_clear()
     mock_module = MagicMock()
-    mock_file = MagicMock()
-    mock_file.read.return_value = b"test content"
-    mock_file.__enter__ = MagicMock(return_value=mock_file)
-    mock_file.__exit__ = MagicMock(return_value=None)
+    mock_path = MagicMock(spec=Path)
+    mock_path.read_bytes.return_value = b"test content"
 
     with (
         patch.dict(os.environ, {}, clear=True),
         patch.dict("sys.modules", {"esphome_dashboard": mock_module}),
         patch("esphome.dashboard.web_server.get_static_path") as mock_get_path,
-        patch("esphome.dashboard.web_server.open", create=True, return_value=mock_file),
     ):
-        mock_get_path.return_value = "/fake/path/js/app.js"
+        mock_get_path.return_value = mock_path
         result = web_server.get_static_file_url("js/app.js")
         assert result.startswith("./static/js/app.js?hash=")
 
@@ -182,26 +177,26 @@ def test_load_file_compressed_path(tmp_path: Path) -> None:
 def test_path_normalization_in_static_path() -> None:
     """Test that paths are normalized correctly."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = "/base/frontend"
+        mock_base.return_value = Path("/base/frontend")
 
         # Test with separate components
         result1 = web_server.get_static_path("js", "app.js")
         result2 = web_server.get_static_path("js", "app.js")
 
         assert result1 == result2
-        assert result1 == os.path.join("/base/frontend", "static", "js", "app.js")
+        assert result1 == Path("/base/frontend") / "static" / "js" / "app.js"
 
 
 def test_windows_path_handling() -> None:
     """Test handling of Windows-style paths."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = r"C:\Program Files\esphome\frontend"
+        mock_base.return_value = Path(r"C:\Program Files\esphome\frontend")
 
         result = web_server.get_static_path("js", "app.js")
 
-        # os.path.join should handle this correctly on the platform
-        expected = os.path.join(
-            r"C:\Program Files\esphome\frontend", "static", "js", "app.js"
+        # Path should handle this correctly on the platform
+        expected = (
+            Path(r"C:\Program Files\esphome\frontend") / "static" / "js" / "app.js"
         )
         assert result == expected
 
@@ -209,22 +204,20 @@ def test_windows_path_handling() -> None:
 def test_path_with_special_characters() -> None:
     """Test paths with special characters."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = "/base/frontend"
+        mock_base.return_value = Path("/base/frontend")
 
         result = web_server.get_static_path("js-modules", "app_v1.0.js")
 
-        assert result == os.path.join(
-            "/base/frontend", "static", "js-modules", "app_v1.0.js"
+        assert (
+            result == Path("/base/frontend") / "static" / "js-modules" / "app_v1.0.js"
         )
 
 
 def test_path_with_spaces() -> None:
     """Test paths with spaces."""
     with patch("esphome.dashboard.web_server.get_base_frontend_path") as mock_base:
-        mock_base.return_value = "/base/my frontend"
+        mock_base.return_value = Path("/base/my frontend")
 
         result = web_server.get_static_path("my js", "my app.js")
 
-        assert result == os.path.join(
-            "/base/my frontend", "static", "my js", "my app.js"
-        )
+        assert result == Path("/base/my frontend") / "static" / "my js" / "my app.js"