sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2024-10-06 10:50:58 +01:00
Code Issues Releases Wiki Activity

debug component, allow without debug logging (#4685)

Browse Source
This commit is contained in:
Jesse Hills 2023-04-14 14:29:28 +12:00
parent 9fbbcd6d8a
commit 9da261cb39
No known key found for this signature in database
GPG Key ID: BEAAE804EFD8E83A
2 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
esphome/components/debug/__init__.py
View File

@ -1,15 +1,11 @@
import esphome.codegen as cg import esphome.codegen as cg
import esphome.config_validation as cv import esphome.config_validation as cv
import esphome.final_validate as fv
from esphome.components import logger
from esphome.const import ( from esphome.const import (
CONF_BLOCK, CONF_BLOCK,
CONF_DEVICE, CONF_DEVICE,
CONF_FRAGMENTATION, CONF_FRAGMENTATION,
CONF_FREE, CONF_FREE,
CONF_ID, CONF_ID,
CONF_LEVEL,
CONF_LOGGER,
CONF_LOOP_TIME, CONF_LOOP_TIME,
) )
@ -43,18 +39,6 @@ CONFIG_SCHEMA = cv.Schema(
).extend(cv.polling_component_schema("60s")) ).extend(cv.polling_component_schema("60s"))
def _final_validate(_):
logger_conf = fv.full_config.get()[CONF_LOGGER]
severity = logger.LOG_LEVEL_SEVERITY.index(logger_conf[CONF_LEVEL])
if severity < logger.LOG_LEVEL_SEVERITY.index("DEBUG"):
raise cv.Invalid(
"The debug component requires the logger to be at least at DEBUG level"
)
FINAL_VALIDATE_SCHEMA = _final_validate
async def to_code(config): async def to_code(config):
var = cg.new_Pvariable(config[CONF_ID]) var = cg.new_Pvariable(config[CONF_ID])
await cg.register_component(var, config) await cg.register_component(var, config)

4
esphome/components/debug/debug_component.cpp
View File

@ -37,6 +37,10 @@ static uint32_t get_free_heap() {
} }
void DebugComponent::dump_config() { void DebugComponent::dump_config() {
#ifndef ESPHOME_LOG_HAS_DEBUG
return; // Can't log below if debug logging is disabled
#endif
std::string device_info; std::string device_info;
std::string reset_reason; std::string reset_reason;
device_info.reserve(256); device_info.reserve(256);