sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-03-17 08:08:16 +00:00
Code Issues Releases Wiki Activity

Solve clang-tidy script errors

Browse Source
This commit is contained in:
Thierry DUVERNOY 2025-01-16 08:33:03 +01:00
parent 8d4b43ab1b
commit 9c809f0e11
3 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
esphome/components/dallas_pio/binary_sensor.cpp
View File

@ -66,12 +66,6 @@ void DallasPioBinarySensor::update() {
if (!this->dallas_pio_->read_state(state, this->pin_)) { if (!this->dallas_pio_->read_state(state, this->pin_)) {
return; return;
} }
} else if (this->reference_ == "DS2406") {
// Action pour DS2406
} else if (this->reference_ == "DS2408") {
// Action pour DS2408
} else {
// Action par défaut
} }
if (this->pin_inverted_) { if (this->pin_inverted_) {

17
esphome/components/dallas_pio/dallas_pio.cpp
View File

@ -123,6 +123,11 @@ bool DallasPio::ds2413_get_state_(uint8_t &state) {
results = this->bus_->read8(); results = this->bus_->read8();
} }
ok = (~results & 0x0F) == (results >> 4); ok = (~results & 0x0F) == (results >> 4);
if (!ok) {
ESP_LOGW(TAG, "One-Wire checksum error.");
this->status_set_warning();
return false;
}
// ESP_LOGD(TAG, "results1=%02x", results); // ESP_LOGD(TAG, "results1=%02x", results);
results &= 0x0F; results &= 0x0F;
// ESP_LOGD(TAG, "results2=%02x", results); // ESP_LOGD(TAG, "results2=%02x", results);
@ -255,7 +260,7 @@ bool DallasPio::ds2406_get_state_(uint8_t &state, bool use_crc = false) {
} }
if (use_crc) { if (use_crc) {
ESP_LOGD(TAG, "CRC for Channel Info Byte: 0x%04X", use_crc); ESP_LOGD(TAG, "CRC for Channel Info Byte: 0x%04X", use_crc);
if (!this->ds2406_verify_crc_(channel_control_byte_1, channel_control_byte_2, channel_info_byte, use_crc)) { if (!this->ds2406_verify_crc_(channel_control_byte_1, channel_control_byte_2, channel_info_byte, received_crc)) {
ESP_LOGW(TAG, "CRC verification failed!"); ESP_LOGW(TAG, "CRC verification failed!");
this->status_set_warning(); this->status_set_warning();
return false; return false;
@ -273,6 +278,16 @@ bool DallasPio::ds2406_get_state_(uint8_t &state, bool use_crc = false) {
bool pio_activity_latch; bool pio_activity_latch;
const bool has_channel_b = channel_info_byte & 0x40; const bool has_channel_b = channel_info_byte & 0x40;
const bool has_supply = channel_info_byte & 0x80; const bool has_supply = channel_info_byte & 0x80;
if (!has_supply) {
ESP_LOGW(TAG, "DS2406 has no supply");
this->status_set_warning();
return false;
}
if ((this->pin_ == 0x02) && (!has_channel_b)) {
ESP_LOGW(TAG, "DS2406 has no channel PIOB");
this->status_set_warning();
return false;
}
switch (this->pin_) { switch (this->pin_) {
case 0x01: // PIOA case 0x01: // PIOA
pio_flipflop = channel_info_byte & 0x01; pio_flipflop = channel_info_byte & 0x01;

6
esphome/components/dallas_pio/switch.cpp
View File

@ -67,12 +67,6 @@ void DallasPioSwitch::write_state(bool state) {
if (!this->dallas_pio_->write_state(state, this->pin_, this->pin_inverted_)) { if (!this->dallas_pio_->write_state(state, this->pin_, this->pin_inverted_)) {
return; return;
} }
} else if (this->reference_ == "DS2406") {
// Action pour DS2406
} else if (this->reference_ == "DS2408") {
// Action pour DS2408
} else {
// Action par défaut
} }
this->publish_state(state); // Set state in ESPHome this->publish_state(state); // Set state in ESPHome
} }