sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-28 13:43:54 +00:00
Code Issues Releases Wiki Activity

optimize

Browse Source
This commit is contained in:
J. Nick Koston
2025-10-22 08:30:17 -10:00
parent 3fda73bcf2
commit 92a812e154
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
esphome/core/enum_bitmask.h
View File

@@ -92,6 +92,7 @@ template<typename EnumType, int MaxBits = 16> class EnumBitmask {
/// Iterator support for range-based for loops and API encoding /// Iterator support for range-based for loops and API encoding
/// Iterates over set bits and converts bit positions to enum values /// Iterates over set bits and converts bit positions to enum values
/// Optimization: removes bits from mask as we iterate
class Iterator { class Iterator {
public: public:
using iterator_category = std::forward_iterator_tag; using iterator_category = std::forward_iterator_tag;
@@ -100,29 +101,29 @@ template<typename EnumType, int MaxBits = 16> class EnumBitmask {
using pointer = const EnumType *; using pointer = const EnumType *;
using reference = EnumType; using reference = EnumType;
constexpr Iterator(bitmask_t mask, int bit) : mask_(mask), bit_(bit) { advance_to_next_set_bit_(); } constexpr explicit Iterator(bitmask_t mask) : mask_(mask) {}
constexpr EnumType operator*() const { return bit_to_enum(bit_); } constexpr EnumType operator*() const {
// Return enum for the first set bit
return bit_to_enum(find_next_set_bit(mask_, 0));
}
constexpr Iterator &operator++() { constexpr Iterator &operator++() {
++bit_; // Clear the lowest set bit (Brian Kernighan's algorithm)
advance_to_next_set_bit_(); mask_ &= mask_ - 1;
return *this; return *this;
} }
constexpr bool operator==(const Iterator &other) const { return bit_ == other.bit_; } constexpr bool operator==(const Iterator &other) const { return mask_ == other.mask_; }
constexpr bool operator!=(const Iterator &other) const { return !(*this == other); } constexpr bool operator!=(const Iterator &other) const { return !(*this == other); }
private: private:
constexpr void advance_to_next_set_bit_() { bit_ = find_next_set_bit(mask_, bit_); }
bitmask_t mask_; bitmask_t mask_;
int bit_;
}; };
constexpr Iterator begin() const { return Iterator(mask_, 0); } constexpr Iterator begin() const { return Iterator(mask_); }
constexpr Iterator end() const { return Iterator(mask_, MaxBits); } constexpr Iterator end() const { return Iterator(0); }
/// Get the raw bitmask value for optimized operations /// Get the raw bitmask value for optimized operations
constexpr bitmask_t get_mask() const { return this->mask_; } constexpr bitmask_t get_mask() const { return this->mask_; }