Run clang-tidy against Arduino 3 (#2146)

* Add macros header with more usable Arduino version defines

* Change Arduino version checking to use our version defines

* Add missing ESP8266 check

* Rename Arduino version macro to ARDUINO_VERSION_CODE

* Upgrade clang-tidy to use Arduino 3

* Fix clang-tidy warnings

* Upgrade NeoPixelBus to upstream 2.6.7

* Use Arduino-version-appropriate API to set redirect flags

* Remove now unnecessary CLANG_TIDY ifdefs

* Add preprocessor hackery to avoid including pgmspace.h

* Bump base image to 4.1.1 and update lint

* Fix nfctag

* Fix make_unique ambiguous

* Fix ignore name

* Fix ambiguous v2

* Remove unused begin

* Cast time_t to prevent issues on platforms where time_t is 32bit

Co-authored-by: Otto winter <otto@otto-winter.com>

.github/workflows/ci.yml

@@ -36,7 +36,7 @@ jobs:
 
     # cpp lint job runs with esphome-lint docker image so that clang-format-*
     # doesn't have to be installed
-    container: ghcr.io/esphome/esphome-lint:1.1
+    container: ghcr.io/esphome/esphome-lint:1.2
     steps:
       - uses: actions/checkout@v2
 

.github/workflows/docker-lint-build.yml

@@ -29,7 +29,7 @@ jobs:
         python-version: '3.9'
     - name: Set TAG
       run: |
-        echo "TAG=1.1" >> $GITHUB_ENV
+        echo "TAG=1.2" >> $GITHUB_ENV
 
     - name: Run build
       run: |
@@ -74,7 +74,7 @@ jobs:
         python-version: '3.9'
     - name: Set TAG
       run: |
-        echo "TAG=1.1" >> $GITHUB_ENV
+        echo "TAG=1.2" >> $GITHUB_ENV
     - name: Enable experimental manifest support
       run: |
         mkdir -p ~/.docker