From 9025f99eb3ae71e7939e15e33ebd3006302defc8 Mon Sep 17 00:00:00 2001 From: Chris <52449218+shadow578@users.noreply.github.com> Date: Wed, 11 Sep 2024 06:54:13 +0000 Subject: [PATCH] fix CI issues --- .../i2s_audio/media_player/__init__.py | 18 ++++++++---------- .../media_player/i2s_audio_media_player.cpp | 2 +- .../media_player/i2s_audio_media_player.h | 2 +- platformio.ini | 3 +-- 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/esphome/components/i2s_audio/media_player/__init__.py b/esphome/components/i2s_audio/media_player/__init__.py index 95bb13b60b..7814a17858 100644 --- a/esphome/components/i2s_audio/media_player/__init__.py +++ b/esphome/components/i2s_audio/media_player/__init__.py @@ -1,17 +1,15 @@ -import esphome.codegen as cg -from esphome.components import media_player, esp32 -import esphome.config_validation as cv - from esphome import pins - +import esphome.codegen as cg +from esphome.components import esp32, media_player +import esphome.config_validation as cv from esphome.const import CONF_ID, CONF_MODE from .. import ( - i2s_audio_ns, - I2SAudioComponent, - I2SAudioOut, CONF_I2S_AUDIO_ID, CONF_I2S_DOUT_PIN, + I2SAudioComponent, + I2SAudioOut, + i2s_audio_ns, ) CODEOWNERS = ["@jesserockz"] @@ -130,7 +128,7 @@ async def to_code(config): cg.add_library( name="ESP32-audioI2S", - version=None, # use close-to latest commit, since tagged versions are fairly irregular... - repository="https://github.com/schreibfaul1/ESP32-audioI2S.git#1bc79e547ebb6f917bf82b47bec9b7e6a9b7e314", + repository="https://github.com/schreibfaul1/ESP32-audioI2S.git#", + version="1bc79e547ebb6f917bf82b47bec9b7e6a9b7e314", ) diff --git a/esphome/components/i2s_audio/media_player/i2s_audio_media_player.cpp b/esphome/components/i2s_audio/media_player/i2s_audio_media_player.cpp index f33f05092c..1abc908712 100644 --- a/esphome/components/i2s_audio/media_player/i2s_audio_media_player.cpp +++ b/esphome/components/i2s_audio/media_player/i2s_audio_media_player.cpp @@ -263,7 +263,7 @@ void I2SAudioMediaPlayer::dump_config() { #endif } -bool I2SAudioMediaPlayer::connecttouri_(const std::string uri) { +bool I2SAudioMediaPlayer::connecttouri_(const std::string &uri) { if (this->audio_ == nullptr) { return false; } diff --git a/esphome/components/i2s_audio/media_player/i2s_audio_media_player.h b/esphome/components/i2s_audio/media_player/i2s_audio_media_player.h index c851d625e2..5553738d3e 100644 --- a/esphome/components/i2s_audio/media_player/i2s_audio_media_player.h +++ b/esphome/components/i2s_audio/media_player/i2s_audio_media_player.h @@ -59,7 +59,7 @@ class I2SAudioMediaPlayer : public Component, public media_player::MediaPlayer, void stop_(); void play_(); - bool connecttouri_(const std::string uri); + bool connecttouri_(const std::string &uri); I2SState i2s_state_{I2S_STATE_STOPPED}; std::unique_ptr