sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-31 07:03:55 +00:00
Code Issues Releases Wiki Activity

fix: simplify read_state method and enhance logging for wiper adjustments

Browse Source
This commit is contained in:
Oliver Kleinecke
2025-02-16 17:32:28 +01:00
parent 8e431d3d5e
commit 81d463c909
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
esphome/components/mcp4461/output/mcp4461_output.cpp
View File

@@ -17,9 +17,7 @@ void Mcp4461Wiper::write_state(float state) {
} }
} }
float Mcp4461Wiper::read_state() { float Mcp4461Wiper::read_state() { return (static_cast<float>(this->parent_->get_wiper_level_(this->wiper_)) / 256.0); }
return (static_cast<float>(this->parent_->get_wiper_level_(this->wiper_)) / 256.0);
}
float Mcp4461Wiper::update_state() { float Mcp4461Wiper::update_state() {
this->state_ = this->read_state(); this->state_ = this->read_state();
@@ -27,8 +25,11 @@ float Mcp4461Wiper::update_state() {
} }
void Mcp4461Wiper::set_state(bool state) { void Mcp4461Wiper::set_state(bool state) {
if (state) { this->turn_on(); } if (state) {
else { this->turn_off(); } this->turn_on();
} else {
this->turn_off();
}
} }
void Mcp4461Wiper::turn_on() { this->parent_->enable_wiper_(this->wiper_); } void Mcp4461Wiper::turn_on() { this->parent_->enable_wiper_(this->wiper_); }
@@ -38,14 +39,16 @@ void Mcp4461Wiper::turn_off() { this->parent_->disable_wiper_(this->wiper_); }
void Mcp4461Wiper::increase_wiper() { void Mcp4461Wiper::increase_wiper() {
if (this->parent_->increase_wiper_(this->wiper_)) { if (this->parent_->increase_wiper_(this->wiper_)) {
this->state_ = this->update_state(); this->state_ = this->update_state();
ESP_LOGV(TAG, "Increased wiper %d to %" PRIu16 "", this->wiper_, static_cast<uint16_t>(this->state_ * 256)); ESP_LOGV(TAG, "Increased wiper %d to %" PRIu16 "", this->wiper_,
static_cast<uint16_t>(std::roundf(this->state_ * 256)));
} }
} }
void Mcp4461Wiper::decrease_wiper() { void Mcp4461Wiper::decrease_wiper() {
if (this->parent_->decrease_wiper_(this->wiper_)) { if (this->parent_->decrease_wiper_(this->wiper_)) {
this->state_ = this->update_state(); this->state_ = this->update_state();
ESP_LOGV(TAG, "Decreased wiper %d to %" PRIu16 "", this->wiper_, static_cast<uint16_t>(this->state_ * 256)); ESP_LOGV(TAG, "Decreased wiper %d to %" PRIu16 "", this->wiper_,
static_cast<uint16_t>(std::roundf(this->state_ * 256)));
} }
} }