sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-11-16 14:55:50 +00:00
Code Issues Releases Wiki Activity

[remote_base] Optimize raw transmit action memory usage - use function pointers (#11800)

Browse Source
This commit is contained in:
J. Nick Koston
2025-11-09 16:25:16 -06:00
committed by GitHub
parent 26a3ec41d6
commit 77ab096b59
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
esphome/components/remote_base/raw_protocol.h
View File

@@ -42,17 +42,20 @@ class RawTrigger : public Trigger<RawTimings>, public Component, public RemoteRe
template<typename... Ts> class RawAction : public RemoteTransmitterActionBase<Ts...> { template<typename... Ts> class RawAction : public RemoteTransmitterActionBase<Ts...> {
public: public:
void set_code_template(std::function<RawTimings(Ts...)> func) { this->code_func_ = func; } void set_code_template(RawTimings (*func)(Ts...)) {
this->code_.func = func;
this->len_ = -1; // Sentinel value indicates template mode
}
void set_code_static(const int32_t *code, size_t len) { void set_code_static(const int32_t *code, size_t len) {
this->code_static_ = code; this->code_.data = code;
this->code_static_len_ = len; this->len_ = len; // Length >= 0 indicates static mode
} }
TEMPLATABLE_VALUE(uint32_t, carrier_frequency); TEMPLATABLE_VALUE(uint32_t, carrier_frequency);
void encode(RemoteTransmitData *dst, Ts... x) override { void encode(RemoteTransmitData *dst, Ts... x) override {
if (this->code_static_ != nullptr) { if (this->len_ >= 0) {
for (size_t i = 0; i < this->code_static_len_; i++) { for (size_t i = 0; i < static_cast<size_t>(this->len_); i++) {
auto val = this->code_static_[i]; auto val = this->code_.data[i];
if (val < 0) { if (val < 0) {
dst->space(static_cast<uint32_t>(-val)); dst->space(static_cast<uint32_t>(-val));
} else { } else {
@@ -60,15 +63,17 @@ template<typename... Ts> class RawAction : public RemoteTransmitterActionBase<Ts
} }
} }
} else { } else {
dst->set_data(this->code_func_(x...)); dst->set_data(this->code_.func(x...));
} }
dst->set_carrier_frequency(this->carrier_frequency_.value(x...)); dst->set_carrier_frequency(this->carrier_frequency_.value(x...));
} }
protected: protected:
std::function<RawTimings(Ts...)> code_func_{nullptr}; ssize_t len_{-1}; // -1 = template mode, >=0 = static mode with length
const int32_t *code_static_{nullptr}; union Code {
int32_t code_static_len_{0}; RawTimings (*func)(Ts...);
const int32_t *data;
} code_;
}; };
class RawDumper : public RemoteReceiverDumperBase { class RawDumper : public RemoteReceiverDumperBase {