sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-04-15 07:10:33 +01:00
Code Issues Releases Wiki Activity

Update mcp4461.cpp

Browse Source
This commit is contained in:
Oliver Kleinecke 2025-02-09 16:24:08 +01:00 committed by GitHub
parent d7e76015cc
commit 6a6c9fda60
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
esphome/components/mcp4461/mcp4461.cpp
View File

@ -136,11 +136,14 @@ void Mcp4461Component::loop() {
} }
uint8_t i; uint8_t i;
for (i = 0; i < 8; i++) { for (i = 0; i < 8; i++) {
if (this->reg_[i].update) { if (this->reg_[i].update_level) {
// set wiper i state if changed // set wiper i state if changed
if (this->reg_[i].state != this->read_wiper_level_(i)) { if (this->reg_[i].state != this->read_wiper_level_(i)) {
this->write_wiper_level_(i, this->reg_[i].state); this->write_wiper_level_(i, this->reg_[i].state);
} }
}
this->reg_[i].update_level = false;
if (this->reg_[i].update_terminal) {
// terminal register changes only applicable to wipers 0-3 ! // terminal register changes only applicable to wipers 0-3 !
if (i < 4) { if (i < 4) {
// set terminal register changes // set terminal register changes
@ -158,7 +161,7 @@ void Mcp4461Component::loop() {
} }
} }
} }
this->reg_[i].update = false; this->reg_[i].update_terminal = false;
} }
} }
@ -292,7 +295,7 @@ void Mcp4461Component::set_wiper_level(Mcp4461WiperIdx wiper, uint16_t value) {
} }
ESP_LOGV(TAG, "Setting MCP4461 wiper %" PRIu8 " to %" PRIu16 "!", wiper_idx, value); ESP_LOGV(TAG, "Setting MCP4461 wiper %" PRIu8 " to %" PRIu16 "!", wiper_idx, value);
this->reg_[wiper_idx].state = value; this->reg_[wiper_idx].state = value;
this->reg_[wiper_idx].update = true; this->reg_[wiper_idx].update_level = true;
} }
void Mcp4461Component::write_wiper_level_(uint8_t wiper, uint16_t value) { void Mcp4461Component::write_wiper_level_(uint8_t wiper, uint16_t value) {
@ -324,7 +327,7 @@ void Mcp4461Component::enable_wiper(Mcp4461WiperIdx wiper) {
} }
ESP_LOGV(TAG, "Enabling wiper %" PRIu8, wiper_idx); ESP_LOGV(TAG, "Enabling wiper %" PRIu8, wiper_idx);
this->reg_[wiper_idx].terminal_hw = true; this->reg_[wiper_idx].terminal_hw = true;
this->reg_[wiper_idx].update = true; this->reg_[wiper_idx].update_level = true;
} }
void Mcp4461Component::disable_wiper(Mcp4461WiperIdx wiper) { void Mcp4461Component::disable_wiper(Mcp4461WiperIdx wiper) {
@ -343,7 +346,7 @@ void Mcp4461Component::disable_wiper(Mcp4461WiperIdx wiper) {
} }
ESP_LOGV(TAG, "Disabling wiper %" PRIu8, wiper_idx); ESP_LOGV(TAG, "Disabling wiper %" PRIu8, wiper_idx);
this->reg_[wiper_idx].terminal_hw = false; this->reg_[wiper_idx].terminal_hw = false;
this->reg_[wiper_idx].update = true; this->reg_[wiper_idx].update_level = true;
} }
bool Mcp4461Component::increase_wiper(Mcp4461WiperIdx wiper) { bool Mcp4461Component::increase_wiper(Mcp4461WiperIdx wiper) {
@ -481,7 +484,7 @@ void Mcp4461Component::update_terminal_register(Mcp4461TerminalIdx terminal_conn
this->reg_[(wiper_index + 1)].terminal_hw = ((terminal_data >> 7) & 0x01); this->reg_[(wiper_index + 1)].terminal_hw = ((terminal_data >> 7) & 0x01);
} }
bool Mcp4461Component::set_terminal_register(Mcp4461TerminalIdx terminal_connector, uint8_t data) { bool Mcp4461Component::set_terminal_register_(Mcp4461TerminalIdx terminal_connector, uint8_t data) {
if (this->is_failed()) { if (this->is_failed()) {
ESP_LOGE(TAG, "%s", LOG_STR_ARG(mcp4461_get_message_string(this->error_code_))); ESP_LOGE(TAG, "%s", LOG_STR_ARG(mcp4461_get_message_string(this->error_code_)));
return false; return false;
@ -530,7 +533,7 @@ void Mcp4461Component::enable_terminal(Mcp4461WiperIdx wiper, char terminal) {
ESP_LOGW(TAG, "Unknown terminal %c specified", terminal); ESP_LOGW(TAG, "Unknown terminal %c specified", terminal);
return; return;
} }
this->reg_[wiper_idx].update = true; this->reg_[wiper_idx].update_terminal = false; = true;
} }
void Mcp4461Component::disable_terminal(Mcp4461WiperIdx wiper, char terminal) { void Mcp4461Component::disable_terminal(Mcp4461WiperIdx wiper, char terminal) {
@ -560,7 +563,7 @@ void Mcp4461Component::disable_terminal(Mcp4461WiperIdx wiper, char terminal) {
ESP_LOGW(TAG, "Unknown terminal %c specified", terminal); ESP_LOGW(TAG, "Unknown terminal %c specified", terminal);
return; return;
} }
this->reg_[wiper_idx].update = true; this->reg_[wiper_idx].update_terminal = false; = true;
} }
uint16_t Mcp4461Component::get_eeprom_value(Mcp4461EepromLocation location) { uint16_t Mcp4461Component::get_eeprom_value(Mcp4461EepromLocation location) {