sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-02 03:12:20 +01:00
Code Issues Releases Wiki Activity

Optimize subprocess performance with close_fds=False (#10145)

Browse Source
This commit is contained in:
J. Nick Koston
2025-08-10 16:14:13 -05:00
committed by GitHub
parent 279f56141e
commit 5a8f722316
12 changed files with 40 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
script/run-in-env.py
View File

@@ -13,7 +13,7 @@ def find_and_activate_virtualenv():
try:
# Get the top-level directory of the git repository
my_path = subprocess.check_output(
["git", "rev-parse", "--show-toplevel"], text=True
["git", "rev-parse", "--show-toplevel"], text=True, close_fds=False
).strip()
except subprocess.CalledProcessError:
print(
@@ -44,7 +44,7 @@ def find_and_activate_virtualenv():
def run_command():
# Execute the remaining arguments in the new environment
if len(sys.argv) > 1:
subprocess.run(sys.argv[1:], check=False)
subprocess.run(sys.argv[1:], check=False, close_fds=False)
else:
print(
"No command provided to run in the virtual environment.",