sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-09-02 03:12:20 +01:00
Code Issues Releases Wiki Activity

Optimize subprocess performance with close_fds=False (#10145)

Browse Source
This commit is contained in:
J. Nick Koston
2025-08-10 16:14:13 -05:00
committed by GitHub
parent 279f56141e
commit 5a8f722316
12 changed files with 40 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
script/clang-tidy
View File

@@ -158,7 +158,11 @@ def run_tidy(executable, args, options, tmpdir, path_queue, lock, failed_files):
invocation.extend(options)
proc = subprocess.run(
invocation, capture_output=True, encoding="utf-8", check=False
invocation,
capture_output=True,
encoding="utf-8",
check=False,
close_fds=False,
)
if proc.returncode != 0:
with lock:
@@ -320,9 +324,11 @@ def main():
print("Applying fixes ...")
try:
try:
subprocess.call(["clang-apply-replacements-18", tmpdir])
subprocess.call(
["clang-apply-replacements-18", tmpdir], close_fds=False
)
except FileNotFoundError:
subprocess.call(["clang-apply-replacements", tmpdir])
subprocess.call(["clang-apply-replacements", tmpdir], close_fds=False)
except FileNotFoundError:
print(
"Error please install clang-apply-replacements-18 or clang-apply-replacements.\n",