sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-14 15:53:48 +01:00
Code Issues Releases Wiki Activity

[api] Avoid object_id string allocations for all entity info messages (#10260)

Browse Source
This commit is contained in:
J. Nick Koston
2025-08-19 21:28:13 -05:00
committed by GitHub
parent 0b50ef227b
commit 5a1533bea9
3 changed files with 32 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
esphome/components/api/api_connection.h
View File

@@ -301,9 +301,15 @@ class APIConnection final : public APIServerConnection {
APIConnection *conn, uint32_t remaining_size, bool is_single) {
// Set common fields that are shared by all entity types
msg.key = entity->get_object_id_hash();
// IMPORTANT: get_object_id() may return a temporary std::string
std::string object_id = entity->get_object_id();
msg.set_object_id(StringRef(object_id));
// Try to use static reference first to avoid allocation
StringRef static_ref = entity->get_object_id_ref_for_api_();
if (!static_ref.empty()) {
msg.set_object_id(static_ref);
} else {
// Dynamic case - need to allocate
std::string object_id = entity->get_object_id();
msg.set_object_id(StringRef(object_id));
}
if (entity->has_own_name()) {
msg.set_name(entity->get_name());