sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-04-16 07:40:29 +01:00
Code Issues Releases Wiki Activity

Revert "fix negative anwser interpretation"

Browse Source 
This reverts commit 7eac405ed84d0be3ddd668005947378cf143cbe3.
This commit is contained in:
Michael Doppler 2024-04-29 10:44:24 +02:00
parent 7eac405ed8
commit 59cba62e20
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
esphome/components/mcp3428/mcp3428.cpp
View File

@ -102,12 +102,6 @@ float MCP3428Component::request_measurement(MCP3428Multiplexer multiplexer, MCP3
} }
// got valid measurement, clean up unused bits from the anwser code and prepare tick size // got valid measurement, clean up unused bits from the anwser code and prepare tick size
bool negative = false;
if (anwser[0] & 0b10000000 != 0) {
// negative number, clean up bit and mark as negative
negative = true;
anwser[0] &= 0b01111111;
}
float tick_voltage = 2.048f / 32768; // ref voltage 2.048V/non-sign bits, default 15 bits float tick_voltage = 2.048f / 32768; // ref voltage 2.048V/non-sign bits, default 15 bits
switch (resolution) { switch (resolution) {
case MCP3428Resolution::MCP3428_12_BITS: case MCP3428Resolution::MCP3428_12_BITS:
@ -138,9 +132,6 @@ float MCP3428Component::request_measurement(MCP3428Multiplexer multiplexer, MCP3
} }
// convert code (first 2 bytes of cleaned up anwser) into voltage ticks // convert code (first 2 bytes of cleaned up anwser) into voltage ticks
int16_t ticks = anwser[0] << 8 | anwser[1]; int16_t ticks = anwser[0] << 8 | anwser[1];
if (negative) {
ticks *= (-1);
}
this->status_clear_warning(); this->status_clear_warning();
return tick_voltage * ticks; return tick_voltage * ticks;