sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-31 07:03:55 +00:00
Code Issues Releases Wiki Activity

Merge branch 'pca9554_loop_churn_fix' into integration

Browse Source
This commit is contained in:
J. Nick Koston
2025-09-04 13:10:31 -05:00
parent 960590434c d29586ba5a
commit 5920508c32
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
esphome/components/pca9554/pca9554.cpp
View File

@@ -53,17 +53,17 @@ void PCA9554Component::dump_config() {
} }
} }
bool PCA9554Component::digital_read_hw(uint16_t pin) { bool PCA9554Component::digital_read_hw(uint8_t pin) {
// Read all pins from hardware into input_mask_ // Read all pins from hardware into input_mask_
return this->read_inputs_(); // Return true if I2C read succeeded, false on error return this->read_inputs_(); // Return true if I2C read succeeded, false on error
} }
bool PCA9554Component::digital_read_cache(uint16_t pin) { bool PCA9554Component::digital_read_cache(uint8_t pin) {
// Return the cached pin state from input_mask_ // Return the cached pin state from input_mask_
return this->input_mask_ & (1 << pin); return this->input_mask_ & (1 << pin);
} }
void PCA9554Component::digital_write_hw(uint16_t pin, bool value) { void PCA9554Component::digital_write_hw(uint8_t pin, bool value) {
if (value) { if (value) {
this->output_mask_ |= (1 << pin); this->output_mask_ |= (1 << pin);
} else { } else {

6
esphome/components/pca9554/pca9554.h
View File

@@ -34,9 +34,9 @@ class PCA9554Component : public Component,
bool write_register_(uint8_t reg, uint16_t value); bool write_register_(uint8_t reg, uint16_t value);
// Virtual methods from CachedGpioExpander // Virtual methods from CachedGpioExpander
bool digital_read_hw(uint16_t pin) override; bool digital_read_hw(uint8_t pin) override;
bool digital_read_cache(uint16_t pin) override; bool digital_read_cache(uint8_t pin) override;
void digital_write_hw(uint16_t pin, bool value) override; void digital_write_hw(uint8_t pin, bool value) override;
/// number of bits the expander has /// number of bits the expander has
size_t pin_count_{8}; size_t pin_count_{8};