sascha/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2025-10-30 22:53:59 +00:00
Code Issues Releases Wiki Activity

changed to nolint

Browse Source
This commit is contained in:
oarcher
2024-05-31 13:21:21 +02:00
parent e1267aedaf
commit 58dcc3b44c
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
esphome/components/modem/modem_component.cpp
View File

@@ -124,7 +124,8 @@ void ModemComponent::setup() {
ESP_LOGV(TAG, "DCE setup"); ESP_LOGV(TAG, "DCE setup");
// clang-format off ( create_modem_dce(dce_factory::ModemType, config, std::move(dte), netif) is private ) // NOLINTBEGIN(bugprone-branch-clone)
// ( because create_modem_dce(dce_factory::ModemType, config, std::move(dte), netif) is private )
switch (this->model_) { switch (this->model_) {
case ModemModel::BG96: case ModemModel::BG96:
this->dce = create_BG96_dce(&dce_config, this->dte_, this->ppp_netif_); this->dce = create_BG96_dce(&dce_config, this->dte_, this->ppp_netif_);
@@ -143,7 +144,7 @@ void ModemComponent::setup() {
return; return;
break; break;
} }
// clang-format on // NOLINTEND
assert(this->dce); assert(this->dce);

8
esphome/components/modem/modem_component.h
View File

@@ -11,14 +11,12 @@
// esp_modem will use esphome logger (needed if other components include esphome/core/log.h) // esp_modem will use esphome logger (needed if other components include esphome/core/log.h)
// We need to do this because "cxx_include/esp_modem_api.hpp" is not a pure C++ header, and use logging. // We need to do this because "cxx_include/esp_modem_api.hpp" is not a pure C++ header, and use logging.
// FIXME: Find another workaround. clang is currently disabled. // FIXME: Find another workaround ?.
// error: using declarations in the global namespace in headers are prohibited // error: using declarations in the global namespace in headers are prohibited
// [google-global-names-in-headers,-warnings-as-errors] // [google-global-names-in-headers,-warnings-as-errors]
// clang-format off using esphome::esp_log_printf_; // NOLINT(google-global-names-in-headers):
using esphome::esp_log_printf_;
// clang-format on
#include <cxx_include/esp_modem_api.hpp> #include <cxx_include/esp_modem_api.hpp> // NOLINT(clang-diagnostic-error)
#include <driver/gpio.h> #include <driver/gpio.h>
#include <esp_modem_config.h> #include <esp_modem_config.h>
#include <unordered_map> #include <unordered_map>